@pmatilai commented on this pull request.


> @@ -149,7 +155,8 @@ int main(int argc, char *argv[])
 
     args = (ARGV_const_t) poptGetArgs(optCon);
 
-    if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY)
+    if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY &&
+       mode != MODE_REBUILD)

Yeah a) and b) are mechanically applicable anywhere, c) requires thinking.

As a reminder, CONTRIBUTING.md has advice too:
> If in doubt, 'indent -kr' generally produces acceptable formatting.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978802177
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3562/review/2656299...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to