@pmatilai commented on this pull request.
> @@ -149,7 +155,8 @@ int main(int argc, char *argv[])
args = (ARGV_const_t) poptGetArgs(optCon);
- if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY)
+ if (args == NULL && mode != MODE_LISTKEY && mode != MODE_EXPORTKEY &&
+ mode != MODE_REBUILD)
For crying out loud. It's not like you need to remember 21 digits of pi here.
The issue is *ambiguity* due to identical indentation so to fix you just need
to change how it ends up laid out, such as:
a) indent the condition continuation deeper.
b) put the opening brace on the next line (unlike the usual style), this
provides the brain sufficient clue about the matter
c) avoid the whole issue by moving part of the condition elsewhere, such as
using an aptly named helper variable
Quite often it's c) that makes for most readable code.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978688520
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3562/review/2656083...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
