@ffesti commented on this pull request.


>  
     virtual ~keystore() = default;
+    keystore(std::string n): name(n) {};

OK; for now I just moved the getKeystore to the keystore module and dropped 
this whole name business. For some reason this just does not work as expected 
with C++. I am all for the name being a static property but I could not make 
this work with C++ as strings are just not static.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#discussion_r1978306551
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3562/review/2655455...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to