Re: [PR] [WIP] Jetty12 + EE8 [solr]
malliaridis commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r1848994558
##
gradle/libs.versions.toml:
##
@@ -138,7 +139,7 @@ jayway-jsonpath = "2.9.0"
jctools = "4.0.5"
jersey = "3.1.9"
# TODO Sync with jersey versions
-jersey-containers = "2.39.1"
+jersey-containers = "3.1.0"
Review Comment:
I would go with jersey version 3.1.9 if possible, so that we can remove this
entry completely (see line above).
##
solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java:
##
@@ -100,9 +100,14 @@ public class ShowFileRequestHandler extends
RequestHandlerBase implements Permis
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
static {
-KNOWN_MIME_TYPES = new HashSet<>(MimeTypes.getKnownMimeTypes());
+KNOWN_MIME_TYPES = new HashSet<>();
+for (MimeTypes.Type type : MimeTypes.Type.values()) {
+ KNOWN_MIME_TYPES.add(type.toString());
+}
KNOWN_MIME_TYPES.add("text/xml");
KNOWN_MIME_TYPES.add("text/javascript");
+KNOWN_MIME_TYPES.add("text/csv");
Review Comment:
Starting from Jetty 11 these two mime types are not included in
`MimeTypes.Type`, but we have tests that check if they are supported. Not sure
if this could cause any issues with jetty though.
##
gradle/libs.versions.toml:
##
@@ -315,23 +316,25 @@ eclipse-jetty-alpnjavaserver = { module =
"org.eclipse.jetty:jetty-alpn-java-ser
eclipse-jetty-alpnserver = { module = "org.eclipse.jetty:jetty-alpn-server",
version.ref = "eclipse-jetty" }
eclipse-jetty-client = { module = "org.eclipse.jetty:jetty-client",
version.ref = "eclipse-jetty" }
eclipse-jetty-deploy = { module = "org.eclipse.jetty:jetty-deploy",
version.ref = "eclipse-jetty" }
+eclipse-jetty-ee8-nested = { module =
"org.eclipse.jetty.ee8:jetty-ee8-nested", version.ref = "eclipse-jetty" }
eclipse-jetty-http = { module = "org.eclipse.jetty:jetty-http", version.ref =
"eclipse-jetty" }
-eclipse-jetty-http2-client = { module =
"org.eclipse.jetty.http2:http2-client", version.ref = "eclipse-jetty" }
-eclipse-jetty-http2-common = { module =
"org.eclipse.jetty.http2:http2-common", version.ref = "eclipse-jetty" }
-eclipse-jetty-http2-hpack = { module = "org.eclipse.jetty.http2:http2-hpack",
version.ref = "eclipse-jetty" }
-eclipse-jetty-http2-httpclienttransport = { module =
"org.eclipse.jetty.http2:http2-http-client-transport", version.ref =
"eclipse-jetty" }
-eclipse-jetty-http2-server = { module =
"org.eclipse.jetty.http2:http2-server", version.ref = "eclipse-jetty" }
+eclipse-jetty-http2-client = { module =
"org.eclipse.jetty.http2:jetty-http2-client", version.ref = "eclipse-jetty" }
+eclipse-jetty-http2-common = { module =
"org.eclipse.jetty.http2:jetty-http2-common", version.ref = "eclipse-jetty" }
+eclipse-jetty-http2-hpack = { module =
"org.eclipse.jetty.http2:jetty-http2-hpack", version.ref = "eclipse-jetty" }
+eclipse-jetty-http2-httpclienttransport = { module =
"org.eclipse.jetty.http2:jetty-http2-client-transport", version.ref =
"eclipse-jetty" }
+eclipse-jetty-http2-server = { module =
"org.eclipse.jetty.http2:jetty-http2-server", version.ref = "eclipse-jetty" }
eclipse-jetty-io = { module = "org.eclipse.jetty:jetty-io", version.ref =
"eclipse-jetty" }
eclipse-jetty-jmx = { module = "org.eclipse.jetty:jetty-jmx", version.ref =
"eclipse-jetty" }
eclipse-jetty-rewrite = { module = "org.eclipse.jetty:jetty-rewrite",
version.ref = "eclipse-jetty" }
eclipse-jetty-security = { module = "org.eclipse.jetty:jetty-security",
version.ref = "eclipse-jetty" }
eclipse-jetty-server = { module = "org.eclipse.jetty:jetty-server",
version.ref = "eclipse-jetty" }
-eclipse-jetty-servlet = { module = "org.eclipse.jetty:jetty-servlet",
version.ref = "eclipse-jetty" }
-eclipse-jetty-servlets = { module = "org.eclipse.jetty:jetty-servlets",
version.ref = "eclipse-jetty" }
+eclipse-jetty-servlet = { module = "org.eclipse.jetty.ee8:jetty-ee8-servlet",
version.ref = "eclipse-jetty" }
+eclipse-jetty-servlets = { module =
"org.eclipse.jetty.ee8:jetty-ee8-servlets", version.ref = "eclipse-jetty" }
Review Comment:
I would go for
```
eclipse-jetty-ee8-servlet = { module =
"org.eclipse.jetty.ee8:jetty-ee8-servlet", version.ref = "eclipse-jetty" }
eclipse-jetty-ee8-servlets = { module =
"org.eclipse.jetty.ee8:jetty-ee8-servlets", version.ref = "eclipse-jetty" }
```
so that it is clear when using them EE8 is active. Suggestion requires
update of references if applied.
##
solr/core/src/test/org/apache/solr/util/tracing/TestHttpServletRequestGetter.java:
##
@@ -41,7 +40,7 @@ public void test() {
"c", Set.of("2"));
HttpServletRequest req =
-new HttpServletRequestWrapper(new Request(null, null)) {
+new HttpServletRequestWrapper(null) {
Review Comment:
If I remember correct, this is annotated with not-null, ca
[PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]
malliaridis opened a new pull request, #2881: URL: https://github.com/apache/solr/pull/2881 https://issues.apache.org/jira/browse/SOLR-16427 # Description With the [ClassInitializationDeadlock](https://errorprone.info/bugpattern/ClassInitializationDeadlock) rule error-prone checks for possible class initialization deadlocks. See error-prone documentation for details about the problem this rule is fixing. # Solution Following the suggestions of error-prone, the possible deadlocks are resolved by introducing separate classes for constant fields. You can review commits individually for a better overview. This PR deprecates the classes in the old location and uses the new classes project-wide for partial backwards compatibility. This may break third-party / user code that reference the old classes. If we drop the need for backwards compatibility we can remove completely the deprecated classes and methods and solely update the CHANGES.txt by mentioning the new classes. - [ ] Update CHANGES.txt before merge # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X ] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]
AndreyBozhko commented on PR #2879: URL: https://github.com/apache/solr/pull/2879#issuecomment-2489578817 Thanks - it also seemed to me that the change is too minor to warrant a JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16427: Enable error-prone PatternMatchingInstanceof rule [solr]
malliaridis merged PR #2867: URL: https://github.com/apache/solr/pull/2867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[I] Pods begin to restart as soon as i enable auth [solr-operator]
VishwajeetPandeyy opened a new issue, #730: URL: https://github.com/apache/solr-operator/issues/730 solr pods begin to restart as soon as I enable auth And as soon as I disable it , they come back on `bin/solr auth enable -credentials admin:admin -type basicAuth -z "$ZK_HOST"` this is the command I am using for auth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-16781: Remove solrconfig.xml directives [solr]
gerlowskija opened a new pull request, #2875: URL: https://github.com/apache/solr/pull/2875 https://issues.apache.org/jira/browse/SOLR-16781 # Description Solr offers a number of ways for users to add JARs and resources to their classpath, including: * solr.xml entries * SOLR_MODULES env-var/support * core and install-level "lib/" directories * the package manager * direct classpath modification In addition to being largely redundant with the methods above, solrconfig.xml's directive has been a pain point and source of security concerns in the past. # Solution This commit removes references and support from 'main'. Most of the functional changes live in SolrConfig.java, where we now check for tags only to log out a warning about them being no longer supported. The remainder of the PR consists of updates to our ref-guide, to recommend other means of adding JARs to Solr's classpath. Most of these are for first-party modules, which can use the SOLR_MODULES system. # Tests Some modifications made to existing tests to ensure that tags no longer function (particularly TestConfigSetsAPI). # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17569) TestLBHttpSolrClient/LBHttp2SolrClientIntegrationTest unreproducible test failures
James Dyer created SOLR-17569:
-
Summary: TestLBHttpSolrClient/LBHttp2SolrClientIntegrationTest
unreproducible test failures
Key: SOLR-17569
URL: https://issues.apache.org/jira/browse/SOLR-17569
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Reporter: James Dyer
*TestLBHttpSolrClient* (branch_9x) was renamed to
*LBHttp2SolrClientIntegrationTest* and has a high failure rate. These failures
are not reproducible. Consider altering the test technique to eliminate
false-positive failures.
-
{noformat}
Build: https://ci-builds.apache.org/job/Solr/job/Solr-BadApples-Tests-main/1486/
1 tests failed.
Build: https://ci-builds.apache.org/job/Solr/job/Solr-BadApples-Tests-main/1486/
FAILED: org.apache.solr.client.solrj.TestLBHttp2SolrClient.testSimple
Error Message:
java.lang.AssertionError: expected:<3> but was:<2>
Stack Trace:
java.lang.AssertionError: expected:<3> but was:<2>
at
__randomizedtesting.SeedInfo.seed([3CF24FAC059E0DDC:4416B52226DD90D]:0)
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at
org.apache.solr.client.solrj.TestLBHttp2SolrClient.testSimple(TestLBHttp2SolrClient.java:165)
Reproduce with: ./gradlew :solr:solrj:test --tests
"org.apache.solr.client.solrj.TestLBHttp2SolrClient.testSimple" -Ptests.jvms=4
-Ptests.haltonfailure=false "-Ptests.jvmargs=-XX:TieredStopAtLevel=1
-XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=3CF24FAC059E0DDC -Ptests.multiplier=2 -Ptests.badapples=true
-Ptests.file.encoding=US-ASCII
{noformat}
-
{noformat}
Build: https://ci-builds.apache.org/job/Solr/job/Solr-Test-9.x/6323/
1 tests failed.
FAILED: org.apache.solr.client.solrj.TestLBHttp2SolrClient.testTwoServers
Error Message:
org.apache.solr.client.solrj.SolrServerException: Total timeout 2000 ms elapsed
Stack Trace:
org.apache.solr.client.solrj.SolrServerException: Total timeout 2000 ms elapsed
at
__randomizedtesting.SeedInfo.seed([C10E68448E178BC0:61E4C6C9555CA5E0]:0)
at
app//org.apache.solr.client.solrj.impl.Http2SolrClient.request(Http2SolrClient.java:562)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.lambda$doRequest$0(LBSolrClient.java:558)
at
app//org.apache.solr.client.solrj.impl.Http2SolrClient.requestWithBaseUrl(Http2SolrClient.java:604)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.doRequest(LBSolrClient.java:558)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.request(LBSolrClient.java:809)
at
app//org.apache.solr.client.solrj.impl.LBSolrClient.request(LBSolrClient.java:753)
at
app//org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:279)
at
app//org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:927)
at
app//org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:940)
at
app//org.apache.solr.client.solrj.TestLBHttp2SolrClient.testTwoServers(TestLBHttp2SolrClient.java:202)
...etc...
Caused by: java.util.concurrent.TimeoutException: Total timeout 2000 ms elapsed
at
org.eclipse.jetty.client.HttpDestination$RequestTimeouts.onExpired(HttpDestination.java:608)
at
org.eclipse.jetty.client.HttpDestination$RequestTimeouts.onExpired(HttpDestination.java:591)
at
org.eclipse.jetty.io.CyclicTimeouts.onTimeoutExpired(CyclicTimeouts.java:110)
at
org.eclipse.jetty.io.CyclicTimeouts$Timeouts.onTimeoutExpired(CyclicTimeouts.java:197)
at org.eclipse.jetty.io.CyclicTimeout$Wakeup.run(CyclicTimeout.java:294)
Reproduce with: ./gradlew :solr:solrj:test --tests
"org.apache.solr.client.solrj.TestLBHttp2SolrClient.testTwoServers"
-Ptests.jvms=4 -Ptests.haltonfailure=false
"-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=C10E68448E178BC0 -Ptests.multiplier=2 -Ptests.badapples=false
-Ptests.file.encoding=ISO-8859-1
{noformat}
-
{noformat}
Build: https://ci-builds.apache.org/job/Solr/job/Solr-Test-main/9375/
1 tests failed.
FAILED: org.apache.solr.client.solrj.TestLBHttp2SolrClient.testTwoServers
Error Message:
org.apache.solr.client.solrj.SolrServerException: Timeout occurred while
waiting response from server at: https://127.0.0.1:42819/solr/collection1/select
Stack Trace:
org.apache.solr.client.solrj.SolrServerException: Timeout occurred while
waiting response from server at: https://127.0.0.1:42819/solr/collection1/select
at
__randomizedtesting.SeedInfo.seed([7736109EB5E7EE54:D7DCBE136EACC074]:0)
at
app//org.apache.solr.client.solrj.impl.Http2SolrClient.request(Http2SolrClient.ja
[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899873#comment-17899873 ] ASF subversion and git services commented on SOLR-16427: Commit b76a29d17c874806e3b6516810772e2238e93098 in solr's branch refs/heads/main from Christos Malliaridis [ https://gitbox.apache.org/repos/asf?p=solr.git;h=b76a29d17c8 ] SOLR-16427: Enable error-prone PatternMatchingInstanceof rule (#2867) * Enable PatternMatchingInstanceof checks * Resolve PatternMatchingInstanceof warnings > Evaluate and fix errorprone rules > - > > Key: SOLR-16427 > URL: https://issues.apache.org/jira/browse/SOLR-16427 > Project: Solr > Issue Type: Task > Components: Build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Time Spent: 10h > Remaining Estimate: 0h > > Errorprone has many rules and there are a bunch that are disabled in Solr. > Some make sense to leave disabled. Others are just disabled because they > weren't evaluated. > See > https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle > This was previously done for some rules in SOLR-15908 and SOLR-15613. This > relates to SOLR-16364 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]
ds-manzinger commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2486175531 https://github.com/apache/solr/pull/2874 This is the Pull Request against main branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17567: Improve Stream CLI implementation [solr]
epugh commented on PR #2872: URL: https://github.com/apache/solr/pull/2872#issuecomment-2486084852 Finally! All the junit tests related to StreamTool are passing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17567: Revert unnecessary signature changes in CatStream [solr]
malliaridis closed pull request #2878: SOLR-17567: Revert unnecessary signature changes in CatStream URL: https://github.com/apache/solr/pull/2878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [WIP] Jetty12 + EE8 [solr]
iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2488502894 `s3-repository` test cases started to failing as HandlerWrapper class not available anymore which was part of Jetty10 and now with Jetty12, it's part of ee8.nested. However, spring-boot jetty-starter doesn't have anything for ee8. They do have support for ee10 webapps, and adding those runs the test successfully but there are multiple library conflict is there. Working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17567: Improve Stream CLI implementation [solr]
epugh commented on PR #2872: URL: https://github.com/apache/solr/pull/2872#issuecomment-2488539724 Okay, this I think is almost ready to merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]
epugh commented on PR #2861: URL: https://github.com/apache/solr/pull/2861#issuecomment-2488570462 Feedback in corporated. When this is back ported we need to remember to remove the CREDENTIALS lookups ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17504) CoreContainer calls UpdateHandler.commit
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-17504. --- Fix Version/s: 9.8 Resolution: Fixed > CoreContainer calls UpdateHandler.commit > > > Key: SOLR-17504 > URL: https://issues.apache.org/jira/browse/SOLR-17504 > Project: Solr > Issue Type: Improvement >Reporter: Bruno Roustant >Assignee: Bruno Roustant >Priority: Major > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > ... and DirectUpdateHandler2.closeWriter supports commit metadata. > This proposal is about unifying calls to UpdateHandler.commit. > CoreContainer.reload may call directly IndexWriter.commit if the core to > reload is readonly (property of the Collection). This is an issue because it > bypasses some logic in UpdateHandler.commit. In addition, the current code > commits without taking the commit lock. > DirectUpdateHandler2.closeWriter may commit if the update log is not empty > (not committed yet). But it does not call DirectUpdateHandler2.commit(), it > copies commit() code instead for some reasons (comments in the code mention > test failures). The proposal is to add the same call to > DirectUpdateHandler2.shouldCommit() as in the commit() method, otherwise > commit metadata are lost. In addition shouldCommit() can be extended > correctly, for example in the solr-sandbox encryption module which needs to > intercept calls to shouldCommit(). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17531: Use new unified GC options [solr]
malliaridis commented on PR #2815: URL: https://github.com/apache/solr/pull/2815#issuecomment-2488321304 > I think I prefer the GC being explicit instead of relying on whatever JDK value is the default. The logging cleanup configs look good, but I would keep the G1GC configs. I was thinking the same when I was editing it, thinking that if the defaults may change under certain circumstances, then we will not have a "reproducible" state. But for the same reason we would have to include all other defaults as well. I tried to understand why this was added in the first place, and it seemed to be some pre JDK 9 stuff, where G1GC was not the default GC and had to be configured explicitly. Since we had a lot of legacy JDK configuration, I decided to remove it during the cleanup. Not sure if there were other reasons though, as I never had to configure the JDK before (besides memory). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17567) Improve Stream CLI implementation
[
https://issues.apache.org/jira/browse/SOLR-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899725#comment-17899725
]
ASF subversion and git services commented on SOLR-17567:
Commit 66a16805be3142705bcfdf22806d4c2b4720b1a1 in solr's branch
refs/heads/main from Christos Malliaridis
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=66a16805be3 ]
SOLR-17567: Fix auth issue in stream tests (#2877)
* Fix auth issue in stream tests
* Add negative test for missing auth
> Improve Stream CLI implementation
> -
>
> Key: SOLR-17567
> URL: https://issues.apache.org/jira/browse/SOLR-17567
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: cli
>Reporter: Christos Malliaridis
>Priority: Major
> Labels: cli, pull-request-available, streams
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The current implemention for the CLI's Streams command that was introduced in
> SOLR-14673 has multiple issues that should be addressed, including but not
> limited to:
> - Use of raw strings in {{Option#getOptionValue()}}
> - Overlapping options ({{\-f}} and {{\-e}})
> - Multiple type suppressions that can be avoided
> - A bug that causes specific bats tests to fail
> - StreamTool.LocalCatStream overrides CatStream btu does not properly set
> commaDelimitedFilepaths (this may be a bug)
> - Obsolete LetStream#getLetParams() was introduced
> - Function StreamTool.constructStream seems obsolete and occurrences can be
> replaced with implementation
> - Implementation of StreamTool.readExpression does not take leading spaces
> infront of comment lines into account
> - Implementation of StreamTool.readExpression does not support {{*/}} at the
> end of line
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2488589191 > So Kerberos Auth is going away with this. Be sure to highlight this in CHANGES.txt and in JIRA. To me, Hadoop-Auth is a forgettable implementation detail (I didn't know _really_ know what this is) to the effective industry feature (I know of Kerberos). If you search our ref guide for "Kerberos", it still exists in this PR. See `authentication-and-authorization-plugins.adoc`. @dsmiley I wanted to follow up on this. Is it possible that Kerberos still exists without Hadoop Auth? I assumed Hadoop Auth was different thatn Kerberos, in that with Kerberos you could authenticate in a Kerberos environment, and that didn't require Hadoop Auth.. That Hadoop Auth was a place to validate kerberous credentials, but you might validate elsewhere? There do seem to be lots of references to Kerberos that aren't tied to Hadoop Auth.. I think I need some guidence on where to go... Should I just remove the rest of the Kerberos code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]
epugh commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2488606888 @gerlowskija how do you want to handle https://github.com/apache/solr/pull/2861? Should it go in first, or after? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17571: Introduce dependabot [solr]
malliaridis opened a new pull request, #2880: URL: https://github.com/apache/solr/pull/2880 https://issues.apache.org/jira/browse/SOLR-17571 # Description With the introduction of Version catalogs we can make use of dependabot and replace our current bot. This allows us to run regular dependency and security updates directly on the project. # Solution The solution introduces a configuration for dependabot that checks for security updates daily and creates PRs with dependency updates if they are security-related (unlimited). Additionally, it creates regular dependency updates bi-weekly and up to 100 PRs, grouping dependencies together based on our version catalog. Custom dependency groups are create for related dependencies (like Apache Calcite dependencies) that use different versions but should update together. For frequently updated dependencies, dependabot will create separate PRs and will check only monthly for updates. Since dependabot does not support additional execution steps for writing locks and updating checksums, the gradle-precommit workflow is updated to run `gradlew writeLocks` and `gradlew updateLicenses`, and commits the changes before running the usual tests. These actions are only executed if dependabot creates the PRs. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17571) Introduce dependabot
[ https://issues.apache.org/jira/browse/SOLR-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17571: -- Labels: pull-request-available (was: ) > Introduce dependabot > > > Key: SOLR-17571 > URL: https://issues.apache.org/jira/browse/SOLR-17571 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: main (10.0) >Reporter: Christos Malliaridis >Assignee: Christos Malliaridis >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > With the migration to Version Catalogs in SOLR-17406, The solrbot stopped > working and requires to be updated. > Because we now use Gradle Version Catalogs, dependabot is also an option we > can consider. It comes with better GitHub integration and more features > related to security. It should be possible to adopt a similar behavior with > our current bot by fine-tuning dependabot. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17567: Revert unnecessary signature changes in CatStream [solr]
malliaridis commented on PR #2878: URL: https://github.com/apache/solr/pull/2878#issuecomment-2488520057 Closing this in favor to https://github.com/apache/solr/pull/2872. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17571: Introduce dependabot [solr]
malliaridis commented on code in PR #2880:
URL: https://github.com/apache/solr/pull/2880#discussion_r1850666596
##
.github/workflows/gradle-precommit.yml:
##
@@ -1,17 +1,80 @@
name: Gradle Precommit
-on:
+on:
pull_request:
branches:
- 'main'
- 'branch_*'
jobs:
+ # Dependabot job that runs only for dependabot PRs
+ # This job is writing locks, updates checksums, and commits the changes on
the dependabot PRs.
+ dependabot:
+name: gradle check
+
+runs-on: ubuntu-latest
+
+# Run only on dependabot PRs (see dependabot-actions.yml)
+if: github.actor == 'dependabot[bot]'
+
+env:
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+
+# Give the default GITHUB_TOKEN write permission to commit
+# and push the changed files back to the repository.
+permissions:
+ contents: write
+
+steps:
+ - name: Checkout project
+uses: actions/checkout@v4
+with:
+ ref: ${{ github.head_ref }}
+
+ - name: Set up JDK
+uses: actions/setup-java@v4
+with:
+ distribution: 'temurin'
+ java-version: 21
+ java-package: jdk
+
+ - name: Setup Gradle
+uses: gradle/actions/setup-gradle@v4
+
+ - name: Grant execute permission for gradlew
+run: chmod +x gradlew
+
+ - name: Use Gradle cache
+uses: actions/cache@v4
+with:
+ path: |
+~/.gradle/caches
+ key: ${{ runner.os }}-gradle-precommit-${{
hashFiles('versions.lock') }}
+ restore-keys: |
+${{ runner.os }}-gradle-precommit-
+${{ runner.os }}-gradle-
+
+ - name: Write locks
+run: ./gradlew writeLocks
+
+ - name: Update licenses / checksums
+run: ./gradlew updateLicenses
+
+ - name: Commit and push changes
+uses: stefanzweifel/git-auto-commit-action@v5.0.1
+with:
+ commit_message: Write locks and update checksums
+ branch: ${{ github.head_ref }}
Review Comment:
Thanks for the insights, I was not aware of these regulations, but it was
definitely a topic for discussion.
I believe it is possible to achieve the same result without third-party
actions and allow github actions to create the commits (if that is ok?). I will
try and test it on a mirrored repository. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17567: Fix auth issue in stream tests [solr]
malliaridis merged PR #2877: URL: https://github.com/apache/solr/pull/2877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17571: Introduce dependabot [solr]
janhoy commented on code in PR #2880:
URL: https://github.com/apache/solr/pull/2880#discussion_r1850477067
##
.github/workflows/gradle-precommit.yml:
##
@@ -1,17 +1,80 @@
name: Gradle Precommit
-on:
+on:
pull_request:
branches:
- 'main'
- 'branch_*'
jobs:
+ # Dependabot job that runs only for dependabot PRs
+ # This job is writing locks, updates checksums, and commits the changes on
the dependabot PRs.
+ dependabot:
+name: gradle check
+
+runs-on: ubuntu-latest
+
+# Run only on dependabot PRs (see dependabot-actions.yml)
+if: github.actor == 'dependabot[bot]'
+
+env:
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+
+# Give the default GITHUB_TOKEN write permission to commit
+# and push the changed files back to the repository.
+permissions:
+ contents: write
+
+steps:
+ - name: Checkout project
+uses: actions/checkout@v4
+with:
+ ref: ${{ github.head_ref }}
+
+ - name: Set up JDK
+uses: actions/setup-java@v4
+with:
+ distribution: 'temurin'
+ java-version: 21
+ java-package: jdk
+
+ - name: Setup Gradle
+uses: gradle/actions/setup-gradle@v4
+
+ - name: Grant execute permission for gradlew
+run: chmod +x gradlew
+
+ - name: Use Gradle cache
+uses: actions/cache@v4
+with:
+ path: |
+~/.gradle/caches
+ key: ${{ runner.os }}-gradle-precommit-${{
hashFiles('versions.lock') }}
+ restore-keys: |
+${{ runner.os }}-gradle-precommit-
+${{ runner.os }}-gradle-
+
+ - name: Write locks
+run: ./gradlew writeLocks
+
+ - name: Update licenses / checksums
+run: ./gradlew updateLicenses
+
+ - name: Commit and push changes
+uses: stefanzweifel/git-auto-commit-action@v5.0.1
+with:
+ commit_message: Write locks and update checksums
+ branch: ${{ github.head_ref }}
Review Comment:
The ASF has a policy that only committers shall commit to the main repo. But
they have made an explicit exception for Dependabot, since it is vetted and
trusted. I suppose our own PR workflows could since it is strictly to PR
branches only. But should we reconsider relying on a 3rd party action
`stefanzweifel` to perform the commit?
Alternatively, is there a way to limit the `permissions.content: write` to
only this PR branch? In the event of a supply-chain attach on the
`stefanzweife` action, we could be at risk. Do we need to check with Infra?
##
.github/workflows/gradle-precommit.yml:
##
@@ -1,17 +1,80 @@
name: Gradle Precommit
-on:
+on:
pull_request:
branches:
- 'main'
- 'branch_*'
jobs:
+ # Dependabot job that runs only for dependabot PRs
+ # This job is writing locks, updates checksums, and commits the changes on
the dependabot PRs.
+ dependabot:
+name: gradle check
Review Comment:
Find a better name for the job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [WIP] Jetty12 + EE8 [solr]
risdenk commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2488602738 s3mock was a problem when I last looked at Jetty 11/12 due to it needing to stay on 2.x due to Java 17 required in 3.x. However, now that we are on JDK 17 on main, we should be able to upgrade to s3mock 3.x - https://github.com/adobe/S3Mock/releases/tag/3.0.0 (latest being https://github.com/adobe/S3Mock/releases/tag/3.11.0) I wonder if that will address the Jetty incompatibilities since this upgraded Spring as well. This upgrade of s3mock should be done separately from any Jetty upgrade if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]
mkhludnev commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2488992810 > PR is only about custom metrics i.e. calculating a value for each bucket. It's not about creating custom faceting types for making buckets in the first place. does it mean `FacetParser` change is not necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17306: fix replication problem on follower restart [solr]
ds-manzinger opened a new pull request, #2873: URL: https://github.com/apache/solr/pull/2873 https://issues.apache.org/jira/browse/SOLR-17306 # Description If Leader has Replication disabled - do not delete Followers data on restart # Solution Check if Leader Replication is enabled # Tests Implemented Unit Tests, that check different restart scenarios. Enable Directory Storage for Replica, othwerwise tests will not work because memory is cleaned on restart # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]
dsmiley commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1851435460 ## solr/modules/hadoop-auth/src/java/org/apache/solr/security/hadoop/KerberosPlugin.java: ## Review Comment: I assumed you were aware of what you were removing, but maybe not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17571: Introduce dependabot [solr]
malliaridis commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2489847298 The current configuration has multiple issues that I will fix in the upcoming changes. Are there any specific needs for how to treat security updates (dependencies with vulnerabilities)? Or should they simply be treated like any other dependency? This would simplify the dependabot config a bit if we want to treat them the same way. Additionally, running dependabot with a working configuration and no PR limit creates over 70 PRs (gradle plugin updates included). Should we limit it for the introduction to avoid spam? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]
dsmiley commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1851435460 ## solr/modules/hadoop-auth/src/java/org/apache/solr/security/hadoop/KerberosPlugin.java: ## Review Comment: Perhaps you deleted the whole module without examining its contents? This is KerberosPlugin, and its loss means no Kerberos with Solr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
