[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220243535
  
@rhtyd It looks fine now. It was present in some tomcat folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Rashmi Dixit]

Congratulations Will!

-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com]
Sent: Thursday, May 19, 2016 12:27 PM
To: dev@cloudstack.apache.org; market...@cloudstack.apache.org; 
us...@cloudstack.apache.org
Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Morning Everyone,

Yesterday at the ASF board meeting, the board passed the resolution making Will 
Stevens the new Vice President of the Apache CloudStack project.

Join me in congratulating Will on this appointment, wish him luck and bring 
your unwavering support !

You may have noticed that Will took on RM duties for the new releases going 
forward and has also taken a very active role to finish bringing us to github 
based  workflow and CI. Will has some updates on that front that I am sure you 
will all like.

-Sebastien
Former VP CloudStack



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Erik Weber]

On Thu, May 19, 2016 at 8:56 AM, Sebastien Goasguen 
wrote:

> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and
> bring your unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases
> going forward and has also taken a very active role to finish bringing us
> to github based  workflow and CI. Will has some updates on that front that
> I am sure you will all like.
>
>

Thanks for all your hard work Sebastien, and congratulations Will!

-- 
Erik

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Glenn Wagner]

Congratulations Will

-Glenn

glenn.wag...@shapeblue.com 
www.shapeblue.com
2nd Floor, Oudehuis Centre, 122 Main Rd, Somerset West, Cape Town  7130South 
Africa
@shapeblue



-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Thursday, 19 May 2016 8:57 AM
To: dev@cloudstack.apache.org; market...@cloudstack.apache.org; 
us...@cloudstack.apache.org
Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Morning Everyone,

Yesterday at the ASF board meeting, the board passed the resolution making Will 
Stevens the new Vice President of the Apache CloudStack project.

Join me in congratulating Will on this appointment, wish him luck and bring 
your unwavering support !

You may have noticed that Will took on RM duties for the new releases going 
forward and has also taken a very active role to finish bringing us to github 
based  workflow and CI. Will has some updates on that front that I am sure you 
will all like.

-Sebastien
Former VP CloudStack

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Nux!]

Congrats Will and thanks you Sebastien! :-)

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Sebastien Goasguen" 
> To: dev@cloudstack.apache.org, market...@cloudstack.apache.org, 
> us...@cloudstack.apache.org
> Sent: Thursday, 19 May, 2016 07:56:35
> Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

> Morning Everyone,
> 
> Yesterday at the ASF board meeting, the board passed the resolution making 
> Will
> Stevens the new Vice President of the Apache CloudStack project.
> 
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your
> unwavering support !
> 
> You may have noticed that Will took on RM duties for the new releases going
> forward and has also taken a very active role to finish bringing us to github
> based  workflow and CI. Will has some updates on that front that I am sure you
> will all like.
> 
> -Sebastien
> Former VP CloudStack

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Wido den Hollander]

Congrats Will! You are doing a great job :)

> Op 19 mei 2016 om 8:56 schreef Sebastien Goasguen :
> 
> 
> Morning Everyone,
> 
> Yesterday at the ASF board meeting, the board passed the resolution making 
> Will Stevens the new Vice President of the Apache CloudStack project.
> 
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your unwavering support !
> 
> You may have noticed that Will took on RM duties for the new releases going 
> forward and has also taken a very active role to finish bringing us to github 
> based  workflow and CI. Will has some updates on that front that I am sure 
> you will all like.
> 
> -Sebastien
> Former VP CloudStack

Re: Migrating CloudStack content from download.cloud.com

[Nux!]

+1 for disabling the default template download, it's the easiest/simplest way.

With regards to seeding if we decide to go with that, I'm sure Wido's 
cloudstack.apt-get.eu has sufficient bw, already several community members have 
access there (I think) and it's running an rsync server, too.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Chiradeep Vittal" 
> To: dev@cloudstack.apache.org
> Sent: Thursday, 19 May, 2016 06:22:45
> Subject: Re: Migrating CloudStack content from download.cloud.com

> Changing the download code to use the mirror is quite involved. Should we
> just disable (remove from templates.sql) download of default templates and
> advise people to use the method outlined here.
> http://shankerbalan.net/blog/seed-cloudstack-templates-offline/
> 
> (actually, we could write a script similar to cloud-install-sys-tmplt to
> install default templates)
> 
> On Wed, May 18, 2016 at 12:14 PM, Chiradeep Vittal 
> wrote:
> 
>> Mirrors still require a "seed" site, right? E.g., msync.centos.org is the
>> seed for CentOS. Depending on the number of mirrors, this seed site would
>> still require a non-trivial bandwidth limit and cap.
>> How soon can the mirror be set up? This week? :)
>>
>>
>> On Wed, May 18, 2016 at 10:12 AM, Will Stevens 
>> wrote:
>>
>>> Inline...
>>>
>>> *Will STEVENS*
>>> Lead Developer
>>>
>>> *CloudOps* *| *Cloud Solutions Experts
>>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>>> w cloudops.com *|* tw @CloudOps_
>>>
>>> On Wed, May 18, 2016 at 1:08 PM, Chiradeep Vittal 
>>> wrote:
>>>
>>> > The mirrolist is a great idea. There's 2 issues though:
>>> >
>>> > 1. Already released ACS releases in the wild will continue to attempt to
>>> > download from download.cloud.com whenever a zone is created. These old
>>> > releases cannot understand mirror lists. But users can be advised to
>>> patch
>>> > templates.sql to point to an alternate location. The question is what is
>>> > this alternate location? I propose "templates.cloudstack.org/old"
>>> >
>>>
>>> ​If they patch, maybe they can pull one of the URLs from the mirror list?
>>> That way we don't have to hardcode a specific mirror into the patch
>>> procedure.​
>>>
>>>
>>> >
>>> > 2. New releases of ACS. The next release of ACS has to support the
>>> mirror
>>> > list, otherwise we're kicking the can too far down the road.
>>> >
>>>
>>> ​I agree, we will need to get this feature into ACS ASAP.​
>>>
>>>
>>> >
>>> > For (1)
>>> > * templates.cloudstack.org/old could redirect (A record) to
>>> > cloudstack.apt-get.eu . Or the project could use AWS S3 (as
>>> > download.cloud.com is currently hosted in S3). Current bill is $40-50
>>> per
>>> > month (between 7GB-40GB downloaded per day). I like the S3 approach
>>> myself
>>> > but it needs the project to cough up some money or a benevolent sponsor.
>>> > There's quite a few organizations making money off of ACS, so this
>>> > shouldn't be a problem?
>>> > ​
>>> >
>>>
>>>
>>> > For (2)
>>> > * Assuming somebody steps up to write the new code, we need to find
>>> > sponsors that can host the mirrors.
>>> >
>>> > As somebody said earlier, this needs to happen much sooner than later.
>>> >
>>> > On Wed, May 18, 2016 at 1:06 AM, Paul Angus 
>>> > wrote:
>>> >
>>> > > Pulling a few threads together - if the ASF would create a
>>> > > download.cloudstack.org page on ASF infra with the mirrorlist json
>>> in it
>>> > > as suggested by Nux, we can maintain just that page and add/remove
>>> > mirrors
>>> > > at will.
>>> > >
>>> > >
>>> > > Kind regards,
>>> > >
>>> > > Paul Angus
>>> > >
>>> > > paul.an...@shapeblue.com
>>> > > www.shapeblue.com
>>> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> > > @shapeblue
>>> > >
>>> > >
>>> > >
>>> > > -Original Message-
>>> > > From: Wido den Hollander [mailto:w...@widodh.nl]
>>> > > Sent: 18 May 2016 08:37
>>> > > To: Giles Sirett ;
>>> dev@cloudstack.apache.org
>>> > > Subject: RE: Migrating CloudStack content from download.cloud.com
>>> > >
>>> > >
>>> > > > Op 17 mei 2016 om 10:34 schreef Giles Sirett <
>>> > giles.sir...@shapeblue.com
>>> > > >:
>>> > > >
>>> > > >
>>> > > > This is a MAJOR problem and needs to be figured out before the
>>> current
>>> > > download site is removed - @Raja - have Citrix committed to it being
>>> > there
>>> > > another year ?
>>> > > >
>>> > > > It is my understanding that Cloudstack relies on this download at
>>> > > > initial build/startup and then periodically if people do things like
>>> > > > build a new zone
>>> > > >
>>> > > > So, users environments aren't going to stop if its pulled, but
>>> nobody
>>> > > > would be a able to build/install cloudstack and it may cause issues
>>> as
>>> > > > and when users make config changes
>>> > > >
>>> > > > The problem is, for new builds, its hard coded : you start the  Sec
>>> > > > Storage VM, CloudStack will try to download the built in template
>>> from
>>> > > > download.cloud

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Dag Sonstebo]

Congratulations Will!

Regards,
Dag Sonstebo







On 19/05/2016, 07:56, "Sebastien Goasguen"  wrote:

>Morning Everyone,
>
>Yesterday at the ASF board meeting, the board passed the resolution making 
>Will Stevens the new Vice President of the Apache CloudStack project.
>
>Join me in congratulating Will on this appointment, wish him luck and bring 
>your unwavering support !
>
>You may have noticed that Will took on RM duties for the new releases going 
>forward and has also taken a very active role to finish bringing us to github 
>based  workflow and CI. Will has some updates on that front that I am sure you 
>will all like.
>
>-Sebastien
>Former VP CloudStack

dag.sonst...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

Re: MySQL : No suitable driver found for jdbc:mysql

[Nick LIVENS]

Now I'm totally clueless, perhaps I'm hitting a bug in tomcat?
Following the official documentation of Apache Tomcat 7.0 (
http://tomcat.apache.org/tomcat-7.0-doc/jndi-datasource-examples-howto.html)

Especially the following part :
"java.sql.DriverManager supports the service provider

 mechanism. This feature is that all the available JDBC drivers that
announce themselves by providing a META-INF/services/java.sql.Driver file
are automatically discovered, loaded and registered, relieving you from the
need to load the database driver explicitly before you create a JDBC
connection. However, the implementation is fundamentally broken in all Java
versions for a servlet container environment. The problem is that
java.sql.DriverManager will scan for the drivers only once.

The JRE Memory Leak Prevention Listener
 that is
included with Apache Tomcat solves this by triggering the drivers scan
during Tomcat startup. This is enabled by default. It means that only
libraries visible to the listener such as the ones in $CATALINA_BASE/lib will
be scanned for database drivers. If you are considering disabling this
feature, note that the scan would be triggered by the first web application
that is using JDBC, leading to failures when this web application is
reloaded and for other web applications that rely on this feature.

Thus, the web applications that have database drivers in their
WEB-INF/lib directory
cannot rely on the service provider mechanism and should register the
drivers explicitly.

The list of drivers in java.sql.DriverManager is also a known source of
memory leaks. Any Drivers registered by a web application must be
deregistered when the web application stops. Tomcat will attempt to
automatically discover and deregister any JDBC drivers loaded by the web
application class loader when the web application stops. However, it is
expected that applications do this for themselves via a
ServletContextListener."
I've checked all steps :
* My mysql-connector-java contains the META-INF/services/java.sql.Driver
file
* This JAR is located in /usr/share/cloudstack-management/lib/
* CATALINA_BASE = /usr/share/cloudstack-management

These are the 3 steps to make the JDBC drivers auto register themselves,
and this is not working.
I've also found a thread on stackoverflow where someone is hitting the same
issue - 2nd reply (
http://stackoverflow.com/questions/20224222/how-to-register-oracle-jdbc-driver-on-tomcat-7-0-47-startup
)

Kind regards,
Nick Livens

On Wed, May 18, 2016 at 6:25 PM, Simon Weller  wrote:

> Are you able to test this on a cleanly installed OS?
>
> It sounds like you've potentially got quite a few customizations and I
> think it would be helpful to see whether this can be reproduced on a clean
> install.
>
> 
> From: Nick LIVENS 
> Sent: Wednesday, May 18, 2016 11:02 AM
> To: dev@cloudstack.apache.org
> Subject: Re: MySQL : No suitable driver found for jdbc:mysql
>
> I've digged a bit deeper, and I've got it working by explicitly loading the
> MySQL JDBC driver with the following code change in TransactionLegacy.java
> :
>
> static {
> try {
> Class.forName("com.mysql.jdbc.Driver");
> } catch (ClassNotFoundException e) {
> throw new CloudRuntimeException("Failed to load MySQL JDBC
> driver", e);
> }
>
> // Initialize with assumed db.properties file
> initDataSource(DbProperties.getDbProperties());
> }
>
> This is the old way of doing it (< JDBC 4.0)
> I know that from that version onwards that these drivers are loaded
> automatically, so I thought that our mysql-connector was outdated.
> I've replaced it with the latest, but without success. The issue is still
> there.
>
> I've got 2 solutions, but either way, it should work with the current
> master ACS without changing stuff manually.
> * This code change
> * Changing the /etc/sysconfig/cloudstack-management file again, so that
> CLASSPATH contains the mysql-connector-java.jar again
>
> Any help / suggestions / ideas are much appreciated.
>
> Kind regards,
> Nick Livens
>
>
> On Wed, May 18, 2016 at 4:43 PM, Nick LIVENS <
> nick.liv...@nuagenetworks.net>
> wrote:
>
> > Java :
> > [root@csc-1 ~]# java -version
> > java version "1.7.0_85"
> > OpenJDK Runtime Environment (rhel-2.6.1.2.el7_1-x86_64 u85-b01)
> > OpenJDK 64-Bit Server VM (build 24.85-b03, mixed mode)
> >
> >
> > Tomcat :
> > [root@csc-1 ~]# tomcat version
> > Server version: Apache Tomcat/7.0.54
> > Server built:   Mar 24 2015 07:49:05
> > Server number:  7.0.54.0
> > OS Name:Linux
> > OS Version: 3.10.0-229.7.2.el7.x86_64
> >
> >
> > Environment :
> > [root@csc-1 ~]# cat /etc/*-release
> > NAME="Red Hat Enterprise Linux Server"
> > VERSION="7.1 (Maipo)"
> > ID="rhel"
> > ID_LIKE="fedora"
> > VERSION_ID="7.1"
> > PRETTY_NAME="

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Koushik Das]

Congrats Will
And thanks Sebastien

-Koushik

On 19/05/16, 12:26 PM, "Sebastien Goasguen"  wrote:

>Morning Everyone,
>
>Yesterday at the ASF board meeting, the board passed the resolution making 
>Will Stevens the new Vice President of the Apache CloudStack project.
>
>Join me in congratulating Will on this appointment, wish him luck and bring 
>your unwavering support !
>
>You may have noticed that Will took on RM duties for the new releases going 
>forward and has also taken a very active role to finish bringing us to github 
>based  workflow and CI. Will has some updates on that front that I am sure you 
>will all like.
>
>-Sebastien
>Former VP CloudStack




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Rohit Yadav]

Congrats Will.

Regards,
Rohit Yadav


rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


On May 19 2016, at 12:26 pm, Sebastien Goasguen  wrote:

Morning Everyone,

Yesterday at the ASF board meeting, the board passed the resolution making Will 
Stevens the new Vice President of the Apache CloudStack project.

Join me in congratulating Will on this appointment, wish him luck and bring 
your unwavering support !

You may have noticed that Will took on RM duties for the new releases going 
forward and has also taken a very active role to finish bringing us to github 
based workflow and CI. Will has some updates on that front that I am sure you 
will all like.

-Sebastien
Former VP CloudStack

Re: Migrating CloudStack content from download.cloud.com

[Erik Weber]

As a user (with old ACS installations) I'd say that this isn't all that
troublesome, this is easily fixed by updating the appropriate db records.

We should ensure that we have some good posts discovered by Google and
other search engines, so that when somebody running old installations hit
this issue they find the workaround.
There's a lot of time to reach out to users and inform of the fix necessary.

-- 
Erik


On Tue, May 17, 2016 at 10:34 AM, Giles Sirett 
wrote:

> This is a MAJOR problem and needs to be figured out before the current
> download site is removed - @Raja - have Citrix committed to it being there
> another year ?
>
> It is my understanding that Cloudstack relies on this download at initial
> build/startup and then periodically if people do things like build a new
> zone
>
> So, users environments aren't going to stop if its pulled, but nobody
> would be a able to build/install cloudstack and it may cause issues as and
> when users make config changes
>
> The problem is, for new builds, its hard coded : you start the  Sec
> Storage VM, CloudStack will try to download the built in template from
> download.cloud.com
>
> My understanding is that its simple db  change to make once an environment
> is running (exisiting users) but *may* require a code patch to fix the
> initial install
>
> #notideal
>
> Really, this should be maintained by ASF/ the project as its key to the
> software working, however my understanding is it involves binaries which
> ASF is never keen on (and may be some 3rd party binaries) - so that just
> wont happen
>
>
>
> Apt-get is controlled by Wido et al (for which we all owe him a massive
> thanks)  - but you are right, it is a 3rd party dependency and arguably a
> SPOF.  But, if ASF wont host binaries, we're always going to have this
> issue.
>
> So, we could patch the code to point somewhere else - but where ? - by
> definition its got to be something maintained by a 3rd party
>
>
> We had this debate some time ago when talking about the repositories. We
> (ShapeBlue) maintain a repo for our customers, which wev'e always opened up
> as public. However, there were concerns about having a company domain name
> (which I understand) - so apt-get became our preferred repo.
>
>
> Thoughts on how to fix this:
>
> 1. if ASF would allow us to create the host entry download.cloudstack.org.
> Its under their domain, but with the site being with a 3rd party it could
> be allowed
>
> 2. maybe Citrix could commit to pointing the current DNS entry to a new
> location (would be simplest but may be legally complex and relies on
> ongoing goodwill)
>
> 3. make a mod to allow users to choose the download location on install.
> We can then maintain apt-get. To remove the SPOF, we could then get the
> templates copied to a number of 3rd party locations and allow people to
> choose which one they use
>
>
>
>
> Kind Regards
> Giles
>
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: 16 May 2016 18:59
> To: dev@cloudstack.apache.org
> Cc: Wido den Hollander 
> Subject: Re: Migrating CloudStack content from download.cloud.com
>
> @Ian, yes, but I think there is more to it than that.  We can change it
> going forward and we can move everything from there over to a new domain.
> I believe the problem is with all of the existing ACS or CCP installs out
> there currently pointing at the download.cloud.com URL, so when it goes
> down, those installs have to be updated.
>
> Maybe I don't understand exactly, but that is the impression I am getting
> from this thread.  Can this be confirmed?
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> @CloudOps_
>
> On Mon, May 16, 2016 at 1:38 PM, Ian Rae  wrote:
>
> > Hey guys, who controls apt-get.eu and given the (rather concerning)
> > level of dependency on the operation of the download.cloud.com - would
> > it not make sense to use a domain that is under the control of party
> > whose alignment with CloudStack will not shift. I hesitate to
> > implicate the red tape of Apache Foundation, but perhaps the fabled
> > CloudStack alliance organization would be a good way to handle this
> > long term.
> >
> > On Mon, May 16, 2016 at 1:32 PM, Raja Pullela
> >  wrote:
> > > Paul,
> > >
> > > trust me, it won’t be go away overnight.  We are talking to Citrix
> > > and
> > requested them to keep it active for another year.
> > >
> > > Once we have the content copied over (I will work with Wido and
> > > verify
> > this) to cloudstack.apt-get.eu and update the documentation (user
> > guides update and create a wiki to show how an existing installation
> > can fixed to point to new URLs) we don’t have a dependency on “
> download.cloud.com” –
> > right?  sorry,

[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1552#issuecomment-220261024
  
Good catch! I can confirm that under Ubuntu 16.04 (Xenial) that is where 
the DHCP leases are stored.

root@example:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 16.04 LTS
Release:16.04
Codename:   xenial
root@example:~# ls /var/lib/dhcp/
dhclient.ens3.leases  dhclient6.ens3.leases
root@example:~#

LGTM for me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Jayapal Uradi]

Congrats Will.

Thanks,
Jayapal
> On 19-May-2016, at 1:54 pm, Rohit Yadav  wrote:
>
> Congrats Will.
>
> Regards,
> Rohit Yadav
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
> On May 19 2016, at 12:26 pm, Sebastien Goasguen  wrote:
>
> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making 
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases going 
> forward and has also taken a very active role to finish bringing us to github 
> based workflow and CI. Will has some updates on that front that I am sure you 
> will all like.
>
> -Sebastien
> Former VP CloudStack




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Some "type"s should refer to "WorkType" in HighAvailabilityDaoImpl.java

[Qian Shaohua]

Hi all,

 There are some HA bugs in CS 4.5.2. 

1. some "type"s should refer to "WorkType" in HighAvailabilityDaoImpl.java.
The same to master branch.

2. Mismatch uses of HighAvailabilityManagerImpl. _timeBetweenFailures. It
may be in seconds as
 HaWorkVO.timeToTry.

3. In

HighAvailabilityManagerImpl.restart(
 HaWorkVO work), the items' size got from
_haDao.listRunningHaWorkForVm is at least 1

 

And we add order for HA work taken sql, so that VR's HA can do first before
User VM's for efficiency.

 

 

diff --git a/server/src/com/cloud/ha/HighAvailabilityManagerImpl.java
b/server/src/com/cloud/ha/HighAvailabilityManagerImpl.java

index 29d0e2c..90cb97d 100755

--- a/server/src/com/cloud/ha/HighAvailabilityManagerImpl.java

+++ b/server/src/com/cloud/ha/HighAvailabilityManagerImpl.java

@@ -430,7 +430,8 @@ public class HighAvailabilityManagerImpl extends
ManagerBase implements HighAvai

 }

 items = _haDao.listRunningHaWorkForVm(work.getInstanceId());

-if (items.size() > 0) {

+// Current HA work is running, so items.size is at least 1

+if (items.size() > 1) {

 StringBuilder str = new StringBuilder("Waiting because there's
HA work being executed on an item currently.  Work Ids =[");

 for (HaWorkVO item : items) {

 str.append(item.getId()).append(", ");

@@ -796,7 +797,7 @@ public class HighAvailabilityManagerImpl extends
ManagerBase implements HighAvai

 _maxRetries = NumbersUtil.parseInt(value, 5);

 value = params.get("time.between.failures");

-_timeBetweenFailures = NumbersUtil.parseLong(value, 3600) * 1000;

+_timeBetweenFailures = NumbersUtil.parseLong(value, 3600);

 value = params.get("time.between.cleanup");

 _timeBetweenCleanups = NumbersUtil.parseLong(value, 3600 * 24);

@@ -859,7 +860,7 @@ public class HighAvailabilityManagerImpl extends
ManagerBase implements HighAvai

 s_logger.info("HA Cleanup Thread Running");

 try {

-_haDao.cleanup(System.currentTimeMillis() -
_timeBetweenFailures);

+_haDao.cleanup(System.currentTimeMillis() -
_timeBetweenFailures * 1000);

 } catch (Exception e) {

 s_logger.warn("Error while cleaning up", e);

 }

diff --git a/server/src/com/cloud/ha/dao/HighAvailabilityDaoImpl.java
b/server/src/com/cloud/ha/dao/HighAvailabilityDaoImpl.java

index 724f4f6..4ed7f53 100644

--- a/server/src/com/cloud/ha/dao/HighAvailabilityDaoImpl.java

+++ b/server/src/com/cloud/ha/dao/HighAvailabilityDaoImpl.java

@@ -98,20 +98,20 @@ public class HighAvailabilityDaoImpl extends
GenericDaoBase impl

 FutureHaWorkSearch = createSearchBuilder();

 FutureHaWorkSearch.and("instance",
FutureHaWorkSearch.entity().getInstanceId(), Op.EQ);

-FutureHaWorkSearch.and("type",
FutureHaWorkSearch.entity().getType(), Op.EQ);

+FutureHaWorkSearch.and("type",
FutureHaWorkSearch.entity().getWorkType(), Op.EQ);

 FutureHaWorkSearch.and("id", FutureHaWorkSearch.entity().getId(),
Op.GT);

 FutureHaWorkSearch.done();

 RunningHaWorkSearch = createSearchBuilder();

 RunningHaWorkSearch.and("instance",
RunningHaWorkSearch.entity().getInstanceId(), Op.EQ);

-RunningHaWorkSearch.and("type",
RunningHaWorkSearch.entity().getType(), Op.EQ);

+RunningHaWorkSearch.and("type",
RunningHaWorkSearch.entity().getWorkType(), Op.EQ);

 RunningHaWorkSearch.and("taken",
RunningHaWorkSearch.entity().getDateTaken(), Op.NNULL);

 RunningHaWorkSearch.and("step",
RunningHaWorkSearch.entity().getStep(), Op.NIN);

 RunningHaWorkSearch.done();

 PendingHaWorkSearch = createSearchBuilder();

 PendingHaWorkSearch.and("instance",
PendingHaWorkSearch.entity().getInstanceId(), Op.EQ);

-PendingHaWorkSearch.and("type",
PendingHaWorkSearch.entity().getType(), Op.EQ);

+PendingHaWorkSearch.and("type",
PendingHaWorkSearch.entity().getWorkType(), Op.EQ);

 PendingHaWorkSearch.and("step",
PendingHaWorkSearch.entity().getStep(), Op.NIN);

 PendingHaWorkSearch.done();

 }

@@ -154,7 +154,7 @@ public class HighAvailabilityDaoImpl extends
GenericDaoBase impl

 sc.setParameters("time", System.currentTimeMillis() >> 10);

 sc.setParameters("step", Step.Done, Step.Cancelled);

-final Filter filter = new Filter(HaWorkVO.class, null, true,
0l, 1l);

+final Filter filter = new Filter(HaWorkVO.class, "type", true,
0l, 1l);

 txn.start();

 final List vos = lockRows(sc, filter, true);

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220262092
  
Ok, so this PR seems to fix multiple things.

I would LGTM on the packaging fixes as well as the Python part.

The MySQL thing I'm not sure about. I wouldn't say that it is a problem 
perse, but we all know what one line of code can do (err, I mean break...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Additional Subnets for networks and VR dhcp

[Linas Žilinskas]

Ok, well thanks for confirmation of my findings.

So i tested creating VMs with API and it is indeed working like it
should. VR gets an alias for the additional subnet and dhcp is working
as expected.

I assume the alias is determined from the gateway on the nic.

So the flaw is in updateVmNicIp which doesn't update the gateway for the
nic when the IP is from a different subnet. This isn't that critical,
but i'll look into it later.

Regards
 

On Wed, 2016-05-18 at 17:24 +0200, Ronald van Zantvoort wrote:
> On 18/05/16 17:10, Linas Žilinskas wrote:
> > This is in relation to https://github.com/apache/cloudstack/pull/1547
> > But since it seems that my observations are beyond the scope of it, I'm
> > posting it here.
> >
> > I'm having hard time understanding what's going on, but something seems
> > off.
> > Like i mentioned in the PR comments, I'm using advanced networking with
> > security groups, so my setup is different to the PR which is meant for
> > Simple zones.
> >
> > My setup consists of initial zone deployment, with defaultGuestNetwork.
> > Then i created a new guest (through infrastructure) network with
> > 172.40.0.0/24, xx.1 gateway.
> > Then added additional subnet 172.50.0.0/24, xx.1 gateway.
> > Created a VM through web ui, which automatically got ip from
> > 172.40.0.0/24
> > Everything seems fine up to this point.
> >
> > Now I changed the ip to 172.50.0.xx through web ui. (interesting point -
> > the gateway doesn't change when IP is assigned from different subnet for
> > VM)
> >
> > Restarted VM / deleted VR.
> > And here's where i don't understand things anymore.
> > VR got assined an IP alias (original 172.40.0.10, additional
> > 172.40.0.11).
> >
> > I would guess it would need 172.50.0.xx to serve the additional subnet
> > (dhcp / metadata)
> 
> That is correct and it's one of the major things my PR fixes. You should 
> find in /var/log/cloud.log references to unparsed/unparseable ipalias.json.
> 
> That JSON contains all alias info:
>   cat /var/cache/cloud/processed/ip_aliases.json.1462968045
> {"aliases":[{ 
> "revoke":false,"ip_address":"172.50.0.11","netmask":"255.255.255.0","count":141
> },{
> "revoke":false,"ip_address":"172.40.0.11","netmask":"255.255.255.0","count":152
> }],"type":"ipaliases"}
> 
> The proposed PR parses through this file and sets up IP, DHCP, metadata 
> etc for each alias.
> 
> >
> > Some confirmation would be nice if this is the intended behavior and if
> > a situation like this is not supported / tested. Or is there some bug
> > somewhere.
> >
> > PS. I started looking into why the VR (4.8 release) dhcp doesn't serve
> > additional subnets. Found the above PR and was hoping it solves the
> > issue. But it seems there might be some problems above the VR as well.
> >
> The part where stuff seems weird in your case is that you got an 
> additional alias in the wrong range, which would seem to have to 
> originate from the CS mgr & db or an error in configuration.
> 

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220263263
  
@rhtyd and @DaanHoogland Could you maybe take a quick look at this one? We 
could finally get the first part of this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: How to fix Jenkins git workspace issues

[Daan Hoogland]

On Thu, May 19, 2016 at 7:22 AM, Rajani Karuturi  wrote:

> untracked


​good call Rajani, it was only doing an ordinary clean in the rat check
step.​



-- 
Daan

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[조대형]

Congratulations Will


Best regards,

---
IT Department 
Manager
Carl Cho
Email:  carl...@renet.kr 
Mobile : 010-4730-9928. Fax:  02-537-4599 

Netdedi at Renet Co.LTD 
https://www.netdedi.com




-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Thursday, May 19, 2016 3:57 PM
To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
us...@cloudstack.apache.org
Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Morning Everyone,

Yesterday at the ASF board meeting, the board passed the resolution making
Will Stevens the new Vice President of the Apache CloudStack project.

Join me in congratulating Will on this appointment, wish him luck and bring
your unwavering support !

You may have noticed that Will took on RM duties for the new releases going
forward and has also taken a very active role to finish bringing us to
github based  workflow and CI. Will has some updates on that front that I
am sure you will all like.

-Sebastien
Former VP CloudStack=

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Daan Hoogland]

thanks Sebastien,

looking forward to a workshop on your new endevours and please have a
thought for poor Will once in a while.

On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
jayapal.ur...@accelerite.com> wrote:

> Congrats Will.
>
> Thanks,
> Jayapal
> > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> wrote:
> >
> > Congrats Will.
> >
> > Regards,
> > Rohit Yadav
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> wrote:
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck and
> bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new releases
> going forward and has also taken a very active role to finish bringing us
> to github based workflow and CI. Will has some updates on that front that I
> am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>



-- 
Daan

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220273077
  
👍 (code review only)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63847694
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);
 
+/* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
-final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
--- End diff --

these names and paths should not be hardcoded here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220273707
  
moved duplicated codes to single method, and squashed the commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63848121
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String _type;
--- End diff --

name convention: please use type and refer to this.type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63848237
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String _type;
+
+ChannelType(String type) {
+_type = type;
+}
+
+@Override
+public String toString() {
+return _type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String _type;
+
+ChannelState(String type) {
+_type = type;
+}
+
+@Override
+public String toString() {
+return _type;
+}
+}
+
+private String _name;
 private String _path;
--- End diff --

this one is legacy but the others should be named without the '_'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63848326
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String _type;
+
+ChannelType(String type) {
+_type = type;
+}
+
+@Override
+public String toString() {
+return _type;
+}
+}
+
+enum ChannelState {
+DISCONNECTED("disconnected"), CONNECTED("connected");
+String _type;
+
+ChannelState(String type) {
+_type = type;
+}
+
+@Override
+public String toString() {
+return _type;
+}
+}
+
+private String _name;
 private String _path;
+private ChannelType _type;
+private ChannelState _state;
+
+public ChannelDef(String name, ChannelType type) {
+_name = name;
+_type = type;
+}
+
+public ChannelDef(String name, ChannelType type, String path) {
+_name = name;
+_path = path;
+_type = type;
+}
+
+public ChannelDef(String name, ChannelType type, ChannelState 
state) {
+_name = name;
+_state = state;
+_type = type;
+}
 
-public VirtioSerialDef(String name, String path) {
+public ChannelDef(String name, ChannelType type, ChannelState 
state, String path) {
 _name = name;
 _path = path;
+_state = state;
+_type = type;
--- End diff --

please remove the '_'s


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63848658
  
--- Diff: 
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParserTest.java
 ---
@@ -144,7 +152,7 @@ public void testDomainXMLParser() {
  "" +
  "" +
  "" +
- "" +
+ "" +
--- End diff --

to bad the kvm restructure didn't come through. we'd have this in a 
separate file ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220275302
  
apart from some code style and convention things LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63849851
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);
 
+/* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
-final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
--- End diff --

agree, @wido do you mind moving them something configurable via global 
settings or agent.properties


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63849902
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 ---
@@ -171,6 +173,25 @@ public boolean parseDomainXML(String domXML) {
 interfaces.add(def);
 }
 
+NodeList ports = devices.getElementsByTagName("channel");
+for (int i = 0; i < ports.getLength(); i++) {
+Element channel = (Element)ports.item(i);
+
+String type = channel.getAttribute("type");
+String path = getAttrValue("source", "path", channel);
+String name = getAttrValue("target", "name", channel);
+String state = getAttrValue("target", "state", channel);
+
+ChannelDef def = null;
+if (state == null || state.length() == 0) {
--- End diff --

we can use Strings.isNullOrEmpty here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63850026
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -1209,25 +1209,95 @@ public String toString() {
 }
 }
 
-public static class VirtioSerialDef {
-private final String _name;
+public static class ChannelDef {
+enum ChannelType {
+UNIX("unix"), SERIAL("serial");
+String _type;
--- End diff --

also, we can consider dropping the `_` as variable prefix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63850379
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);
 
+/* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
-final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
 }
 
+/* Add a VirtIO channel for the Qemu Guest Agent tools */
+devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", 
ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".org.qemu.guest_agent.0"));
--- End diff --

We're hardcoding channel type `unix` here, is that the default or should we 
allow users to choose between unix, serial and others? Also, about the guest 
agent name, while `/var/lib/libvirt/qemu` is the default path on most distros 
we should make it configurable or make it detect the path based on the env.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220278587
  
In general, a good idea and would be useful for flushing out disk IO and 
doing clean shutdown of VRs and vms. There are some outstanding issues, but the 
feature is nice.

I've not tested this, I suppose @wido would have tested this for 
Debian/Ubuntu based kvm hosts, we'll also need testing efforts on centos6 and 7 
based kvm hosts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r63851057
  
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse(SslCertVO 
cert, List chain, Certificate cert) {
 
-List certs = new ArrayList();
-Set anchors = new HashSet();
+final List certs = new ArrayList();
+final Set anchors = new HashSet();
 
 certs.add(cert); // adding for self signed certs
 certs.addAll(chain);
 
-for (Certificate c : certs) {
-if (!(c instanceof X509Certificate))
+for (final Certificate c : certs) {
+if (!(c instanceof X509Certificate)) {
 throw new IllegalArgumentException("Invalid chain format. 
Expected X509 certificate");
+}
 
-X509Certificate xCert = (X509Certificate)c;
+final X509Certificate xCert = (X509Certificate)c;
 
-Principal subject = xCert.getSubjectDN();
-Principal issuer = xCert.getIssuerDN();
+xCert.getSubjectDN();
+xCert.getIssuerDN();
 
anchors.add(new TrustAnchor(xCert, null));
 }
 
-X509CertSelector target = new X509CertSelector();
+final X509CertSelector target = new X509CertSelector();
 target.setCertificate((X509Certificate)cert);
 
 PKIXBuilderParameters params = null;
 try {
 params = new PKIXBuilderParameters(anchors, target);
 params.setRevocationEnabled(false);
 params.addCertStore(CertStore.getInstance("Collection", new 
CollectionCertStoreParameters(certs)));
-CertPathBuilder builder = CertPathBuilder.getInstance("PKIX", 
"BC");
+final CertPathBuilder builder = 
CertPathBuilder.getInstance("PKIX", "BC");
 builder.build(params);
 
-} catch (InvalidAlgorithmParameterException e) {
+} catch (final InvalidAlgorithmParameterException e) {
 throw new IllegalArgumentException("Invalid certificate 
chain", e);
-} catch (CertPathBuilderException e) {
+} catch (final CertPathBuilderException e) {
 throw new IllegalArgumentException("Invalid certificate 
chain", e);
-} catch (NoSuchAlgorithmException e) {
+} catch (final NoSuchAlgorithmException e) {
 throw new IllegalArgumentException("Invalid certificate 
chain", e);
-} catch (NoSuchProviderException e) {
+} catch (final NoSuchProviderException e) {
 throw new CloudRuntimeException("No provider for certificate 
validation", e);
 }
 
 }
 
-public PrivateKey parsePrivateKey(String key, String password) throws 
IOException {
-
-PasswordFinder pGet = null;
-
-if (password != null)
-pGet = new KeyPassword(password.toCharArray());
-
-PEMReader privateKey = new PEMReader(new StringReader(key), pGet);
-Object obj = null;
-try {
-obj = privateKey.readObject();
-} finally {
-IOUtils.closeQuietly(privateKey);
-}
-
-try {
-
-if (obj instanceof KeyPair)
-return ((KeyPair)obj).getPrivate();
-
-return (PrivateKey)obj;
-
-} catch (Exception e) {
+public PrivateKey parsePrivateKey(final String key, final String 
password) throws IOException {
+try (final PemReader pemReader = new PemReader(new 
StringReader(key));) {
+final PemObject pemObject = pemReader.readPemObject();
+final byte[] content = pemObject.getContent();
+final PKCS8EncodedKeySpec privKeySpec = new 
PKCS8EncodedKeySpec(content);
+final KeyFactory factory = KeyFactory.getInstance("RSA", "BC");
+return factory.generatePrivate(privKeySpec);
+} catch (NoSuchAlgorithmException | NoSuchProviderException e) {
+throw new IOException("No encryption provider available.", e);
+} catch (final InvalidKeySpecException e) {
 throw new IOException("Invalid Key format or invalid 
password.", e);
 }
 }
 
 public Certificate parseCertificate(String cert) {
-PEMReader certPem = new PEMReader(new StringReader(cert));
+final PemReader certPem = new PemReader(new StringReader(cert));
 try {
-return (Certificate)certPem.readObject();
-} catch (Exception e) {
+return readCertificateFromPemObject(cer

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r63851517
  
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse(SslCertVO 
cert, List chain, Certificate cert) {
 
-List certs = new ArrayList();
-Set anchors = new HashSet();
+final List certs = new ArrayList();
+final Set anchors = new HashSet();
 
 certs.add(cert); // adding for self signed certs
 certs.addAll(chain);
 
-for (Certificate c : certs) {
-if (!(c instanceof X509Certificate))
+for (final Certificate c : certs) {
+if (!(c instanceof X509Certificate)) {
 throw new IllegalArgumentException("Invalid chain format. 
Expected X509 certificate");
+}
 
-X509Certificate xCert = (X509Certificate)c;
+final X509Certificate xCert = (X509Certificate)c;
 
-Principal subject = xCert.getSubjectDN();
-Principal issuer = xCert.getIssuerDN();
+xCert.getSubjectDN();
+xCert.getIssuerDN();
 
anchors.add(new TrustAnchor(xCert, null));
 }
 
-X509CertSelector target = new X509CertSelector();
+final X509CertSelector target = new X509CertSelector();
 target.setCertificate((X509Certificate)cert);
 
 PKIXBuilderParameters params = null;
 try {
 params = new PKIXBuilderParameters(anchors, target);
 params.setRevocationEnabled(false);
 params.addCertStore(CertStore.getInstance("Collection", new 
CollectionCertStoreParameters(certs)));
-CertPathBuilder builder = CertPathBuilder.getInstance("PKIX", 
"BC");
+final CertPathBuilder builder = 
CertPathBuilder.getInstance("PKIX", "BC");
 builder.build(params);
 
-} catch (InvalidAlgorithmParameterException e) {
+} catch (final InvalidAlgorithmParameterException e) {
 throw new IllegalArgumentException("Invalid certificate 
chain", e);
-} catch (CertPathBuilderException e) {
+} catch (final CertPathBuilderException e) {
 throw new IllegalArgumentException("Invalid certificate 
chain", e);
-} catch (NoSuchAlgorithmException e) {
+} catch (final NoSuchAlgorithmException e) {
 throw new IllegalArgumentException("Invalid certificate 
chain", e);
-} catch (NoSuchProviderException e) {
+} catch (final NoSuchProviderException e) {
 throw new CloudRuntimeException("No provider for certificate 
validation", e);
 }
 
 }
 
-public PrivateKey parsePrivateKey(String key, String password) throws 
IOException {
-
-PasswordFinder pGet = null;
-
-if (password != null)
-pGet = new KeyPassword(password.toCharArray());
-
-PEMReader privateKey = new PEMReader(new StringReader(key), pGet);
-Object obj = null;
-try {
-obj = privateKey.readObject();
-} finally {
-IOUtils.closeQuietly(privateKey);
-}
-
-try {
-
-if (obj instanceof KeyPair)
-return ((KeyPair)obj).getPrivate();
-
-return (PrivateKey)obj;
-
-} catch (Exception e) {
+public PrivateKey parsePrivateKey(final String key, final String 
password) throws IOException {
+try (final PemReader pemReader = new PemReader(new 
StringReader(key));) {
+final PemObject pemObject = pemReader.readPemObject();
+final byte[] content = pemObject.getContent();
+final PKCS8EncodedKeySpec privKeySpec = new 
PKCS8EncodedKeySpec(content);
+final KeyFactory factory = KeyFactory.getInstance("RSA", "BC");
+return factory.generatePrivate(privKeySpec);
+} catch (NoSuchAlgorithmException | NoSuchProviderException e) {
+throw new IOException("No encryption provider available.", e);
+} catch (final InvalidKeySpecException e) {
 throw new IOException("Invalid Key format or invalid 
password.", e);
 }
 }
 
 public Certificate parseCertificate(String cert) {
-PEMReader certPem = new PEMReader(new StringReader(cert));
+final PemReader certPem = new PemReader(new StringReader(cert));
 try {
-return (Certificate)certPem.readObject();
-} catch (Exception e) {
+return readCertificateFromPemObject(cer

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r63852079
  
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 
---
@@ -429,60 +434,42 @@ private void validateChain(List chain, 
Certificate cert) {
 
 }
 
-public PrivateKey parsePrivateKey(String key, String password) throws 
IOException {
-
-PasswordFinder pGet = null;
-
-if (password != null)
-pGet = new KeyPassword(password.toCharArray());
-
-PEMReader privateKey = new PEMReader(new StringReader(key), pGet);
-Object obj = null;
-try {
-obj = privateKey.readObject();
-} finally {
-IOUtils.closeQuietly(privateKey);
-}
-
-try {
-
-if (obj instanceof KeyPair)
-return ((KeyPair)obj).getPrivate();
-
-return (PrivateKey)obj;
-
-} catch (Exception e) {
+public PrivateKey parsePrivateKey(final String key) throws IOException 
{
+try (final PemReader pemReader = new PemReader(new 
StringReader(key));) {
+final PemObject pemObject = pemReader.readPemObject();
+final byte[] content = pemObject.getContent();
+final PKCS8EncodedKeySpec privKeySpec = new 
PKCS8EncodedKeySpec(content);
+final KeyFactory factory = KeyFactory.getInstance("RSA", "BC");
+return factory.generatePrivate(privKeySpec);
+} catch (NoSuchAlgorithmException | NoSuchProviderException e) {
+throw new IOException("No encryption provider available.", e);
+} catch (final InvalidKeySpecException e) {
 throw new IOException("Invalid Key format or invalid 
password.", e);
--- End diff --

changed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220281463
  
@swill, did this pass the (not so C)I?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220289585
  
@swill I was able to reproduce the addHost issue and fixed it. I was able 
to deploy against a KVM env with two clusters with Ubuntu and CentOS based 
hosts in each: (addHost can fail silently if we're trying to mix CentOS and 
Ubuntu KVM hosts in the same cluster)

![screenshot from 2016-05-19 
16-01-48](https://cloud.githubusercontent.com/assets/95203/15390946/46eb9f38-1ddc-11e6-8b78-0d6fb25c0535.png)

If possible, I would request for this bugfix to be added in 4.9.0 release 
as it fixes:

- critical nio reconnection, improves SSL handling by making it non-blocking
- without this fix, agents (kvm, systemvm etc) can take some time (minutes 
to hours) to reconnect
- the management server's agent handler on port 8250 can be pwned by a 
single telnet (or similar malicious) client. To test, on existing deployments 
without this patch just connect a telnet agent on port 8250 of the mgmt server, 
now this mgmt server can no longer immediately handle any agent connection (try 
restarting kvm agent for example).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Discuss] CloudStack documentation

[Dag Sonstebo]

All,

since we've added CloudStack documentation to the discussion topics for the 
Montreal meetup I wanted to gauge peoples opinion on areas of improvement.

Personally I would like to see the following:

  1.  Overall documentation navigation needs to be improved.
  2.  Ideally all documentation should be under a single documentation tree 
with a single table of contents. All content should be searchable without 
having to visit each of the current documentation roots separately (Getting 
Started / Installation Guide / Admin Guide / Release Notes).
  3.  Advanced topics should be moved away from the "Getting Started Docs". The 
people reading the getting started / concepts sections are typically new 
CloudStack users  who will easily be put off by immediately being presented 
with advanced topics.
  4.  API documentation to be a chapter of the Developers guide.
  5.  Upgrade instructions to be moved from the release notes to the 
installation guide.
  6.  Compatibility matrix in single location only – i.e. not in both the 
release notes and installation guide as this has caused discrepancies in the 
past.

I appreciate we are also working against multiple Github repositories which 
complicates things slightly, but if we can overall improve the end user 
experience this is worth the effort.

Thoughts?

Regards,

dag.sonst...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220295771
  
@ustcweizhou this failed due to an error in the jenkins config. can you 
reopen it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220295817
  
I see.

Shouldn't the system be using annotations to make this less brittle.

At present, there's no obvious way to see that changing these variable 
names will break anything.

At the least, we should have unit tests that look for certain variable 
names in certain classes and fail if expected ones no longer exist.

On May 18, 2016, at 11:05 PM, Anshul Gangwar 
mailto:notificati...@github.com>> wrote:


@mike-tutkowski First one which I hit is 
in ModifyStoragePoolCommand.java. But I am sure there will be more. Hyper-V 
uses json to communicate between management server and Hyper-V agent. So if we 
are changing variable names it no longer will be able to parse that info.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220295965
  
this failed due to a jenkins config error. can you reopen it @nlivens ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[ustcweizhou]

Github user ustcweizhou closed the pull request at:

https://github.com/apache/cloudstack/pull/1410


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[ustcweizhou]

GitHub user ustcweizhou reopened a pull request:

https://github.com/apache/cloudstack/pull/1410

CLOUDSTACK-6928: fix issue disk I/O throttling not applied

Disk IO throttling (for KVM) is not applied in the merge of 4.2.

Tests passed:
(1) start vm
(2) attach volume
(3) start vm with volume
(4) migrate vm (with volume)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
CLOUDSTACK-6928-io-throttling

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1410


commit 976b3b7df4fda3e51a9e32ca00729caacec3983e
Author: Wei Zhou 
Date:   2016-02-09T11:55:41Z

CLOUDSTACK-6928: fix issue disk I/O throttling not applied




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1549

CLOUDSTACK-9348: NioConnection improvements

Reopened PR with squashed changes for a re-review and testing after 
https://github.com/apache/cloudstack/pull/1493 and sub-sequent PRs got reverted

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack nio-fixagain-singlepr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1549


commit 9c7518698d2f4a9fcc6a83fd22dd5b2fc4260232
Author: Rohit Yadav 
Date:   2016-04-14T18:54:53Z

CLOUDSTACK-9348: NioConnection improvements

- Unit test to demonstrate denial of service attack
  The NioConnection uses blocking handlers for various events such as 
connect,
  accept, read, write. In case a client connects NioServer (used by
  agent mgr to service agents on port 8250) but fails to participate in SSL
  handshake or just sits idle, this would block the main IO/selector loop in
  NioConnection. Such a client could be either malicious or aggresive.

  This unit test demonstrates such a malicious client that can perform a
  denial-of-service attack on NioServer that blocks it to serve any other 
client.

- Use non-blocking SSL handshake
  - Uses non-blocking socket config in NioClient and NioServer/NioConnection
  - Scalable connectivity from agents and peer clustered-management server
  - Removes blocking ssl handshake code with a non-blocking code
  - Protects from denial-of-service issues that can degrade mgmt server 
responsiveness
due to an aggressive/malicious client
  - Uses separate executor services for handling ssl handshakes

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1297

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1297


commit 0d02a778fa89a175a5e1869766202f2308f23fcf
Author: Loic Lambiel 
Date:   2015-05-15T13:15:26Z

CLOUDSTACK-9203 Prevent security group update while instance is running

  cherry-picked from a exoscale internal fix

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

commit aa72dbd814de4ea88f1835a3eb99053082a2e84c
Author: Daan Hoogland 
Date:   2015-12-30T12:13:38Z

CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit f72c8f23b4a35bea10455e70dbc30afeee29
Author: Daan Hoogland 
Date:   2015-12-30T12:13:38Z

CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit 659f527095fe24f55cbe2a73ecbe6eec31714052
Author: Wei Zhou 
Date:   2016-01-12T09:56:07Z

CLOUDSTACK-9203: fix issue if there are multiple shared networks

commit 64e5792d347540df505dff88087a33d8d62bc0e4
Author: Wei Zhou 
Date:   2016-01-22T11:45:13Z

CLOUDSTACK-9203: fix issue when update vm in isolated networks

commit acf0213f1cee740ec9ff6c9df902ab5a64adb922
Author: Daan Hoogland 
Date:   2016-04-11T18:22:34Z

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java

commit 976feb31862b5b17f3a3d139bd348ac501cc512b
Author: Daan Hoogland 
Date:   2016-04-11T18:22:34Z

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1297

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1297


commit 0d02a778fa89a175a5e1869766202f2308f23fcf
Author: Loic Lambiel 
Date:   2015-05-15T13:15:26Z

CLOUDSTACK-9203 Prevent security group update while instance is running

  cherry-picked from a exoscale internal fix

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

commit aa72dbd814de4ea88f1835a3eb99053082a2e84c
Author: Daan Hoogland 
Date:   2015-12-30T12:13:38Z

CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit f72c8f23b4a35bea10455e70dbc30afeee29
Author: Daan Hoogland 
Date:   2015-12-30T12:13:38Z

CLOUDSTACK-9203 refactorred DeployVM code to be used by UpdateVM as well

 Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

commit 659f527095fe24f55cbe2a73ecbe6eec31714052
Author: Wei Zhou 
Date:   2016-01-12T09:56:07Z

CLOUDSTACK-9203: fix issue if there are multiple shared networks

commit 64e5792d347540df505dff88087a33d8d62bc0e4
Author: Wei Zhou 
Date:   2016-01-22T11:45:13Z

CLOUDSTACK-9203: fix issue when update vm in isolated networks

commit acf0213f1cee740ec9ff6c9df902ab5a64adb922
Author: Daan Hoogland 
Date:   2016-04-11T18:22:34Z

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java

commit 976feb31862b5b17f3a3d139bd348ac501cc512b
Author: Daan Hoogland 
Date:   2016-04-11T18:22:34Z

CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
server/src/com/cloud/vm/UserVmManager.java
server/src/com/cloud/vm/UserVmManagerImpl.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220301483
  
@ustcweizhou sorry to burden you again but can you try once more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

jenkins pr check

[Daan Hoogland]

People,

I've asked several people to reopen their pr because of jenkins
configuration problems. I think i found the little checkbox that needed
setting now. Please do not hurry but reopen any failed PRs on jenkins
problems, if you fell it wasn't in your code. don't do it all at once as
builds.a.o is kind of heavily loaded.

-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[ustcweizhou]

GitHub user ustcweizhou reopened a pull request:

https://github.com/apache/cloudstack/pull/1410

CLOUDSTACK-6928: fix issue disk I/O throttling not applied

Disk IO throttling (for KVM) is not applied in the merge of 4.2.

Tests passed:
(1) start vm
(2) attach volume
(3) start vm with volume
(4) migrate vm (with volume)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
CLOUDSTACK-6928-io-throttling

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1410


commit 976b3b7df4fda3e51a9e32ca00729caacec3983e
Author: Wei Zhou 
Date:   2016-02-09T11:55:41Z

CLOUDSTACK-6928: fix issue disk I/O throttling not applied




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[ustcweizhou]

Github user ustcweizhou closed the pull request at:

https://github.com/apache/cloudstack/pull/1410


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Discuss] CloudStack documentation

[Ron Wheeler]

Removal of duplicate information as part of item 2 . Item 5 has this 
implicitly.


Item 3 +1

"Marketing" information targeted at SMB market.

Ron

On 19/05/2016 6:54 AM, Dag Sonstebo wrote:

All,

since we've added CloudStack documentation to the discussion topics for the 
Montreal meetup I wanted to gauge peoples opinion on areas of improvement.

Personally I would like to see the following:

   1.  Overall documentation navigation needs to be improved.
   2.  Ideally all documentation should be under a single documentation tree 
with a single table of contents. All content should be searchable without 
having to visit each of the current documentation roots separately (Getting 
Started / Installation Guide / Admin Guide / Release Notes).
   3.  Advanced topics should be moved away from the "Getting Started Docs". 
The people reading the getting started / concepts sections are typically new CloudStack 
users  who will easily be put off by immediately being presented with advanced topics.
   4.  API documentation to be a chapter of the Developers guide.
   5.  Upgrade instructions to be moved from the release notes to the 
installation guide.
   6.  Compatibility matrix in single location only – i.e. not in both the 
release notes and installation guide as this has caused discrepancies in the 
past.

I appreciate we are also working against multiple Github repositories which 
complicates things slightly, but if we can overall improve the end user 
experience this is worth the effort.

Thoughts?

Regards,

dag.sonst...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue





--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: [Discuss] CloudStack documentation

[Ron Wheeler]

Identify where most issues are raised in the ML and fix the docs to 
reduce the confusion.
I suspect that Networking is the source of most problems but perhaps 
other have a better sense of this.


Ron

On 19/05/2016 8:29 AM, Ron Wheeler wrote:
Removal of duplicate information as part of item 2 . Item 5 has this 
implicitly.


Item 3 +1

"Marketing" information targeted at SMB market.

Ron

On 19/05/2016 6:54 AM, Dag Sonstebo wrote:

All,

since we've added CloudStack documentation to the discussion topics 
for the Montreal meetup I wanted to gauge peoples opinion on areas of 
improvement.


Personally I would like to see the following:

   1.  Overall documentation navigation needs to be improved.
   2.  Ideally all documentation should be under a single 
documentation tree with a single table of contents. All content 
should be searchable without having to visit each of the current 
documentation roots separately (Getting Started / Installation Guide 
/ Admin Guide / Release Notes).
   3.  Advanced topics should be moved away from the "Getting Started 
Docs". The people reading the getting started / concepts sections are 
typically new CloudStack users  who will easily be put off by 
immediately being presented with advanced topics.

   4.  API documentation to be a chapter of the Developers guide.
   5.  Upgrade instructions to be moved from the release notes to the 
installation guide.
   6.  Compatibility matrix in single location only – i.e. not in 
both the release notes and installation guide as this has caused 
discrepancies in the past.


I appreciate we are also working against multiple Github repositories 
which complicates things slightly, but if we can overall improve the 
end user experience this is worth the effort.


Thoughts?

Regards,

dag.sonst...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue








--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: MySQL : No suitable driver found for jdbc:mysql

[Nick LIVENS]

When I add the mysql-connector-java.jar to /usr/lib/jvm/java/jre/lib/ext
without touching the CLASSPATH in /etc/sysconfig/cloudstack-management it's
working fine as well..
So either something is broken in the tomcat class loading mechanism, either
it's related to some environment specifics of mine..

Still digging deeper, keeping you guys posted..

Kind regards,
Nick Livens

On Thu, May 19, 2016 at 10:05 AM, Nick LIVENS  wrote:

> Now I'm totally clueless, perhaps I'm hitting a bug in tomcat?
> Following the official documentation of Apache Tomcat 7.0 (
> http://tomcat.apache.org/tomcat-7.0-doc/jndi-datasource-examples-howto.html
> )
>
> Especially the following part :
> "java.sql.DriverManager supports the service provider
> 
>  mechanism. This feature is that all the available JDBC drivers that
> announce themselves by providing a META-INF/services/java.sql.Driver file
> are automatically discovered, loaded and registered, relieving you from the
> need to load the database driver explicitly before you create a JDBC
> connection. However, the implementation is fundamentally broken in all Java
> versions for a servlet container environment. The problem is that
> java.sql.DriverManager will scan for the drivers only once.
>
> The JRE Memory Leak Prevention Listener
>  that is
> included with Apache Tomcat solves this by triggering the drivers scan
> during Tomcat startup. This is enabled by default. It means that only
> libraries visible to the listener such as the ones in $CATALINA_BASE/lib will
> be scanned for database drivers. If you are considering disabling this
> feature, note that the scan would be triggered by the first web application
> that is using JDBC, leading to failures when this web application is
> reloaded and for other web applications that rely on this feature.
>
> Thus, the web applications that have database drivers in their WEB-INF/lib 
> directory
> cannot rely on the service provider mechanism and should register the
> drivers explicitly.
>
> The list of drivers in java.sql.DriverManager is also a known source of
> memory leaks. Any Drivers registered by a web application must be
> deregistered when the web application stops. Tomcat will attempt to
> automatically discover and deregister any JDBC drivers loaded by the web
> application class loader when the web application stops. However, it is
> expected that applications do this for themselves via a
> ServletContextListener."
> I've checked all steps :
> * My mysql-connector-java contains the META-INF/services/java.sql.Driver
> file
> * This JAR is located in /usr/share/cloudstack-management/lib/
> * CATALINA_BASE = /usr/share/cloudstack-management
>
> These are the 3 steps to make the JDBC drivers auto register themselves,
> and this is not working.
> I've also found a thread on stackoverflow where someone is hitting the
> same issue - 2nd reply (
> http://stackoverflow.com/questions/20224222/how-to-register-oracle-jdbc-driver-on-tomcat-7-0-47-startup
> )
>
> Kind regards,
> Nick Livens
>
> On Wed, May 18, 2016 at 6:25 PM, Simon Weller  wrote:
>
>> Are you able to test this on a cleanly installed OS?
>>
>> It sounds like you've potentially got quite a few customizations and I
>> think it would be helpful to see whether this can be reproduced on a clean
>> install.
>>
>> 
>> From: Nick LIVENS 
>> Sent: Wednesday, May 18, 2016 11:02 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: MySQL : No suitable driver found for jdbc:mysql
>>
>> I've digged a bit deeper, and I've got it working by explicitly loading
>> the
>> MySQL JDBC driver with the following code change in
>> TransactionLegacy.java :
>>
>> static {
>> try {
>> Class.forName("com.mysql.jdbc.Driver");
>> } catch (ClassNotFoundException e) {
>> throw new CloudRuntimeException("Failed to load MySQL JDBC
>> driver", e);
>> }
>>
>> // Initialize with assumed db.properties file
>> initDataSource(DbProperties.getDbProperties());
>> }
>>
>> This is the old way of doing it (< JDBC 4.0)
>> I know that from that version onwards that these drivers are loaded
>> automatically, so I thought that our mysql-connector was outdated.
>> I've replaced it with the latest, but without success. The issue is still
>> there.
>>
>> I've got 2 solutions, but either way, it should work with the current
>> master ACS without changing stuff manually.
>> * This code change
>> * Changing the /etc/sysconfig/cloudstack-management file again, so that
>> CLASSPATH contains the mysql-connector-java.jar again
>>
>> Any help / suggestions / ideas are much appreciated.
>>
>> Kind regards,
>> Nick Livens
>>
>>
>> On Wed, May 18, 2016 at 4:43 PM, Nick LIVENS <
>> nick.liv...@nuagenetworks.net>
>> wrote:
>>
>> > Java :
>> > [root@csc-1 ~]# java -version
>> > ja

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Sanjeev Neelarapu]

Congratulations Will!!

Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelar...@accelerite.com 



-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, May 19, 2016 2:55 PM
To: dev 
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

thanks Sebastien,

looking forward to a workshop on your new endevours and please have a thought 
for poor Will once in a while.

On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi < jayapal.ur...@accelerite.com> 
wrote:

> Congrats Will.
>
> Thanks,
> Jayapal
> > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> wrote:
> >
> > Congrats Will.
> >
> > Regards,
> > Rohit Yadav
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> wrote:
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck and
> bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new releases
> going forward and has also taken a very active role to finish bringing us
> to github based workflow and CI. Will has some updates on that front that I
> am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>



-- 
Daan



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Syed Mushtaq]

Congratulations Will! Super excited to be working with you :)

-Syed

On Thu, May 19, 2016 at 5:24 AM, Daan Hoogland 
wrote:

> thanks Sebastien,
>
> looking forward to a workshop on your new endevours and please have a
> thought for poor Will once in a while.
>
> On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
> jayapal.ur...@accelerite.com> wrote:
>
> > Congrats Will.
> >
> > Thanks,
> > Jayapal
> > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > wrote:
> > >
> > > Congrats Will.
> > >
> > > Regards,
> > > Rohit Yadav
> > >
> > >
> > > rohit.ya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > wrote:
> > >
> > > Morning Everyone,
> > >
> > > Yesterday at the ASF board meeting, the board passed the resolution
> > making Will Stevens the new Vice President of the Apache CloudStack
> project.
> > >
> > > Join me in congratulating Will on this appointment, wish him luck and
> > bring your unwavering support !
> > >
> > > You may have noticed that Will took on RM duties for the new releases
> > going forward and has also taken a very active role to finish bringing us
> > to github based workflow and CI. Will has some updates on that front
> that I
> > am sure you will all like.
> > >
> > > -Sebastien
> > > Former VP CloudStack
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Daan
>

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220326489
  
@DaanHoogland  to your question :

We are embarking full CloudStack build automation as that gives us 
cloudstack-nuagevsp-plugin <> nuagevsp-client-jar version compatibility by 
design, and provides us higher development efficiency as it gives us java 
compile time checking.

We could publish the code at our github.com/nuagenetworks repo's if that is 
desired. I see this is not consistently applied by other vendors though.

Let me know if there are other actions to take, or feel free to shoot any 
additional question.

cheers,
Kris


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Paul Angus]

Thank you Sebastien and congratulations Will.


Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Syed Mushtaq [mailto:syed1.mush...@gmail.com] 
Sent: 19 May 2016 14:25
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Congratulations Will! Super excited to be working with you :)

-Syed

On Thu, May 19, 2016 at 5:24 AM, Daan Hoogland 
wrote:

> thanks Sebastien,
>
> looking forward to a workshop on your new endevours and please have a 
> thought for poor Will once in a while.
>
> On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi < 
> jayapal.ur...@accelerite.com> wrote:
>
> > Congrats Will.
> >
> > Thanks,
> > Jayapal
> > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > > 
> > wrote:
> > >
> > > Congrats Will.
> > >
> > > Regards,
> > > Rohit Yadav
> > >
> > >
> > > rohit.ya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > >
> > >
> > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > wrote:
> > >
> > > Morning Everyone,
> > >
> > > Yesterday at the ASF board meeting, the board passed the resolution
> > making Will Stevens the new Vice President of the Apache CloudStack
> project.
> > >
> > > Join me in congratulating Will on this appointment, wish him luck and
> > bring your unwavering support !
> > >
> > > You may have noticed that Will took on RM duties for the new releases
> > going forward and has also taken a very active role to finish bringing us
> > to github based workflow and CI. Will has some updates on that front
> that I
> > am sure you will all like.
> > >
> > > -Sebastien
> > > Former VP CloudStack
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Daan
>

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Suresh Sadhu]

Congratulations Will!!

Regards
Sadhu

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Thursday, May 19, 2016 2:55 PM
To: dev 
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

thanks Sebastien,

looking forward to a workshop on your new endevours and please have a thought 
for poor Will once in a while.

On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi < jayapal.ur...@accelerite.com> 
wrote:

> Congrats Will.
>
> Thanks,
> Jayapal
> > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> wrote:
> >
> > Congrats Will.
> >
> > Regards,
> > Rohit Yadav
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> wrote:
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck 
> > and
> bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new 
> > releases
> going forward and has also taken a very active role to finish bringing 
> us to github based workflow and CI. Will has some updates on that 
> front that I am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which 
> is the property of Accelerite, a Persistent Systems business. It is 
> intended only for the use of the individual or entity to which it is 
> addressed. If you are not the intended recipient, you are not 
> authorized to read, retain, copy, print, distribute or use this 
> message. If you have received this communication in error, please 
> notify the sender and delete all copies of this message. Accelerite, a 
> Persistent Systems business does not accept any liability for virus infected 
> mails.
>



--
Daan



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Rafael Weingärtner]

Thanks for all the hard work you have been doing.
Congratulations Will.


On Thu, May 19, 2016 at 11:11 AM, Suresh Sadhu 
wrote:

> Congratulations Will!!
>
> Regards
> Sadhu
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, May 19, 2016 2:55 PM
> To: dev 
> Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
> Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> thanks Sebastien,
>
> looking forward to a workshop on your new endevours and please have a
> thought for poor Will once in a while.
>
> On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
> jayapal.ur...@accelerite.com> wrote:
>
> > Congrats Will.
> >
> > Thanks,
> > Jayapal
> > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > wrote:
> > >
> > > Congrats Will.
> > >
> > > Regards,
> > > Rohit Yadav
> > >
> > >
> > > rohit.ya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > >
> > >
> > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > wrote:
> > >
> > > Morning Everyone,
> > >
> > > Yesterday at the ASF board meeting, the board passed the resolution
> > making Will Stevens the new Vice President of the Apache CloudStack
> project.
> > >
> > > Join me in congratulating Will on this appointment, wish him luck
> > > and
> > bring your unwavering support !
> > >
> > > You may have noticed that Will took on RM duties for the new
> > > releases
> > going forward and has also taken a very active role to finish bringing
> > us to github based workflow and CI. Will has some updates on that
> > front that I am sure you will all like.
> > >
> > > -Sebastien
> > > Former VP CloudStack
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which
> > is the property of Accelerite, a Persistent Systems business. It is
> > intended only for the use of the individual or entity to which it is
> > addressed. If you are not the intended recipient, you are not
> > authorized to read, retain, copy, print, distribute or use this
> > message. If you have received this communication in error, please
> > notify the sender and delete all copies of this message. Accelerite, a
> > Persistent Systems business does not accept any liability for virus
> infected mails.
> >
>
>
>
> --
> Daan
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>



-- 
Rafael Weingärtner

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Nicolás Vázquez]

Congratulations Will!

2016-05-19 11:21 GMT-03:00 Rafael Weingärtner :

> Thanks for all the hard work you have been doing.
> Congratulations Will.
>
>
> On Thu, May 19, 2016 at 11:11 AM, Suresh Sadhu <
> suresh.sa...@accelerite.com>
> wrote:
>
> > Congratulations Will!!
> >
> > Regards
> > Sadhu
> >
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Thursday, May 19, 2016 2:55 PM
> > To: dev 
> > Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
> > Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
> >
> > thanks Sebastien,
> >
> > looking forward to a workshop on your new endevours and please have a
> > thought for poor Will once in a while.
> >
> > On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
> > jayapal.ur...@accelerite.com> wrote:
> >
> > > Congrats Will.
> > >
> > > Thanks,
> > > Jayapal
> > > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > > wrote:
> > > >
> > > > Congrats Will.
> > > >
> > > > Regards,
> > > > Rohit Yadav
> > > >
> > > >
> > > > rohit.ya...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > > >
> > > >
> > > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > > wrote:
> > > >
> > > > Morning Everyone,
> > > >
> > > > Yesterday at the ASF board meeting, the board passed the resolution
> > > making Will Stevens the new Vice President of the Apache CloudStack
> > project.
> > > >
> > > > Join me in congratulating Will on this appointment, wish him luck
> > > > and
> > > bring your unwavering support !
> > > >
> > > > You may have noticed that Will took on RM duties for the new
> > > > releases
> > > going forward and has also taken a very active role to finish bringing
> > > us to github based workflow and CI. Will has some updates on that
> > > front that I am sure you will all like.
> > > >
> > > > -Sebastien
> > > > Former VP CloudStack
> > >
> > >
> > >
> > >
> > > DISCLAIMER
> > > ==
> > > This e-mail may contain privileged and confidential information which
> > > is the property of Accelerite, a Persistent Systems business. It is
> > > intended only for the use of the individual or entity to which it is
> > > addressed. If you are not the intended recipient, you are not
> > > authorized to read, retain, copy, print, distribute or use this
> > > message. If you have received this communication in error, please
> > > notify the sender and delete all copies of this message. Accelerite, a
> > > Persistent Systems business does not accept any liability for virus
> > infected mails.
> > >
> >
> >
> >
> > --
> > Daan
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Rafael Weingärtner
>

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Ahmad Emneina]

Awesome stuff Will! Congrats.

Ahmad E

> On May 18, 2016, at 11:56 PM, Sebastien Goasguen  wrote:
> 
> Morning Everyone,
> 
> Yesterday at the ASF board meeting, the board passed the resolution making 
> Will Stevens the new Vice President of the Apache CloudStack project.
> 
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your unwavering support !
> 
> You may have noticed that Will took on RM duties for the new releases going 
> forward and has also taken a very active role to finish bringing us to github 
> based  workflow and CI. Will has some updates on that front that I am sure 
> you will all like.
> 
> -Sebastien
> Former VP CloudStack

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220342553
  
Thanks for the feedback, I will work on that tomorrow.

@rhtyd I tested this on both Ubuntu and CentOS systems.

The main issue with Ubuntu is AppArmor where libvirt isn't allowed to write 
in /var/lib/qemu.

I'll make that directory configurable, but keep in mind that on all 
platforms I know that is the directory where the sockets are stored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63889814
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);
 
+/* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
-final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
--- End diff --

This has always been hardcoded, it's just that I'm moving this part.

This is the SSVM socket which is already there. The socket patch code wants 
to find the .agent there. Not much I can do there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481
  
Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM.

```
 $ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:   trusty

$ls  /var/lib/dhcp/
dhclient.leases

```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63893791
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+self.assertEqual(
+capacity_state[1][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[1][0])
+
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type = 3 order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertNotEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+return capacity_state[0][0]
+
+
+class TestHosts(cloudstackTestCase):
+
+"""
+Testing Hosts
+"""
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestHosts, cls).getClsTestClient()
+cls.testdata = cls.testClient.getParsedTestDataConfig()
+cls.apiclient = cls.testClient.getApiClient()
+cls.dbclient = cls.testClient.getDbConnection()
+cls._cleanup = []
+
+# get zone, domain etc
+cls.zone = Zone(get_zone(cls.apiclient, 
cls.testClient.getZoneForTests()).__dict__)
+cls.domain = get_domain(cls.apiclient)
+cls.pod = get_pod(cls.apiclient, cls.zone.id)
+
+cls.logger = logging.getLogger('TestHosts')
+cls.stream_handler = logging.

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63893826
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+self.assertEqual(
+capacity_state[1][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[1][0])
+
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type = 3 order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertNotEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+return capacity_state[0][0]
+
+
+class TestHosts(cloudstackTestCase):
+
+"""
+Testing Hosts
+"""
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestHosts, cls).getClsTestClient()
+cls.testdata = cls.testClient.getParsedTestDataConfig()
+cls.apiclient = cls.testClient.getApiClient()
+cls.dbclient = cls.testClient.getDbConnection()
+cls._cleanup = []
+
+# get zone, domain etc
+cls.zone = Zone(get_zone(cls.apiclient, 
cls.testClient.getZoneForTests()).__dict__)
+cls.domain = get_domain(cls.apiclient)
+cls.pod = get_pod(cls.apiclient, cls.zone.id)
+
+cls.logger = logging.getLogger('TestHosts')
+cls.stream_handler = logging.

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63894357
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
--- End diff --

This check is not required. The check_db will only be invoked if there is a 
host_db_id, storage_pool_db_id and capacity check =3. 
In my last check in I have added checks for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Migrating CloudStack content from download.cloud.com

[Giles Sirett]

Erik
I agree on the existing users - not the end of the world. We could even release 
a tiny patch to update the DB records

The piece that we need to be really careful with is the "I've just downloaded 
cloudstack  thing for the first time" scenario 

But - there seems to be plenty of good ideas flowing on that


Kind Regards
Giles


giles.sir...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com] 
Sent: 19 May 2016 09:32
To: dev 
Subject: Re: Migrating CloudStack content from download.cloud.com

As a user (with old ACS installations) I'd say that this isn't all that 
troublesome, this is easily fixed by updating the appropriate db records.

We should ensure that we have some good posts discovered by Google and other 
search engines, so that when somebody running old installations hit this issue 
they find the workaround.
There's a lot of time to reach out to users and inform of the fix necessary.

--
Erik


On Tue, May 17, 2016 at 10:34 AM, Giles Sirett 
wrote:

> This is a MAJOR problem and needs to be figured out before the current
> download site is removed - @Raja - have Citrix committed to it being there
> another year ?
>
> It is my understanding that Cloudstack relies on this download at initial
> build/startup and then periodically if people do things like build a new
> zone
>
> So, users environments aren't going to stop if its pulled, but nobody
> would be a able to build/install cloudstack and it may cause issues as and
> when users make config changes
>
> The problem is, for new builds, its hard coded : you start the  Sec
> Storage VM, CloudStack will try to download the built in template from
> download.cloud.com
>
> My understanding is that its simple db  change to make once an environment
> is running (exisiting users) but *may* require a code patch to fix the
> initial install
>
> #notideal
>
> Really, this should be maintained by ASF/ the project as its key to the
> software working, however my understanding is it involves binaries which
> ASF is never keen on (and may be some 3rd party binaries) - so that just
> wont happen
>
>
>
> Apt-get is controlled by Wido et al (for which we all owe him a massive
> thanks)  - but you are right, it is a 3rd party dependency and arguably a
> SPOF.  But, if ASF wont host binaries, we're always going to have this
> issue.
>
> So, we could patch the code to point somewhere else - but where ? - by
> definition its got to be something maintained by a 3rd party
>
>
> We had this debate some time ago when talking about the repositories. We
> (ShapeBlue) maintain a repo for our customers, which wev'e always opened up
> as public. However, there were concerns about having a company domain name
> (which I understand) - so apt-get became our preferred repo.
>
>
> Thoughts on how to fix this:
>
> 1. if ASF would allow us to create the host entry download.cloudstack.org.
> Its under their domain, but with the site being with a 3rd party it could
> be allowed
>
> 2. maybe Citrix could commit to pointing the current DNS entry to a new
> location (would be simplest but may be legally complex and relies on
> ongoing goodwill)
>
> 3. make a mod to allow users to choose the download location on install.
> We can then maintain apt-get. To remove the SPOF, we could then get the
> templates copied to a number of 3rd party locations and allow people to
> choose which one they use
>
>
>
>
> Kind Regards
> Giles
>
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: 16 May 2016 18:59
> To: dev@cloudstack.apache.org
> Cc: Wido den Hollander 
> Subject: Re: Migrating CloudStack content from download.cloud.com
>
> @Ian, yes, but I think there is more to it than that.  We can change it
> going forward and we can move everything from there over to a new domain.
> I believe the problem is with all of the existing ACS or CCP installs out
> there currently pointing at the download.cloud.com URL, so when it goes
> down, those installs have to be updated.
>
> Maybe I don't understand exactly, but that is the impression I am getting
> from this thread.  Can this be confirmed?
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> @CloudOps_
>
> On Mon, May 16, 2016 at 1:38 PM, Ian Rae  wrote:
>
> > Hey guys, who controls apt-get.eu and given the (rather concerning)
> > level of dependency on the operation of the download.cloud.com - would
> > it not make sense to use a domain that is under the control of party
> > whose alignment with CloudStack will not shift. I hesitate to
> > implicate the red tape of Apache Foundation, but perhaps the fabled
> > CloudStack alliance or

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Giles Sirett]

Sebastien - thank you for your drive, dedication and hard work over the last 
year

Will - many congratulations - keep up the good work !

Kind Regards
Giles

giles.sir...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: 19 May 2016 07:57
To: dev@cloudstack.apache.org; market...@cloudstack.apache.org; 
us...@cloudstack.apache.org
Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Morning Everyone,

Yesterday at the ASF board meeting, the board passed the resolution making Will 
Stevens the new Vice President of the Apache CloudStack project.

Join me in congratulating Will on this appointment, wish him luck and bring 
your unwavering support !

You may have noticed that Will took on RM duties for the new releases going 
forward and has also taken a very active role to finish bringing us to github 
based  workflow and CI. Will has some updates on that front that I am sure you 
will all like.

-Sebastien
Former VP CloudStack

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63895181
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertEqual(
+capacity_state[0][0],
--- End diff --

In my last check in I have added checks for this.

Actually we don't have to add these checks for inner list. The array is 
generated from mysql cursor. So either its empty (if no rows found)  or it has 
a value in [0][0].



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Will Stevens]

Thank you all for the well wishes.  :)

Thank you Seb for all the hard work you have put into this project.  You
have enabled us to make larger strides forward and we all really appreciate
that.  Thanks...  👍

On Thu, May 19, 2016 at 10:56 AM, Giles Sirett 
wrote:

> Sebastien - thank you for your drive, dedication and hard work over the
> last year
>
> Will - many congratulations - keep up the good work !
>
> Kind Regards
> Giles
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: 19 May 2016 07:57
> To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> us...@cloudstack.apache.org
> Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and
> bring your unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases
> going forward and has also taken a very active role to finish bringing us
> to github based  workflow and CI. Will has some updates on that front that
> I am sure you will all like.
>
> -Sebastien
> Former VP CloudStack
>

Re: How to fix Jenkins git workspace issues

[Will Stevens]

Thanks guys.  I think this will make a big difference.  👍

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 5:01 AM, Daan Hoogland 
wrote:

> On Thu, May 19, 2016 at 7:22 AM, Rajani Karuturi 
> wrote:
>
> > untracked
>
>
> ​good call Rajani, it was only doing an ordinary clean in the rat check
> step.​
>
>
>
> --
> Daan
>

Re: jenkins pr check

[Will Stevens]

Haha.  Too bad you can't batch this email to a smaller groups.  Daan just
crashed the Jenkins...  :P

Seriously, thank you for your help on this.  I think this will make a big
difference going forward.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 7:46 AM, Daan Hoogland 
wrote:

> People,
>
> I've asked several people to reopen their pr because of jenkins
> configuration problems. I think i found the little checkbox that needed
> setting now. Please do not hurry but reopen any failed PRs on jenkins
> problems, if you fell it wasn't in your code. don't do it all at once as
> builds.a.o is kind of heavily loaded.
>
> --
> Daan
>

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Gabriel Beims Bräscher]

Thank you for all the effort Sebastien.
Congrats Will!!

Let’s keep up this great work.

Cheers,
Gabriel.

2016-05-19 12:17 GMT-03:00 Will Stevens :

> Thank you all for the well wishes.  :)
>
> Thank you Seb for all the hard work you have put into this project.  You
> have enabled us to make larger strides forward and we all really appreciate
> that.  Thanks...  👍
>
> On Thu, May 19, 2016 at 10:56 AM, Giles Sirett  >
> wrote:
>
> > Sebastien - thank you for your drive, dedication and hard work over the
> > last year
> >
> > Will - many congratulations - keep up the good work !
> >
> > Kind Regards
> > Giles
> >
> > giles.sir...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: Sebastien Goasguen [mailto:run...@gmail.com]
> > Sent: 19 May 2016 07:57
> > To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> > us...@cloudstack.apache.org
> > Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making
> > Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck and
> > bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new releases
> > going forward and has also taken a very active role to finish bringing us
> > to github based  workflow and CI. Will has some updates on that front
> that
> > I am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
> >
>

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220362988
  
I will get this run through CI.  Just to be clear, this PR includes all of 
the changes that were included in 1543, 1538, 1534, 1493 as well as a fix for 
the `addHost` issue.  Is that correct?  Thx...  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220365886
  
Sorry, I need to queue this one up...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: jenkins pr check

[Daan Hoogland]

Maybe I should have formulated my request A little less open minded :) Hope
it did help. As I choose one of two possible solutions let me know if I
should try the other one.

On Thu, May 19, 2016 at 5:25 PM, Will Stevens  wrote:

> Haha.  Too bad you can't batch this email to a smaller groups.  Daan just
> crashed the Jenkins...  :P
>
> Seriously, thank you for your help on this.  I think this will make a big
> difference going forward.
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Thu, May 19, 2016 at 7:46 AM, Daan Hoogland 
> wrote:
>
> > People,
> >
> > I've asked several people to reopen their pr because of jenkins
> > configuration problems. I think i found the little checkbox that needed
> > setting now. Please do not hurry but reopen any failed PRs on jenkins
> > problems, if you fell it wasn't in your code. don't do it all at once as
> > builds.a.o is kind of heavily loaded.
> >
> > --
> > Daan
> >
>



-- 
Daan

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220375273
  
So @KrisSterckx what are the copile, install, configuration and runtime 
dependencies that users of your plugin will encounter? What do they need to buy 
(except for the control plain) and how will they be notified when they try to 
use nuage in their setup?
As this passes CI your answer will not be of much consequence to this PR 
but we do want to have a sound model to make sure #cloudstackworks for 
everyone. Especially those experimenting with how to setup their environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220378822
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 15m 16s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4/runinfo.txt)

**`/tmp/MarvinLogs/test_network_2ZOCMY:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_2ZOCMY/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_2ZOCMY/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_2ZOCMY/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_M227NQ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_vpc_routers_M227NQ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_vpc_routers_M227NQ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_vpc_routers_M227NQ/runinfo.txt)


Uploads will be available until `2016-07-19 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220379062
  
This was run prior to your changes.  I will need to rerun to incorporate 
the recent changes...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220380081
  
@swill yes, this PR includes all the reverted changes and the addHost fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1549

CLOUDSTACK-9348: NioConnection improvements

Reopened PR with squashed changes for a re-review and testing after 
https://github.com/apache/cloudstack/pull/1493 and sub-sequent PRs got reverted

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack nio-fixagain-singlepr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1549


commit 9c7518698d2f4a9fcc6a83fd22dd5b2fc4260232
Author: Rohit Yadav 
Date:   2016-04-14T18:54:53Z

CLOUDSTACK-9348: NioConnection improvements

- Unit test to demonstrate denial of service attack
  The NioConnection uses blocking handlers for various events such as 
connect,
  accept, read, write. In case a client connects NioServer (used by
  agent mgr to service agents on port 8250) but fails to participate in SSL
  handshake or just sits idle, this would block the main IO/selector loop in
  NioConnection. Such a client could be either malicious or aggresive.

  This unit test demonstrates such a malicious client that can perform a
  denial-of-service attack on NioServer that blocks it to serve any other 
client.

- Use non-blocking SSL handshake
  - Uses non-blocking socket config in NioClient and NioServer/NioConnection
  - Scalable connectivity from agents and peer clustered-management server
  - Removes blocking ssl handshake code with a non-blocking code
  - Protects from denial-of-service issues that can degrade mgmt server 
responsiveness
due to an aggressive/malicious client
  - Uses separate executor services for handling ssl handshakes

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220380639
  
@swill thanks, though the latter changes are all packaging related. I've 
built rpm/deb repository to show packaging works: 
http://packages.shapeblue.com/cloudstack/custom/master-latest/ (this is master 
+ this PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220382990
  
Thanks for the update @ustcweizhou, now I can't find anything to :-1: this 
code.
Based on code review and the CI result, the code LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Sateesh Chodapuneedi]

Congrats, Will!
Wish you the best.

Regards,
Sateesh Chodapuneedi
Chief Product Engineer, CloudPlatform Development, Accelerite.
Off: +91 80 6772 1329 | EMail: sateesh.chodapune...@accelerite.com

> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Thursday, May 19, 2016 12:27 PM
> To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> us...@cloudstack.apache.org
> Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your
> unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases going
> forward and has also taken a very active role to finish bringing us to github
> based  workflow and CI. Will has some updates on that front that I am sure you
> will all like.
>
> -Sebastien
> Former VP CloudStack



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220385286
  
Thanks guys for getting that sorted out.  Is the problems that @anshul1886 
ran into something that others could potentially run into?  Would it be useful 
to document the problem and the solution so others can benefit from it if they 
run into it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: jenkins pr check

[Will Stevens]

Ya, we will see if people actually do kick off new jenkins runs.  I will
follow up with a few people to ask them to as I know their PRs are running
into some of the problems we have discussed.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 11:45 AM, Daan Hoogland 
wrote:

> Maybe I should have formulated my request A little less open minded :) Hope
> it did help. As I choose one of two possible solutions let me know if I
> should try the other one.
>
> On Thu, May 19, 2016 at 5:25 PM, Will Stevens 
> wrote:
>
> > Haha.  Too bad you can't batch this email to a smaller groups.  Daan just
> > crashed the Jenkins...  :P
> >
> > Seriously, thank you for your help on this.  I think this will make a big
> > difference going forward.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Thu, May 19, 2016 at 7:46 AM, Daan Hoogland 
> > wrote:
> >
> > > People,
> > >
> > > I've asked several people to reopen their pr because of jenkins
> > > configuration problems. I think i found the little checkbox that needed
> > > setting now. Please do not hurry but reopen any failed PRs on jenkins
> > > problems, if you fell it wasn't in your code. don't do it all at once
> as
> > > builds.a.o is kind of heavily loaded.
> > >
> > > --
> > > Daan
> > >
> >
>
>
>
> --
> Daan
>

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220389940
  
@swill the problem was environment dependent where an unclean environment 
was used to build/run management server, it is recommended to git clean -fdx 
one's local repository (or at least run a mvn clean -P developer,systemvm 
-Dnoredist -Dsimulator) to get rid of old files.

The case has been documented on the FS that for `dynamic roles feature to 
work the setting value should be true and there should be no 
commands.properties file readable on the classpath`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1516#issuecomment-220393200
  
Thank you for the clean up.  It looks much better now.  I will rerun CI on 
this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220394412
  
Hi @DaanHoogland 

The architecture is 

`cloudstack   ---cmp-->  nuage-vsp-acs-client  ---cfg-->  
Nuage VSP platform`

with 

- nuagevsp-plugin : the plugin in cloudstack
- nuage-vsp-acs-client : publicly available middleware which glues the 
plugin to the Nuage VSP platform
- Nuage VSP platform : the Nuage Networks SDN platform, commercially 
available (http://www.nuagenetworks.net)

and

- `---cmp-->` a compile-time dependency (resolved by Maven, cfr @nlivens's 
update of the pom file)
- `---cfg-->` a configuration-time dependency, resolved at cloudstack 
infrastructure provisioning time when adding the cloudstack NuageVsp device to 
its Physical Network (and part of that, provisioning the API URL and 
credentials of the Nuage VSP platform itself).

Adding the NuageVsp device in cloudstack will fail when invalid Nuage VSP 
configuration is submitted (wrong API URL and/or wrong credentials) (as at that 
time the nuage-vsp-acs-client software will attempt to logon to the specified 
Nuage VSP platform), which would happen when the user has no Nuage VSP platform 
at all. The end-result of that is that no device is added, and so the physical 
network remaining unusable until another device is added.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220395388
  
I already started another run against this PR, so that should also validate 
nothing was accidentally broken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220396410
  
I will kick off another CI run just to verify again.  Thanks for the update 
on this @ustcweizhou.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220397187
  
@rhtyd thanks, just wanted to make sure we extracted anything that was 
useful from @anshul1886's experience.  Thanks for working this out guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Migrating CloudStack content from download.cloud.com

[Pierre-Luc Dion]

I would be -1 about disabling the autodownload of the systemvm template,
has this should be simplify deployment of a cloudstack system.
although, the download URL should be a configurable value, maybe in a
property file or thru the API somehow or via a pre-install command.

I really like  download.cloudstack.org + mirror. I'm looking at getting the
DNS entry: builds.cloudstack.org for the new Jenkins and I got no
objections on using the cloudstack.org domain for community services so I'm
pretty sure we would be ok to use download.cloudstack.org, where would we
setting this up? on the current webserver of our website? could we ?


Cheers,

PL

On Thu, May 19, 2016 at 11:00 AM, Giles Sirett 
wrote:

> Erik
> I agree on the existing users - not the end of the world. We could even
> release a tiny patch to update the DB records
>
> The piece that we need to be really careful with is the "I've just
> downloaded cloudstack  thing for the first time" scenario
>
> But - there seems to be plenty of good ideas flowing on that
>
>
> Kind Regards
> Giles
>
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: Erik Weber [mailto:terbol...@gmail.com]
> Sent: 19 May 2016 09:32
> To: dev 
> Subject: Re: Migrating CloudStack content from download.cloud.com
>
> As a user (with old ACS installations) I'd say that this isn't all that
> troublesome, this is easily fixed by updating the appropriate db records.
>
> We should ensure that we have some good posts discovered by Google and
> other search engines, so that when somebody running old installations hit
> this issue they find the workaround.
> There's a lot of time to reach out to users and inform of the fix
> necessary.
>
> --
> Erik
>
>
> On Tue, May 17, 2016 at 10:34 AM, Giles Sirett  >
> wrote:
>
> > This is a MAJOR problem and needs to be figured out before the current
> > download site is removed - @Raja - have Citrix committed to it being
> there
> > another year ?
> >
> > It is my understanding that Cloudstack relies on this download at initial
> > build/startup and then periodically if people do things like build a new
> > zone
> >
> > So, users environments aren't going to stop if its pulled, but nobody
> > would be a able to build/install cloudstack and it may cause issues as
> and
> > when users make config changes
> >
> > The problem is, for new builds, its hard coded : you start the  Sec
> > Storage VM, CloudStack will try to download the built in template from
> > download.cloud.com
> >
> > My understanding is that its simple db  change to make once an
> environment
> > is running (exisiting users) but *may* require a code patch to fix the
> > initial install
> >
> > #notideal
> >
> > Really, this should be maintained by ASF/ the project as its key to the
> > software working, however my understanding is it involves binaries which
> > ASF is never keen on (and may be some 3rd party binaries) - so that just
> > wont happen
> >
> >
> >
> > Apt-get is controlled by Wido et al (for which we all owe him a massive
> > thanks)  - but you are right, it is a 3rd party dependency and arguably a
> > SPOF.  But, if ASF wont host binaries, we're always going to have this
> > issue.
> >
> > So, we could patch the code to point somewhere else - but where ? - by
> > definition its got to be something maintained by a 3rd party
> >
> >
> > We had this debate some time ago when talking about the repositories. We
> > (ShapeBlue) maintain a repo for our customers, which wev'e always opened
> up
> > as public. However, there were concerns about having a company domain
> name
> > (which I understand) - so apt-get became our preferred repo.
> >
> >
> > Thoughts on how to fix this:
> >
> > 1. if ASF would allow us to create the host entry
> download.cloudstack.org.
> > Its under their domain, but with the site being with a 3rd party it could
> > be allowed
> >
> > 2. maybe Citrix could commit to pointing the current DNS entry to a new
> > location (would be simplest but may be legally complex and relies on
> > ongoing goodwill)
> >
> > 3. make a mod to allow users to choose the download location on install.
> > We can then maintain apt-get. To remove the SPOF, we could then get the
> > templates copied to a number of 3rd party locations and allow people to
> > choose which one they use
> >
> >
> >
> >
> > Kind Regards
> > Giles
> >
> >
> > giles.sir...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > Behalf Of Will Stevens
> > Sent: 16 May 2016 18:59
> > To: dev@cloudstack.apache.org
> > Cc: Wido den Hollander 
> > Subject: Re: Migrating CloudStack content from download.cloud.com
> >
> > @Ian, yes, but I think there is more to it than that.  We can change it
> > going forward and we can move everything f