Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220295817
I see.
Shouldn't the system be using annotations to make this less brittle.
At present, there's no obvious way to see that changing these variable
names will break anything.
At the least, we should have unit tests that look for certain variable
names in certain classes and fail if expected ones no longer exist.
On May 18, 2016, at 11:05 PM, Anshul Gangwar
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
@mike-tutkowski<https://github.com/mike-tutkowski> First one which I hit is
in ModifyStoragePoolCommand.java. But I am sure there will be more. Hyper-V
uses json to communicate between management server and Hyper-V agent. So if we
are changing variable names it no longer will be able to parse that info.
â
You are receiving this because you were mentioned.
Reply to this email directly or view it on
GitHub<https://github.com/apache/cloudstack/pull/816#issuecomment-220228493>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
