Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63848326
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString() {
}
}
- public static class VirtioSerialDef {
- private final String _name;
+ public static class ChannelDef {
+ enum ChannelType {
+ UNIX("unix"), SERIAL("serial");
+ String _type;
+
+ ChannelType(String type) {
+ _type = type;
+ }
+
+ @Override
+ public String toString() {
+ return _type;
+ }
+ }
+
+ enum ChannelState {
+ DISCONNECTED("disconnected"), CONNECTED("connected");
+ String _type;
+
+ ChannelState(String type) {
+ _type = type;
+ }
+
+ @Override
+ public String toString() {
+ return _type;
+ }
+ }
+
+ private String _name;
private String _path;
+ private ChannelType _type;
+ private ChannelState _state;
+
+ public ChannelDef(String name, ChannelType type) {
+ _name = name;
+ _type = type;
+ }
+
+ public ChannelDef(String name, ChannelType type, String path) {
+ _name = name;
+ _path = path;
+ _type = type;
+ }
+
+ public ChannelDef(String name, ChannelType type, ChannelState
state) {
+ _name = name;
+ _state = state;
+ _type = type;
+ }
- public VirtioSerialDef(String name, String path) {
+ public ChannelDef(String name, ChannelType type, ChannelState
state, String path) {
_name = name;
_path = path;
+ _state = state;
+ _type = type;
--- End diff --
please remove the '_'s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
