Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r63848658
  
    --- Diff: 
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParserTest.java
 ---
    @@ -144,7 +152,7 @@ public void testDomainXMLParser() {
                          "</console>" +
                          "<channel type='unix'>" +
                          "<source mode='bind' 
path='/var/lib/libvirt/qemu/s-2970-VM.agent'/>" +
    -                     "<target type='virtio' name='s-2970-VM.vport'/>" +
    +                     "<target type='virtio' name='s-2970-VM.vport' 
state='disconnected'/>" +
    --- End diff --
    
    to bad the kvm restructure didn't come through. we'd have this in a 
separate file ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to