Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r63889814
  
    --- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
    @@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
             final SerialDef serial = new SerialDef("pty", null, (short)0);
             devices.addDevice(serial);
     
    +        /* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
             if (vmTO.getType() != VirtualMachine.Type.User) {
    -            final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
    -            devices.addDevice(vserial);
    +            devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
    +                                             "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
    --- End diff --
    
    This has always been hardcoded, it's just that I'm moving this part.
    
    This is the SSVM socket which is already there. The socket patch code wants 
to find the .agent there. Not much I can do there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to