Re: Package does not migrate to testing

[Niels Thykier]

On 2012-03-14 10:14, Johannes Ring wrote:
> Dear all,
> 
> One of my packages, syfi, has not migrated to testing, but I fail to
> see why. According to the excuses page [1], it won't migrate because
> "Updating syfi introduces new bugs: #628243", but that bug was closed
> a long time ago. The excuses page also says "syfi (source) has new
> bugs!", but it does not have any bugs. Any idea what I should do to
> help syfi migrate to testing?
> 
> [1] http://qa.debian.org/excuses.php?package=syfi
> 
> Best regards,
> 
> Johannes
> 
> 

Hi,

Britney (the testing migration tool) gets her data from the BTS, which
thinks it affected 1.0.0.dfsg-1[1].  I cannot quite grok why the BTS
does not think it is fixed, though.

~Niels

[1] The "graph" (top right corner of the bug) marks 1.0.0.dfsg-1 as red.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f606ac8.8000...@thykier.net

Re: bad lintian warning?

[Niels Thykier]

On 2012-05-21 17:38, Daniel Pocock wrote:
> On 21/05/12 10:02, Andrey Rahmatullin wrote:
>> [...]
>>> - - make a lintian override to suppress the warning, with a comment to
>>> explain I am using -release deliberately for resiprocate?
>> I'm not sure you want to keep the current names for the lib and the dev
>> symlink (but if you do, then probably you should override the warning).
>>
> 
> Now I get exactly the type of filenames described in the manual:
> http://www.gnu.org/software/libtool/manual/html_node/Release-numbers.html#Release-numbers
> 
> e.g.
> usr/lib/librutil.so -> usr/lib/librutil-1.8.so
> 
> The .0.0.0 suffixes are gone, but I still have the lintian warnings
> 
> As this scenario is valid from the libtool manual, it is acceptable to
> use the override for lintian?
> 
>> [...]

Hi,

As far as I can tell, you do not ship the symlink in the dev package (or
any other package for that matter)[1], so in that sense, Lintian is right.

That being said, Lintian does have a bug here,  which should be fixed in
commit 714b4ec[2].

~Niels

[1]

$ find -name librutil.so
./rutil/.libs/librutil.so
./debian/tmp/usr/lib/librutil.so

$ find -name librutil-1.8.so
./rutil/.libs/librutil-1.8.so
./debian/libresiprocate-1.8/usr/lib/librutil-1.8.so
./debian/tmp/usr/lib/librutil-1.8.so

[2]
http://anonscm.debian.org/gitweb/?p=lintian/lintian.git;a=commit;h=714b4ecdd59577792eac4006fc3b0b834bacb949


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4fbb6312.4010...@thykier.net

Re: Bug archiving

[Niels Thykier]

On 2012-06-21 09:37, Olе Streicher wrote:
> Hi list,
> 
> I just re-inserted a package that was removed from Debian a year ago
> (saods9), and following some recommendations, I exhumated the old bugs
> and set them to "fixed" in the new version.
> 
> Shall I archive them now again manually? Or is this done somehow
> automatically?  What is this "archived" flag about?
> 
> Best regards
> 
> Ole
> 
> 

Bugs are automatically archived as soon as the "last affected version"
has been fixed (and the BTS is not "confused"[1]).
  I recommend using the bug page for the package;  click "Toggle all
extra information" and find the bug - if the bug will auto-archive it
will have a "Can be archived in X days".

~Niels

[1] Happen in cases like "fixed version" == "found version"  or if
binNMU versions have been used.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4fe2d0b0.6040...@thykier.net

Re: libircclient packaging (Chances to get it into Wheezy)?

[Niels Thykier]

On 2012-07-04 22:14, Andreas Rönnquist wrote:
> Hey
> 

Hi,

> I have done some work on the recently orphaned libircclient package,
> (O/ITA: at [1]), updated it to the latest release, updated packaging to
> current standards, and amongst other things made it Multiarch aware, and
> enabled hardening in the build. (It hadn't been updated since 2009
> previously, so there were quite some stuff to do). See [2] for details
> on my changes.
> 
> [...]
> 
> Would anybody be interested in this, and perhaps help out getting a
> freeze exception so that we don't have to be stuck with this aged
> package for a complete release cycle?
> 
> [...]
> Do you think there is any chance to get this into Wheezy?
> 
> (CC'ing my standard sponsor - Are you interested in this, or are you
> busy with release-related work, Niels?)
> 


While I appreciate your changes and that you are picking up an orphaned
package, I fear the changes are "too much" for unstable given that
Wheezy is frozen.  This is especially true if it involves a transition
that has not been pre-approved.
  I am open to sponsoring minimal changes to the existing package where
permitted by the freeze policy (see [1]).  Or even uploading the new
version to experimental.

> Help would be very much appreciated - 
> /Andreas
> gus...@gusnan.se
> 
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674882
> [2] http://anonscm.debian.org/gitweb/?p=collab-maint/libircclient.git
> [3] http://packages.debian.org/megaglest
> [4] http://packages.debian.org/pokerth

~Niels

[1] http://release.debian.org/wheezy/freeze_policy.html


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ff4a93e.1090...@thykier.net

Re: RFS: l2tp-ipsec-vpn (updated package)

[Niels Thykier]

On 2012-10-19 10:23, Werner Jaeger wrote:
> 
> Dear mentors,
> 
> My sponsor is kil...@debian.org.
> 
> I just uploaded the new version 1.0.9-1 of my package "l2tp-ipsec-vpn".
> 
> This upload contains  RC bug fix #684962
> [...]
> 
>   dget -x
> http://mentors.debian.net/debian/pool/main/l/l2tp-ipsec-vpn/l2tp-ipsec-vpn_1.0.9-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Please CC me when replying to this message!
> 
> Kind regards,
> 
> Werner Jäger
> 
> 

Hi,

I had a look at it and the updated package appears to remove the debian
changelog entry for 1.0.7-1 (which is the current version in sid).

~Niels


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50997fb2.6060...@thykier.net

Re: RFS: l2tp-ipsec-vpn (updated package)

[Niels Thykier]

On 2012-11-07 06:59, Werner Jaeger wrote:
> Hi,
> 
> unfortunately you're right. Is it OK. to upload it again,  with only the
> changelog corrected, or do I also need a new version entry
> (l2tp-ipsec-vpn (1.0.9-1.1) unstable; urgency=low) in the changelog ?
> 
> Thank you
> 
> - Werner
> 
> [...]

Hi,

Personally, I would prefer if you just correct it without adding a new
entry.

~Niels



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/509a56f3.50...@thykier.net

Re: How to specify a >= X < Y Depends (Was: Packaging GNU Health)

[Niels Thykier]

On 2012-11-26 08:24, Michael Tautschnig wrote:
> Hi all,
> 
>> Hi Emilien,
>>
>> On Sat, Nov 24, 2012 at 11:54:59AM +0100, Emilien Klein wrote:
>>> ...
>>> As a general question:
>>> If package A depends on a specific set of releases (like in this case
>>> Tryton 2.4.X), how do we usually handle the case where the "libraries"
>>> are updated before the package depending on the library?
>>> Should I depend on Tryton >= 2.4 < 2.5? I assume that would generate
>>> conflicts once 2.6 is made available, but GNU Health still depends on
>>> an earlier version...
>>
>> I admit a quick search has not uncovered the answer how to express this
>>
>>  Tryton >= 2.4 < 2.5
>>
>> relation correctly.  So I ask on debian-mentors list for help.
>>
> 
> So what's wrong with using Conflicts: Tryton >= 2.5?
> 
> Best,
> Michael
> 

I believe it is quite valid to use:

  tryton (>= 2.4~), tryton (<< 2.5~)

At least lintian4python uses this approach (rather than breaks/conflicts
etc).

~Niels

PS: The "~" is there to handle the case where tryton might be backported.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50b31df4.4040...@thykier.net

Re: How to specify a >= X < Y Depends (Was: Packaging GNU Health)

[Niels Thykier]

On 2012-11-26 08:59, Emilien Klein wrote:
> [...]
>>
>> I believe it is quite valid to use:
>>
>>   tryton (>= 2.4~), tryton (<< 2.5~)
>>
>> At least lintian4python uses this approach (rather than breaks/conflicts
>> etc).
>>
>> ~Niels
>>
>> PS: The "~" is there to handle the case where tryton might be backported.
> 
> Just for my information, what happens when Tryton 2.6 is made
> available in the repo, whith my package using either conflicts or <<
> 2.5~? Does that result in some kind of error/conflict message (in apt,
> update manager, etc.) or is the new Tryton package ignored?
> 
> Thanks,
>+Emilien
> 
> 

Either way, APT will refuse the upgrade or have the user pick between
the new tryton package or your package (assuming your package has not
been updated by then).
  The new tryton will by default not be able to migrate to testing until
your package has been updated[1].

~Niels

[1] In theory, it can if the new tryton "fixes more than it breaks", but
packages in testing are not uninstallable all that often, so odds are it
will tryton will wait in sid till you are done updating.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50b32341.4070...@thykier.net

RFS: mscgen

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear mentors,

I am looking for a sponsor for my package "mscgen".

* Package name: mscgen
  Version : 0.15-4
  Upstream Author : Michael C McTernan

* URL : http://www.mcternan.me.uk/mscgen/
* License : GPL/LGPL
  Section : devel

It builds these binary packages:
mscgen - Message Sequence Chart (MSC) generator

The package appears to be lintian clean.

The package can be found on mentors.debian.net:
- - URL: http://mentors.debian.net/debian/pool/main/m/mscgen
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/m/mscgen/mscgen_0.15-4.dsc

I would be glad if someone uploaded this package for me.

Kind regards
 Niels Thykier

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkopQcoACgkQVCqoiq1YlqxrMQCg2gtUnsEeMa/2TV6XFxmZwj74
AR8AoIIGRVc4edEGjGhDKpA5U60wkoui
=7gOY
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

RFS: mscgen

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear mentors,

I am looking for a sponsor for my package "mscgen".

  Package name: mscgen
  Version : 0.16~svn31-1
  Upstream Author : Michael C McTernan

  URL : http://www.mcternan.me.uk/mscgen/
  License : Partly GPL-2 (or later), partly LGPL-2.1 (or later)
  Section : devel

It builds these binary packages:
mscgen - Message Sequence Chart (MSC) generator

The package appears to be lintian clean.

The package can be found on mentors.debian.net:
- - URL: http://mentors.debian.net/debian/pool/main/m/mscgen
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/m/mscgen/mscgen_0.16~svn31-1.dsc

I would be glad if someone uploaded this package for me.


Kind regards
 Niels Thykier
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpLXXMACgkQVCqoiq1Ylqz/SQCeM1F1N9PNCAe1DSb+uPX0tyT7
7/oAn3w+om7ELlYlyXgDSe7pxe9cS9Xp
=XThq
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Re: RFS: mscgen

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Y Giridhar Appaji Nag wrote:
> Hi Niels,
> 
> I looked at mscgen 0.16~svn35-1 on mentors.debian.net
> 
> On 09/07/02 16:51 +0530, Y Giridhar Appaji Nag said ...
>> [...]
> 
> Comments:
> 
> I noticed that the "released" version upstream is 0.15 and you choose to
> package the svn version.  Is this a conscious decision?  Any reason why you
> choose to do it this way?  The svn snapshot is suitable for widespread user.
> You might want to upload 0.15 to unstable and upload 0.16~svn to experimental.
> 
> For an svn snapshot package, the debian/watch file doesn't really make sense.
> 

Yes, the 0.15 release suffers from two very apparent bugs (an easily
introduced seg. fault and a regression on a "promoted" sample file). I
think that these could, however, easily be changed into using being a
0.15 with some debian patches.

Though such a change would require that the version number of mscgen was
lowered. How would I go about doing that in regards to my changelog?
Merge all entries so far into 0.15-5 (updating svn-releases to patches)?

I think it would also greatly simplify the the watch-file if I had used
0.15+svn[NN] rather than 0.16~svn[NN].


> in debian/control, it doesn't look like you need versioned dependencies on
> most of the packages in Build-Depends.  You don't need to Build-Depend on
> libc6 (Hint: see build-essential) [...]

Okay, fixed these.

> and you probably need libgd2-noxpm-dev or libgd2-xpm-dev but not both.
> 

As far as I can tell that is what it says in my control file, though it
was not nice of me to writing like: "depA |  depB".
Nevertheless, I am considering to use the virtual package "libgd-dev"
instead.

> in the Package: mscgen stanza, you don't need "libgd2-xpm | libgd2-noxpm" in
> Depends.  That would be generated automagically from ${shlibs:Depends}
> depending on what you have in Build-Depends based on the above (Hint: read
> about substvars and ${shlibs:Depends}).
> 
> In the Description "Can be used ..." is a bit abrupt, you might want to say
> "mscgen can be used ..." and "There also exists extensions ..." would rather
> be "extensions also exist ...".  "although MSCs need not be complicated to
> create or use." is a bit odd in there.
> 
> The description of the dpatch 01_debian-patch is verbose and is incorrect wrt
> what the patch actually does (in particular about the linker flags).
> 
> in debian/rules, it is not necessary to have "dh_installdocs TODO" when there
> is a debian/docs file that lists TODO. dh_makeshlibs is not needed.
> 

Fixed these.

> Suggestions:
> 
> In debian/control Priority need not be extra, you can make it optional.  See
> the thread http://lists.debian.org/debian-mentors/2009/05/msg00666.html also
> 

Done.

> Please consider maintaining the package in collab-maint on alioth, you would
> want to add the Vcs-* headers to debian/control in case you do that.
> 
> In case there is no location from where you can download the upstream source
> (because you are packaging an svn snapshot), it is a good idea to have a
> get-orig-source target in debian/rules that gets the upstream source from svn
> and makes an .orig.tar.gz.
> 

Both of these sounds like good ideas, I will have a look at them.

> Cheers,
> 
> Giridhar
> 

I will wait with uploading the corrections until the "version" number of
this package as been sorted out.


~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpVvm8ACgkQVCqoiq1YlqwK5gCgtiTpjiL+KqEUWVYTI9nvbMgv
CIMAn2a71fcCTLJI4HtOBlvg+XTTiAyN
=g59C
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Re: RFS: mscgen

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


Y Giridhar Appaji Nag wrote:
> Hi Niels,
>
> I looked at v0.16-1 of mscgen that you uploaded to mentors.debian.net.  We are
> good to go except for a few small details.
>
> Comments:
>
> - You've modified the .orig.tar.gz to remove a file that doesn't have license
>   information.  In such cases, you should indicate that in the version number
>   of the package (by adding a +dfsg1 or such to it).  See also - lintian-info
>   for the tag dfsg-version-with-period.
>

Done - I used "+dfsg-" since "+dfsg"
wanted me to rename the "orig" to include the deb-version (I assumed it
 would make me unable to recycle the orig in case of a debian specific
upgrade).

I had a short chat about this on the #debian-mentors and from what I
gathered there was no definite standard on this and supposedly both
notations were okay.

> - Please also include a small README.source documenting the above and
>   indicating the use of dpatch (and refer to the README.source of dpatch in
>   it).  This is necessary per policy 3.8.1 (and I think a lintian check
>   corresponding to this is on its way).
>

Added, I decided to include (most of) the dpatch README.source (it
seemed to be written for this purpose).

When I read up on this I noticed that the upgrade checklist [1] uses the
word "should" whereas the standard policy [4.14] uses "recommendation" [2].

> Suggestions:
>
> - Few of the example files have a syntax error in them because they have a C
>   style comment.  Please consider including a dpatch that makes them work with
>   mscgen without the user having to do any modifications to them.
>
> - You don't have to have the ".0" in Standards-Version: 3.8.2.0.  Only the
>   first 3 digits of the version number are enough.
>
> The package looks good and we can upload if the above "Comments" are fixed.
>

Done and done. (NB: the examples were/are added via a dpatch
01_add_examples)

> Also, read on ...
>
> On 09/07/09 11:54 +0200, Niels Thykier said ...
>> Yes, the 0.15 release suffers from two very apparent bugs (an easily
>> introduced seg. fault and a regression on a "promoted" sample file). I
>> think that these could, however, easily be changed into using being a
>> 0.15 with some debian patches.
>
> This is preferred usually if development is too active to consider uploading
> an SVN snapshot to unstable.
>
>> Though such a change would require that the version number of mscgen was
>> lowered. How would I go about doing that in regards to my changelog?
>> Merge all entries so far into 0.15-5 (updating svn-releases to patches)?
>
> Yes, you could do that.  As as aside, I don't mind (and infact prefer it) that
> you don't add a new changelog stanza every time a new revision of the package
> is uploaded to mentors.debian.net
>
>>> In debian/control Priority need not be extra, you can make it optional.  See
>>> the thread http://lists.debian.org/debian-mentors/2009/05/msg00666.html also
>> Done.
>
> The Priority stills seems to be extra in v0.16-1.  But this will not be a
> blocker for our upload.
>

Right, forgot to move that over to the new upstream release build. Fixed
it (again).

>>> Please consider maintaining the package in collab-maint on alioth, you would
>>> want to add the Vcs-* headers to debian/control in case you do that.
>>>
>>> In case there is no location from where you can download the upstream source
>>> (because you are packaging an svn snapshot), it is a good idea to have a
>>> get-orig-source target in debian/rules that gets the upstream source from 
>>> svn
>>> and makes an .orig.tar.gz.
>> Both of these sounds like good ideas, I will have a look at them.
>
> Thanks for considering.
>

Thanks for sponsoring.

> Giridhar
>


It is uploaded on mentors again (0.16+dfsg-1).

~Niels

[1] /usr/share/doc/debian-policy/upgrading-checklist.txt.gz
[2] line 2 of [4.14]
 - http://www.debian.org/doc/debian-policy/ch-source.html#s-readmesource
debian-mentors@lists.debian.org

NB: Sorry for the dobble mail, Y Giridhar Appaji Nag, but I forgot to
send it to the list.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpbpLoACgkQVCqoiq1YlqyFjgCg48vC/8JR6VihgdBU9UqDQZSG
Tx0AoKoZ2frysXKi7kxb3Ces0SmgKbNS
=qfnx
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Re: RFS: mscgen

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Y Giridhar Appaji Nag wrote:
> On 09/07/13 23:18 +0200, Niels Thykier said ...
>>> - You've modified the .orig.tar.gz to remove a file that doesn't have 
>>> license
>>>   information.  In such cases, you should indicate that in the version 
>>> number
>>>   of the package (by adding a +dfsg1 or such to it).  See also - 
>>> lintian-info
>>>   for the tag dfsg-version-with-period.
>> Done - I used "+dfsg-" since "+dfsg"
>> wanted me to rename the "orig" to include the deb-version (I assumed it
>>  would make me unable to recycle the orig in case of a debian specific
>> upgrade).
> 
> I don't think you can use "+dfsg", it would either be
> "+dfsg-" (like you did) or "+dfsgX-" where X
> starts from "0".  And you will have to modify X only if find out later that
> you did some mistake in cleaning up for DFSG freeness.  For other debian
> specific upgrades on the same version of the package, you will increment the
> .
> 
>>> - Please also include a small README.source documenting the above and
>> Added, I decided to include (most of) the dpatch README.source (it
>> seemed to be written for this purpose).
> 
> I tend to just include a pointer on the dpatch README.source rather than
> duplicate that information.  That way people always get the latest info on the
> dpatch usage (if that changes).
> 
>> When I read up on this I noticed that the upgrade checklist [1] uses the
>> word "should" whereas the standard policy [4.14] uses "recommendation" [2].
> 
> Ah, I did not notice that.  Perhaps file a "minor" debian-policy bug?
> 

Actually I think the wording "should" is intentionally used for
"recommended" (or at least not "required"). The upgrade checklist
contains a few lines that "upgrades a should to a must" - like this one [1]:

  * Tighten some format requirements for changelog files from a should
to a must.  [4.4]


>>>> Though such a change would require that the version number of mscgen was
>>>> lowered. How would I go about doing that in regards to my changelog?
>>>> Merge all entries so far into 0.15-5 (updating svn-releases to patches)?
>>> Yes, you could do that.  As as aside, I don't mind (and infact prefer it) 
>>> that
>>> you don't add a new changelog stanza every time a new revision of the 
>>> package
>>> is uploaded to mentors.debian.net
>>>
>>> The Priority stills seems to be extra in v0.16-1.  But this will not be a
>>> blocker for our upload.
>> Right, forgot to move that over to the new upstream release build. Fixed
>> it (again).
> 
> I suppose you could've avoided this minor detail if the package was in a VCS
> :-).  Also, the intention behind a new dch stanza for each upload is to show
> changes from the previous revision.  This becomes redundant if the package is
> in VCS.  It also makes life easier for a sponsor to review what changed.
> 
>> It is uploaded on mentors again (0.16+dfsg-1).
> 
> Uploaded, thank you for your work.  Hereafter, do contact me directly for
> sponsorship of updates to the mscgen package.
> 

Will do and thanks for sponsoring.

> I could not include the changelog for 0.15-1 in the changes file (the -v
> option to dpkg-buildpackage needs a valid version number that is present
> _before_ all the stanzas that one wants to include in the .changes file).  You
> will have to mark the bug pending now (see the bts program in the devscripts
> package).  And you will also have to close that bug when the package gets out
> of the NEW queue.
> 

Alright, I already tagged it pending and will keep my eyes open for when
it reaches the mirrors.

> Giridhar
> 

~Niels

[1] /usr/share/doc/debian-policy/upgrading-checklist.txt.gz - under 3.8.1.0
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpdoTYACgkQVCqoiq1Ylqzl/QCeJNhtEBqsYYwv+HGSI0i7Ze4h
CwMAoNNbRd5FcPRtjEi5aJCTutWovatx
=zdyf
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Subject: RFS: jflex (updated package)

[Niels Thykier]

Dear mentors,

I am looking for a sponsor for the new version 1.4.3-1
of my package "jflex".

It builds these binary packages:
jflex  - lexical analyzer generator for Java

The package appears to be lintian clean.

The upload would fix these bugs: 538063

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/j/jflex
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/j/jflex/jflex_1.4.3-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
 Niels Thykier


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Re: about debian/watch

[Niels Thykier]

Elías A. M. wrote:
> Hi all,
> How I can put in debian/watch this path..?
> i.e.
> 
> http://downloads.sourceforge.net/project/app/app/1.10/app-1.10.zip
> 

Hi

You may want to look in the "uscan"'s man page, where there is an
example of how to watch files on SourceForge via http://sf.net/


> I've searched, but I don't find it .. yet
> and my try, spits:
> 
> no matching hrefs for watch line
> 
> If someone know about some man, please.
> 
> Thanks.
> 
> Elías
> 


~Niels



signature.asc
Description: OpenPGP digital signature

Re: Dependency against ant

[Niels Thykier]

Giovanni Mascellani wrote:
> Hi all.
> 
> A Java package I'm working on (osmosis) uses some bzip2 embedded code
> copy (less than 10 classes) from the ant project (classes
> org.apache.tools.bzip2.*): if I want to avoid embedded code copies, I
> need to make osmosis depend on ant, forcing the user to have a whole
> copy of ant (and its dependencies) installed.
> 
> Should I depend on ant anyway, or can I just leave the embedded copy, in
> order to have lighter dependencies?
> 
> Thanks, Giovanni.

Hi,

I would say you should depend on ant. If 3.5MB of dependencies[1] is too
much for your package, you probably have to convince the Debian Java
Maintainers[2] to put this part of ant in a separate binary package.

Though before you go on with that consider the following: osmosis's
current dependencies pulls in 76MB for openjdk-6-jre-headless[3] alone
(ignoring non-free VMs). Those 3.5MB are somewhat pale in comparison to
that.

You may want to check if other VMs takes less space and try if your
package can run with those.

~Niels

[1] Based on aptitude's "Uncompressed Size", excluding "Recommends" and
java-runtimes, which you cannot avoid depending on anyway.

[2] List email: debian-j...@lists.debian.org
They are also available on irc.debian.org #debian-java

[3] openjdk-6-jre which in turn depends on openjdk-6-jre-headless.
default-jre pulls in openjdk-6-jre.

Note:

In case you were wondering why I excluded sun-java6-jre, which is
provides java6-runtime and only ~17MB (excluding its dependencies):
sun-java6 is expected to reach "End of Life" during/before squeeze
is/becomes stable. Since it is non-free it cannot be patched in case of
security issues, so there is an interest in removing it before its EOL.

Sadly security bugs in JVMs are not unheard of:
http://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=both;src=sun-java6;include=tags%3Asecurity



signature.asc
Description: OpenPGP digital signature

Re: RFS: JavaMorph - IANADD

[Niels Thykier]

Claus Wimmer wrote:
> From: Claus Wimmer 
> To: debian-mentors@lists.debian.org
> Subject: RFS: javamorph
> 
> Dear mentors,
> 

Hi

Thank you for your interest in packaging for Debian. I am not a Debian
Developer; nevertheless I had a look at your package and have a few
pieces of advices based on past experience.

First off, for java-related packages you can send your RFS to
debian-j...@lists.debian.org; this will probably give you faster
responds time on your RFS. You are also more than welcome to ask
questions there related to java packaging and (if you use it) you can
also reach us via IRC in #debian-java on irc.debian.org.

> I am looking for a sponsor for my package "javamorph".
> 
> * Package name: javamorph
>   Version : 0.0.20090514-1
>   Upstream Author : Claus Wimmer 
> * URL : http://code.google.com/p/javamorph
> * License : GPL-2
>   Section : graphics
> 
> It builds these binary packages:
> javamorph  - Java morphing film-make program for pixelpicture-input
> 
> The package appears to be lintian clean.
> 

The source package is lintian clean; however the bianry package gives
the following:

I: javamorph: desktop-entry-contains-encoding-key ...
E: javamorph: doc-base-invalid-document-field JavaMorph.pdf:1 ...
W: javamorph: doc-base-abstract-field-is-template JavaMorph.pdf:6
W: javamorph: doc-base-uses-applications-section ...
W: javamorph: doc-base-file-unknown-format JavaMorph.pdf:9 ...
E: javamorph: doc-base-file-references-missing-file ...

That you will probably need to fix (I shortened some of the lines). I
have not looked the "I" note (first line); it may or may not be important.

The orig.tar.gz contains the source-code; but the diff.gz also contains
a copy of it (in a different folder). I assume this was not
intentionally - there are also some other files in the diff.gz that I
personally feel belong in the orig.tar.gz. "lintian" catches this if you
have it report pedantic issues (--pedantic).

The resulting jar-file contained the "src/" dir with all the java files
(though this is probably due to the diff.gz issue above).

You should remove the ".bash" extension on the javamorph script
installed in /usr/bin to comply with the Debian Policy [10.4]. This will
also allow you to get rid of the duplicate manpage.
  On a related note, this script (as it is now) is also a valid sh
script (slightly faster loading time, etc) - though to my knowledge,
there is no problem with it being a bash script.

Both the description of the package and the manpage state that after the
program has been run it will install a pdf in:

  $HOME/JavaMorph/help/JavaMorph.pdf

You will probably be asked to disable this (at least for Debian); users
are expected to look in /usr/share/doc/$package/ for documentation. It
also allows us to correct the documentation in a later upload without
worrying about having outdated documentation flowing around.

When compiling java code, you should ensure that the correct compiler is
always used. In this case you depend on the Openjdk compiler, so you
should use (as I recall) /usr/lib/jvm/java-6-openjdk/bin/javac and not
/usr/bin/javac.
   On two related notes, you have find the package "javahelper" helpful
for this (with jh_build you just have to set JAVA_HOME and it will find
the compiler for you).
Secondly, you may want to use default-java instead of openjdk. On
all platforms that supports openjdk, it will be default-java and it will
be gcj on the rest. The packages you need for this are default-jdk and
default-jre.

You should also add alternatives to openjdk (or default-jre) in the
Depends (but not Build-Depends). The package java6-runtime (and also
java5-runtime if it can be run with java5 - you may have to pass -target
1.5 to javac for that) can be used.

> The upload would fix these bugs: 99 -> I was not able to obtain an
> ITP, reportbug sent, but no email received.
> 

I think your reportbug may not have been able to send the email. If you
cannot fix it, you can file the bug yourself by sending an email to
 (see [1] for more info).

> My motivation for maintaining this package is: I want to broadcast my
> own program. Additional MORPHING prog offer.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/j/javamorph
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/j/javamorph/javamorph_0.0.20090514-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Claus Wimmer
> 
> + I'm not a member of this mailing list.
> + OpenJdk is slower then SUN when dragging points over the screen.
> 
> --
> Claus Wimmer
> Steinern Straße 44
> 55246 Mainz Kostheim
> Handy: 01520 143 8758
> Inet-Tel.: 01801 555 777 1490
> http://www.glesir.de/~claus
> 
> 

Again, some of this is just my personal recommendation based on what I
have been asked to do with my packages.

Re: [debian-mentors] question regarding rejected uploads

[Niels Thykier]

Scott Howard wrote:
> Hello,
> 
> I recently adopted the "eagle" package, and with the help of the
> previous maintainer was able to upload a new version (I've received
> multiple requests through BTS and direct contact asking for this
> version from users). My sponsor uploaded for i386 (i386.deb and
> i386.changes.) However, since it is non-free, the package won't be
> autobuilt on amd64, which is the only other architecture needed for
> this package. Another DD tried to upload the package for amd64 so it
> could migrate to testing, but it was rejected:
> 
> Reject Reasons:
> eagle-data_5.7.0-2_all.deb: can not overwrite existing copy already in
> the archive.
> md5sum and/or size mismatch on existing copy of eagle-data_5.7.0-2_all.deb.
> md5sum and/or size mismatch on existing copy of eagle_5.7.0-2.diff.gz.
> md5sum and/or size mismatch on existing copy of eagle_5.7.0-2.dsc.
> eagle_5.7.0-2.dsc: old version (5.7.0-2) in unstable >= new version
> (5.7.0-2) targeted at unstable.
> can not overwrite existing copy of 'eagle_5.7.0-2.diff.gz' already in
> the archive.
> 
> What is the proper procedure for uploading additional binaries to
> non-free so it can be available to users and migrate to testing?
> Thank you.
> Regards,
> Scott Howard
> 
> 

Hi

I think your sponsor should have built it with "-B" (binary
arch-dependent only). All the source and arch-independent packages have
already been uploaded (with the original upload) and cannot be
overwritten (except by a "higher" version).

That being said - IANADD.

~Niels




signature.asc
Description: OpenPGP digital signature

Re: New packager

[Niels Thykier]

Fabrizio Furnari wrote:
> Ok, sorry for the previous, long email.
> My question is: is there someone who want to help me to package these:
> 
> OpenJump 1.3.1 (http://sourceforge.net/projects/jump-pilot/files/)
> Saga 2.0.4 (http://sourceforge.net/projects/saga-gis/files/)
> AutoQ3D Community  (
> http://www.autoq3d.com/downloads/category/3-autoq3d-community)
> Stereo 0.2b (http://stereo.sourceforge.net/)
> uDig 1.2RC1 (http://udig.refractions.net/download/)
> gvSIG 1.9 (
> http://www.gvsig.gva.es/eng/off/gvsig-desktop/all-versions/download/gvsig-19/downloading-the-program/
> )
> e-foto 0.1 (http://www.efoto.eng.uerj.br/doku.php?id=en:download)
> jSVR 0.5 beta http://sourceforge.net/projects/svr/files/
> Total Open Station http://tops.berlios.de/
> 
> Most of them are Java packages, all the licenses should compatible with
> Debian (GPL and LGPL).
> Obiviously I listed all before, but I'm happy also starting with one of
> them, I need to learn! :-)
> 
> Fabrizio
> 
> 
> 

Hi

You may want to join or/and ask Debian's Java team[1] about the java
packages - they will (also) be far better equipped for java specific
questions than the general mentors list (and can provide sponsors for
java packages); though for general packaging issues, mentors is still a
good (if not the better) choice.

~Niels

[1] http://wiki.debian.org/Java#Developers-JavapackagingworkinDebian
http://pkg-java.alioth.debian.org/




signature.asc
Description: OpenPGP digital signature

Re: RFS: pleiades - Japanese Language package for Eclipse using Dynamic AOP - IANADD

[Niels Thykier]

Hideki Yamane wrote:
> Dear mentors (CC: debian-j...@lists.debian.org),
> 
>  I am looking for a sponsor for my package "pleiades", Japanese Language 
> package 
>  for Eclipse. It is very popular for Japanese Eclipse users. Its newest 
> release 
>  is downloaded about 50,000 times.
> 
> * Package name: pleiades
>   Version : 1.3.1-dfsg-1
>   Upstream Author : Shinji Kashihara
> * URL : http://mergedoc.sourceforge.jp/
> * License : Eclipse Public License 1.0
>   Section : devel
> 
>  It builds these binary packages:
>  pleiades   - Japanese Language package for Eclipse using Dynamic AOP, 
> Pleiades
> 
>  The package appears to be lintian clean.
> 
>  My motivation for maintaining this package is: improve Japanese desktop 
> envrioment
> 
>  The package can be found on mentors.debian.net:
>  - URL: http://mentors.debian.net/debian/pool/main/p/pleiades
>  - Source repository: deb-src http://mentors.debian.net/debian unstable main 
> contrib non-free
>  - dget 
> http://mentors.debian.net/debian/pool/main/p/pleiades/pleiades_1.3.1-dfsg-1.dsc
> 
>  I would be glad if someone uploaded this package for me. 
> 
> 

Hi

Thanks for taking your time to package this; it is much appreciated. I
have had a look at your package, but as the subject says, I am not a DD.

It would be nice if it could be installed beneath /usr/share/eclipse/
rather than /usr/lib/eclipse/ because it is a large arch all package.
  However it did not work when I tried to move it (even when symlinking
from /usr/lib/eclipse/). I think it complained because it could not find
the eclipse.ini file[1].

pleiades failed without libjavassist-java present; I think you should
also add libcommons-lang-java and libcommons-io-java to Depends (since
they are also mentioned in the classpath of pleiades's jar file).
  I did not test if they are strictly required (I already have those
packages installed due to other packages). Even if they are not strictly
 required, I believe a recommends or a suggests is in order.

I am a little unsure about whether pleiades should recommend a JVM. That
being said, eclipse (and therefore also pleiades) is an X11 application,
so if anything it should recommend default-jre and not the -headless.
  But I would like to hear you reason for recommending
default-jre(-headless).

As for building, I think you should Build-Depend on default-jdk instead
of openjdk-6-jdk | gcj-jdk. Then set (and export) JAVA_HOME to
/usr/lib/jvm/default-java.

Once again, thanks for packaging this.

~Niels

[1] Guessed from the stack trace rather than the error message, which
was written in Japanese.



signature.asc
Description: OpenPGP digital signature

RFS: mscgen 0.17-2 (Usual sponsor is [VAC])

[Niels Thykier]

Hi

I have prepared mscgen 0.17-2.This upload is mainly just bug-fixes from
upstream's SVN. Some of these bug-fixes requires an update of
configure.ac and to avoid having to update the orig.tar.gz I decided to
remove the affected autogenerated files during clean.

Upstream seems to have become rather fond of pkg-config - sadly libgd2
does not ship a .pc, so I have created a small .pc for my purpose, so I
can use pkg-config (instead of using /bin/true).

I cannot reach my usual sponsor Y Giridhar Appaji Nag for mscgen. Last I
heard from him, he was when he marked himself as on vacation about a
month ago.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/m/mscgen
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/m/mscgen/mscgen_0.17-2.dsc

Thank you in advance,
~Niels




signature.asc
Description: OpenPGP digital signature

Re: RFS: pleiades - Japanese Language package for Eclipse using Dynamic AOP - IANADD

[Niels Thykier]

Hideki Yamane wrote:
> Hi,
> 
>  thank you for review!
> 
> On Sun, 21 Mar 2010 21:17:16 +0100
> Niels Thykier  wrote:
>> It would be nice if it could be installed beneath /usr/share/eclipse/
>> rather than /usr/lib/eclipse/ because it is a large arch all package.
> 
>  put it to /usr/share/eclipse, now.
> 
>>   However it did not work when I tried to move it (even when symlinking
>> from /usr/lib/eclipse/). I think it complained because it could not find
>> the eclipse.ini file[1].
>  
>  Could you try updated package?
> 

Hi again

Sorry for the wait; I tested it and it works after the move to share.
Good work :)

>[...] 

~Niels



signature.asc
Description: OpenPGP digital signature

Re: dpkg-buildpackage misunderstanding my instructions ...

[Niels Thykier]

Wuttke, Joachim wrote:
> Dear specialists:
> 
> I am preparing two packages:
>liblmmin3
>liblmmin-dev
> from upstream project lmfit (http://www.messen-und-deuten.de/lmfit).
> 
> [...]
> Problems:
> - The shared library liblmmin.so.3.0.2 went into the package liblmmin-dev, 
> though I thought
> I clearly instructed the system to send it to package liblmmin3.
> - Why the hell liblmmin-dev contains the examples not only in form of *.c 
> sources, but
> also as binaries (/usr/bin/*) ? I said nothing about that.
> 
> Thanks in advance - Joachim
> 
> [...]
> 

Hi

It is debhelper (or/and your debian/rules file) and not
dpkg-buildpackage causing this issue.
  Have you checked whether it installs everything into
debian/liblmmin-dev/ rather than debian/tmp/?

Also, it is a release goal for Debian to get rid of ".la" files, so you
should not include them in a new package.

~Niels



signature.asc
Description: OpenPGP digital signature

Re: dpkg-buildpackage misunderstanding my instructions ...

[Niels Thykier]

Wuttke, Joachim wrote:
>> It is debhelper (or/and your debian/rules file) and not
>> dpkg-buildpackage causing this issue.
>> Have you checked whether it installs everything into
>> debian/liblmmin-dev/ rather than debian/tmp/?
> 
> Thank you, Niels:
> there is indeed a problem with the directories:
> dpkg-buildpackage builds directories
>   liblmmin3/
>   tmp/
> but not
>   liblmmin-dev/
> 
> $ cat rules
> #!/usr/bin/make -f
> # -*- makefile -*-
> %:
> dh  $@
> 
> If these arcane lines must be modified, I would be most
> grateful for help -
> 
> Joachim
> 
> [...]
> 

That may have been poorly worded on my part. To clear any
misunderstandings: debian/tmp should exist and be filled with everything
and from there liblmmin-dev should pull its files.

Can you upload your source package somewhere (e.g. mentors) as it is
now, so I get a better look at it?

~Niels



signature.asc
Description: OpenPGP digital signature

RFS: libsysactivity (new package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear mentors,

I am looking for a sponsor for my package "libsysactivity".

* Package name: libsysactivity
  Version : 0.5.1-1
  Upstream Author : Carlos Olmedo Escobar 
* URL : http://sourceforge.net/projects/libsysactivity/
* License : LGPL 2.1+
  Section : libs
  Program-Lang: C
  Build-Tools : dh7 + cmake
  Description : [1]

It builds these binary packages:
libsysactivity-dev - Retrieves statistics of the system's activity (development 
header)
libsysactivity-doc - Retrieves statistics of the system's activity (development 
doc)
libsysactivity0 - Retrieves statistics of the system's activity
libsysactivity0-dbg - Retrieves statistics of the system's activity (debug 
package)

The package appears to be lintian clean.

The upload would fix these bugs: 567500

My motivation for maintaining this package is: It is a dependency of 
Sentinella (see #577591).


The package can be found on mentors.debian.net:
- - URL: http://mentors.debian.net/debian/pool/main/l/libsysactivity
- - Source repository: deb-src http://mentors.debian.net/debian unstable main 
contrib non-free
- - dget 
http://mentors.debian.net/debian/pool/main/l/libsysactivity/libsysactivity_0.5.1-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
 Niels Thykier

[1] Full description (from libsysactivity0):
Description: Retrieves statistics of the system's activity
 A lightweight library that retrieves statistics of the system's
 activity in a portable and thread safe way. In each OS that it
 supports it offers the same API for retrieving the activity of:
 .
  * hard disks
  * CPUs memory
  * processes
  * network interfaces.

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Topal (http://freshmeat.net/projects/topal)

iEUEARECAAYFAkvE2JgACgkQVCqoiq1Ylqy6rwCSAndWmEBkeLHlmwDMbBgw9CyZ
mwCgruGkTkhHpi5IHwHBLWOtNH7oKYE=
=Vyfn
-END PGP SIGNATURE-


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/alpine.deb.2.00.1004132238570.14...@getsu.thykier.net

Re: RFS: libsysactivity (sponsor found)

[Niels Thykier]

Hi

I found a sponsor for this package.

Thanks for your time,
~Niels



signature.asc
Description: OpenPGP digital signature

Re: editing former patches

[Niels Thykier]

Joachim Wiedorn wrote:
> Mihamina Rakotomandimby  wrote on 2010-06-04 14:44:
>> When I get it with "apt-get source" the untared folder is already
>> patched.
> 
> This is the new behaviour with Debian's source format 3.0 (quilt).
> 

Nope, the slim package referred to is a 1.0 package. From what I can
tell (but I did not dig too deep) the theme is put in to the debian/
part, not sure if the build part includes it from there or not (I never
looked up the debian/rules).

>> I would like to build a separate package for themes and keep the other
>> patches, which are, I think, necessary:
>> - adding the debian/ directory
>> - patching the original code for various reasons
>>
>> How to? Would you please help me?
> 
> Simple use this command:
>   dpkg-source -x --skip-patches  foo.dsc
> 
> Then the patches will no more executed.
> 
> 
> Fondest regards,
>  Joachim Wiedorn
> 

~Niels



signature.asc
Description: OpenPGP digital signature

Re: New Package: Lejos NXJ

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-07-20 20:14, Chris Baines wrote:
> Hello,
> 
> My name is Chris and I have just started using Debian. I would like to
> build a Debian package for the Lejos NXJ project
> (http://lejos.sourceforge.net/). Its a replacement firmware and java api
> for a commercially available robotics platform, the Lego NXT. While I
> understand this is not the easiest program to package, I do want to
> still try.
> 

Hi Chris and welcome.

Thanks for your interest in Debian and packaging for Debian.

I suspect you are right when you say it is not the easiest; personally I
can recommend starting with smaller packages until you get the hang of
general packaging.
  But if you firmly believe that you can handle both the documentation
for packaging Debian packages in general, Java packages and this
particular package all in one go, then I will not stop you.

That being said, if you find it all too overwhelming, do not be afraid
to admit it and take a few smaller packages to get a feel of it. I have
found myself putting one of my more complex packages on hold in favour
of some easier packages just to get the steam back up.


On a more practical note, you may want to join the Java Team - you
probably will not find any better place to get help on Java related
issues and when your package is done, the team also have a number of
Java interested DDs to review and upload your package. The team have
also produced a number of helper tools to assist building Java packages
depending on the build system.

Finally, I am not sure how much documentation you have read about
general packaging, but if you have not already done so, you will need to
declare your intend to package this program.
  This is done by either retitling and taking ownership of an existing
"Request For Package" (RFP) bug on this software or filing a new "Intend
To Package" (ITP) bug against wnpp. It goes without saying that if there
already is an ITP bug, then you should ask the owner of that bug if you
can join as a co-maintainer.
  reportbug has a template for filing an ITP bug, for taking over an RFP
you may want to look at the bts script or reading [BTS].

There are a few guides on how to do the packaging e.g. [0], [1] and [2].
Then there is the Java Team info [3] and (once you have gotten an idea
of how general packaging works) a short set of examples for "how to use
various Java helper tools" [4]. Reading the Developer's Reference might
also be useful [5]. Then there is the Debian Policy[6], which formally
dictates the requirements for your package, plus the Java Policy[7].

I know it is a lot of reading (I have been here as well), but take it a
little at the time.

Finally if you are new to the Debian Bug Tracker (BTS), then there is an
IRC lesson on it Thursday at 1800 UTC in the Ubuntu Classroom[8]. They
may also have other classes they may be interesting/useful for you and
your packaging. While some things are done differently in Ubuntu, the
concepts of how to do a package is more or less the same.

> I have however run in to a couple of problems I was hoping you could
> help me with. Firstly, to compile it requires the cpptasks java library
> (http://ant-contrib.sourceforge.net/cpptasks/index.html) for ant and
> currently as far as I can tell this is not included with Debian. It
> looks to be separate, but part of the ant-contrib project that is
> included with Debian. I don't want to really package this as well. How
> should I move forward?
> 

You need to figure out if it is in Debian or not. If it isn't you may
want to request its inclusion either as a part of the ant-contrib package.
  In that case you probably want to file a bug against ant-contrib,
asking the maintainers (the Java Team as far as I recall) to include it.

> Secondly, I have little understanding of the usb permissions on Debian.
> I have done some basic tests and the device can't be accessed without
> root permissions on a standard installation of Debian. The project
> readme says:
> To use udev rules, set up a file such
> as /etc/udev/rules.d/70-lego.rules and populate it with the
> following lines:
> # Lego NXT
> BUS=="usb", SYSFS{idVendor}=="03eb", GROUP="lego", MODE="0660" 
> BUS=="usb", SYSFS{idVendor}=="0694", GROUP="lego", MODE="0660" 
> 
> This relies on the username you are using being in the lego
> group. You can modify the file to your requirements. The two
> vendors are LEGO and Atmel (for the samba driver used in
> firmware update mode). You may need to reload the rules or
> restart udev. On some Linux systems, the command to reload the
> rules is udevadm control --reload-rules.
> 
> However I don't believe this is the best solution, the device just needs
> to be accessible by the normal user, does a specific group need to be
> added just for this purpose?
> 

Cannot help here, sorry :)

> Thanks,
> 
> Chris
> 
> 
> 
> 
> 

Re: RFS: cpptasks (fwd to d-java@l.d.o)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-07-24 00:29, Chris Baines wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "cpptasks".
> 
> * Package name: cpptasks
>   Version : 1.0~b5-1
>   Upstream Author : Unknown
> * URL :
> http://ant-contrib.sourceforge.net/cpptasks/index.html
> * License : Apache (v2.0)
>   Section : java
> 
> It builds these binary packages:
> ant-contrib-cpptasks - C/C++ compilation tasks for Ant.
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 590045
> 
> My motivation for maintaining this package is: that I needed this to
> continue packaging the lejos-nxj package (ITP: 590049) and that its a
> simple introduction in to packaging and maintaining.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/c/cpptasks
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/c/cpptasks/cpptasks_1.0~b5-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Christopher Baines
> 
> 
> 

Hi

Just cross posting this to debian-j...@l.d.o as you are more likely to
find a sponsor for a Java package on that list.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREIAAYFAkxKNVoACgkQVCqoiq1Ylqxe2ACfVKLx8qHa//3QzKB5/5UyTKIL
+vUAoLXP5Q1yXQYaQjITzo/s21IXzHQO
=9hnp
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4c4a355b.20...@thykier.net

Re: RFS: loopdub

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-07-31 05:39, Stephen Sinclair wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "loopdub".
> 

Hi

I am not a Debian Developer and cannot upload your package; nevertheless
I have had a look at it in the hope that it will speed up your the
progress for your package.

Secondly, thank you for your interest in maintaining your project in Debian

> * Package name: loopdub
>   Version : 0.4-1
>   Upstream Author : Stephen Sinclair 
> * URL : http://loopdub.sf.net
> * License : GPLv2
>   Section : sound
> 
> It builds these binary packages:
> loopdub- Software for live audio loop manipulation.
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 588054
> 
> My motivation for maintaining this package is: It is my software that
> I use for live music performances.  After receiving several requests
> for help on how to build it, I decided to try to package it for Debian
> so that users would have an easier time finding and installing it.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/loopdub
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/l/loopdub/loopdub_0.4-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Thank you
>  Stephen Sinclair
> 
> 

I believe there are a few things that should be improved; do not worry
though, it takes a couple of uploads to get a package right in the first
attempt.

Starting with lintian; I suspect mentors.debian.net has/had an old
version of lintian, which is why it reported it as clean. However,
please note that mentors.d.n does not check binary packages, so you
should always check your package (both source and binaries) yourself and
not rely on mentors.d.n to check it.

If you build both the source and the binary packages (e.g. by not using
- -S, -b or -B with dpkg-buildpackage) then you can just pass the changes
file to lintian and it will check everything.

This is the output I got with lintian 2.4.3 when checking your source
and your binary packages. (Note I enable more checks than lintian
displays by default.)

$ lintian -EvI --pedantic ../loopdub_0.4-1_i386.changes
N: Setting up lab in /tmp/yiYjo20ggG ...
N: Processing 3 packages...
N: 
N: Processing changes file loopdub_0.4-1_i386 (version 0.4-1) ...
N: 
N: Processing source package loopdub (version 0.4-1) ...
I: loopdub source: debian-watch-file-is-missing
W: loopdub source: out-of-date-standards-version 3.8.4 (current is 3.9.1)
N: 
N: Processing binary package loopdub (version 0.4-1) ...
I: loopdub: description-synopsis-might-not-be-phrased-properly
I: loopdub: extended-description-is-probably-too-short
W: loopdub: binary-without-manpage usr/bin/loopdub
I: loopdub: possible-documentation-but-no-doc-base-registration
I: loopdub: package-contains-empty-directory usr/share/man/man1/
N: Removing /tmp/yiYjo20ggG ...

You can use lintian-info -t to read what a tag means if you are in
doubt. e.g.

  $ lintian-info -t debian-watch-file-is-missing
  N: debian-watch-file-is-missing
  N:
  N:   This source package is not Debian-native but it does not have a
  [...]

About the synopsis and the description I can recommend reading [1] and [2].

I tested your package in a clean chroot and it builds; there were some
compiler warnings during the build you may want to fix (as an upstream)
and finally I noticed that loopdub is linked against libraries it does
not need:
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if
"debian/loopdub/usr/bin/loopdub" were not uselessly linked against it
(they use none of its symbols).
dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if
"debian/loopdub/usr/bin/loopdub" were not uselessly linked against it
(they use none of its symbols).

On a related note: the ${shlibs:Depends} more or less all your
dependencies - you can see this by running dpkg --info $loopdub.deb.
  If you believe that ${shlibs:Depends} fails to find the (exact)
dependencies loopdub needs (I suspect libsdl1.2debian vs
libsdl1.2debian-alsa could be a valid case - but I honestly do not
know), please speak up so we can figure it out.

The last thing I noticed was that are some files not owned by you and
licensed under other licenses than GPL in your tarball. You can use
licensecheck --copyright -r * (from the devscripts package) to find
them[3]. These files, their copyright holders and their licenses must be
listed in debian/copyright.

I will stop my review here because I am getting rather hungry. Feel free
to ask questions if you have any to my review. Also, if you have not
already done so, you may want to consider joining the Debian Multimedia
Team[4].

~Niels

[1]
http://www.debian.org/doc/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis

[2]
htt

Re: .deb package for a library generation

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-08-08 15:45, Zvi Dubitzky wrote:
> I need to generate a Debian package for a library 
> As an exercise I tried it with   libvirt . 
> I am running a Ubuntu 8.10 . and use the libvirt.0.6.1 tar.gz 
> 

Hi,

Thanks for your interest in Debian, unfortunately I do not have a lot of
time so this message will be rather brief.

I have added the mail to debian-ment...@l.d.o which is our dedicated
mailing lists for how to do packaging and put you in CC, since I was
unsure whether you would receive the email otherwise.

> 
> For the library package I followed the Ubuntu instructions at  : 
> https://wiki.ubuntu.com/PackagingGuide/Basic
> (I first generated  a .deb for the hello program and it  went ok)
> For the library I did :
> 1.  got the tar of libvirt .  made a copy to orig.tar.gz
> 2. untarred the tared library . cd to the untarred code
> 3.  there ran :  dh_make -e your.maintai...@address . This created the 
> debian directory. Got no bad 
>  commnetsfrom lintian.
> 
> 4. ran : debuild -S -us -uc  (to avoid gpg for now)
> That generated the ../*.dsc and ../*.diff.gz  . Looks ok.
> 
> 5. ran: sudo pbuilder build ../*.dsc  ( changed the debian/rules to have 
> ./configure --with-xen=no otherwise
>it complained about xs_read missing in libxenstore - which exists . 
> libxen3, libxen3-deb are installed ok)
> 
>   But now during the ./confugre run I get the following message :
> 
> .
> checking for pkg-config... no
> checking libxml2 xml2-config >= 2.5.0 ... configure: error: Could not find 
> libxml2 anywhere (see config.log for details).
> make: *** [config.status] Error 1
> dpkg-buildpackage: failure: debian/rules build gave error exit status 2
> pbuilder: Failed autobuilding of package
>  -> Aborting with an error
>  -> unmounting dev/pts filesystem
>  -> unmounting proc filesystem
>  -> cleaning the build env
> ...
> 
> pkg-config is installed and the newest . libxml2 is installed  and newest 
> (/usr/lib/) and  xml2-config --version gives  2.6.32
> 
> so why does the system complain : Could not find libxml2 anywhere  . BTW: 
> config.log was not generated yet .
> 
> Any idea/ help ?
> 
> thanks
> 
> Zvi Dubitzky 
> Email:d...@il.ibm.com
> IBM Haifa Research LaboratoryPhone: +972-4-8296182
> Haifa, 31905, ISRAEL 
> 
> 
> 


dh_make cannot deduce every Build-Dependency of your package, which is
likely to be your problem. As I recall (but I have not used it in a
while) it only generate a set of template files to get you started.
  Also pbuilder builds your package in a "clean chroot" where it only
installs the packages listed in Build-Depends and Build-Depends-Indep of
your debian/control (+ the "build-essential" packages).

So you probably have to open the debian/control file and add the correct
build dependencies there.

I apologize for the short answer with no reference to relevant
information, but I am really out of time :)
  I am about to leave DebConf10 (like a lot of other Debian people).

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREIAAYFAkxewlcACgkQVCqoiq1YlqykKACfTId9Pw0Q2yerPPeuUXnyZbFU
QIAAoMV8gYAjuecmaHjkN8bdvPdwENWX
=GAMJ
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4c5ec258.8080...@thykier.net

Fwd: Re: .deb package from compiled libraries

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Oops, forgot to send this to the list as well.

-  Original Message 
Subject: Re: .deb package from compiled libraries
Date: Wed, 11 Aug 2010 20:45:13 +0200
From: Niels Thykier 
To: Zvi Dubitzky 

On 2010-08-11 19:46, Zvi Dubitzky wrote:
> Hi
>
> I was able to build a good .deb package of a library . thanks
>
> I am not suer if you would like my following questions but there is a
> reason for them:
>
> 1. Is it possible to run pbuilder not in a chroot environment  without
> using base.tgz , But from  a local file tree ?
> I tried : pbuilder --debuid or pbuilder  --use-pdebuild-internal  but
> both use the base.tgz file.
>

Depending on exactly what you need, cowbuilder may or may not be what
you want.

If you want to modify this chroot, then you probably want to read man
cowbuilder/pbuilder about --login and --save-after-login

> 2) I was watching the output of the dh_command s that come out as the
> rules/ binary-arch: target   run  (pbuilder).
> It seems it is possible to build a .deb package from an existing tree
> of binaries/libraries  that were pre compiled.
> What is the naming convention of  such a tree  path ? is it defined in
> the debian-policy ?
>

I believe the policy for this is "don't"; Debian works around the idea
of compiling everything from source.
  Nevertheless, it is possible and you can see such a tree in
debian/$package/ after the build is done and before you clean (though
not trivial to do with pbuilder/cowbuilder)
  I /think/ you can also regenerate that try by using something like:

  dpkg -x $debfile .
  dpkg --control $debfile

But I have not actually tested this.

>- Can dpkg-shlibdeps accept several libraries in one call ( not clean
> from the man pages) ?

Yes, When building the eclipse source package (eclipse, -rcp, -platform,
plugin-cvs, -jdt and -pde) we use the following to make it calculate the
dependencies for the eclipse-rcp package.


dh_shlibdeps -peclipse-rcp
- -l$(JAVA_HOME)/jre/lib/$(DEB_HOST_ARCH_CPU) \
-- -dDepends \
$(JNI_SO_PATH)/libswt-gtk-*.so \
$(JNI_SO_PATH)/libswt-atk-gtk-*.so \
$(JNI_SO_PATH)/libswt-awt-gtk-*.so \
$(JNI_SO_PATH)/libswt-cairo-gtk-*.so \
$(JNI_SO_PATH)/libswt-pi-gtk-*.so \
$(JNI_SO_PATH)/libswt-xpcominit-gtk-*.so \
$(JNI_SO_PATH)/libswt-xulrunner-gtk-*.so \
$(shell find $(JNI_SO_PATH) -name '*.so' | grep
- -v libswt-) \
$(LAUNCHER_LIB) \
-dRecommends \
$(JNI_SO_PATH)/libswt-gnome-gtk-*.so \
$(JNI_SO_PATH)/libswt-glx-gtk-*.so


NB: dh_shlibdeps is a debhelper wrapper for dpkg-shlibdeps, everything
after the "--" is passed directly to dpkg-shlibdeps.

For public shared libraries you may also want to maintain a symbols
file. Assuming you haven't heard about it - it tracks which symbols are
available in a library and helps you to make sure no symbols "disappear"
without you noticing it (e.g. ABI backwards compatibility broken). It is
also possible to use this to warn you when the public API/ABI is
expanded (see man dpkg-gensymbols for more).
  It also helps the dpkg-shlibdeps to emit more precise versions for
reverse dependencies of your library - e.g. it may allow users to use an
older version of the library than reverse dependency was built against
(based on the symbols that the reverse dependency needs).

symbols files are superior to "shlibs" files, but shlibs appears to be
needed for the udeb files (see #571776)[1].

>- is the generation of  the postinst and postrm scripts mandatory ?
>

Maintainer scripts are not mandatory in general as far as I know[2] -
they are used for library packages (to call ldconfig), though it may be
migrated to be using "file triggers" (see man deb-trigger and
dpkg-trigger) in the near future[3].

Note that debhelper (dh and all the dh_* commands run) may generate a
script for you/your package, since it is designed to handle common
cases. Particularly dh_makeshlibs auto generates postinst and postrm
snippets for library packages to call ldconfig for you (if you use
debhelper).

>- The  pbuilder run output shows dpkg-deb is  generating the final .deb
> file .
>   What is the role of dpkg-buildpackage command (if any) that I do not
> see called explicitly ?
>

dpkg-buildpackage handles calling the commands to build the source
package as well as invoking the correct targets of debian/rules in your
build to build the package. By default it will also try to sign the
resulting changes and dsc files (if it knows your GPG key).
  Other than that it calls dpkg-buildflags to set 

Re: RFS: obdgpslogger [ITP #580176]

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-08-16 01:28, Gary Briggs wrote:
> 
> Dear mentors,
> 
> [...]
> * Package name: obdgpslogger
>   Version : 0.15-1
>   Upstream Author : Gary Briggs  [myself]
> * URL : http://icculus.org/obdgpslogger/
> * License : GPLv2+
>   Section : science
> 
> It builds these binary packages:
> obdgpslogger - Suite of tools to log OBDII and GPS data
> 
> The package appears to be lintian clean.
> 
> [...]
> I would be glad if someone could become my mentor for this and hopefully
> future packages.
> 
> Thank-you very much for your time,
> Gary
> 
> 

Hi Gary,

First off, thanks for your interest in packaging this package for
Debian. I have done a little review of your package, though IANADD so I
cannot upload your package even if you address all my comments. Also a
DD may have additional comments on top of mine.

As far as I can tell the package embeds a copy of sqlite3, which is
already packaged in Debian (as libsqlite3-dev). Optimally you would not
ship this in your tarball at all.

There are several files in the package not under GPL v2; you can find
some (possibly all) of them by running:
  licensecheck -r  * | grep  -v v2\ or\ later

Their copyright holders and licenses should be listed in
debian/copyright. Also "Michael Carpenter" is listed as a copyright
holder of a handful of files, but he is not mentioned in d/copyright.

On a related note, the copyright file refers to the versionless GPL from
common-licenses, which implies Debian is relicensing it under GPL-3 or
later (lintian finds this with issue --pedantic).

Your package is also missing a watch file (lintian reports this with
- -I). Even though you are your own upstream and therefore undeniable
aware of new upstream releases it is good practise for future packages -
and it would also be nice to have in case you at some point in the
future retire either your upstream or your downstream "hat".

I did not have time to run test it - unfortunately I do not own hardware
needed either, so at best I would run the simulator.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREIAAYFAkxrBEAACgkQVCqoiq1YlqzJKgCfdlIaFKMiWrKkA/zAF18wfz0x
XSwAoLqhT3DnfoMrmB6yqBBk/eA0uFcX
=20jE
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4c6b0441.6040...@thykier.net

Re: Doubts in Sigar packaging

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-09-14 18:51, Thiago Franco de Moraes wrote:
> Hi all,
> 

Hi

> [...]
> * This library contains a bunch if bindings, one of them is java. These
> java bindings is compiled using ant. The compilations generates a bunch
> of .class and .jar files, and there isn't a make install. What is the
> best way to put those files in the right directories? To use the cp or
> mv command? And the right directories I think [4] is this
> "/usr/share/java/libsigar-1.7" ?
> 

Personally I would recommend using jh_installlibs from javahelper.

> 
> Thanks to all!
> 
> PS. We need some help in translations [5] too.
> 
> [1] - http://support.hyperic.com/display/SIGAR/Home
> [2] - http://svn.softwarepublico.gov.br/trac/invesalius
> [3] - http://github.com/hyperic/sigar
> [4] - http://www.debian.org/doc/packaging-manuals/java-policy/x104.html
> [5] - http://www.transifex.net/projects/p/invesalius/
> 
> 

By the way, you are very welcome to ask on debian-j...@l.d.o if you have
questions on how to handle java related packaging.

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREIAAYFAkyQdZAACgkQVCqoiq1Ylqwh2wCeKVRA3ZdTeT23AXi1wl11WUpk
gUMAn3+yvdJkhCzuxPcnEd1Fp95ctqtS
=lyJQ
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4c907590.1030...@thykier.net

Re: RFS: subversion (updated package) [lenny-backports, 1.6.12dfsg-2~bpo50+1]

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-02 22:25, Jesús M. Navarro wrote:
> Hi, Michael:
> 
> On Saturday 02 October 2010 21:24:22 Michael Diers wrote:
>> Dear mentors and backporters,
>>
>> I am looking for a sponsor for the new version 1.6.12dfsg-2~bpo50+1
>> of my existing backport of package "subversion".
>>
>> Please note that 1.6.12dfsg-2 is currently in "unstable" and will take a
>> few days to migrate to "testing"; however, this update addresses
>> CVE-2010-3315 for the existing backport.
>>
>> subversion (1.6.12dfsg-2~bpo50+1) lenny-backports; urgency=low
>>
>>   * Rebuild for lenny-backports.
>>   * Disable ra_serf, need a newer version than the one in lenny.
>>   * Build-depend on libdb4.6-dev, suggest db4.6-util.
>>   * Build-depend on openjdk-6-jdk instead of gcj-jdk.
>>   * Depend on openjdk-6-jre-headless instead of gij.
> 
> Just out of curiosity: how is it that subversion depends on jdk/jre?
> 
> Cheers.
> 
> 

I would assume that (Build-)Depends relate to libsvn-java binary package
without actually having checked the control file.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREIAAYFAkynlewACgkQVCqoiq1YlqwBWACcDcyCzs4Acjy/eHgNiAIYlMtg
HRYAoLMR3npXm69PV8Lw5ivrr9PO8N7v
=TtCp
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ca795ed.8080...@thykier.net

Re: Four days

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-03 13:16, Michael Tautschnig wrote:
> Hi all,
> 
>> Hey everyone,
>>
>> Niels Thykier and I were talking on #debian-mentors. I was saying
>> that I find the debian-mentors list kind of lonely and impersonal --
>> it's mostly RFSs, and so many emails don't even get an answer.
>>
>> How depressing!
>>
> 
> While I can understand your feelings, I still have several questions and
> somewhat contradictory remarks. Obviously I can only speak for myself.
> 
> - Briefly looking at http://lists.debian.org/debian-mentors/2010/09/
>   it seems that the number of emails not being responded to by anyone is not
>   that high. Furthermore it seems there's a lot more to this list than just 
> RFS.
>   And I found only a single non-RFS email that wasn't responded to.

Manually counting all the unanswered emails to d-mentors for 2010-09 I get:

RFS QA: 1
RFS: 34
RFS NMU: 1
non-RFS: 1

or 37 unanswered emails. This includes duplicates like "2nd"/"3rd" ping.
When I counted I assumed any email that had received a reply was
answered satisfactory, btw.

Personally I would like to see that 37 drop closer to 0.

> - As a mentor, as far as RFS are concerned, I can only work on packages where 
> I
>   have some proper background. That is, I should be using those packages or 
> work
>   on related packages. 

I agree that we cannot expect that any DD can sponsor any given package
dumped on d-mentor. But if we see an RFS remain unanswered we can have a
look at it and try to associate the package with the relevant teams or
keywords (e.g. as you did with vavoom -> contact games team).

> - As a mentor, I cannot look at each and every RFS, I'll have to be able to 
> spot
>   interesting packages quickly. I therefore ignore all RFS with package names
>   where I cannot deduce that they could be relevant for me. Hint: it might be
>   useful to add the short description of the main binary package to the 
> subject
>   (I have no idea what, e.g., "vavoom" is about).

Perhaps we can extend mentor's RFS template to recommend such a
practise? And even in the case where mentees do not do it (good enough
to easily "sort" the package) we can (as explained above) spend the
10-20 minutes to write review the email + d/control file and come with a
suggestion for whom to contact or simply reply with a "this package is
this and that" so other DDs can easier find it.

> - Although debian-mentors is a default destination for RFS, it would probably
>   better to contact one of the teams that works on related packages. Again, 
> the
>   vavoom package (I now looked at the RFS): Why wasn't
>   pkg-games-de...@lists.a.d.o contacted?
> 

Agreed; it would be nice if we could have mentors.d.n recommend this
(particularly if it could come with educated guesses based on the source
package).

>> So I was thinking it would be nice if every email thread got a
>> public reply within four days. That's a goal that Niels and I have
>> set, and we hope maybe some of you help too. Even if we reply, "Eek,
>> I'm swamped. Try again later," I figure that is nicer than hearing
>> nothing back.
>>
> 
> Would you mind to elaborate on the expected benefit of such a step? *Whom*
> would you expect to be doing such replies? Is that more than an "ACK, your
> message made it to the list" (you can check that by looking at the list 
> archives
> as well)? I think you are only curing some symptoms, but fail to tackle the
> underlying root cause (some of which might be the points I mentioned above). 
> 

Personally I would hope any mentor and possibly also non-DDs with
experience could help with this. Again they do not have to sponsor ever
RFS they reply to, either promote its "keywords" or (if possible)
redirect it to a team that handles the particular type of packages.

>> In general, I encourage mentees and mentors to consider 4 days the
>> timeout on your debian-mentors conversations. So if you email your
>> usual sponsor and don't hear an answer within 4 days, try once more.
> 
> I'm not sure how mentees usually handle the situation where a package has
> already been sponsored once. I'd expect mentors to be ready to handle further
> uploads, and IMHO such RFS shouldn't even pop up on the list. After a few
> rounds, people should be both ready and willing to apply for Debian-Maintainer
> status. 
> 

In my case I have been lucky; my sponsors always said "Feel free to send
your next RFS for this package to me directly" for my
non-team-maintained packages.

>> After another four days, email the list asking for a sponsor
>> (expl

Review of gnome-gmail

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256


On 2010-09-25 15:28, David Steele wrote:
> Dear mentors,
> I am looking for a sponsor for my package "gnome-gmail".
>
> * Package name: gnome-gmail
>   Version : 1.6-3
>   Upstream Author : David Steele 
> * URL : http://gnome-gmail.sourceforge.net/
> * License : GPL
>   Section : gnome
>   Language : Python
>
> It builds these binary packages:
> gnome-gmail- Add Gmail support to GNOME
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 597903
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/g/gnome-gmail/
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/g/gnome-gmail/gnome-gmail_1.6-3.dsc
>
> Gnome Gmail adds support for the Gmail web client as a GNOME Preferred
> Application for email. Once selected, mailto links, Nautilus "Send
> File" commands, Open Office "Send Document" commands, etc, will cause
> an appropriate Gmail window to open in your default browser.
>
> You can read more about Gnome Gmail from the following Press coverage:
>
>Lifehacker -
> http://lifehacker.com/5493654/gnome-gmail-tightly-integrates-gmail-into-linux-desktops
>Linux Magazine Online - 
> http://www.linux-magazine.com/content/view/full/42375
>Sourceforge Blog - http://sourceforge.net/blog/gnome-gmail-made-simple/
>
>  Thanks for your assistance
>
>

Hi

(Sorry for the double mail - I forgot to send it to the mentor list as
well so others could see it had been answered)

Thanks for your interest in Debian. It looks like you have not received
any feedback on nor found a sponsor for your package yet. I have spent
some time reviewing your package and got a few comments for you, which I
hope you find useful.

Please note that I am not a Debian Developer (DD), so I cannot sponsor
your package even if you address all my comments/remarks. Also neither
python nor GNOME is my strong suit, so there are possibly some
python/GNOME specific things that I have missed in my review.

On a related note have you considered contacting/joining the Debian
GNOME or the Debian Python Apps team? These teams may be a better source
for help with your package and possibly also sponsors for your package.

Also you may want to read [1] if you have not already done so; there are
talks about how to improve the current RFS template and what some
mentors look for/would like to see in an RFS.


Anyhow; my review:

d/watch:
  - Contains a lot of unused comments (left overs from dh_make)

d/rules:
  - lots of unused comments (looks like left overs from dh_make)
  - Consider using either dh $@ (a.k.a. the dh7 method or "tiny rules")
or cdbs. These tools can handle your entire build without any
override targets/modification to their default setup/run.
This would also remove a warning during the build [2].
  - Even if you do not use dh7 or cdbs you should clean up your
d/rules files. As an example, there is nothing to do in the
binary-arch target.

Note: if you are joining a team, the team may have a helper tool
preference or a build style. In that case you probably want to stick
with the build styles preferred by the team.

d/control:
 - ${shlibs:Depends} does not make sense for arch: all packages.
   It finds "arch dependent" dependencies for native shared libraries.
 - The Description (and possibly the Synopsis) needs improvement.
   It might be a help to have a look at [3].

d/changelog:
 - You have multiple revisions in your changelog, but this package has
   not been released into Debian. Consider merging it into a single
   entry[4].
   Note there is no reason to repeat the "closes" for the
   same bug (see man dpkg-buildpackage/dpkg-genchanges about the "-v"
   flag for more information). Though if you need the package built
   with the -v flag be sure to mention this in your RFS, so that your
   sponsor is aware of it.

d/copyright:
 - Looks like a mix of "freestyle" and the DEP-5 machine readable
   format.
   Either of those formats are acceptable, but the mix appears a bit
   "weird" for me. I would recommend you choose either of the formats
   and stick to it.
 - You have claimed copyright for the year 2009, but there is no
   mention of copyright in the upstream files except for
   gnomemail.glade, which claims copyright for the year 2010 (about 200
   lines into the file).
   I am not sure if that single copyright mention in gnomemail.glade is
   enough for the FTP-masters. Optimally you would write your copyright
   statement plus the "license header" in all your source files.
 - There is no explicit mention of allowing the GPLv2 or later in your
   upstream pacakge as far as I can tell. COPYING only contains GPLv2
   and none of the source file seems to carry an explicit license.
   Note: The "How to apply GPL v2 to your program" exam

Re: RFS: galinette

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-01 12:23, Paul McEnery wrote:
> Dear mentors,
> 

Hi

I have had a look at your package; please note that I am not a DD (which
means I cannot sponsor it, even if you address all my comments) and I
ran out of time to do a full review, so I only checked a few things.
Nevertheless I hope you can use my comments.

> I'm not sure the package is ready for upload just yet. In particular,
> I am having trouble eliminating excessive linking brought about by
> cmake. In particluar, I am getting the following warnings:
> 
> [...]
> dpkg-shlibdeps: warning: dependency on libftdi.so.1 could be avoided
> if "debian/galinette-nox/usr/bin/galinette-flash" were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libfontconfig.so.1 could be
> avoided if "debian/galinette/usr/bin/galinette" were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if
> "debian/galinette/usr/bin/galinette" were not uselessly linked against
> it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libatk-1.0.so.0 could be
> avoided if "debian/galinette/usr/bin/galinette"were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libxml2.so.2 could be avoided
> if "debian/galinette/usr/bin/galinette" were not uselessly linked
> against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libftdi.so.1 could be avoided
> if "debian/galinette/usr/bin/galinette" were not uselessly linked
> against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if
> "debian/galinette/usr/bin/galinette" werenot uselessly linked against
> it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be
> avoided if "debian/galinette/usr/bin/galinette"were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libgio-2.0.so.0 could be
> avoided if "debian/galinette/usr/bin/galinette"were not uselessly
> linked against it (they use none of its symbols).
> [..]
> 
> 
> I have done some investigation, and it appears that cmake has
> automatically added some of these without any good reason. Hopefully a
> mentor with some cmake experience can help me eliminate these issues
> (despite them not being a specific packaging issue)...
> 
> Regards,
> Paul.
> 
> 

By the looks of it you have fixed this by now. :)

Anyhow - on to my short review:

d/control:
 - Redundant B-D on quilt; it is a 3.0 (quilt) package.
 - Standards-Versions is at 3.9.1 (package is at 3.8.4)
 - Section: utils in galinette-nox and galinette not
   needed (due to it being present in Source as well)

d/copyright:
 - looks good.

d/rules:
 - The --buildsystem option is probably not required as
   dh can guess common build systems.
 - You may want to double check whether dh passes on
   CFLAGS and LDFLAGS to cmake - as I recall it does not
   (but I did not have the time to double check).
   if not see [1] for how to fix it.

patches/001-linking-fix.patch
 - Could use some cleaning (unrelated/whitespace changes)
 - No description/author.

You may be able to replace (most of) this patch by passing extra options
to cmake via dh_auto_configure[1]


A little lintian output (all tags enabled, even those you are usually
not required to fix):

N: Processing binary package libgalinette0 (version 1.1-1) ...
X: libgalinette0: shlib-calls-exit usr/lib/libgalinette.so.0
I: libgalinette0: no-symbols-control-file usr/lib/libgalinette.so.0

I would strongly recommend that you implement a symbols file for
libgalinette; have a look at [2]. It can help you discover if
libgalinette has broken backwards compatibility as as well allows dpkg
to calculate minimum needed versions for packages depending on libgalinette.

The exit tag appears to be correct; but it is in a call-back method
so it is probably okay (even if the callback is installed by default).
  Also note that it is usually not required to fix or even override
X (experimental) tags.


You can get more information about these tags by using:

  lintian-info -t 


If you have any questions to this or other questions to your
package/packaging, feel free to write back.

~Niels


[1] e.g. by adding something like this to your debian/rules file
(requires debhelper >= 7.0.50~):

override_dh_auto_configure:
dh_auto_configure -- -DCMAKE_C_FLAGS="$(CFLAGS)"
 -DCMAKE_CXX_FLAGS="$(CFLAGS)" \
 -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-undefined" \
 -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--no-undefined" \
 -DCMAKE_EXE_LINKER_FLAGS="-Wl,--no-undefined "

[2] http://wiki.debian.org/UsingSymbolsFiles

man deb-symbols dpkg-gensymbols


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozill

Re: RFS: disco

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-06 20:47, Janos Guljas wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "disco".
> 
> * Package name: disco
>   Version : 0.3.1-1
>   Upstream Author : Ville Tuulos 
> * URL : http://github.com/tuulos/disco/downloads
> * License : GPL-2+
>   Section : admin
> 
> It builds these binary packages:
> disco-doc  - A distributed computing framework - documentation
> disco-master - A distributed computing framework - master
> disco-node - A distributed computing framework - node
> python-disco - A distributed computing framework - client python module
> python-discodb - An efficient, immutable, persistent mapping object Disco
> python-discodex - Distributed indices for Disco
> 
> [...]
> 
> Kind regards
>  Janos Guljas
> 
> 

Hi

Thanks for considering to contribute to Debian, your help is much
appreciated. :)

While I am not a python/erlang/etc. packager, I did a small review of
your package. It is quite possible that I missed some issues that a
second reviewer will find (particularly if said review knows anything
about packaging python or erlang).

That aside, here is what I got:

You got two license files in
  contrib/discodex/lib/discodex/restapi/
  master/src/mochiweb/

which mentions a copyright holders and/or licenses not mentioned in
d/copyright. Their presence implies that the respective subdirectories
are copyrighted and licensed as described in those license files (unless
individual files in those directories state otherwise).

Why do disco-master Pre-Depends on python-disco? I see nothing in the
preinst script that suggests that python-disco must be present before
disco-master is unpacked.

There is a reference in preinst disco-master and disco-nodes to
  /etc/init.d/disco-node
but neither of them appears to install that script.

Is disco-master really an arch:any package? It appears to only contain
image files, javascript, python scripts and html files?

I am not much of a Python packager, but I suspect you should not be
getting this warning.
dpkg-deb: warning: 'debian/$pkg/DEBIAN/control' contains user-defined
field 'Python-Version'

Probably you want X-Python-Version or XS-Python-Version (check the
Debian Python documentation or with the Python Team).



It fails to build from source if Build-Depends-Indep are not satisfied
when dpkg-buildpackage is invoked with -B:
[...]
sphinx-build -b html -d .build/doctrees   . .build/html
make[2]: sphinx-build: Command not found
[...]

This is how auto-builders will build your package. As I recall the
debian-policy is disagreeing with reality here. I believe there is an
attempt to make these two agree, but for now your package must be able
to build without Build-Depends-Indep when dpkg-buildpackage is passed -B.

Have you contacted (or considered to contact) the python application
team about team maintaining the package? (See [1] for more info).

If you have any questions or comments about the things I mentioned (or
anything else regarding your package) then feel free to write back.
~Niels

[1] http://wiki.debian.org/Teams/PythonAppsPackagingTeam

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJMs2/1AAoJEAVLu599gGRCwoQP/ipOCKeee+5NOgmSE+DW051y
dYfYnAGYZ6coGVmNVwlz4+SGy+d9JeGRwhHbAhG9pclYo94r3SdD7arTH09BeS+3
as1ySVEjkxrNmNaz6F58hd9GBCNQQD6AJpn/i0VEHuxwmVr8R8sjfTJdbWiEpMpQ
2zwtR3l663C+DpcDwqkwswBrjeMf7RbMFTkx4qgZg/ZkiimpbjdRuuZnpKneuxzM
HONBMbdtsPOEve+kjNgBtI9qUjpQRW2Lu87GSUa4EtqfPDi5wuyL0zJk1Uc8vKCw
5dOR7Bx7zbAHw2PtSg+JncZnwOVXj8KUKjFEOQgflD0pNyDl8yD7zVLgocPkGNAY
4UddlmjorGOr0+74oTwuo7P14pR19NEkBiXG2NIwoBHMQHTg5sUqN4uRw9ig+Stw
76fJj1nxgXhyhZ0sdTNIYABUk4ArRCNIUA/pJO/0KSaZYbbDpBAL5LSP7d0ot5n8
AKZU0j59Yvw5P0+ZH00Gkp4hrfwg46DbXQpfUICNfVEoKabjvChCgpLKQw8jikNm
AQW8YjWRUzpRpTtqKpSTQhkm5yKCn9ekfYwIii9X641QC1torRjR/Ii2UIyDRxNh
pbzE7NNEr/BXcaBVJjhhQwEwXvn+VcZ37TSzXYZsnVscS5WR+MZiZ0dXQ2CyfRTS
D3Jg6gVYBkWVzILCfc3C
=rSvV
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cb36ff7.2080...@thykier.net

Re: RFS: equinox-themes

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-10 10:52, Hadret wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "equinox-themes".
> 
> * Package name: equinox-themes
>   Version : 1.30.2-2
>   Upstream Author : Matthieu James 
> * URL : http://gnome-look.org/content/show.php?content=121881
> * License : GPL-2+
>   Section : gnome
> 
> It builds these binary packages:
> equinox-themes - themes for gtk2 equinox engine
> 
> The package appears to be lintian clean.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/e/equinox-themes
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/e/equinox-themes/equinox-themes_1.30.2-2.dsc
> 
> I'm already the owner of #599689 ITP:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599689
> I would be glad if someone uploaded this package for me.
> 
> Kind regards

Hi

Sorry for the very late reply on your email. I have done a quick review
of your package. Since I do not use GNOME nor have any experience with
GNOME related packages or desktop themes, this package is mostly outside
my domain.

Nevertheless I have a few comments about it.

debian/control: A dependency on ${shlibs:Depends} does not make sense
for Architecture: all packages. This is for architecture dependent
packages only and is calculated from binaries compiled (e.g.) from C or C++.

debian/copyright: Your RFS suggests it is GPL 2+, but your copyright
says GPL (unversioned) and points to the unversioned GPL in
common-licenses (which points to GPL 3).
  I looked at the upstream files and all I could find was a few xml
files and gtkrc files suggesting an unversioned "GPL" as well. However,
the upstream site also gives an unversioned GPL and links to [1], which
might imply GPL 3.

Personally I would advise you to ask your upstream to clarify the
license[2]. If he/she/they truly mean the "unversioned GPL", he/she/they
can use "any version of GPL" or "GPL version 1 or any later" (both makes
his/her/their intend explicit). I know the license says:

" ... If the Program does not specify a version number of the
GNU General Public License, you may choose any version ever published
by the Free Software Foundation."

But for all I know (as a reviewer or potential user) the xml files
containing the license may be using a different context (e.g. "no
version attribute/tag" means "version 2 or any later"), of which the
program(s) reading these xml files might be aware.


Finally, any reason for using DEP-5 revision 59? 135 appears to be the
newest revision.

~Niels

[1] http://www.gnu.org/licenses/gpl.html

[2] Particularly a license file in the top-level directory or in each of
the sub directories saying "All the content in this/these theme(s) are
copyright $year, $author. You may use/modify/distribute it under the
terms of the $license" would be really nice.

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJMwLNQAAoJEAVLu599gGRCqFsQAK1f4/XxUgbj5r3piE5CaVyt
cNdnkA+GQ3jIEu/UVxTGu/vyR89E73WcdJdPWeczwVsVVIpIh/YovaWn0GOkJIAk
XAzWzxrWX+81oEADwG9wBdQlkCz1DG6Q6Bq/kCjS7qRQEbMVxYPSPgkq8MQQx3RY
LY6kDlbfkaXz4SK93xPoKGkOHyVQgmmgsCDcvLMYKQ1SCE2522x3XC9DuALwrNmK
SNxM+scl9WGN+L7NBZrKNMTEdmsr1iRDfInvHY6bH4j5uxI8EPk4qHvlNiaxlnTb
5lKhFHBO+JwoPiHoAZUMo4s5Bb52s/9NcnwsTLTkkIlnshhmMfOEZyY3tAjNL9k6
THn7+ZKfA3+3goM03xHbLrA4mtKju7cMKx/tbL8VVEuC/3EmpEroNYwqD84f/BAJ
UhapZMkMQPe6g4Q5DiWbJHgyAhtqYegs6OtJJvlwe/KUq2IQDBOVCQ/w6mtXTgA5
vs1+oPuCjrUk/6R8pFZvFDFqXT49MphWnL3BQ+x/s7pyadFOrOaolyJqjiFgduWM
mAVjCWrPc3nx1L3QwDfaIlsZ0RDOA+WiJeWNM+LswW6IKnCcsnleU7Ihj9xBy4nC
B6J3DaHfVEmHtL0OfGZ0ahH59/h/7PRdnEXZTyCMlGDyVlP5NtPX010laJHkfGdI
RHrT8RIqM9PDJ84dRL1+
=Zy4q
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cc0b351.4000...@thykier.net

Re: Open RFS lacking (further) response

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-30 08:59, Michael Tautschnig wrote:
> [...]
>
> One technical question, however, remains: Could we have some list of packages
> that remain to be reviewed? Just telling people "please review some package" 
> is
> pretty awkward...
> 
> Best regards,
> Michael
> 

Asheesh: Sounds like you got a feature request for Debexpo!

Currently we got a list of "unanswered" list emails at [1]; though it
has a couple of issues (not limited to it not updating regularly). It
also creates a number of false-positives (e.g. "nanoblogger-extra" was
also handled in the reply to the "nanoblogger" email, but detecting this
is non-trivial).

I can try to extend this script to be more suited for this purpose.

~Niels

[1] http://rose.makesad.us/~paulproteus/four-days/

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJMy9gMAAoJEAVLu599gGRC758P/RdzE+Alo25HtZBfyfr8ilUJ
TOYPn44A5IeI1ohlSi+8pJEGuAFjliD2pvXDmoPWokgERAaowsE/SYzlCoqCsZxL
zYMUnhnYLUBfdOrcRgsMNPeibiNJr/ckxq+/HZ1E705jSfNQy8SCBBWtrKSVj8ba
i2Yr5qZwc+z6QAaOTbHwmJDjgZiCerhVqsISaVgTNGY8CeiSz6S9FziklN1yKa0A
18YpRiTxaZOy9TyMQfU4iosPjQ0n5A41bAZux88mfG2I0ANzFTOa1aHspcEhswqU
J2PRVhSa7mopFWYvzwasr/oN7lQLvLcb8JAt4NHQqpJawoxb139Aq7NFrY7WZ4ja
aISZV8EMnzxgdyZUkCJpeHPxuI+3z/OR6Yj23IyzZRxxAjBMgYor50Uqdv8iza/d
YAv8+vTHlYc6Peern12mCtgJCiM56e4Rfy7f/N8TKd5334DvtaNXgNCCBnNxw5fH
6/UH5ZF0SmIHJHwwWZQjQk44ebiAMPqYWUgWhgy4dtJ9CxmVAn9Ufpn7Ed5Xv9j2
mSqAJeRLwIsa1ehMNLF8LaXdiLEvFXlSCSrpT4klK+UyjO9tHf1pbqUnxCVX7LU0
fmVzjzg4NdKJJVr7SIwoA6x+k+R395QR1JZMRn8FiTznNg+PlRYYB53Ng72e9Vqe
98Vu6m+NBHSQlMIvHh98
=ItMW
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ccbd80d.5010...@thykier.net

Re: Open RFS lacking (further) response

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-10-30 02:16, The Fungi wrote:
> On Fri, Oct 29, 2010 at 10:44:37PM +0100, Noel David Torres Taño wrote:
> [...]
>> Is it always an upstream package worst than a repackaged package?
> [...]
> 
>>From what I've seen, in most cases, yes.
> 
> I am one of the guilty "one pet package" upstream authors who gets
> my Debian work uploaded by a gracious sponsor. [...]
>

Hi

Personally I believe that Noel's statement is relates to upstream, who
have their own packaging + their own little repository as compared to
upstreams like you, who also work on the Debian side.

> Even with a "special interest in Debian" I am fairly certain my
> *one* package would be improved if repackaged by an experienced
> Debian Developer.

Mmm... if such an improvement exists, it is likely a non-issue (or not
worth the time) since your sponsor has not mentioned it.

On a related note, while an experienced DD (or non-DD for that matter)
may make a "better" debian package most of them would still be an
inferior maintainer. All bug reports are handled by one who knows the
code and the latency of forwarding upstream bugs is ... 0!

> On several occasions I've gotten close to ...
> even applying for a DM/DD role
> in the project, but I'm mindful of the limited spare time I have in
> my life and careful not to commit to responsibilities beyond my
> present capacity.

Personally I think you should have an extra look at the DM role. You may
not be ready for it just yet, but I think aiming for it would be an
improvement for you. :)

As I see it, the DM role does not come with any extra responsibilities
for you other than the annual ping, if you are already double checking
your own package before sending it to your sponsor. It is not like
becoming a DM forces you to become a DD later[1] or anything.
  Sure, you also have to explicitly agree to abide by some rules and
guidelines, but you are probably following all these already.

On the plus side, you would be able to upload your pet package at will.
This saves you an email to your (at that time ex-)sponsor with every
upload (at the price of one email per year).

But of course, you should contact your sponsor about it - he/she knows
you, your package and your skills better than I do. :)

~Niels

[1] "Individuals may apply to become a Debian Maintainer without being
in the n-m queue, or having any intention of joining the n-m queue."

http://www.debian.org/vote/2007/vote_003

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJMy+okAAoJEAVLu599gGRCesQP/1FF0vpnom/N8xpjV9T8x617
Mtb8SXK1W8CJ+guomx8tRYuSTU2O/IPguJAMRtG2vm+taBW7szI0SLKC3QYMLFik
/xxqZOk16EQPBtNCybYEJ49QkLQ/9oIqjZjApZryNJsojeSTsfoHBDNMbORngrRU
LxF9gK643Trd/wgmnwDCNYA9jA34xzQvVUI3LHT+oosI7kwf5p21vNFjuTBhdbxn
tGz82ovQOWenuYisZiMalMjr7bJHrdqNdMZo4iF9bBs5Kv+85yMMWTO7yn2KQm6w
LrxdxSuYAmF5eN121T7ThcPyr0J0KCeDnaq9gXLLz+dyNiLAZv645MyhEzeH4JRc
/BxoHe+m9LZe3QzykCIDEVXqOFGJIhucXbRLWcB0TfrqrYLC8At04TL/MFTy+JtL
bvMmRQ47A5bY3TIAuKGhTyu0kBJLsj3fcL0VyktrOxSNVQ0maQyccZLvk7HzLkcr
I61y0htmasO4esYW2fMuiLOsC69GEjILYu6sc/0vP1JSL0PXCFb2r5o5wZmay0NK
NeC47ePFKpYesF6qHtY/+t/ACaWkYke559LegI6GFU+HYB5t4uKYAGhwale+ADLH
t6de3B16HB2vR+cTVIAMECktcATvlLmoS3iyyRU5jP79e/pf3xXkGIZgOLbaXHRF
7zUV4pyGSD6IelTN6jx/
=SITe
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ccbea25.5050...@thykier.net

Re: Bug merge fail owner mismatch

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-11-01 14:29, Daniel Stender wrote:
> Hi people,
> 
> it would be good idea to merge my ITP with the "original" RFP, but my attempt 
> to merge two bugs failed:
> 
> 
> Bug#568920: RFP: didjvu -- encoding into DjVu with layers separation
> Bug#601781: ITP: didjvu - DjVu encoder with foreground/background layer 
> separation using Gamera
> Mismatch - only Bugs in same state can be merged:
> Values for `owner' don't match:
>  #568920 has `';
>  #601781 has `Daniel Stender '
> 
> 
> What could I do for housekeeping here, "forcemerge"?
> 
> ---
> http://www.danielstender.com/granthinam/
> PGP key: 1654BD9C
> 
> 

Hi

forcemerge works (though remember that forcemerge x y is not the same as
forcemerge y x).

Alternatively you can take ownership of the RFP bug first and then do
the merge (which can be done in the same email). Though...

> "Mismatch - only Bugs in same state can be merged:"

merge is rather pedantic, so you may have to do other changes first as
well (I cannot remember if the "title" is a part of the "bug state" or not).

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJMzwCoAAoJEAVLu599gGRCVkIQAJaO1QQhSK16YrlJRItiJ1xi
9IUj/sHJgkqhkT2Xnc1jx0TREjt0P6DDHMXxYXUxkximMAjc4CwDnVZULE1aZGEN
6/mRKMN43aurMdj5yh0SWvKMwUICyW2cPmzWcJrxV6ZYOvozAOL/IZEko22is+j2
WoFg3Y1xD+4cSJDGA0L1qwRI5x30U3jvTXAN8RCRgxlB1CFRXgIdEZKRsuXmlDNi
f2v4GvKYoNKvUPce98pUy/oVqxAUMGVG4asI5CxvS6X4h4vfcg1GIUUXMgB+DE/U
CZfst6o9LLKU6IeHk9sQjFEAF24672UEzzCREhLAs2DuAsRHCKhV3FC+i0FUqnYg
EUJ/XJmMtuIS8kfN1ZDF7lyorHsY4Wd/n4cstvF+DLMPbR3OA1rG7qhT1ZwO3KY6
LzpdXn8+/11hBEpC1wBY7w9nqyU8W5Kc0sLyIZTOFkQo1IovuTDQv8UJRS09tieY
3kMjTix4b4TJGR1mEeP/w0f7VdJgnhY955+QHsi/cXYDXPRpoyNSJPYsqmrbFlQg
u0WyXCQIMnuWyz/H78IWI+oRZrcl2Hb1+FrCxhiACsiKC7xg5rLYzkcrDKK+0sx+
F4e/OQn6qfcoagbAE9pFJLbsYM9KaFuCEIXRclDXpC3gXZ147PYWPCctm/1WIh0A
qHmXTGBiDfah1vbsVzpS
=N3du
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ccf00aa.7020...@thykier.net

Re: RFS: clipit

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-11-12 13:51, Julien Valroff wrote:
> Le vendredi 12 nov. 2010 à 13:48:01 (+0100), Raphael Hertzog a écrit :
>> Hi,
>>
>> On Fri, 12 Nov 2010, Cristian Henzel wrote:
>>> P.S. I find it odd that it includes the package even if there's no
>>> referece to it and I also use -Wl,--as-needed...
>>
>> Maybe -Wl,--as-needed is not smart enough to cover this case. Entirely
>> dropping the -lpthread is the only way to fix this apparently.
> 
> I haven't checked the package at all, but if it uses libtool, it might also 
> be related to #347650 [0] which prevents -Wl,--as-needed to work as expected.
> 
> Cheers,
> Julien
> 
> [0] http://bugs.debian.org/347650
> 

I noticed that --as-needed was one of the first arguments passed and is
definitely passed before the libraries.
  I think the issue is that it picks up -pthread via pkg-config and
- --as-needed does not handle -pthread, since it is not a "-l", but it is
a wild-guess.

~Niels


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJM3UDNAAoJEAVLu599gGRC6U8P/RApv10gubEdmmOMaY72p6ii
EjBVx7X1q/HZ+W0S8vRDCj6EHnFRB3u/fmE+9qdfDGvKVmmj0sDmifCJfEWzFwDa
oyovoMLqTNHpSfsMxRpzHXS186v2fwVl78094NBz7GAvQrUyCatDuu6l7gqjdDJ9
9nw6yazB4uoIlFqOdEpDcEJ2SUzJy1O3TBeOTAIXbnyMMViD4BK+Mtf6nSfYMl7v
xxVXYBcBoWI5IJnglffCbf4OxO7oNru6WT/XhBcgWFIHgMZj1Q9SEMtun+39xHWf
btmgfo+GVJZNEWDSaHHSjNbrJEM9dFcbrNfF0x9aYyVkvSSlfgodTepH5TDL3doc
ZEmEMLOhVyF4D8wTfishZsnuWIfjE/naa9AqTc6ezIzsMMXWRKqU61ykUWyTyCqO
gvwrPbUQ4fm9Eet3DSIgbGyD5kCd6+aSwIbav11yr9xEybViLB5bmrQub2xcnpJa
lHQmde6gLiZfKdjwOy+cviKbWXy5E8Ny1b2NzmhtWOeOeBRW4+GVuy6iEVtc4BJh
QMSDxZhI08mJ92uyaOwLvC9+gNNaIVceeuDWyX6/oXjTxTfAilpe5WXStbZuWBgQ
h5wDrqEs91uIpa3NuJ15xbjedn7HF449eHmuVW0BGmoT8fIY8lEeULI2ZZVzs3iM
fsbwKnzkTfwV+DkjWwuS
=6bve
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cdd40ce.8040...@thykier.net

Re: RFS: clipit

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-11-12 18:32, Cristian Henzel wrote:
>> I responded on a specific point (which concerns me since I'm maintaining
>> dpkg-shlibdeps), I have not looked the rest of the package and I don't
>> intend to do it, sorry.
>>
>> Someone else should be sponsoring it.
> 
> 
> Ohh, ok then, I got you wrong.
> Sorry about that. :-)
> 
> I'm still figuring out how all of this works (I mean the procedure for
> finding a sponsor)...
> 

You are in the middle of the process; it started when you sent the first
RFS email. :)

Anyhow, I had yet another look at your package; the copyright file does
not Xyhthyx as the copyright holder of a lot of files. Even if he/she
stopped developing on the project and you forked it, the original code
is still (also) copyrighted by Xyhthyx.

Which brings us to another interesting detail; parcellite (the forked
project) has already been packaged for Debian by someone[1]. Have you
talked to the current maintainer of parcellite? Andrew might be
interested in replacing parcellite with clipit as well (with the
upstream retiring).
  You got an perfect opportunity to get a co-maintainer and a sponsor
here. :)

There are a few bugs filed against parcellite; have you checked if
clipit is affected by those? Fixing all of them is not a requirement for
getting the package sponsored - I am just lazily forwarding bugs to
upstream here ^^

Anyhow, once you fix the copyright issue I listed above and get in
contact with Andrew about parcellite and clipit; I think this package is
good to go. :)

> 
> Best regards,
> Mit freundlichen Grüßen,
> 
> Henzel Cristian
> 
> 

~Niels

[1] http://packages.qa.debian.org/p/parcellite.html

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJM3bR1AAoJEAVLu599gGRCIYwP/i5wLQhRUliiV8OXgU69FPs4
svIPKl06/3fC60ThkmhDOntufpWeVp1K6JRIx58fcvC7NST2i5NG9BEzIycvG3yN
Mt16i291gjY7y6yOxwr664a0QK4aXLQulYTcG4V1uC9LMLvM4LGp6/F49tKVl/fE
pISXucvdcyA9QNE0ia75gImTUmRAGjRlutSCexmdLi8fWi8J71dUPFwLzaOPhhup
jZ4h7jAM4SK7EjjZu/h1e+t8Dis3egDHubUU7k8pv9sRqBFAHz2KO9jdkCDSpnRp
rjNi3lDL8QX8pH4mwb1Jj6P4FCczGdK2sJMtrt9/k2/NyoN2EUsp+8lvV4T8iTV4
HIdc0q7k+Q1o3W8PfZ9zSMT8lXXTTSHlFDOqHAL2anN5qJpKL70W1ir+WsD4Rnik
BMJkJeDIVQqGpFEpm+pmci4zXHFMo9Tfad2PuVCPy1snKxmTqE4YVXQBA36LaBhH
owGxBB/rH4AKzDN/FN1RO1w2GYnJnAIHZVO9HQ9fWVs/s8/Ot21OLiqG/6UWNzfa
EQpgunzKSIYuBrdjDl2Rcmw+IjeY0+oCapFyXie9fNKK3YwVxDimHdnfVRs78T8k
unhEl0bWDLm4lpzaMsy+zvkSo4F77mc0pWf69E/HQnkGqH0mIlHjG5sUdYzVWtbf
+KtqNg3K2xMJ1mPp1Ryg
=rRwR
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cddb476.7070...@thykier.net

Re: RFS: clipit

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-11-15 10:13, Henzel Cristian wrote:
> Hello,
> 

Hi

> 
> so I have written an E-Mail to the original maintainer of parcellite
> more than 2 days ago and haven't got any answer yet. Should I still wait
> for an answer, or is anyone else interested in uploading this package?
> 
> 

The maintainer may have been away for the weekend or just a bit above
average busy right now. Debian consists of a lot of volunteers spending
their spare time on the project, so unfortunately some times it may take
a while for people to respond. :)

I say we give Andrew another 5-7 days reply; then if you have not heard
from him, ping him again CCing the list. But most likely you will see an
answer within 14 days of your first email. If not, just reply to this
email and we can check up on it.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJM4QWTAAoJEAVLu599gGRCARUQAJbOC3XJZl+uncQ4O/xa4PXD
vyUWZi1MPyDyDhxLrUfdmckOg3pOSYg4/PtMNzLhqYOAGLEYsA7yiEpmdg3N4oAh
ZSwe8PZOslJzcVYYUiwB8GgMDGX8B+C0WEsV+1El0ZEIE44ySn7AcMMmzd8e2xhp
FzdsW4qYzK4mV0Z2zMXNF4Hz5svZqS28f02ZuxJgsYOPecJ6++XBnRFCtQguwxcj
/DK8oi2ArRE90Hj37jIt/2SKzR8BnOLjs0pUK8bOeEwnfG/oMbjDI+gsomF0+itC
afflXLryqWznV8utn8R5zqyAfVy9rWjiMWUPmagLALmeg9jXe09zq7qYz9kM1ncF
s3As5RIK8NNl3j0+vwgisufxXKEmO1EXXFRTmWuVM5u3yXpUX+jRnjVAl0HHZ62w
yE5gOEz/3ChDFe9pW6doPQK5B0QwJF9GmvU+isNI+8c+GhGb3AyimF9bY7ju1Hvf
SCCT+7xLflRd2+5zHygUdA6dQo2Y5acK8OAnsjwY1937VTb6dngid/8sB97cixY5
zbcAESjQR1p4tbck+ZABqeha4sHP/1++BtPNcAViab+RxN1BZ6WM3O2MyhNZP8Sv
N7AlJMw8Z2FHucg8fuKxJXuwbOh9b6qvnBXr06JDlJWEgprMN9JNGKDsdxmCW/qU
vYlGJ9vCUf2r6oHbbpWr
=8yeW
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ce10595.2000...@thykier.net

Re: RFS: clipit

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-11-25 13:16, Cristian Henzel wrote:
> 
> Hello,
> 
> 
> it's been almost two weeks now and I still haven't got an answer from
> the maintainer of parcellite.
> 
> 
> --
> Best regards,
> Mit freundlichen Grüßen,
> 
> Henzel Cristian
> 
> 

Alright, I will follow up on this; unfortunately this may take a while.
I will let you know if I hear something.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJM7mRIAAoJEAVLu599gGRCAJEP/1FZ+UR13dEemANGffPE9oWG
6IQ0fKAoGjE6WC00DicgB5OQrPt2ytbc0dRHRtMtHInlL4hwj8uXGFOmbUq49vxr
01Ufq1BsQW/mh7lwyb7oL1I2bIDyeV9JvbHDLiZz8Ly7kIfwJgkAP8SxJ3JYxzj0
UfO9IUWjkY3ftoXz2N1HJxDHpyNlk4szlVS1mUNHbCVs3X1lc4MYH1Fvg3bFx0Yr
6R14LdYeKKAx7yPh6v6ism/jOWH8NLfLbQA/aB7b2R0E0cKSM2fvmL+jbt8MPUOC
a6lZMshR1l1h7lQEYt5xhkQk6aIeWzy4v6V6F9CqyyWIj5Lsy6onvL6V1Pc4bdgS
NYyjSvr+S1/c6/DrhvD78QKONVz7v/euw3KoDzCOD0XPiglfEsbXG9ToU4V9UyUc
Yt68Q054gasD+Er8tbrfbUPf0+gSbfsvRkdctZ4b1/9bQU+tLVm2npHWfVlHJnG6
CUvuTA9B9NWdlNeGG5/R3AO0Y0TauLbEQCsTbKkE5MvgttuYTKPfsZRyX0O7jeKN
+pph4z/wQUvn9hwBiXWDKh3dBbIIeAKueOME7O7LZKODk84wIuqPN1EylYoYIk76
wtd7PGQQgyHGTXV3oA6xnW0jDoyY0QYWF96TtTubw2uOtN0DWA1LvNNu0GELs1Fh
QVAGms7Bw/M7k38BBKKi
=I+dK
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cee6449.5020...@thykier.net

Re: ClipIt -- Clipboard manager

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-11-26 13:59, Cristian Henzel wrote:
> Hello again,
> 
> 
> I just made a new upstream release to fix a couple of open issues and
> have updated the debian package on mentors.debian.net to the latest
> version (1.3.4).
> 
> I'd welcome reviews of it and I'd be very thankful if someone could
> upload it.
> 
> 
> Best regards,
> Mit freundlichen Grüßen,
> 
> Henzel Cristian
> 
> 

Hey Andrew

Do you have a long term sponsor for parcellite (e.g. one that said "feel
free to contact me about future uploads for parcellite") who might be
interested in long term sponsoring of ClipIt?

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJM+B38AAoJEAVLu599gGRCnrQQAJcw1j4iGuLN3g21DsfRxXkV
brAFAro/Iq/Ep9RJQxZI7TRfOAGUVwuErk2IxG3Y0mUZt7K1tfLVLa0D51tq/RUf
3i4x1u5Rm7X9lXoyXjXQYidlG3WyKbNKhrQ3w8w/Nouak1ZXTOMkk/CaZ9QFOvIz
E69auGiwvtpZ0TXBpahZF+gM5+zxIYoTlBZqXAe3LskJgjVlcdMsh3cCBO3Y0yKa
ZyWSTLTK59rjRy52zvia/LaRZ4N3kz6wbHBAEoYR+/Hr19YG/Rjaqgyb31qSy7dO
cZfamaujee5saDkznsGSu7rFAGH42VCzoQh4A3EEl1SsSxMqh07xc/cK248nWswI
WDN5IIiQp0t/HdUNenc07AhirLo7sH4oIejZcGJZ6an9i8rx7IQUMd63lKJS2gPM
mferufUdAqzQ0mvCRQOfdu6uvvkbjS1otFxrDh26XAzlvLHp2cBWeZNGD/j6EOqx
2ux00Yp/rXiD+1TNoxd0fpVsbYiU1O50h2RPGJyZ+qnh8x8AieGC1HjAdl7Rt8Ci
LYRCsm25BUWQeInOVfXEvo0dr2UauI+otKEXuZmqadVaDpLlYgmjDWjeBlrBKN9R
npaB3s7JfquLZRawNg2DiZtTTqxbqPGdaIcrdMzxiPQweOH0CwnPEukHRyuS9Z/O
CBMtBAZeoK2SE74NeDxX
=2j0F
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cf81dfd.4030...@thykier.net

Re: RFS: amavisd-milter (updated package - 2nd try)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-03 19:47, Harald Jenny wrote:
> Hello,
> 
> I know it's not good mailing style to reply to my own message but as 5 days
> have passed I just wanted to send a reminder to the list (yes I know it's not
> very polite to be noisy and things need their time but this package is 
> targeted
> at Squeeze which means time is limited...).
> 
> Thanks for your help
> Kind regards
> Harald Jenny
> 

Hey,

Sorry to hear that you have not gotten a reply within four days, which
some of us try to keep as a guideline for longest reply time.


Have you talked with the release team about your changes? Particularly
there no bugs closed by this upload and there are a lot of changes, so
are any of these changes actually closing an RC bug or solve any issue
that the release team has asked you to fix (or approved an
unblock/freeze-exception for)?

Also, consider removing "irrelevant" changes. As much as fixing minor
packaging issues is great, it is very disturbing during the freeze.
Before unblocking the package, the release team will probably review the
changes with a "there is potentially a bug in every change" mentality
and they can reject packages that have unrelated changes.

~Niels


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJM+UJ+AAoJEAVLu599gGRCdCQP/At2xuGZtMvTAjCQT42lR4Gu
7UrrXmtVTgjHMQ35GxTn2MF9kfVPUESWMbEKzlCXhbk1QPY1+jDya9zIXmIgkiGA
ScnyhHKNb1iH9ScbmOlbkwTBnz5MBH1isE2706o82S0EhsBr1nVbLa2GvGGOrGUD
LFvnX7EWNouO+Ye4LSIsVdwBXJOTjbRXOgbuSAD7BpGF2y34YtQDIx8E2qUrtzR0
mvdBVaRT1XwnpJhj/l76Bv8z53ni2DooQ7U5A9ilski8Sxy/FW2gTJtzcMIMt3B6
I/Ek7R7SD6hJOSR9XSsPVsRQVRR1bht4aiBijrbhs4osYY0qvXhsJjmYvxnkX+DL
MYvYBL1+L5IHe0rum+Xa8hsVfvBa9USO+yXKigGQODByiG83WGjZQwjKzxRWQvim
lQHYuVCKvKohAbC3QrSyp24DBT54RA41Kt+H6qdqaaxIDewZEOjNLWxtR4Wgy/QU
5kdTPPno5k/Dqul1xdT423Xgr31qL78olS3Q3YuQ77j9ZsGxyQTuIntjcgu56gOi
IpN7hs6VsqtYwqLD1BPeLlgvrVO+m++jqSQYo2qxm1fcCxbEGvH4G9iV6Dmz+k8i
hUgbcZMXZK31OranBFmu8PMtlC2carOjmu2lyy1I6TJaBPrY01qMgkx/X2Q0QS+N
DeMFM52vLFpJLabt6izP
=NY1v
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cf9427f.6020...@thykier.net

Re: RFS: disco

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-08 02:25, Janos Guljas wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "disco".
> 
> [...]
> 
> Kind regards
>  Janos Guljas
> 
> 

Hi again,

Sorry for not getting back to you earlier[1].

[quote]
>
> Why do disco-master Pre-Depends on python-disco? I see nothing in the
> preinst script that suggests that python-disco must be present before
> disco-master is unpacked.

Python module "disco" is needed for starting python-master.
Python-setuptools on disco python module must be triggered before
running /etc/init.d/disco-master start, which is done after installing
python-disco. Trying to start disco-master before configuring
python-disco package will fail.
[/quote]

You only need a Pre-Depends if you are starting disco-master in the
preinst script (which does not make sense, since the package has yet to
be unpacked at that point).
  If a package A depends on B, then the postinst script of B will always
be run before the postinst of A.

If you can avoid Pre-Depending then please do, since the strength of the
dependency makes some difficult and you need approval to do it.

[qoute]
> It fails to build from source if Build-Depends-Indep are not satisfied
> when dpkg-buildpackage is invoked with -B:
> [...]
> sphinx-build -b html -d .build/doctrees   . .build/html
> make[2]: sphinx-build: Command not found
> [...]
>
> This is how auto-builders will build your package. As I recall the
> debian-policy is disagreeing with reality here. I believe there is an
> attempt to make these two agree, but for now your package must be able
> to build without Build-Depends-Indep when dpkg-buildpackage is passed -B.

Are you suggesting to move references from:
Build-Depends-Indep: python-sphinx, libjs-jquery
to Build-Depends?

With that set, cowbuilder --build disco_0.3.1-1.dsc --buildresult .
- --binary-arch is building packages fine. But I do not understand the
reason for -B option in autobuild scripts. Do you have some references
that can clarify reason for it. Until now, I tested packages without
- --binary-arch build. I see now that this is a requirement.
[/quote]

Moving those packages (as you now have done) to Build-Depends is one
solution.

You should be able reproduce the original issue by moving them back to
Build-Depends-Indep and running cowbuilder with --debbuildopts "-B".

[quote]
>
> Have you contacted (or considered to contact) the python application
> team about team maintaining the package? (See [1] for more info).

Yes, but I am not sure is this belongs to DMPT or PAPT. There are
modules and application packages...

[/quote]

Have you tried contacting any of the teams? Either team should be able
to help you (at least by telling you, that you should contact the other
team). Again I am not really into Python, so I cannot do much for you here.

Once again, sorry for the late reply. Another time, feel free to ping me
privately if I do not reply to you within 4 days. :)

~Niels

[1] http://lists.debian.org/debian-mentors/2010/10/msg00213.html


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNA1J/AAoJEAVLu599gGRCbtAQAIXUixlPcgpRXOqZwQlWFQf+
EqGBKiisv6cQtfzLikiwe94DO4UXkeUXqiUYNwx7A6liIeqT6vtcEHboMa0W8ALk
QupNn1Kt9IVLqgi51NZh6KB+vveYNo8xL4B++zwiq8GGd0+W2Ul8X2/eGascXrbl
coQO+uQ2MbpMWhTMS+Af4SUzJ9KHv8QFJfUwqxI244u188tUNCiujOoc3aiwayUO
7LZKQm8BruPnAVinIUjQ/I/bE6CBQ8ir5C4y/DEXq2Oa22YI1eci5XKkjchvxqtU
XRDnuTgiZ07Xw+iHwkCflZ5utHofiueloOTNZ1oP/hnSqi9Cd0zb7bRhXDaVAlXz
B1jKGyhBk4jUI0hbc+735XKNmUgutFz8TrpZsWpJsjDPqANlFckQiV1IBI+pWN47
6SNOp93FhGaPr7gANKmHLLXToQnNE18aLYA2cvS0ksEQBg18cE/UtEHX6IH4HLol
r5novmJD+BWbzhoahTqOihdAdX3CsOAEvKtB5YDlK+54AJJYQeeJd5LYEiHSCXdw
E4ZBKo95Q4Bl/w0HiYGwI5rCri6JwNRjxxiZ0LDdCLDvv+GRi39LpX/SMbd/0s6L
z5carlQGPfCT4x34bqkIdMfLtPqKjBPbrjVkp4VEnyQtJgzLyXPUnKuUIAdhtEDu
z5Wuk1mbkBWnoBwK6Buj
=Imx0
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d035280.7050...@thykier.net

Re: RFS: sciteproj (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-08 02:48, Andreas Ronnquist wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 0.3.17-1
> of my package "sciteproj".
> 
> It builds these binary packages:
> sciteproj  - project manager for the SciTE editor
> 
> The package appears to be lintian clean.
> 
> New upstream, with just a small trim to the short description (Removal of the 
> two
> words "usage with").
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/sciteproj
> - Source repository: deb-src http://mentors.debian.net/debian unstable main 
> contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/s/sciteproj/sciteproj_0.3.17-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Andreas Rönnquist

Hey

I only had time for a very short review right now; cppcheck reports a
few leaks in your package. Could you have a look at patching them?


Checking src/folder_to_xml.c...
[src/folder_to_xml.c:168]: (error) Memory leak: shortname
Checking src/properties_dialog.c...
[src/properties_dialog.c:174]: (error) Memory leak: size_string

Feel free to ping when you have done that and I will give a more
thorough review of your package.

Thanks in advance,
~Niels


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNA1pgAAoJEAVLu599gGRCer4P/3fUif+FBokonCbVX+M8X9Yf
ShDFj6yb10LpBnTssy+3sgdcdpnOVWBU+biMxySEHwqnt+Anthd5laCmnrJBh7+J
zopF/I7KIvxsD9Amz7O/BSBLrI977JFnb6O8DC7njsM75XBLtTkIQxrwy+qv3ESY
3F+TqJSEfKqLgtErBB4mGS6iRgFAdfp7mm4N3alGjr9TECn8YG7WrxnV+POvLjls
ObR1AMDO0IoDhZWAgXAhWoEg2l0iX2qmX75mcNzhSN6QBV1k7bYzvFU7MBBUsz90
XOFOzoeIUKm8NBspT8LmM7UxO33M+8xVkU/u/+uiNSeffpcsnaCCImq0z56wNgrJ
PogrPNQ88psbkgfeCzSCXy9xA3MKQLDlo+9I1nJU9PuMLQuMOh2JHNa8bNLVOJnm
1Vz3CJsfoE9fWeYUyDiBx/j+//GGwqyVsbT/RIiOloD2cJIwYS2JwuhaCzPHEaKS
82V0+CI1YFTjjP6Uh8lWRPRW8HBDr/2n1aGFpelDqDFNdu0tTEmO0XgkeG8/xBVT
RXZ4TmE9JVMDdSNZuuAaAMLvXhIOus3c1otjkm0aMggRP3NHcQB6USpKjTl+f8CP
CDtVzs44ae+bcM5lX5GhtREnud8DIwVx8AA4ug+y1EMCeauSpbMOBeHeHGX7U0aT
AYxXX5rFAW5CPObWR2/J
=TG79
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d035a60.6070...@thykier.net

Re: RFS: sciteproj (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-11 17:40, Andreas Ronnquist wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 0.3.20-1
> of my package "sciteproj".
> 
> It builds these binary packages:
> sciteproj  - project manager for the SciTE editor
> 
> The package appears to be lintian clean.
> 
> - This upload fixes a whole lot of problems brought to my attention by Niels 
> Thykier. Many thanks!
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/sciteproj
> - Source repository: deb-src http://mentors.debian.net/debian unstable main 
> contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/s/sciteproj/sciteproj_0.3.20-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Andreas Rönnquist

uploaded, thanks for your contribution to Debian and feel free to
contact me directly when there is new version ready of sciteproj.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNA6rrAAoJEAVLu599gGRCuHcQAI8GjSn3/bQcEqjAieV+L5Z4
g6HwP9/ju3Qe3fCKHvQzniicRw3QdUTKtDf7ld35dxm2TphgKN9J+HtMIYL6aDeF
f9+VshT34g/Yb7dZEFXJvyuSShZxeae6ZmfY9ZWrh60mUQ27PAnnLsfqZaQGh1AX
RwM8/EC7nNXM5Twv4NbSMmM2LVcegX1l5oV67S2bRFqwdjXiWWUVPasZoYxPB4jB
4AoNeoAH//MDmzwBj30k/3LNYfIVrrJd48X5+jrWFJvv8feThQ7tyjilHSR5Fl4Q
jMs+ul2Jn49CNzwZWYvsjtgq6kdAtj6tyQ6ZuZiXcgQxVSCpwe/jvhS7aYqI3ju0
E2yiLLwH2Q1VzJ72YCl/ZRnb7yW7VNf0cHoNXzF8j4HBOO/G6S3399jjrPPBRB2Q
lHS2M4J4LrYs2kYjIL0rhnyamDsCi8QyMAn7+xygg4N9EdfHi2lZTb0m3eyTolL8
rvweGUHKeseK2eWn3Kr2TmmJJVxB3S8A3daO98O1TEUiW4hjCLIs+3os2kAu2/eK
wJlIR6GBYXHmbn8vA00j37gKoNOt3SGL9H3p0jEWrLIPGNnKSSjtILH9TA3G6+Aj
UYMMGVX6i6unKX19u95Cfm05NRLh+10HgjJW2pvEOaqldqcvOQQA2sXOazjG2c1K
QPeKBI5gMS4FYgP+URBH
=1rUi
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d03aaec.9080...@thykier.net

Re: RFS: lilo (updated package) (new Maintainer)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-11 18:29, Joachim Wiedorn wrote:
> Dear mentors,
> 

Hi,

I had a quick look at your package, though there are things I may have
missed.

> I am looking for a sponsor for the new version 1:22.8-9
> of my package "lilo".
> 
> It builds these binary packages:
> lilo   - LInux LOader - The Classic OS loader can load Linux and others
> lilo-doc   - Documentation for LILO (LInux LOader)
> 
> The package appears to be lintian clean.
> 

Too much copy paste from the RFS template :) The binary package has 11
warnings (it also triggers a number of less severe tags e.g. I). Anyhow,
considering you are targeting this for Squeeze, lintian-cleanless in
itself is not a priority.

> The upload would fix these bugs: 398957, 400642, 409285, 420587, 427507
> 
> [...]
> I would be glad if someone uploaded this package for me.
> 
> The CTTE disposed at 1st December that I am allowed to be the new 
> Maintainer for the LILO package:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=587886#158
> 
> This update of the LILO package (based on lilo 22.8-8.3) comes with a 
> small set of bugfixes to work better within Squeeze. The target is to 
> enter to testing before Squeeze will be released (I hope to the release
> team).
> 

Your priority being what it is; you should aim for fixing critical or
highly annoying bugs with the minimal number of changes. If the diff
gets to large, the release team may choose to reject it because they
cannot keep track of the changes.

Have you talked with the release team about the bugs you are fixing? I
can understand the feeling of wanting to fix as much as possible, but
the release team may feel the bugs are not important enough for the
changes required.

> 
> FYI here are the last changelog entry:
> 
> lilo (1:22.8-9) unstable; urgency=low
> 
>   * New maintainter.
>   * debian/patches:
> - Remove patch 16_geometry.patch for inaccessible disks and add
>   information in README.Debian about using of 'inaccessible' option.
>   (Closes: #409285, #400642)
> - Fix script checkit for newer gcc.
> - Fix for use LVM volume as root device. (Closes: #398957)
> - Fix for better computing vmlinux size, upgrade hints in
>   README.Debian. (fixing sporadic failures).
>   * Fix hook scripts: check for /sbin/lilo.
>   * Add lacking file disk.com for creating test floppy.
>   * Add universal menu image for debian, remove menu image for sarge.
>   Update of template, postinst and postrm. (Closes: #420587, #427507)


>   * Set source format 1.0. Add README.source file.

I recommend undoing at least the README.source file; first off, it does
not describe what it is supposed too and secondly even if you correct
it, it has no functional change. The format part is only 1 line, so it
is (probably) not going to disturb the reviewer too much.

>   * Update watch file to new alioth project area.
>   * debian/control:
> - Remove VCS urls and add new Homepage url.
> - Remove IA64 architecture (this is already status quo).
> - Remove double lines of Priority and Section.
> - Add package conflicts to grub-pc and grub-legacy.
> - Remove conflicts to manpages.
> - Bump to Standards-Version 3.9.1 (without changes).
> 
> 
> Kind regards
>  Joachim Wiedorn


I had a look and:

- --- lilo-22.8/debian/lilo.postinst
+++ lilo-22.8-9/debian/lilo.postinst
[...]
+   # to be compatible to older debian package
+   if [ ! -e /boot/sarge.bmp ]; then
+   ln -sf debian.bmp /boot/sarge.bmp
fi
[...]

That "debian.bmp", should that have been a "/boot/debian.bmp"?

In this snippet:
- --- lilo-22.8/debian/rules
+++ lilo-22.8-9/debian/rules
@@ -23,6 +23,7 @@
dh_testdir
make spotless
-rm -f build debian/files debian/lilo.substvars [...]
+   -rm -f  debian/*.debhelper.log debian/lilo-doc.substvars
-rm -f doc/*.dvi doc/*.ps doc/*.aux doc/*.toc doc/*.log
-rm -rf debian/lilo debian/lilo-doc debian/*.debhelper [...]
[...]

Most of these lines (incl. the one added) appear to be re-implementing
dh_clean. Replacing those lines with dh_clean /might/ be better (because
the release team knows what dh_clean does and do not need to verify the
handmade version)

There are also a lot of po file updates, which are not translation
changes. I presume they have been made by some tool (e.g.
debconf-updatepo from the clean target). As far as I can tell it has
just added a Language header and in some cases modified the translation
so that % is with its arguments (e.g. "%"\n"s" becomes \n"%s").
  If these changes can sanely be avoided, then that might be a good idea
as well.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNBOTPAAoJEAVLu599gGRCQpMP/AggVPyEMLlcCe8SCJAGi02D
kGpvLlNeKC7WilH3Vk7AJ0Xvylt/0F1kTCq5b/29QCXesZFtSv2GD8lxxjBx1VSN
MJB1a+b4C9+ghFM8MSXGJ4l5K9QRRgeyV0CN6jEVHERa2

Re: RFS: lilo (updated package) (new Maintainer)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-12 16:34, Jakub Wilk wrote:
> * Niels Thykier , 2010-12-12, 16:05:
>> --- lilo-22.8/debian/lilo.postinst
>> +++ lilo-22.8-9/debian/lilo.postinst
>> [...]
>> +   # to be compatible to older debian package
>> +   if [ ! -e /boot/sarge.bmp ]; then
>> +   ln -sf debian.bmp /boot/sarge.bmp
>>fi
>> [...]
>>
>> That "debian.bmp", should that have been a "/boot/debian.bmp"?
> 
> Nope, this symlink should be relative, as per Policy 10.5.
> 

Thanks for the correction, I always manage to confuse myself with how ln
works.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNBO71AAoJEAVLu599gGRChRwQALY9sxDyYOj47A16U4TFRfZv
w4hpTGH+uJSOl62oq6+jRa9mVpX/Q5vLDCMJMXjUdvAkDDrX/XbTGIM6HU8okEWc
WX8Nn0i6xm34lgRtOwqBbwgfmW+qQkRQk+Np6P7cekJE5zMj+C5FCansI+KozymW
LOkjSyofAKEo5RuRzDhmY9q3zGiWs2DUP+5yTL7qLo4XU9psUSi2UdMn0j8kDs79
sXlXsNRyPOOWOv3yO4DlXn1Qj8FOAR6z6RgQ+atgLbo4O5yFbLe8VJh0zK6UURJb
rPrn6TYe3r+RB0+KTrRNLxrsM50iUvu+iY7nhvhmqXqNkqOmX342+MqXn6xgVo+B
fPimsIMP2a2isS3rTLjHZTeHDSlrxlJBilwSjq9pXYjlVg0AnTqDsyAVB4IaoZts
Y+JiampBZXsO0uOWGCRxWI16otYyeb2Hw9Pn2JduSg0AfsEzjnfdosgLWlqe+MMN
cQ15Y8dsdVxGNufIEzwSbaH6P5pkE2sM20ifG0Cq/P/WwbuG+FTVT4gt1TK3BRZG
yWOjE9SrzKa4SfO+Cr5+uqZlKqTG/PDkbCQjh+Dvtq1fIWpBWhLMAmKnQQvgQR8h
/ojutYPCiCgpcyGI0kq0voSi+FW72Lx+6vs/RQBNfw/2YN1R7m51UnNBS/xkQysz
bXdRCKmAR2ba8gB8mmwm
=gYB4
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d04eef6.3040...@thykier.net

Re: RFS: lilo (updated package) (new Maintainer)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-12 16:05, Niels Thykier wrote:
> On 2010-12-11 18:29, Joachim Wiedorn wrote:
>> [...]
>> This update of the LILO package (based on lilo 22.8-8.3) comes with a 
>> small set of bugfixes to work better within Squeeze. The target is to 
>> enter to testing before Squeeze will be released (I hope to the release
>> team).
> 
> 
> Your priority being what it is; you should aim for fixing critical or
> highly annoying bugs with the minimal number of changes. If the diff
> gets to large, the release team may choose to reject it because they
> cannot keep track of the changes.
> 
> Have you talked with the release team about the bugs you are fixing? I
> can understand the feeling of wanting to fix as much as possible, but
> the release team may feel the bugs are not important enough for the
> changes required.
> 
> [...]

Hi again,

I had a chat with Mehdi on IRC and they seemed positive about the
changes (even those I would have minimalised). I will have a second look
at it and upload to unstable unless I notice a real issue. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNBPCAAAoJEAVLu599gGRConoP/3ln/OYezmfmqzVuzHAMOdvP
okbVx14Z0Fs6X5hRLd0ArrIACLX+vbe6/qnFNAwQzME/1posAIl2pvl8oDOSWlRi
50JvGRvxY1KleC8cG4ZFjoPOqpgkvu4JKKZM0v43YZN44YjEZSnmt/5Qiqpu7YBR
xjoKzBwryX94U7APYaT/VB14+hat0Tfx1RSYYWE5SnoXaEa6GUpDBCo7813lT+O2
Zzzhl+rTuJqZ5bHCPwqtANc7zRSUQP7yctpnd+gVNGGBR1SQJBeAuSpfTC+ACDwm
rZg6uttts3YaiZij1S6np8KABtCgh4ktq6eMnlfhCWvE/Z2b8MM6PeywyUUBXpWF
KwD85fZdFsg8p1QiwXOhHPl4o+8G5F4nLYo6J/3qow9Kn035EPAAodiYvBs3jf/c
i1lhgzarxz0DR8VehAu1sFIGtWs1KJ6/7afkKth1/xDGVJObtEVFtYekmgLGji0d
RNQHdrCN4r2T89EM955f6VpkM2f4ZrZDnKAcRmlELRXs2Nnvd1mnP7IXE6PdjZej
frnbpFxFe68GN8lfsFsC+tyB7PjE388FxEo6+VyC/4oRc03XZo4rSPK9mE2+Q9vF
cFZsZHBzQVHp7S58QV7g+/afl0tC/ucg2gMIpBMtp+EZm0NwxDfBEdC9nkYv+F2M
YtgHs0kS3ntJRFX0z+5L
=2HiY
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d04f081.8090...@thykier.net

Re: RFS: lilo (updated package) (new Maintainer)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-11 18:29, Joachim Wiedorn wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 1:22.8-9
> of my package "lilo".
> 
> It builds these binary packages:
> lilo   - LInux LOader - The Classic OS loader can load Linux and others
> lilo-doc   - Documentation for LILO (LInux LOader)
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 398957, 400642, 409285, 420587, 427507
> 
> [...]
> 
> Kind regards
>  Joachim Wiedorn

Uploaded, thanks for your contribution to Debian. :)

For the next non-Squeeze upload you may want to consider using the 3.0
(quilt) format, since it supports binary files in the debian dir
(insteand of the uudecode) as well as cleaning up in the d/rules file
(e.g. using dh_clean instead of multiple "rm -f" etc)

Also the old maintainer is still listed as the "primary maintainer" in
d/copyright.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNBPXKAAoJEAVLu599gGRCDtcP/RpW1Pu1XyTZ+laMlcyKDEgi
5MIl4kp30Lzgjxvq1TgO237v/ETA9Fped4d5qr0/lYe0GOOTrFlga6JlETvDbKFP
37H2JhWEOM1bc4NJPxORAzuR34EroeMyE9SBQ1azUBQziusQPzoittMnCPkWd4ES
Utu9I/n4X5hObemDEskm4X52IJCYo3PpqEtPPLqsBRgCLaQZ/RleAWimzFVx4DLw
YFC/feHMdHsYH/IKLVJ9V6t12ehOo1AUnKzdqwIyZ569DauVsv2yWux9Ar+242VJ
p6+SmL6Yq0Pb8sVU+v1HldNXdmjdXkaPkp+7D00iitTg/xOpRQQ0HaOhiJnxxmTE
kBx6a1oRxXnFMOysXaNCAEyv3xILI/Ilt6uN52tAmm2SXWhPw+J4berOKJ9gD6hA
ibvpAnGHXIwUzS/K4hWYCDghh30A3YvU9UP7nFyllko1Cg367qQeWIGpmowNacRH
UgylpddVG+Pn7cQhOZNvJ+1dv2W84sWKaqseX6WOzdW78uSX0ZYlYeK0q+vG6CBf
a2WWXmt150ESSzGGfCk2wHsDYB5F9JybehG9Ja2LZyYZKIxiwzwGCTVzhgqAnt8u
pvgRVCNVbQOOYMkCL6Iwc6+OGAhWNvG0hmT9DBx5OwsPD/vvH5B0O8HKLa9lzotH
6PS68xkxjI0WO4ly1Nmp
=gdZu
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d04f5ce.90...@thykier.net

Re: RFS: lilo (updated package) (new Maintainer)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-12 19:43, Joachim Wiedorn wrote:
> Hello Niels,
> 
> Niels Thykier  wrote on 2010-12-12 17:18:
> 
>> [...]
>> For the next non-Squeeze upload you may want to consider using the 3.0
>> (quilt) format, since it supports binary files in the debian dir
>> (insteand of the uudecode) as well as cleaning up in the d/rules file
>> (e.g. using dh_clean instead of multiple "rm -f" etc)
> The next (already made) package with lilo 23.1 will use all new "dh"
> methods with format 3.0 (quilt). You can see the "unofficial" packages
> here:  http://lilo.alioth.debian.org/ftp/
> 
>> Also the old maintainer is still listed as the "primary maintainer" in
>> d/copyright.
> With the new file format (see above) it is gone.
> 

On 2010-12-12 17:46, Joachim Wiedorn wrote:
> I know that problem. The most problems come from the special script
> 'liloconfig' which uses with debconf (but it should not do). It is a
> legacy.


Sounds good :) I was not sure how much you had done in your 23.1 package
(I did not check it)

On 2010-12-12 17:46, Joachim Wiedorn wrote:
> [...]
> Should I nevertheless do an update of the package to
> give the release team the chance to let it into Squeeze?
> [...]


In this case, I believe none of the changes mentioned here are worth
trouble for a second upload for Squeeze (given that the release team
were okay with the current package). Personally I would probably just do
them in the next Squeeze + 1 upload.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIbBAEBCAAGBQJNBpMeAAoJEAVLu599gGRCg+oP90gesEouwkGSpvNfz8IOz8cq
HZJHbbMs0pM1lEU1K1kK1OicUg6s67mytVt4L/IvCsMtR2b/4aKjIcZkeWjkbgNH
3LfG6QwWYp+dTdW/xvnflknWzQN72mX8Zm1sf5wB1b01FpI/T/lZRHJ3FpyG40cL
g8ePq5xHsstwdzngNBTHEC7qs9DjLQGJz16wMddhBS+iC8ovgYVEA/V8V+Vz1CB+
vQvkVJq7jqH8LlBOowPerA97c0itfWw/rwqkHvu4FLEf7gMzC23IYbCX1t9romzH
JCtkUJk5LhQEBWsp9w+4R8Zix9zr90E+zoVjEUlqd0caU551puuZKkwiV7lT3oL9
6iub1hWY20Ajzjh9j0PRE4XGBlHwww9tj9Z5XZYZYrPPEhCy40F0yUjMxPwYlEqU
BSeDfbYU4IbGbO1ux5UHbG1+cacUy4JtGKf8e1kqKHEkq63tzVGP6HdWgu0kQl07
F0jnV6sBSs7jxdCmpk7pxrqCCuSK+Bcvv46gxTdlD/de/ZSv9SUSfCBUvU1s4nrR
v5HbOQk+LiL0arI98O5aThl+4b8fM24CDeHRgVdPOtP+gkE9UpSn7aL0n0YxNo1P
e6GQ59elc5egAa+aJZoBcsI1mN+3BNMnnOumtNm2r8Ur1cX8IrmE0OKFEsxBlzlm
Rh8i7zWdAETHJz7qeFk=
=QtoM
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d06931f.1080...@thykier.net

Re: RFS: epr-api

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-19 13:05, Antonio Valentino wrote:
> Dear Debian mentors,
> 
> the epr-api package has been moved to
> 
> git.debian.org/git/pkg-grass/epr-api.git
> 
> so it is no more available on
> 
> http://mentors.debian.net/debian/pool/main/e/epr-api
> 
> 

Hey

It looks like you have gotten the package under the pkg-grass team; have
you contacted them to see if they can provide a sponsor? I suspect the
team is at least a very good place to get a reviewer.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJND0BhAAoJEAVLu599gGRCMkEQAK7r2FPkYCMPpS3ZYUA7TRnO
1u1tNmLHBQvUwkeIbNvv+KaaRSqkOfZcVrsN9Xgu99A/cc3JJxgi8QpSUsAJBbPE
sx28lP5q9DBcT5P/pa4clIPhNGisw23HD304x7DmN2mNNY+cxCiarlbxb5jN427o
eonmNhXF9xL6zK7P0TIthIIwA7oRvRz9axNscB9YlJ6NpUCKnVU/WuKFYEtw+xxN
vRH3cAQ/gg+93lXnlOlpnWOvro8eKusU0Y2zccgzrWAw2VE8a6nD46/x+9m/xTyv
weyvqT1DjDLTO2R5OIK9m3Uzon5KDia3SU4lYBhcFgY86O/dvvUEJAvHRpY7azc7
zWYvc3MFpzYmdc/VT2/DtxYZDzYunDcgmoUNRvn1qsAqb3nu4/cauksPQLwloI1r
RTXELwerWiZMTzQDzZ5m+uimWmSuHlpNPDIYHf4HZBRT5wCJ/x6VWYet5r2VyGmw
Oxk0k3ht5h9Xa5ogjQy/A8Yx7Sr91/CV4twOUCT0TSKP8KjSdNV4o/RP7TsyNkO/
QqndJxHXtvEe770ymcfiT+P+pnlt1+ABLmQO0MR7FPrIsHwyPGwTOTl1FFpXzX5L
23t9T9Z48pJi4ziHKOrfOGxFBz8s9HRFkWtQHs2JRz9pzCibo8vGMhgRkk5tHLRp
GuMIXcfz+ZPbD2L51T27
=ln/e
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d0f4062@thykier.net

Re: RFS: triggerhappy

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-18 15:10, Stefan Tomanek wrote:
> Dear mentors,
> 
> 
> [...]
> 
> Looking for a way of globally assigning hotkey handlers to the special keys
> found on my notebooks, I developed triggerhappy. I also use it to control
> headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB
> keypad or bluetooth wiimote. Having this software in Debian would provide an
> easy way to bind commands to input events without the need for running an
> X11 session or logging in.
> 
> [...]
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Stefan Tomanek
> 
> 

Hey

I just did a quick review of your package; packaging-wise your package
looks good.

Though the upstream code might need a little attention (or some
clarification); e.g. cppcheck finds a resource leak:

Checking cmdsocket.c...
[cmdsocket.c:126]: (error) Resource leak: fd

Looking at the code I am not sure what the intention is. My best guess
is that it is trying to transmit the "leaked" file descriptor.
  Though I am not convinced this will work; even if it is possible (I
vaguely recall seeing an extension in Linux to allow something like
this), I suspect the program relies on undefined behaviour here:

char buffer[CMSG_SPACE(sizeof(dev_fd))];
m.msg_control = buffer;

The issue is that buffer goes out of scope before m is used (in sendmsg).


In the if in uinput.c:27 it looks like you are missing a uinput_fd = -1;

In trigger.c:205 there is no check for if fork failed and this leads to
a "silent nothing happened". There are also got a number of unchecked
malloc/strdup, which could lead to "out of memory" segfaults, but at
least that is "some kind of feedback".

cppcheck also believes that count_triggers (trigger.c) and print_ignores
(ignore.c) are never used. I did not verify that.

In thd.c:331 the error message implies that the user does not exist, but
getpwnam can fail with other reasons; it might be a good idea to
use a more "neutral" error like:
  int err = errno;
  fprintf(stderr, "Could not look up the user %s\n", user);
  errno = err;
  perror("getpwnam");


Adding warnings to gcc I saw the following:
cc -g -O2 -Wall -Wextra -g -O2 -Wall -Wextra  -c -o eventnames.o
eventnames.c
In file included from eventtable.h:10,
 from eventnames.c:5:
evtable_KEY.h:123: warning: initialized field overwritten
evtable_KEY.h:123: warning: (near initialization for 'KEY_NAME[122]')
evtable_KEY.h:154: warning: initialized field overwritten
evtable_KEY.h:154: warning: (near initialization for 'KEY_NAME[152]')
evtable_KEY.h:379: warning: initialized field overwritten
evtable_KEY.h:379: warning: (near initialization for 'KEY_NAME[113]')
In file included from eventtable.h:14,
 from eventnames.c:5:
evtable_SW.h:5: warning: initialized field overwritten
evtable_SW.h:5: warning: (near initialization for 'SW_NAME[3]')

They are were triggered with -Wextra; it may be nothing, but I figured I
would mention it.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJND1SBAAoJEAVLu599gGRCmvcP/ivZpTqSIr210vAC2RY+Sb9+
dEjtT/QUGkxmBqK85yJ34uDsTciguKQ+JrQO0NouvaHiFjGMGFp/JI8oD0wKEf+n
ZCLMTWLp2C1Y0F6g6F6AdLpAijmD2kHVKeSbriFB9b6thjOC3VZBi/IycGO4oIiZ
Fg4TcF/4AcMov++YMJ9HN/ruXWdFrlHcjidYVW1ihnmyTFUW4HFtoYOFoj+kEYQX
0EUQ2cfJDArVkOLvWyxF62bAXryYEg0SvUkQH6Sqaybn9vdoQf3uv8XuGdNPhcPz
AvGq4U6SgHI655T5jHUn9JUO93IaYobm+ftoFgoo4zPd8+ufLsle4KgVyXTwBItR
BbTem2UgMqALKiL2uPhw8AtUZ2ObRIv3OTgWo0fJO1C0EzfeOVcEV73eKTVup2kZ
+aqTeHHal6eynV2+dswvHmpMB4WoK+IIquS5I6upPA/JEOWRtq0hVpa3rNR0p+y5
IE6aVToP9Usop1QzbwRj27iHHEZ+q+xAVv4uK8KdWy+AxH+fjiYrxl35N83BW//V
yNphRegV11NqjqgRx/z+WoE+8jT5r52JCgJts251z1ttiSo28DljXrvuO/UYHrn3
HFJI1Mh8yv0KfVTp8bCDkWJUIyeIKttVDp/qRGzXXOgSR9uM95xlP7zmWziQjTXX
CfSgd9/evkTcod/2yq9q
=Fjok
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d0f5482.3070...@thykier.net

Re: RFS: triggerhappy

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-20 17:08, Stefan Tomanek wrote:
> Dies schrieb Niels Thykier (ni...@thykier.net):
> 
>> Though the upstream code might need a little attention (or some
>> clarification); e.g. cppcheck finds a resource leak:
>>
>> Checking cmdsocket.c...
>> [cmdsocket.c:126]: (error) Resource leak: fd
>>
>> Looking at the code I am not sure what the intention is. My best guess
>> is that it is trying to transmit the "leaked" file descriptor.
> 
> Yes, it does that. This allows the daemon itself to run as user "nobody",
> while th-cmd (launched by udev) can open a new device and pass the fd
> to thd.
> 

Okay, perhaps you could document this in the code that this is
intentional (e.g. transmitting the fd and the leak is a false-positive)?

>> [...]
>> cppcheck also believes that count_triggers (trigger.c) and print_ignores
>> (ignore.c) are never used. I did not verify that.
> 
> Indeed, I used those functions for debugging purposes only, but I guess
> leaving them there does no harm.
> 

There is no harm in leaving them; worst case the program is a bit larger
than needed (which could be solved with some #ifdef...#endif magic).
Anyhow just double checking it was intentional here. :)

>> In thd.c:331 the error message implies that the user does not exist, but
>> getpwnam can fail with other reasons; it might be a good idea to
>> use a more "neutral" error like:
>>   int err = errno;
>>   fprintf(stderr, "Could not look up the user %s\n", user);
>>   errno = err;
>>   perror("getpwnam");
> 
> OK, I "neutralized" the error message, however using perror(errno) from 
> getpwnam
> is not really interesting, since all I get is "Sucess", even when specifying 
> a completely
> bogus name.
> 

Mmm, reading getpwnam(3) I see that it may leave errno untouched (or set
it to 0; not quite sure) on a failure, but it is system/error dependent?

I guess you can do something like:
  errno = 0;
  var = getpwnam(...);
  if(!var){
  if(!errno){
 fprintf(stderr, "No such user %s\n", ...);
  } else {
/*possible no such user or "other" issue*/
  }
  }

Or simply suppress the perror if errno is 0. Anyhow - not a strict
requirement.

>> Adding warnings to gcc I saw the following:
>> cc -g -O2 -Wall -Wextra -g -O2 -Wall -Wextra  -c -o eventnames.o
>> eventnames.c
>> In file included from eventtable.h:10,
>>  from eventnames.c:5:
>> evtable_KEY.h:123: warning: initialized field overwritten
>> evtable_KEY.h:123: warning: (near initialization for 'KEY_NAME[122]')
> [...]
>> They are were triggered with -Wextra; it may be nothing, but I figured I
>> would mention it.
> 
> Yes, I was aware of those. evtable_{KEY,EV,SW} are autogenerated from 
> ,
> generating a mapping table from event names to the integer values, but since 
> some events
> have multiple names, these messages appear.
> 

Cool, just double checking this as well since I was not sure :)

> Thanks for your review, I'll push the changed advocated by you to my git 
> repository
> today (https://github.com/wertarbyte/triggerhappy).
> 
> 

You are welcome.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJND4U/AAoJEAVLu599gGRCjjkQAIzvwcIwjAOJqkNaH9yvsU5B
BmJdBxiVXBjgsYpH2fa0RNVlRCjwZCuA87O8OoZlbkPdcLxy8g5V8fSfR0wwK0gl
o4MqZxrBjbOdAeuFoQSyfsQ1wSAPJ5fXXN3dzOrVDl+FoQLkGfFrjn9n0bjRpkqX
+6muhjq5cBJBiWkpwgsRrfR1/kujTMt8PdS8RRmpBT7LXcnpreJEMk9zaG4UOT5b
Z1+YaNcW/rK6XDTCx5LLYWj6K/RZbND5H0e5xyqWN2MyJyepWh+fgg1kxAJKmcEJ
T4ixcB5qk4lpcllwjAgBhYdLmM5Mlgy8e2FTlf0UOVEdaUehiNIK3GCTJmKw3kWo
P8YlPZ2ZiwoHi/xNsTGlvYoLEWHbMLgU5KBz1pDX1PFsspmLhncR2fnspdPqmF+U
lvyOmlCyD9Wa8EMNA9Y/3sO9STlIgvipXtoEbbpvqAaLfBJph09IpRn46ZKJNY7F
Ef8t6UZcSkgwX70R4vb/piSns3KgoncGAuQoKbgZeSZfcJwJudV7ZZp3tRKD25fG
xVTH6ywOGwIesRyhmdn03nk25RwCPESjNqPzwpnxhwnHBWzYxa3eTrZ6W/qrgCCc
xHEsrMSxl9fy6EJLN0KZGk6OZOiPppPqk5Jypq7I4dAQenrXQ3jRpPXLSyDLC83m
DgUfTW3Ra96YNheQi6uK
=mWKg
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d0f8540.30...@thykier.net

Re: RFS: triggerhappy

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-20 21:20, Stefan Tomanek wrote:
> Dies schrieb Niels Thykier (ni...@thykier.net):
> 
>>>> Checking cmdsocket.c...
>>>> [cmdsocket.c:126]: (error) Resource leak: fd
> [...]
>> Okay, perhaps you could document this in the code that this is
>> intentional (e.g. transmitting the fd and the leak is a false-positive)?
> 
> I'm playing around with cppcheck myself, but I cannot reproduce the message 
> above;
> how did you call the program?
> [...]

It might be because you have a different version than I; I am using 1.44
(from testing).

~Niels



-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNEIOhAAoJEAVLu599gGRCScMQAJYvXHea6sJBjI5K1SiIlm5Y
M62IFy7H4e2Tr16nvtwIzzz0ZISctEif0kAcuZjAYBEBpK7ZEgN3mgqdS9ft1vo9
UNp7rmqpnnN6PvpGQY/7l7JI6mXS5GW9DPzPNjI7e/GmQqAVYReSk3+s5Xz30SLM
0OcVPg6FPSGlXKupZYoj8lRuKdLGcTvEoiyo14T7RNPV+ZehuiDkzincAQ19070C
GUjkPQFxFyG4ZrAUtf8KR0Y9oNwfQ4W0ifT7HuH1649Wqe0YN/eV9o04YMk6dQK6
7yejbtvYWMdg89JG2eyju11F6M4Fb3W2j8GDsawj3XB3W0LnbAtr49BVQ1F6iTKQ
PMZHpV78xqd27H4GS1MQ8WIE5k/2YR+pbKTDyxfMFkWLtbIKSa6ZySkpE43PiDtu
chEfGT5LVc9Rpe+LC9AtAobBS0JsYgYsOqzLGpmYpPqdaQWBjZcmHl+V8Krk4KV1
jHIm+FpfgKLVn2unZZj/M9/XNf34G2RPxqDU4M82e3Qi2g5G1bPYi/uafgH8Lkte
TnRz66NxKCDMJLTOavobrS4aCj5rIDU8NpJ2Ckh0mVhoa506NiXAFw66jcwlV1AX
rNpHOGjQsKHQ9Vgl0xK8GeKhWcn3z9AvD5VQ07D/lAyIiec/sFLsVYzHA1RhDqub
QCabmNugL7beV/GTubp6
=4RLM
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d1083a1.3060...@thykier.net

Re: RFS: triggerhappy

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-21 11:48, Stefan Tomanek wrote:
> Dies schrieb Niels Thykier (ni...@thykier.net):
> 
>> It might be because you have a different version than I; I am using 1.44
>> (from testing).
> 
> So am I:
> 
> ste...@exa:~$ cppcheck --version
> Cppcheck 1.44
> 
> 

I just cloned the git repository and I cannot reproduce any more either.
I suspect this is because you fixed the buffer variable going out of scope.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNEJGqAAoJEAVLu599gGRCAZ0P/1hUi3yQCHNk4yyQKeehzkDS
cNMWqrhAOHJ+XFfdCNFw2k23Tls3sFFCYwFR7ya2FIQOinDgENLYELwqg0f9cSVu
lL8D5MTYX1SKkODK8XND5kcmmrhDBTr7rPmzfjNpCZtGMc8Ehu2CifrMclivl1H+
5tDs3vcCBJh9D/U6Y5OfZNq7w5q9mZ4Ln7YlXLOsGDq0KulGo2iuGBmrAPiDcvjy
BlcJWe7N0/ElhVhbpfNypPnJfFybSMJ63bc+ByR8MCTPL7PZB+U8jMHNelr1RScr
RkF/rDBF0hLxDrhReHAwx5LtWWvrebJUlyyOPgy8B/uUdwwAjFI8RO8m57GAhGgK
zhtvVrLXgqe2gsShP+0Gs5D9xdyxnwx8z7VNF+QWuFjpsiLgCuffyBU/3K1/dVcq
Zm9TTets9ChzTHNczrP5pTB7jQNWf5P031Rob9i5+awR5Z0coAvyZkdlQW82SH8R
35gKTxmLA7EMKQwO0V1bmywZf8oOqp5JKVYxKAr76CNGcvyuzkC24bwy8tTXpTku
l7cRfEyaWidfIsSD5/feL0xoxr2v2X4wm5MWX0mEEA5o8EPNPXkmnQ7dtZhpAyNG
1ey/Tp0gvcjIfhb6lSDWfk/upP+HwAhYakHmpt9pux9DPVumLK2hFMG3+o0KVnUX
z9295VrhTYmqSsrtsG2m
=5pND
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d1091ab.3040...@thykier.net

Re: Building and uploading package, depending on experimental

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2010-12-26 14:18, Anton Gladky wrote:
> Dear mentors,
> 
> I want to upload  a package to http://mentors.debian.net, which I am working
> on (https://launchpad.net/yade).
> Now I am trying to build the package with pbuilder.
> The problem is, that the software depends on package from experimental
> branch (python-sphinx>0.99).
> 

Hey

> I have 2 questions:
> 1) How can I build the package in pbuilder (--othermirror option did not
> work)?

You want to create a --distribution experimental chroot for this (man
pbuilder for more information). Note you should not use the experimental
chroot except when you build packages targeted for experimental.

> 2) May I upload such package to mentors.debian.net?
> 

Yes, if you target the package for experimental (instead of unstable).

> I would appreciate any comments or links, where I can find a solution for
> the problem.
> 
> Thank you.
> 
> Anton Gladky
> 


~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNF0GgAAoJEAVLu599gGRCD3YP/iSluG1MMn/Q7Piq/5vtV7Th
AgH03O5QBCK8FH1o6mqTni5SYPLGAaxCsifxa4o6LZgzxbnBD3mn5XVQ284V/u2H
y+fYeslKXuF2oW9U8fee/6Ki3484rhv5KjEVFshpCkOD2cAEAyvUvqJmLVcTHJmO
fI+iBSSMlcu76m0I0Kr6tODy4ubTchV13b0d8NibZiVcipT8D5Jjpb7ne6L/Jysr
SPxPh8qA1pLHvO0Yfs0o7jzRwhVaWPVmAOPQ5uyrsxtfa6MUY+dg540F55CPULTP
D2PDQ3PS7/cKkfIGb5P92wI5kkMBdkNY9iDdEzj10F/jhlRZnMD/Aw+PQQzuN8C8
KPcEpxIF4NnkQDkfp9Rg4dgIpGDD2Ss9xT9WsEwWOTRgtVHpm4oxYGI9brvxJrG2
MdYIuIFR/tNj7KPAMmjLhAZBfsoDcHLVVL0GyjKv7xDbXwvawiExBjr2RvJ2TaQ1
5KfdBUUUuKqqOlmPyt5W/n1bL8OcyP1jKoTWBUtpQrUyWq9QK83RltaR6IxYB4rj
xbBM9zlUkEVFGhNS9/JDCNTG4Bfq0qj28eJ8AlFRLKNRptum/e9957EekiBbi399
8OUsuOW6UpGhdofGbS50bNitZJhJZc4Ve4R4rYCTL8dYFy2RocYUvdIYCOD63pX3
wAn8yEpvmYsEInUWrm7S
=Ik6y
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d1741a2.40...@thykier.net

Re: RFS: failmalloc - Memory allocation failure crash-test tool (2nd try)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-04 12:31, Alessandro Ghedini wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "failmalloc".
> 

Hey

Thanks for your interest in Debian. This is indeed an interesting
library. :)

> * Package name: failmalloc
>   Version : 1.0-1
>   Upstream Author : Yoshinori K. Okuji 
> * URL : http://www.nongnu.org/failmalloc
> * License : LGPL-2+
>   Section : utils
> 

I thinking that devel might be a better section than utils. Particularly
the devel section covers "Development utilities" according to [1].

> It builds these binary packages:
> failmalloc - Memory allocation failure crash-test tool
> libfailmalloc0 - Memory allocation failure crash-test tool (library)
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 462792 (ITP)
> 
> [...]
>
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Alessandro Ghedini
> 
> 

Any particular reason for Build-Depending on autotools-dev? It does not
appear to be required for the actual build? Likewise you do not need
debhelper >= 7.0.50~ since you do not have any override targets.

Regarding the library <-> application split; I am not entirely sure what
is best. The best "similar" case I can think of would probably be
fakeroot, which installs its helper library in /usr/lib/libfakeroot/ and
then does without the lib-package. I also noticed that libeatmydata does
the same.
  Admittedly it is far less likely to make sense to compile your
application directly against one of those libraries. Nevertheless I
doubt a lot of developers would link the production releases against
this library either.

~Niels

[1] http://packages.debian.org/unstable/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNIx7MAAoJEAVLu599gGRCw60P/iTIQOLRJGiQOvCagWbWF/yR
HulQz4vkHJa9cXyNtDuGriSEhwjsjkYBB6eMJCbfvVO/6cbdbSZT3dTg2hbbn/C9
Uzos5Tez4oM3bdgfe4WGgF2BkpCjcX7dMUCcuKEvF6FzuIMqOgB6A4W2ACulUXw3
iky+FsB3Cea3VVVMsSm/+z2Z+9YHcqzj0bLPDWAgEDpVEwWRiL+GgYqQBBL86NEC
2EdPfJtrYioJFtwiCSPyavciTgI5ZIdbrP+oNPDJWD4cew9z/sWkHdMxOkZhms0L
SKR3ar6ACKUxGkGkv8W0lWYgTJOhoHok9g3n1hIU+TF8P3CM+wOLGGgtNbitd3EL
5N1cXCwKNbCZOxxHjHRSYNISivPfAPaOaVKhXWtjQTWtPdU0tiN44Ai9T5FtUk2A
2WbTEB2rFETay/CnJsXARQ24oZuHo/TWE7tRbdHaLxjewXfnBoWaMoCaRQ6WYeeN
MPF4Id0T++0CvCjYzeDpc4sofCkluG/V6+UqS86JW9042GNs/quqFyzJ7iT1ZLyQ
8z9QCAXDpH1xl1Npl34/Q/umvNdLAYAo1LyyPXQzaMxJL8C9QlaLLP+1d3B/HCtz
nkXHwEuR+31KW2LoBolbf8PQ7SWbXUqHZRA8lyPI+9hbJ6KehpyuY+uI1R5BK7kD
F+XyjNiRgUfEMbSDXPK4
=oqJ/
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d231ecc.6040...@thykier.net

Re: RFS: failmalloc - Memory allocation failure crash-test tool (2nd try)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-04 16:40, Alessandro Ghedini wrote:
> On Tue, Jan 04, 2011 at 02:21:16PM +0100, Niels Thykier wrote:
>> I thinking that devel might be a better section than utils. Particularly
>> the devel section covers "Development utilities" according to [1].
> 
> Agreed.
> 
>> Any particular reason for Build-Depending on autotools-dev? It does not
>> appear to be required for the actual build? Likewise you do not need
>> debhelper >= 7.0.50~ since you do not have any override targets.
> 
> autotools-dev is needed, since it updates the config.{guess,sub} files 
> during build (otherwise lintian would complain with the error 
> ancient-autotools-helper-file).
> 

Not quite correct. Lintian allows you to B-D on autotools-dev (among
others) to suppress this warning. Adding it to B-D makes lintian skip
the check entirely (yupe, I did look it up in the lintain source[1]). As
I recall you can do this with a B-D dh-autoreconf plus

%:
dh $@ --with autoreconf

in d/rules.

Though lintian will not suppress the warning in this case (see #592358).
In this case, just override the tag or even leave it there; I /suspect/
this will be fixed in lintian in one of the next versions.

> debhelper 7.0.50~ is indeed not needed.
> 
>> Regarding the library <-> application split; I am not entirely sure what
>> is best. The best "similar" case I can think of would probably be
>> fakeroot, which installs its helper library in /usr/lib/libfakeroot/ and
>> then does without the lib-package. I also noticed that libeatmydata does
>> the same.
>>   Admittedly it is far less likely to make sense to compile your
>> application directly against one of those libraries. Nevertheless I
>> doubt a lot of developers would link the production releases against
>> this library either.
> 
> I was just following what upstream says ("This software generates a shared
> library which can be loaded by LD_PRELOAD or linked at compilation time.").
> The helper script was written mostly by me for this package, so probably
> others that have used the library before may want to not use it (so that 
> there is no need to install its package). The same applies for the library's
> direct linkage: if someone prefers to use it that way (and it is supported 
> upstream), who am I to judge? :)
> 

True, but if they want to directly link against it they can still do it
by passing -L/usr/lib/libfailmalloc -lfailmalloc, so you are not
preventing it (just making it slightly less trivial).

  As for linking against it and not needing failmalloc (binary package);
I think you would, since the unversioned symlink is shipped in
failmalloc (alternatively there is no reason to ship the unversioned
symlink in the failmalloc binary package).

> Anyway, I updated the package (both on mentors.debian.net and on git) with 
> the other changes you suggested. Thank you for the help.
> 
> Cheers
> 

Anyhow, I am on my way out the door. :)
~Niels

[1] checks/cruft lines: 122 + 333 (plus 136 and 291)
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNI0t5AAoJEAVLu599gGRCawMP/0CHzw5ZDouR5XX7vheFvbbM
ZkUFy72cOGOoNqUFHuh6EAu3z3KNsJ8geNh9bz2sb2uPfUIo7vU04UxYFE+RE6p0
0bsWXBCS7ikEqr6CqmgPcTclHcIoK5KtT0UJ5410yNb79tejndMvtiWh/Nb1iULz
7uGzYu209stulUPve5pB1NLXzR320tIsFkpPDwIN/SYIY/HBUB4qW9ImL6xBJ3JX
xuih/9z8E+8lNtD8icr35pCJPj7/6Wxmh4d83a2gh+rLgalcYdhbT1ABz1OS3CE1
aW9e6uGN6ZlsmI16vvv+iJHiPjrS46zHxDTXSi9DkZRhSzncmw0nZ075nHEb64ZB
e9oOqK/9B2/eylX1Dsw3BByzdhye8QuyaXSG3dgJyFMDhU5cb5UgOk2tG4Kckt03
hbu43JGIEWOG65rUkvJ1dhpvT9md21KaIVip9cYy23TROcB/zohM3+JAA/NXjdRx
7eiOtJmbfqil1COjlEokwgEmTqBP40NF4JAK726f1SYe6+WpuR80cY59peA2yIfv
lL8+4CM2tZdKmn6h9Wxfb1iVd8SJDvlEE1VXV894NclhQVxkWXI13g3eBFOfpGNR
pXPaYCzFZ1qLjQiKTPMZ1MNr1Qf5Kdq3IDBOnnHQhOTmo1wd6r6cY/ngkXidUtYY
6KZo2FOMTncV0ummCcWs
=u/BX
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d234b7a.5050...@thykier.net

Re: RFS: biomaj

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-06 11:32, Olivier Sallou wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "biomaj".
> 
> * Package name: biomaj
>   Version : 1.1.0-1
>   Upstream Author : olivier.sal...@irisa.fr
> * URL : http://www.genouest.org
> * License : CeCILL, french equivalent of GNU GPL
>   Section : science
> 
> It builds these binary packages:
> biomaj - Biological banks updater
> 
> The upload would fix these bugs: 609038
> 
> My motivation for maintaining this package is: Me, and my team have
> developped this software. We use it internally but it is also on
> production servers in several countries. It is used by biologists and
> bioinformaticians.
>  I want to ease and spread the use of this software to a larger
> community help with Debian, used by many science communities. We already
> maintain the software, currently packaged with an installer.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/b/biomaj
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/b/biomaj/biomaj_1.1.0-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Olivier Sallou
> 
> 

Hey

Looking at the section/name/description I think this is something the
Debian Sciene team might interested in[1]. That being said, the package
contains a lot of pre-compiled Jar files including biomaj itself. The
package must be compiled from source it is to go into main.
  Even for a non-free package you should use the packaged version of
Java libraries available in main/contrib/non-free (e.g. ant, commons-cli
etc. are packed).

If you use apt-file you can find many of these by
  apt-file search 
 - or -
  apt-file search usr/share/java | less

We also have a gzip'ed text file that can map a Java class to Debian
package if the approach above does not help you[2]. I believe "zgrep
$classname jar-content.txt.gz" should do.

The install files can be greatly simplified. If you specific a directory
dh_install will install everything below that directory as well.

Running lintian on the resulting binary file reveals a lot (potential)
issues you may want to look at.

The dsc file is generated as a native Debian package (no orig.tar.gz),
but the source format is specied as "3.0 (quilt)" which is a non-native
format. Pack all the sources excluding the debian/ in
biomaj_.orig.tar.gz and put it in the parent directory of the
unpacked sources.


There are other issues as well, but I think this should be enough to
start on. Also, if you have not read these, you may want to have a look at:

  New Maintainer's Guide
  http://www.debian.org/doc/maint-guide/

  The Mentor FAQ
  http://wiki.debian.org/DebianMentorsFaq

  The Debian Policy (terse, but when in doubt ...)
  http://www.debian.org/doc/debian-policy

  The Java Policy
  http://www.debian.org/doc/packaging-manuals/java-policy/

  The Science team also have a draft policy.
- NB: I have not read that, so I do not know how good/helpful it is.
  http://debian-science.alioth.debian.org/debian-science-policy.html

~Niels

[1] http://wiki.debian.org/DebianScience

[2] http://ftp-master.debian.org/users/twerner/jar-content.txt.gz
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJabCAAoJEAVLu599gGRCGJEQAKc96tECBMvwRvDqjfv9rbtK
CRrQ+9le2BKVbEzeGorDpVVLIgK5d+BFk3VcePHFreouFtZO6KDFmA8XSXFkpfge
B7f7OBbYuZ0cXgrSnNRjnOcK6jyqwaJ/5OOg++aPxGG7oIDBzRa5X9izwuNAS0h4
KF+BU8AAU4Kre5zrbki9y229aXUCFDwy6cAP/M1oX/Z41eA7odMXfNAo1hiRDtnR
ahqLHi9/Fo+L8Pr2PVYux5o25b0Crw9dlqD/ZOD89kWAajdvIkeCNIrRJmrsZvof
BEY1j7lP6RJl1W/5kyZB3dXOuITkhbDdwT3I9HVOhI1/PAXIHzyeQjNzMfwbP9WA
G00foHii4ZUDfTzapMAZf9iB7uUE8bdiPn7l/ME/yLuz+xn4aKRoqK0YbYa8ESrH
qEAEcMT8mwFuCfc+YqmGWV23eGhoGzTuNQYQ91DlWgaRmDRj54Y5r4U7m2dKPlGT
Z9YClNQGJCfKHRY8BwBipGNDDhUaHCR78TwJ3nDpniza1CUHsE/Ek+QJNDdtZliR
qlSR6cg4IN64upismU8Oukh8OlhhLq9JjQwyU9L+MmtwmkYKtoR28YbGEbVSoxao
GfyGPofDh2gI5/It4MFAnae6bHY9s47AIpoIGqsskkoMr/SHMeyiNbnfKFaZUZfi
KoQVMPJR6GNaHGCyWCs1
=OnpB
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d25a6c2.6090...@thykier.net

Re: RFS: c2html (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-06 03:30, fulapol hl wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 0.9.6-4
> of my package "c2html".
> 
> It builds these binary packages:
> c2html - Highlight C sources for WWW presentation
> 
> The upload would fix these bugs: 595541
> 

Yes and no... the package would technically still be orphaned as you
have not updated the Maintainer field in d/control. Also I personally
think it is overkill to mention the entire bug title in the changelog.
In this case I think a:

  * New maintainer (Closes: #595541)

is perfectly fine.

> [...]
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
> fulapol
> 
> Please CC me, i'm not in the list
> 


Other than that, I did not really see any issues. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJax6AAoJEAVLu599gGRCYbUQAI0ljmG4tiOXhSqccGRXNl4E
mi4ViYCXGt6vgqZAPzNIscWbZtZ2dhXt67cq7aHTAdMfRER4RlAI+/kSYXDyRKwn
QR/N9zqow1arjdl001GCl7AKcveu5R+HeZiiQqCQwxq7A8ZdUTjiacRBgzTErg77
jrshbU8vc2GJYdgQpyXroICmh89ItrG/zEHOFoNefRndSSMrsQnbDzcIg00PqCY1
0EzoBONhs4Fn9p1s/0dU3Bf15/h/l9Cvi1UP7Mob0W+ziZ9lXADIBN+5ZsWjQo2D
kfHJKXAinNqTPBP1TtyjZaf9sfL7GdVpcbZoZNV+Q6kynz6ZXvYW4C0iqyqJ5xcw
qVaBAmqC8Fpb1wYwySW707DP3NqJYDN11UgqoVPgdIEDqQXCWlY1ASoRxuOmIROy
5BUiLSds2UQIXHSo/dLxhmeB4fH3CJqMHfEsxAWaLXgvRIMh3EP6VT6axANbsddL
WwNp98y5UzKVJlcdQeFEq1TKleZMCgVV/hSvnNhgxKkUPPrEvcPRUADf9n3Mo2M0
gB7ilYfTr4n5kjzmGVaI9rVgZu/jPY/s6Lx34XvgxDZ43J/7ar4+WZmenVkaIcfr
jfDMTfY9sG3tlfVUN6zYyf9Lu1F3ED4AVXUF/NirmjGjwpvRRlCi7yMmY6RNCYwI
Jene7BOKfASWUzjLpuoV
=dEEl
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d25ac7a.80...@thykier.net

Re: RFS: googlizer (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-06 03:31, fulapol hl wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 0.3-4
> of my package "googlizer".
> 
> It builds these binary packages:
> googlizer - utility to search Google via your GNOME menu/panel
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 554674
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/g/googlizer
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/g/googlizer/googlizer_0.3-4.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
> fulapol
> 
> Please CC me, I'm not in the list.
> 

Hey

I missed this for c2html as well, but we are in deep freeze so uploading
to unstable requires an ok from the release team.
  You are welcome to target experimental instead of unstable and the
packages can be reuploaded to unstable after the freeze.

d/patches/*: Personally I prefer not using "debian-changes-".
The name does not really give any hint to what it patches and they are
also generated if the clean target is not good enough; but if you prefer
that convention it is okay. That being said, you should at least update
the header in the patches to describe exactly what has been changed/why.
  d/patches/debian-changes-0.3-3.1 refers to non-existent version number
in d/changelog. I assume this was supposed to be a part of the -4 patch.

d/rules: I strongly suspect you can reduce this to the "tiny debhelper"
style without any issues[1]. When you only have one binary listed in
d/control dh_auto_install uses the package directory as install
directory (instead of d/tmp). You can add d/googlizer.xpm to d/install
in this case.
  If you do not feel like re-writing the rules file, then please remove
out commented commands (e.g. #dh_link).

d/control - any reason why you put the Homepage field in the binary
section and not in the source section?

The upstream application is overlinked and does not react to
LDFLAGS/CFLAGS. Unfortunately if you add -Wl,--as-needed (to reduce
overlinking) it will fail to build. It is possible to make it build with
- --as-needed and --no-add-needed at the same time[2].
  In this case I /think/ (but I could be wrong) this means something
googlizer depends on needs to be patched/updated. Maybe someone else on
this list can comment on this?

It might be a good idea to patch the upstream Makefile even further to
make it react to CFLAGS and LDFLAGS. It would make it easier for us to
later introduce different default flags on an archive wide basis (see
dpkg-buildflags).

~Niels


[1]
#!/usr/bin/make -f
%:
dh $@


[2] Insert the following flags before the `pkg-config --libs ` part in
the upstream Makefile:

- -lgtk-x11-2.0 -lglib-2.0 -lgnome-2 -lgnomeui-2 -Wl,--no-add-needed
- -Wl,--as-needed

All of the libraries listed here are present in the output of pkg-config
- --libs ...
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJcAjAAoJEAVLu599gGRCNfwP/iD34LAHhgP6LyE3lAllSLJ5
cv3WA8a7L1okNG9eGxLsTR9KggAeJxg6z/xntSsWbtzyuWJPSZEviaKAwYx4cCF7
JJtbKU6QydKUFwrRzlgT/wzOu+P+25KPGotPQHNGrCnvRg+qb6Kx+nyICiJIaJNg
ipmtyIx6zsRdebD4wnlxG6JK4jI08KRV5YGSzjx8NusnLEnmOlwBQrfbAGhwOUjD
8pIM6btdq9u1IC59z/kDfTYsuoMckWWu38eVQ5bVEE7KDGgcgtP5RE/HKguWAUa1
/ZUgPHCPqgTh/KhCIBibWLhtBn06ynatEPmMsMPzTBYPTGEVsyTUOBJ5DdLfvFmk
0Y/DPQQBDRxTzM3b8qPID0kMNEqQU8MZY8s8XyOtmwI/5MtU3LUJtno68Es5gYx4
VO6d4CXXotheziLZzE7YhylxB92akeHQKWSifYHK7K/IVnTlRDpsDgtFfcae0usp
G327cPY/OQ3EFr5C0WoaYh4Vx9vonImFLP6GMpW+Zj42ZxSaDOdEYwJBm0YqR7Ka
Bv5cd1DDIeMZkwjQPsiyCjQdbetxfkZhTIU6j4spOhM/CAprUf1IZLIgryt3HqaE
DVV3dZ45TfSVvq52jHbi/lI5fWvf3u8+d6qlg8oxpZHwjSXw69J+RNjU4DPXNJJh
Tbn1mkCDRprhlkNYzZ3d
=sWz1
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d25c024.1090...@thykier.net

Re: RFS: c2html (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-09 04:23, Gildardo Adrian Maravilla Jacome wrote:
> Ops, a very little (big) mistake I did. Update, and using experimental
> as target.


Uploaded to experimental, thanks for your contribution to Debian.

Feel free to contact me directly next time you need a sponsor for c2html. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNK2lIAAoJEAVLu599gGRCPGMP/jzYCYB4Tlmp38hAJB02BoEV
nj0EJbrzk0HR5aU+NDS1uCpqKdsR0lMqy+BIqkjDAqokiJJwiLrR+b/YifXRvQcQ
uX2xjfDtXNoSBN52hbjsVv/YKEo6Y6h9bgQOv438+49Ww9Nb7YQBVhfetIP+Sak6
Jy8mTxow+k382arUqlRxEfUtTG56ooN2EY13teeTHsvapoZ3qJ8a3L8LUAkQLfDE
1f6h6JOz0AWRbq1PQdwpJB0MFMj62Zhj7S7ZoD6P4IhcAu5lBgf/l6H2a5XvkruO
/eHH3lD9+BUNxCdjLYY6BM/HtkYs9gFHEHVyrC4HT2hqnrPs0hRnk8FR/MO6PAvJ
md3Y7ToNSMRtcksWCereaG1oTBAAzK6soINlEmcXxtAQG73bm/8aSbK3p0TU2teP
TJkSZcxI+YuAeztAzxe3XHcHHo9BdA7GCAa8YT1+1c4GxY17YZx+HzMdpVaaqjCu
QuvrE4wGpVNZ5iTokx6D452HwKRhJ+jUDKjZJMzjEW7aoUUJpw8gomrS/2+7sPb9
f9Cefm6JpDbidAbEO0Xe6VevX1Ewg2u5Hg9um333bSIjPpbWpXYMbBdR0H88vxMj
Y5t84RU6EYota9/1gor/weCioUUsqyF3SCY4vcjjmA4/+hB2xyNYBKHVInOyDyPI
zlYcBGIHtTi3WYsDZT+H
=QZvA
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d2b6949.6000...@thykier.net

Re: RFS: pev

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-11 23:05, Fernando Mercês wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "pev".
> 
> * Package name : pev
>   Version : 0.22-1
>   Upstream Author : Fernando Mercês 
> * URL : http://coding40.mentebinaria.com.br
> * License : GPL
>   Section : utils
> 
> It builds these binary packages:
> pev - Utility to the get Product Version of PE32 executables
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 608460
> 
> My motivation for maintaining this package is: This is a program that I
> wrote and I'm a big Debian fan and user for five years. I really want to
> contribute do project by starting a maintainer life.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/p/pev
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/p/pev/pev_0.22-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards,
> Fernando Mercês
> 

Hey

I had a look at your package:

d/copyright:
 - I guess "Source: ftp://ftp.example.com/pub/games"; should be updated.
 - I believe it has a few syntax errors (e.g. email written on their
   own line)

For repeated licenses I believe the right notation is

Files: a
Copyright: ...
License: GPL-3+

Files: b
Copyright: ...
License: GPL-3+

License: GPL-3+
  Yada yada yada

But I could be wrong here.  There is a new tool to check the DEP-5
format[1], though all though it still has some quirks (see the thread
for more info).  Just a heads up if you try it; it has been reported
that the --save option made undesired changes to copyright file[2].

d/rules: I think there is no need to override dh_auto_install. As I
recall when there is exactly one package dh_auto_install will do exactly
what you are doing in your override target.

d/control:
 - Any particular reason not to put the Homepage: field in the source
   entry?  All package entries will inherit it if they do not have
   they own and in this way the Homepage field will also appear in the
   dsc file.
 - Why the build-depends on debhelper 7.3.8? Based on your rules file
   you could do with 7.0.50~ (or even 7 if you remove the override
   target).
   It is perfectly fine if debhelper >= 7.3.8 fixed some issue
   that your package triggers with older debhelpers.


~Niels

[1] http://lists.debian.org/debian-devel/2011/01/msg00381.html

[2] http://lists.debian.org/debian-devel/2011/01/msg00410.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMCH9AAoJEAVLu599gGRCLOUP/icE3kYnaJFMZhK37qJ0aIk1
Oq8cV2b5k75zYji6RzhC1jj2ecJ/nxx+2FqxS4vmjgyu35HIU6m/V81MEmw1kizs
Q0BxhE0sMnNjRAR24Gm61yglYgtB/wijX170owZ83gfPkACeVj3MKmEYYFaO5ZGZ
sVvRBHAmSerqpTvlvBNCNAjINBfAE3XJ1lxGpTiCTMnyoyNnCdKoTjYlpa0V+KHf
HbWwOOXTBZJOBDUc1FLc3KJbQ5OlhK7fqLblUN+snyhTze4PHuBPB87ZpWKxbOwj
aKM4E9ykTuZmyDMcXdWl2GquT9427Yder+pdSzj282bYyNs0Im1xGn2j70gzxICh
IVgsZ4avuIqVfrcGdHDdzgqOskK3cSSrqH1GyYkfHCPs0lqnivStHH/8+46bAumD
YmJyCLCu8KovJX6ApisY1SKXLoPStZedNufC4/QUXk28t/bDG4Wge9XiiR6CAjJa
/taxhWnGzjOhM2880z0TRa8u4R5FxGrISzUTIpUuLj2fNd0Cb7jIicrUNtS1J2Wu
w6FpKxkskipszfIeIUSg4I2dsDMFpbuybDH5YJUCcFtGaxbyWrcHffknRoKfKaaP
o9EEZ9Ilc5rGKZVno9GNdwiHMOYaL36wUyQ6ZBZdHtpRdyhitR+utZQUVyzBdeLr
9YyBO1Y9kXv8L2r1HfyB
=G9UY
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d3021fd.9040...@thykier.net

Re: RFS: libzeep

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-11 08:26, Maarten L. Hekkelman wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "libzeep".
> 
> * Package name: libzeep
>   Version : 2.0.1-1
>   Upstream Author : Maarten L. Hekkelman
> * URL : http://www.cmbi.ru.nl/libzeep/
> * License : Boost
>   Section : libs
> 
> It builds these binary packages:
> libzeep-dev - XML Library for SOAP servers written in C++ (development
> files)
> libzeep2   - XML Library for SOAP servers written in C++
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 609541
> 
> My motivation for maintaining this package is:
> I'm the upstream author. This software is used in several of the
> projects I'm involved in and has been in production for well over a year
> now. The inclusion of libzeep will enable me to submit more software,
> like e.g. mrs .
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/libzeep
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/l/libzeep/libzeep_2.0.1-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
> 
> -maarten hekkelman
> 
> 

Hey

I tried to build your package, but it fails in a clean chroot.  Most
likely you are missing a Build-Depends or two.  Based on the output I am
guessing they are related to libboost.

cc -MD -c -o obj/doctype.o src/doctype.cpp  -iquote ./ -g -fPIC -O3
- -pthread -shared
src/doctype.cpp:10:31: error: boost/tr1/tuple.hpp: No such file or directory
src/doctype.cpp:11:38: error: boost/algorithm/string.hpp: No such file
or directory
src/doctype.cpp:12:29: error: boost/foreach.hpp: No such file or directory
src/doctype.cpp:14:26: error: boost/bind.hpp: No such file or directory
src/doctype.cpp:15:45: error: boost/enable_shared_from_this.hpp: No such
file or directory
In file included from src/doctype.cpp:18:
./zeep/xml/doctype.hpp:13:46: error: boost/ptr_container/ptr_vector.hpp:
No such file or directory
./zeep/xml/doctype.hpp:14:44: error: boost/ptr_container/ptr_list.hpp:
No such file or directory
./zeep/xml/doctype.hpp:15:33: error: boost/tuple/tuple.hpp: No such file
or directory
./zeep/xml/doctype.hpp:16:43: error: boost/filesystem/operations.hpp: No
such file or directory


Also d/copyright needs to contain the entirely licenses.  The only
licenses you can refer to without including a full copy of them are
those listed in /usr/share/common-licenses (with the exception of the
BSD license, which we are trying to remove from common-licenses).  On a
related note, the LICENSE_1_0.txt should not be installed.

In d/rules you could shorten it a bit.  configure/configure-stamp is
definitely not doing anything useful that is not handled by build-stamp
itself.  I believe you could reduce your d/rules file to:

-  START
#!/usr/bin/make -f
%:
dh $@

override_dh_auto_install:
$(MAKE) LIBDIR=$(CURDIR)/debian/libzeep2/usr/[...]
$(MAKE) LIBDIR=$(CURDIR)/debian/libzeep-dev/[...]

.PHONY: ...
-  END

If you used debhelper (>= 7.0.50~).  You are not required to do this, I
am just mentioning it. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMCktAAoJEAVLu599gGRC7AAQALRIWDVx+lpcQtm9f+7MlsLx
aZfSQIMBMhmzwQ59SAOaiDME/+of6eWT3MYASF8WjvzWMRCtfS81nHQwpOgieIw1
o07SZ5HDT4AlOm2WagWVGse7vpE8SPH18SKVaw4WEN0iFBZuHI2qB0/7dgyByvbg
HC6E7K8ELBbtqNjBxD9+SwNd9AxtQaI0iOqM3vlXO2OUpOlDIFHKWKoHd28hPGnZ
uzPrQlvPxMrD6+X+fN4w4P6/Jd88IJ7/GyPe8BOppK5/QjMyJT2cJe1R0L2TlKTj
bQKn8PhGvah0LbpuVZweadWzhIfKAF0ePGv9ZZtQGU6e95Whc7+SX9jtwa68Mbqh
7vDjUjMf3d8hN2pD97SlqKC/e9Ll9S5dcylWvuWuGUAewr7bQ2jKdDmVJ+sCGduT
7zlHMxiXhNYT0x7orYkPDHtQtKs7Mls7OMje3WAuqme5GqM2X81NQm3nVXw1TcUN
DfQ7vt3z5ebBrJbXyVH2tWUtAfd+4i5sLdUFY50F5cz7cGuiPyU3oyBzw7eOzb0C
Fi1IfMTw29VUzoRanRfYEECQSdYsAc7MZXK0RvYAv44GZQJMrBAD4m77090UMIL6
E7cS8IbObVejJ19GjZ+w1LQ6YeDJGRCEA0CM6JT2iiEqJ4r45evXM7im+Wa1WOu9
PCXntk9kIHoo5mYzLXI2
=B9w8
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d30292e.1000...@thykier.net

Re: RFS: fgrun

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-12 23:32, Chris Baines wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "fgrun".
> 
> * Package name: fgrun
>   Version : 1.5.2-1
>   Upstream Author : Frederic Bouvier (Project admin)
> 
> * URL : http://sourceforge.net/projects/fgrun/
> * License : GPL-2
>   Section : games
> 

Hey,

Have you tried to contact the Games team about having them review this
package?


> It builds these binary packages:
> fgrun  - graphical frontend for running FlightGear
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 590182
> 
> My motivation for maintaining this package is: I would like to improve
> Debian's support for the FlightGear project.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/f/fgrun
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/f/fgrun/fgrun_1.5.2-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Christopher Baines


~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMCn4AAoJEAVLu599gGRC2CoQAKRGyOcj4RT+VmtsHeHQlGPs
jNpXRvz/0Bho0csQgEnSHs7QNuw2tNW4MLLtzw7zl9gPpq8lSDQJNy8vS0xusCQ1
JLZMAZNW9GtUe08UGgECiVVA8Q/6O+L7LVekuSeAtkBDkFQDZ4tMPriQEyIMegwC
OdZRCjOtlbshnSkFdW7fv/3G28n3os7zPen+vMivcgBFGFiyEvnreNYC8mbT1nLA
GZSeL6T7xI2RX5P+XndVZmc9K128ILIfgN8qRNCR/DtI+5rt35qdkTqYu8vCXTKZ
CCnzqTv36OMaUkUhB9zMNZnKqcHyN8JKDYgk7zC/ygRFU+1ojiVbKbq2DKPznZBr
C5lL+sccRMCLiX11pBnShCXKNKeQU7g3MjaLlUh+mcGSVRCwCZvnD21lFc1BJZQi
Tqwo/XUG6Y117dsR2RSaA0kq68WsQQDMADr5JMykTFDt3JUMkaxdcArDaPqUm5Y5
EoOhhEreTZ20nKKwWT4hw8loAG+Q9F+WNdHLZlLAyu86VHrikn+dJQmXZaE1TuSA
yUHG+prH4mh2zFpUZdfkLxgBk98FsZDzcIphcBO2kw9HHJhIk7LVsQ1x6chLBAgK
sTkKsp56tiZG2FAPbXf6V86nENEqhZga8K7v7JJKR0y6lYy8CuqlVqbSueWJo+ca
ea/OwXL/TshlumvveKJA
=4WWj
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d3029f9.8070...@thykier.net

Re: RFS: naev

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-11 09:18, Vincent Cheng wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "naev".
> 
> * Package name: naev
>   Version : 0.4.2
>   Upstream Author : Edgar Simo "bobbens" 
> Nikola Whallon <6.satur...@gmail.com>
> Josiah Schwartfeger
> Deiz
> Bas Fournier "BTAxis" 
> * URL : http://code.google.com/p/naev/
> * License : code - GPL-3
> data - public domain, GPLv2, GPLv3, CC-By (and -SA) 3.0
>  (upstream has confirmed that the GPLv2-licensed data files are actually
> licensed as GPLv2+,
>  so there shouldn't be any licensing issues)
>   Programming Lang: C, Lua
>   Description : 2D space trading combat game
> NAEV is a 2D space trading and combat game, in a similar
>  vein to Escape Velocity.
> 
> NAEV is played from a top-down perspective, featuring fast-paced combat,
>  many ships and outfits, and a large galaxy to explore. The game is highly
> open-ended, letting players proceed at their own paces.
> 
> It builds these binary packages:
> naev   - 2D space trading combat game
> naev-data  - 2D space trading combat game - data files
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 523834, 609295
> 
> My motivation for maintaining this package is: This is a fun game that I
> personally enjoy playing, and I hope that this package would be useful to
> other Debian users who would like to easily give Naev a try.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/n/naev
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/n/naev/naev_0.4.2-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Vincent Cheng
> 

Hey

Have you tried contacting the Games team about having them to review the
package?

~Niels


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMCrfAAoJEAVLu599gGRCe30P/3kpO50+OcGrSwOImjlbB5Gr
HiHI/8WR4VeqfZX5BioRUT260n/IS1GgJU3pTNXK457aJVgLQoGn7RND1l4dVpNh
6ovoHgtjWYrUtgHoOft8wIrSlOmIrEr7F5yxouTQ/0o71KuFmPFjO+n19grHLvYq
K1GnhU6PgPsrJVTivoTtI5TdAsPOkzHEqDi/PwslkOtuiYtauZaAnWR4QJ6fRKk5
IeWI9ZJ2LYyvba+7HKUaQ9j7Odk1Cfd7rke+R1vEF4/gfaTHl+wOmQfm7EtSTL4k
//DPIOlGITR/RfGeM5vgjBTe2dMa1yLnmsTOJdv2Phe1LG/I4phQG6YdkqOkEuTP
kwmlGiPRdc/T4wSdCnynUVvcFirgtP0jPW6ku8jHjPXCmhfwdkJ38ecR+MAKauMe
pSlILFP0XR2l7z2PKVD7155FMRrgxrpT3Q7V2CBfqF1Y0hPT3E0q6LE5dOGI8oUW
DeGxh8n45w+6BGcTE7kHqRsGHn+VqydQWyAT8ahMOP93ndX3vPM2yRMb7QRZrrGG
dV97PN0YwgbKAxFTtk9dgA5yOFUMjSeKSRVOnHCGzDLK/4O3J9fxV8LSt/ZNmoBX
xu60QCpXJtY7KQ3f78lY7kkEsCQeHlXkgAh08Z+pv0qyLG95REfq9NGdFae99ORZ
ett5NH8nAAgVTXlHjmfJ
=kz6w
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d302adf.2020...@thykier.net

Re: RFS: mangler

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-09 09:13, Vincent Cheng wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "mangler".
> 
> * Package name: mangler
>   Version : 1.2.1
>   Upstream Author : Eric Connell, Daniel Sloof
> * URL : http://www.mangler.org/
> * License : GPL-2, GPL-3, LGPL-2.1
>   Programming Lang: C, C++
>   Description : A Ventrilo compatible client for Linux
> Mangler is an open source VoIP client capable of connecting to Ventrilo 3.x
> servers. It is capable of performing almost all standard user functionality
> found in a Windows Ventrilo client. Ventrilo is a proprietary VoIP
> communication software, letting users communicate through voice or text.
> 
> It builds these binary packages:
> mangler- A Ventrilo compatible client for Linux
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 609291
> 
> My motivation for maintaining this package is: I often communicate with
> others who use Ventrilo, and Mangler lets me do just that. As far as I know,
> there is no other package in Debian that can communicate with Ventrilo
> servers or its protocol, so I hope that this package can be useful for
> fellow Debian users.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/m/mangler
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/m/mangler/mangler_1.2.1-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Vincent Cheng
> 

Hey,

Have you had any luck with the VoIP team (Re: #609291#35[1])?

~Niels

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=609291#35


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMC0VAAoJEAVLu599gGRC0ZwP/j7NvYc5AFXcokB3q/k2dT1K
ESacyDZJWdDHSFJIS/AwXdsZA1GdUHNd9bEWRftv4sDCSCW7ef2lLSLUAh4zA4Po
m/75czTCySmrK2qYZEth0Fedf0MoYtFDNjdZQKQpHRKGTbfQjjKKQHXdBhLdlLWq
EzNoYjLMVvL+WaaJG/v3iI9FvBuq3pKmZglcIJWzXnPxa2UD4U1VRtwA1Leoxsw7
M5FBty5MERnRXHsjuqjfjhqPBCR4ujYfhW4rPzzWAYZSOm3hcOmBbDrXWuu1Vuln
ymJrb8HaPhnO76NXsYARYCtmknnVoHvIfVw/rcLAPbJ2kmBRkY24kmUaQ1uPiqwX
lK/oq+5F/jgo7DhJ8ygK/VzsSZ5S1m0tyP3nAfsGMvYAiWpYBTsDNGNpZvmLenEi
dxRrhQ820dsi7wFfQbwv6BQ0slztiuKr7QSXP1uPXszaSiM7stYnu38pLTJR5MfU
BKsTJnG9N+juw9QlmyNQByWjhLzputwe8CZIvsrORWRWVF+FTWTvbQdnmEQR7Dk7
Ab9dNCX2BVSo0cH02yb/sbDWoSHL61Du1dKNPNaJOnBLCc1mQR9HJWkVjbhZTNFR
nSzdt2VVdbUSjOSbID0f57P7dyBMpS30x45clvyByi8Z3AmTL3HVAP8iO7v2+4ar
XCYLi+h/KKAFc5TsZ59f
=mRyb
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d302d16.6010...@thykier.net

Re: RFS: rman (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-09 10:33, Anton Gladky wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 3.2-5
> of my package "rman".
> 
> It builds these binary packages:
> rman   - PolyglotMan - Reverse compile man pages
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 358478, 465951, 530329
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/r/rman
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/r/rman/rman_3.2-5.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Anton Gladky
> 
> 

Hey

Thanks for your interest in this orphaned package.

cppcheck reports a few issues that should probably be patched and sent
upstream:

$ cppcheck rman.c
Checking rman.c...
[rman.c:4621]: (error) Common realloc mistake: "file" nulled but not
freed upon failure
[rman.c:3981]: (error) Mismatching allocation and deallocation: proc
[rman.c:3987]: (error) Mismatching allocation and deallocation: proc
[rman.c:3995]: (error) Mismatching allocation and deallocation: proc


You should also have a look at d/rules.  Currently it builds d/copyright
from d/copyright.prefix and README-rman.txt and also removes d/copyright
in the clean rule.


Personally I would prefer if the patches were separated into "related
changes".  (e.g. the "debian-changes-before-3.2.5" could be split into
one that fixes #! lines, one that adds the GZIP stuff and one that
modifies the man pages etc.)
  It is not a requirement, but it makes the patches easier to maintain.

Finally - this upload is targeted for unstable.  Since Squeeze is
frozen, the Release Team should approve the upload.  Alternatively you
can target experimental, which is always okay.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMDD4AAoJEAVLu599gGRCQQgQAKlF9ScDohZABa3csotNW77m
dQzdi12z+4lb2OuUATPhj9tlUizEifvR0jJkVezlgPNirirVS0MTbMZq9uod+dgr
JD99Ho0yGb+DGoXo26joMGqehwexx4h1VKQ0ATyHiUBLIdGqKsI8HkdPoGm0+D5+
FQA6XKHgX6FQlfSayDkUK9q7zFDB8fRI2OrPFcY9aSs3iiloO5K7VaqyaOIZm8Oc
NZatADVNG8fkyJsgT2SoGnduTbPNjkriLlV3ZQ1PcRy3upvokOdholYbknrMKsGg
g8tcEgCSkhsemw/A0QWnHgoQex4Bd+RRBzVQVNCZV0xi6srYKYDpU1bqvN7fMx9C
bMc6jdloxLs7pXJr1BrBgGMjbHzn7+tDZlkWyFwIlNgTlU9oqerD4XPQd7YhxOZb
oyshH51B1ZdcB6D42GUrtV+TQA8P1596Bz5mOsVyhpLBVlksB24uHTjEoUw5hyXh
HMUcOP95+ZJNOY+ZymBrgvJeKvmeC7V1hs7yON2FRDfo3Q3oI2oYkEAKYq+sKHQ2
utMAYLU6LmBDYQIsrqxHfvKWlQoa0iTvZKRU+rQHp7UhZOX3T61pJ1U1L1jf5cmc
LDH3iFMcFfGEPnUgTEPgtciT3hEmogZm4pKrM+e3YAi/sp5AVLaIURlE0jRtEgx7
sZqHwoPiG9bsfErdm0qA
=JwW5
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d3030fa.9030...@thykier.net

Re: RFS: libzeep

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-14 20:31, Maarten L. Hekkelman wrote:
> On 14-01-11 11:45, Niels Thykier wrote:
> 
>> I tried to build your package, but it fails in a clean chroot.  Most
>> likely you are missing a Build-Depends or two.
> 
> Thanks for having a look at my package. And yes, I totally overlooked
> those Build-Depends. Should be fixed now.
> 

Thanks.  Also if you do not know it, you can use line breaks in the
(Build-)Depends fields. This can make the fields easier to read if done
properly :)

>> Also d/copyright needs to contain the entirely licenses.  The only
>> licenses you can refer to without including a full copy of them are
>> those listed in /usr/share/common-licenses (with the exception of the
>> BSD license, which we are trying to remove from common-licenses).  On a
>> related note, the LICENSE_1_0.txt should not be installed.
> 
> OK, so I copied this LICENSE' contents over to the copyright file.
> 

Right, you do not have to paste its contents in twice.  You can say
something like:

"Distributed under the Boost Software License, Version 1.0.
 See the full text of the license above/below"


Also, the license file is still installed in the -dev package.  (see
debian/docs).  In general, when you have multiple binary packages (like
this case), you should use debian/.docs (etc.) instead of
debian/docs

>> In d/rules you could shorten it a bit.
> 
> Did that, created a new package and uploaded it. I hope it is better now?
> 

Sweet. The original was probably also good too, the new one is just
easier for reviewers/sponsors because all the "standard stuff" is hidden
in the "dh $@" line.

> Best regards,
> 
> -maarten hekkelman
> 
> 

It would also be cool if the build supported the CFLAGS/LDFLAGS set by
dpkg-buildpackage/dpkg-buildflags.  This would allow derivatives and
users to rebuild the package with different standard flags.  A notable
example here is Ubuntu, which is currently linking with --no-add-needed
and --as-needed.
  I messed around a bit and the library appears to build just fine with
- --no-add-needed (and --no-undefined), so it appears to be properly linked.


~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMhv/AAoJEAVLu599gGRCrOEP/jMzP6EZsghceB4aRONT0pW6
GGt7BDCMNUdBJUkQEKLh4Kmbji5fOXDB1vLXG+tdR8FGiURy4Ns4mOA2IXnkkcdV
pISTHnqF0of+v2hMDzBufArRxs1YCDh82FCDqFF7KLZU6FAaEDziDFi5cwPOF1HC
ZhqTPx2j4HHfAAWPnVxASf0z+skghRl2SWAFoVB0YBaq6MIcdMOME3V5+v4qcN25
tkG11CpMTM+e4MEFcfeGUrqL7gsiFdDZtRuhUzKPLhuLBXk9FuzKqShT6gQay8qR
IIlMyyLk978js6yN2VxbzIa4nXV7zea9fSQU/Rip/Y54so6ebvjDiBEauVSfD9R1
5mHRvvYiMLWbadPFxW+GZfhnB0RvYKovEQVjSlzJPdSkNqKumPQ+dHYE9CbH5Kg7
Eexpjofeo3kWnfIum/YoJb+rbxLOp8SaPsO3fINGXUBIcASjWGpcCxGMO2mMPhV1
IodRDXR0FExEZBJSJxt1c9DHeiPPz47fW/YqNAfhdRPCt13anU3Rzw3drHE7pAWH
enDmz+VqV79+zbVcUasg4UO1P64QSwCJ+xklby44yatflVT3wi1bqvFQX8ssejSF
1iyzXsEO0jisW6b5OsN/4laPfpvBSUiV/JBr5/nGzKJp8hzn6uuYN+2FbGpVLA2E
+hrdZGAc3JckFX5gfYNZ
=LXqb
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d321c01.2050...@thykier.net

Re: RFS: fgrun

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-14 16:36, Chris Baines wrote:
> I did consider contacting the Games Team, but FGRun is related to
> FlightGear, which is maintained by the Debian FlightGear Crew, so I
> thought I would try there and the mentors list first.
> 
> I will contact the games team, if nothing comes up·
> 
> Thanks,
> 
> Chris
> 
[...]

Truly it is.  My bad, I completely failed to notice the CC for the
FlightGear mailing list. >.>

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMh2LAAoJEAVLu599gGRC1dcP/15FQN2dGIkxNutPF/EtynaL
RTNTsYmgJzEhQdYTMflguVwmFNzLVPiBf/rCE/ouxuMS2qsn90Tpy0tU0yYWjN0x
TNRHIXYvnCkJPJnx3r7B2E2fkkG4XBa6p2yWwVSm1hLnque+wh5xSVvFYNrs4pdW
+hGZ/6esCcfaVRyMYbrmOue+SUcerR8QC6erboxosPWMeBgcWD7VhS45hXsSxUjv
T0noM9YfnhuTBBAul6/RSekaqka5hb3KZhlI4Kn8XcM9A8cFU4EDST9tDjT4gx2s
sPH5j+2+K374gx63nKS2uQkT7I6v7jeYA6RkynCtgrDCNEvdO0/8zNG8I+AOYpOr
eeXw/55W7MU4eDOFnm33DNXLs/pp8HbgrV1the9rc6tWzSAXDtwN2k5UkfAxNyDt
3L3FPQT1Nxi5ZGStaw1i9Ow3QhJruV/UbSwCu4Hq/AOzTFOXal3h3FwRy9i1CbPY
+HO127M9dtdfDa9CLG6+/ulPTsEzMGX4l18PWwpwBsbo0fyWu4R75F5KSpPmBf04
qt/rU8sxkwdaLwmJgpBV3unJmTngVRXkDtSJSSHpS+LhQ6XsLL9V3RiqjZce9NLy
+acUpZZzE3U4cAJAST4SA/TecQZAxFN9gLp4qf9+QenaUFbfN+wp/ntDuzwPH/vs
GgsonXlED/T2qc6Y0cKn
=euXA
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d321d8c.7050...@thykier.net

Re: RFS: libzeep

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-17 12:18, Maarten L. Hekkelman wrote:
> Op 15-01-11 23:13, Niels Thykier schreef:
> 
>>I messed around a bit and the library appears to build just fine with
>> - --no-add-needed (and --no-undefined), so it appears to be properly
>> linked.
> 
> Today I found out something is still wrong, when I tried to link to the
> libzeep.a file the linker was not able to find the symbols. Trying to
> get rid of the lintian error: 'unstripped-binary-or-object
> ./usr/lib/libzeep.a' I clearly stripped too many symbols. However, using
> 
> strip --strip-unneeded
> 
> is not enough to keep lintian happy. What is going on here? I tried
> rebuilding the static library without the -fPIC flag but that made no
> difference (to lintian). (I now also understand I'm supposed to do that
> anyway, using -fPIC for shared libraries only I mean).
> 
> What symbols does lintian check for, and how am I supposed to get rid of
> those (if that's at all possible?).
> 
> For the record, I'm linking the shared library using the 'ld -r'
> command, so I'm not using 'ar' or 'ranlib'.
> 
> Best regards,
> 
> -maarten
> 
> 
> 

Hey

Libraries are always a heap of fun!  I have not had this particular
problem before, though I checked lintian and it checks for the following.

If the output of "file library" contains "not stripped".  If it does not
match that, Lintian further checks for the presence of some unneeded
sections (particularly ".comment" and ".note").

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNNCpuAAoJEAVLu599gGRCQtQP/10VAr2xQYPFpb8Wh1yZoBrf
6R/VBJk896Lua206dEuOm7d/BCse2Q+pYYxKCsxuJJejKGFS4kTCk6RonKI+odxB
LNDMvAxaRGL74mKpwmBkTe9g+dtafcbGcMM7N92EfHe3LGCskmBrz5nVrxfDLxZo
TLKh83Q4nsiF5StU8zkZ6v5GaNV6Y0n6wYbxdbHfjEVKVXpPIIVRmVZBlA7I7vDh
uaKbAOfoOlpJZRA/cGE6vvJdP/e11CSvZ+pZ2L+D7Ms7tjRX0/q3aiqO9NmN1Gzd
+CgsdRQ1bd34Bnc/0F8VoYDfZTck1RTe+KNvlBDZl/PXUpbGcjXE2xvOQlCQ9KSD
nYbWp+4pLCERm6BFpoFV4kpLZRstAsas6VayGdwF1YNfS/5BMq2DbvHA5HLvI5pL
EmKIyOkrlUDnbjUwOzJOaVo4jg1Db7J/qAmiLJk9VMKGOpX4K2yHdxnnarwb/V/9
yrY4zOahX18Bw0SnMS4xcncXBcPUrM/hjxsWlN/vrRVlIv1TB99hzd7H1G/feY76
TPhQQJThZKmy/O1GwPtNW+ESQ2H5u/wEJ43MOSa6FGOhKWGoHNOr6k7rUsDji++l
DrCKLY9fIxiVQ+2rpmsNTcDEyQMbK9xklxYqE/yh6x8AZAOgtZirr6S5KfEz0gcY
55ibYw7vPYdMlrldb0cL
=7MSM
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d342a6f.8090...@thykier.net

Re: RFS: snake4 (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-16 21:33, michael wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 1.0.12-12
> of my package "snake4".
> 
> It builds these binary packages:
> snake4 - Snake game
> 
> The upload would fix these bugs: 581387 (O: snake4 -- Snake game)
> 

Hi

Thanks for your interest in Debian and for wanting to adopt an orphaned
package.

First things first; you should officially declare your intend to adopt
snake4. See [1] for how to do that.

You should probably also remove Ola Lundqvist from Uploaders (just
remove the entire field).  If Ola was an active uploader the package
would not be orphaned :)

> This is just for adopting the package.
> I know that the package is not lintian clean - I will do that next, but 
> because I'm asolutely new
> in maintaining Debian I want to do one step after another. I hope there`s 
> someone to help me
> anyway...
> 

A strictly lintian clean package is not required for uploading, but it
is generally preferred.  Your source package triggers at least 4 lintian
tags that probably ought to be fixed before the first upload.

W: snake4 source: dh_desktop-is-deprecated line 73
W: snake4 source: debhelper-but-no-misc-depends snake4
E: snake4 source: build-depends-on-obsolete-package build-depends: x-dev
W: snake4 source: ancient-standards-version 3.7.2 (current is 3.9.1)

You can get more information about these tags by running lintian with
"-i" or running lintian-info -t .

I believe x-dev has been replaced by x11proto-core-dev (but I have not
doubled checked this).

It is also generally advised to read the New Maintainer's Guide[2].
Feel free to ask if you have questions or problems understanding it.

Once the package has gotten into better shape and you got a better
understanding of how to maintain the package, I will recommend we
involve the Games Team.

> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/snake4
> - Source repository: deb-src http://mentors.debian.net/debian unstable main 
> contrib non-free
> - dget 
> http://mentors.debian.net/debian/pool/main/s/snake4/snake4_1.0.12-12.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Michael Boegl
> 
> 

~Niels

[1] See http://www.debian.org/devel/wnpp/#l3

[2] http://www.debian.org/doc/maint-guide/

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNNDLIAAoJEAVLu599gGRC1GQP/1C3/brbB0DsmePcoazdZR37
sgm+xB21sg7Nh5TqpcZ52A1RUO8pVbRpHVhc6XmmwkV8svy1aBDcxHglOLzbt5JJ
dSe22d8xn64OeeuglO8cYQXlK/SHTYx57VUf8ycT+Lviacd+lmHb7/Yslhcf1CZQ
1gkCvwquL+OBd6fSCg2Zt/tmTvkDJIW2h6444DBensuIDXNm577NTbrdC44Eqrxp
+hbRT2vI67KfkB76lwXofAVzTuIQR7o2UQd0QLbHkJVM95ZJ683PGGZAwjHDdgPt
XK84M+zW08OaPnMuN/x1neBQbSejmLw8uy0smW2UpfuzP9ufM3jdMvp5NLreU2sN
N5aG1Up4XZMsByrKboOWy/bulq4YjUv6sgD+PxDOGLl2ytal7xbsA+L5ACadTRMR
G5N4KDa5kCuf2Wda0ZIiIFJAiupAIg9+2z+bOIxNaKLyd2Clu0O5cG0/W/BdIXv7
X/9Kid0C+wVuu4DpY2CsYxqfKU5OKWxbE6VRXsr4TE44HIVVQmwtX9CWTSyO8rQZ
5ySaMNddF0TdqkDfE/yPn0H0FvGoq7tuRtBaxNNV8oIXxSYVyIZqRZxU4IAkxeCZ
NoRDH81cFjz4/++ODuTCqtf+BX0Yqq7k3nFCbMIIWeS/pmUwmgs49cDrCMmuIkRe
oyA/ffz21fpHE3sB5k9t
=qxWB
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d3432c9.5080...@thykier.net

Re: RFS: rman (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-17 22:04, Anton Gladky wrote:
> Hi, Niels,
> 

Hey

> I have uploaded a new version of rman. Could you not, please, have a look?
> It seems, that I have fixed all issues, which were suggested by you.
> 

Sure; I have a question to the realloc replacement.  It seems like your
replacement will be unable to handle if there was not enough memory in
the first iteration.

@@ -4615,10 +4615,10 @@ char *
 filesuck(FILE *in) {
   const int inc=1024*100;  /* [...] */
   int len=0,cnt;
- -  char *file = malloc(1);  /*[...] */
+  char *file;

   do {
- -file = realloc(file, len+inc+1);   /* w[...] */
+file = malloc(len+inc+1);  /* [...] */
 cnt = fread(&file[len], 1, inc, in);
 len+=cnt;
   } while (cnt==inc);
- 

I believe the following pattern can be used to solve the original problem.

char *tmp = realloc(file, len + inc + 1);
if(!tmp) { free(file); ; }
file = tmp;

> I did not sent a patch, which fixes cppcheck warnings,  to upstream as
> those warnings were done by adding gzip-feature to the code (probably,
> maintainer).
> 

Admittedly upstream looks rather dead. :)

> Thank you.
> 
> Anton
> 
> [...]

Also, please change "unstable" to "experimental" in the changelog.
Without approval from the Release Team we cannot upload to unstable this
deep in a freeze.  It can easily be re-uploaded to unstable when the
freeze is over.

There are also a couple of Lintian info tags.  About the no-doc-base I
think it is related to the removal of d/rman.doc-base.manual (though
honestly I did not check your binary package with Lintian the last
time).  Note these are only emitted by Lintian with the extra flags (-I
in the particular case), since they are more pedantic or less serious
than other tags.

I: rman: possible-documentation-but-no-doc-base-registration
I: rman: spelling-error-in-manpage usr/share/man/man1/rman.1.gz
extention extension
I: rman: example-wrong-path-for-interpreter
./usr/share/doc/rman/examples/hman.cgi (#!/usr/bin/ksh != /bin/ksh)
I: rman: example-wrong-path-for-interpreter
./usr/share/doc/rman/examples/hman.ksh (#!/usr/bin/ksh != /bin/ksh)
I: rman: example-wrong-path-for-interpreter
./usr/share/doc/rman/examples/man2html (#!/usr/bin/ksh != /bin/ksh)


I think that is about it. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNNWEOAAoJEAVLu599gGRC3dQQAKz9iGQyCJSMVF+51F8j+lwq
bpARdvr/O/Sj/YRDdkdqKHPID61klXHMRla/GKxnNBRoDCbDJE6R+VCLouUmTXwF
u1Bvwo7tOX1S4dNv+tf9IEZ30nLgvUDWjRKTC1bi308wSdxnElEwT+ec2hK0o942
X5n4i7761C3/vBdI9r9NeA1A77EAJDTlAozyG/zcPUTQ+tUFW6HUMFP4lCsU4ZE2
mnrUb9T6+yufs84ldmRW3FdLOKukX0bBHEVB+pDy4W114kKkG3AC/BzyytS15gGR
/6E8A5LmXH01VPIVLpqs5Xdu5lqni8bDsAWJM6lIMpY7oFPP+rR4DH0jwvcpuE5q
QTg24yuMHriWb8XMOfoaDcgqAR5Tm+1P22NU+bRfeLF0Bzo/hlggG5Lrp56m7dqe
MEV1oc68yulMCcMPBfQp0r86cXxzMnaPtf4SxA3gHesGFvb8r/qS47unnwfJZJpv
pvh/k9zWHA1C08nkhrSkn8XWthdAXg/3bYj7PdGuzYAEwJMQAMbPVHiFvGnFi0Vi
umLNfZTnmg0Fj+6JQ9nvpzL/YIwy4GxUpi6f53YHekhhkX8vcy71OrN+rlGV2Qkz
KcCDonqo9CctSqLO5lTDTucJTLZQI3qBvG4B0jk4aXrOlC5aLnYKbiH1LHRSu9fF
l9IFOzascmvgjaLk3FcC
=GjPn
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d35610f.6050...@thykier.net

Re: RFS: rman (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-18 12:15, Anton Gladky wrote:
> Hi, Niels,
> 
> I have re-uploaded that.
> 
> Thanks.
> 
> Anton
> 
> 
> 
> 
> On Tue, Jan 18, 2011 at 10:44 AM, Niels Thykier  wrote:
> On 2011-01-17 22:04, Anton Gladky wrote:
>>>> Hi, Niels,
>>>>
> 
> Hey
> 
>>>> I have uploaded a new version of rman. Could you not, please, have a look?
>>>> It seems, that I have fixed all issues, which were suggested by you.
>>>>
> 
> Sure; I have a question to the realloc replacement.  It seems like your
> replacement will be unable to handle if there was not enough memory in
> the first iteration.
> 
> @@ -4615,10 +4615,10 @@ char *
>  filesuck(FILE *in) {
>   const int inc=1024*100;  /* [...] */
>   int len=0,cnt;
> -  char *file = malloc(1);  /*[...] */
> +  char *file;
> 
>   do {
> -file = realloc(file, len+inc+1);   /* w[...] */
> +file = malloc(len+inc+1);  /* [...] */
> cnt = fread(&file[len], 1, inc, in);
> len+=cnt;
>   } while (cnt==inc);
> 
> 
> I believe the following pattern can be used to solve the original problem.
> 
> char *tmp = realloc(file, len + inc + 1);
> if(!tmp) { free(file); ; }
> file = tmp;
> 
>>>> [...]

Better, but it is still lacking the "" part :)

Right now it will free file and continue, leading to a null pointer
dereference when it calls fread().  You should be able to use

fprintf(stderr, "Out of memory\n");
exit(EXIT_FAILURE);

as a sane way to fail.

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNNbpYAAoJEAVLu599gGRCZuwP/1qlMa4A8+qEFPeVHh5kv057
NTZXxHyLqWcHDy/LHVa/1uDjYglo/dvIuQZgZonUS3rGxJMQhS6UaWzCd8eoKCm0
0Mm7g+Z0+xsy3Kr5ymhtiOYugCf/RKfQLB3iqzWEeOiVUEn2av5XMUvtqmUhfgKk
sgppTKLYLyMOhaHHzgIA9Hl9UYahOZRGOmb0uFYVr5pQQVY8RpfEHn9OZKQvIrJv
IexJI6rESTCXFitp3HidUQZPD2xZhKhLRlGBKxEw+qXtkP3/QAgowb54eXF3f9mE
LNmzbQkHfqQUCIwBplvNvGx9gm91DRgli135U4pJMdXhaWYxZt1SUgQQ6A3xyF4l
Dy3xWzjnasI+gnvlgwuytiBwCbAdFXU3/d1nR7wO59PtdKf8qN3W/1jue0tfBF0N
6hqNWejhsLsD0s6qnPd0cKgqV/KWS0wMqAp17Re0RqdieB7dDSoTMwIsd4QsTXVC
GlCPqZnAddIHwBtxQHsFhzfzmlIAY8vEup+MW3iysp4VJJWR2whwY2/LujNNCiWN
Z3YyEZW/chUnIlwN288e4XCh2MtkfUqtyKdEr2zCxtcmZJid5r3SyXHRsnsE0Mes
F1hFclFIVAqfr7IhYPh4FWOUZlRq7vFH06xTPAGXcFrD7NATFLKmWnFfxSrqhgzB
IvaVsw4oyA7TxiKag89R
=50Rw
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d35ba59.9010...@thykier.net

Re: RFS: pev

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-16 02:16, Fernando Mercês wrote:
> Niels,
> 
> You're right in all points. Thank you for help. I've used the new tool
> for DEP-5 and got no warnings. I've fixed the other issues too.
> 
> Please, can you check the package now (already re-uploaded)?
> 
> Best regards,
> Fernando Mercês
> Linux Registered User #432779
> www.mentebinaria.com.br
> http://linuxreversing.org
> http://softwarelivre-rj.org
> --
> Participe do I Hack'n Rio, dias 8 e 9 de abril na UFRJ!
> --
> [...]

Hey,

Uploaded, thanks for your contribution and feel free to contact me in
private if you have a new version of pev ready. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNNbyzAAoJEAVLu599gGRCcOwQAJKlf9rl6mv8hY6s+GjC4xAm
sJxh52NSZwBEYEbCVmVqXdn2FaGlpwRpflkuUCHKAQrOAjg9OrEsK3T+OAyylRQs
0G5JkYYQYwmu8qbrGobNvqZsV2oHvzcBasXCjkeECz7u6ao/bYzHsJpbZdFjmIA4
cx5hcm9UbEef9y/d3Mj0PpGdEuXDj2TY7IyBMjbe/GOh/KDtxg+jhNVQgkY1g+4W
PMDIwb1aClnlXCmqRhZvStRYMDPRtapDijycqh07qiDr3oFglySazA0E4DvC/w7j
H2H7FUmEcxTpyyt0eCF0NBsyhg2mekkec0Bmxcavxejbt+P/HJJoxYwRVMjoIU6x
GZeMLZIklk7btNFZ5jcdHowO03Ph3ylQo/ZxqOT5MNAREIIr+LGcMW2aQWcBfjS8
iUqhqvRzohiOlrHTEGDAdM2i2LNnM0dCO5a6q6D9DLLBAthX/FjUl4kcjLWA+EiN
e63rv7vZIRCxVTiIL9jGtt9FvUPkI0oq9CRB7XOy58LLrPSyLFHLEm/rnKSbvJTk
s6D2LE2sg5ec3lFEEG0/PamMKiiTrXks2XNK6U/7ZVk44IUWRzTOaWCT2LAvaXNv
x2wXqoHCS2q/FfJPbVm9DCi1fvFGAt2aU14+pm6E2c+KNXQ4lCnBxfI1G+tAVWVD
vR6hQ2YWiHq4zl0gtlkF
=N51K
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d35bcb3.2000...@thykier.net

Re: DEP5 and multiple copyrights for same file

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-20 22:25, Siegfried-Angel Gevatter Pujals (RainCT) wrote:
> Hi Jean,
> 
> Something likes this should do:
> 
> --
> Files: gtk/core_math2.cc
> Copyright: 2004-2010, Thomas Okken
> License: GPL-2
> 
> Files: gtk/core_math2.cc
> Copyright: 1993, Sun Microsystems, Inc.
> License: other
>  Permission to use, copy, modify, and distribute this
>  software is freely granted, provided that this notice
>  is preserved.
> --
> 
> Regards,
> 

It has been a while since I last read the DEP-5, but I believe the above
is handled with "GPL-2 and other" instead of multiple sections.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNOLKgAAoJEAVLu599gGRCel4P/j3PmxGtKgiCuSaPJWO9fj3Q
GiEibP0tGKuWm33Hl4OeR9SY7AYS+Y2U02Ad3cTXQW9ucGoBx5eRiw2IZ5Ar7XqH
pI3y+H6tJHRTQv9TMKPMReBFykm22yC23xeMmYrElZbGA6ylSIemQ232MNeBcyRw
hWFT2N7KasyX0+TwjXXKKNN9BNsQgMzXgGt4PXP1ekGZyLSWDvoq6HEX970MVqek
6iBsmetliL9hg6fczJSscKZGUke9F7TgaQUUQIgecsV6QZWERqy4ggByZxRlodB3
bRKKWVCpSxSRYKajQBjTNTCe3+9piMvJsm0O0wxh0stUQzM7lhN5SFl73Bwz4lLX
+kl49CQLsYa3/CvkcFmx1h4pU6mZAUsZs9XqnuM8lOM67/eHa10TFL2Pr3M9dIKR
tPS3rn8O7FS706EsloIZdwHw7qAMGBDtFdHhOONhFFLGCVqt0wrdA0wgOvnra4+q
m98yIIEt/D8GdLNitj6yrHNc8e8Y7QMZqo+XLZZ8HdGvb2nubKvm8YKETOgRQk1G
ndWyQEidce2shNEt5rvEdoEvkxfNl0eWsAhHYLyttBoS/oK4WwPhgojSia4O9cJu
axBIX3L4htWWVKafs77E3V3yhDT+hN4gljlxNbGYPj3mD+tT+ZRNTi6Xfub93qRi
+/mnHkaxdtC78wOHCoYy
=Y6hf
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d38b2a1.9050...@thykier.net

Re: RFS: rman (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-18 17:38, Anton Gladky wrote:
> Ups, sorry.
> 
> Uploaded.
> 
> Anton
> 
> 
> 
> 
> [...]

Hey

Uploaded, thanks for your contribution to Debian and feel free to ping
me privately if you have another upload of rman ready. :)

~Niels



-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNOghbAAoJEAVLu599gGRCozAP/jBO5WZU3NcMbMPzI1JgGGvO
XzjBJpzJi9qAkr+gOvw2NQHSTzARGc+ewLEzSbXXcZVns5QBuIXBUvGqymwtgri5
pkGWalPhMKHVSltOZEIqdCftg97oD7pveHylqUEJEo+etVZNLj+wKIe6+ePNU5lY
K2oFmQzhk9u7qIoXFyLSxioQWpNNaxVDZh892fNuCcugJfgOBN8YZYxsB+7A8sHI
jbmQFps6IkX+ugqd+RwTUGGbRn+1JIkhXp81HfIhEGBWbUFrzlGBfY3tWV3RVCzo
4pLF2HgoWDPv9yOPUzWHXHbevBdPSh6ljXOF/wZE7WpK4fJxLS8Aangsh4JElGm6
3MS0qdVCTM5D2PWwaQhU4TEae3Dz6zGNjt6ebmWRECRY1CT/tV8mdf4Qws+eubzV
TQVZZYz91e0Ml18hmBwvB2aXLRhFrhwwnwpbPVlu2CnoiD9gY+R/CXEfffBt7YoP
1NI/A3O2Utxw9r8oMVwGOXAncN1ayEACssNeLCIkH2SdXOuwylpr8aegvzjUaKUN
EcucyqQTVPNOAgo78LEB+xMdQuyPh3gZ/qtqj/YxAdN66as7mLVQzftn9SC5g7th
iXDSbAHpKV7UvYmG05E/hnyFkKq5TiVTX1uQHnK/Do2wtqye/+KneawZKkGOb9Tz
Pl1BIFaM50pFIhIcVRiY
=/UFz
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d3a085d.9080...@thykier.net

Re: RFS: lilo (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-19 20:51, Joachim Wiedorn wrote:
> Dear mentors,
> 

Hey

> I am looking for a sponsor for the new version 1:23.1-1 of my package
> "lilo".
> 
> It builds these binary packages:
> lilo   - LInux LOader - the classic OS boot loader
> lilo-doc   - LInux LOader - Documentation for the classic OS boot loader
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 158955, 244741, 278373, 287257, 304065,
> 306472, 325235, 335084, 339778, 389328, 409663, 428390, 431077, 459714,
> 504267, 522283, 590022, 596258, 599934
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/lilo
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> - dget http://mentors.debian.net/debian/pool/main/l/lilo/lilo_23.1-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Some notes: 
> - This package goes into unstable, ready for squeeze+1.

Right, but until Squeeze is out I will upload to unstable without prior
agreement with the release team.

> - This package can be build an Ubuntu systems, too (without changes).
> 
> Kind regards
>  Joachim Wiedorn
> 
> 
> ---
> Here is the changelog of these package:
> 
> 
> lilo (1:23.1-1) unstable; urgency=low
> 
>   * New upstream release. (Closes: #339778)
>   * Upstream bugfixes:
> - Option 'append' works with acpi=off. (Closes: #428390)
> - Working on degraded RAID-1 device. (Closes: #278373, #522283)
> - Working with spaces in labels. (Closes: #287257)
> - Using new hook scripts for kernel and initrd only one time
>   when needed. (Closes: #599934)
> - Include diffs for NMUs. (Closes: #504267, #409663)
> - Fix error with LVM partition. (Closes: #244741)
> - Compatible with devmapper version. (Closes: #325235)
>   * Solved upstream bugs of Ubuntu:
> - Raid related error while upgrading (LP: #242879)
> - Warn if initrd is too large (LP: #260059)
> - Allow using LVM as root partition (LP: #274972)
> - Stack overlaping on second stage (LP: #438177)
> - Raid setup fatal errors (LP: #470502)
> - Use hook scripts while updating kernel/initrd 
>   (LP: #43869, #345482, #628858, #636211, #691975)
> 
>   * Remove all old patches.
>   * Remove very old lilo.conf examples.
>   * Remove obsolete file debian/NEWS.
>   * Bump to Standards Version 3.9.1.
>   * Move to debhelper compatibility level 7.
>   * Move to source format 3.0 (quilt).
>   * Update and new formatting of debian/copyright.
>   * debian/control:
> - Move source dependency debhelper to version >= 7.0.15.
> - Update some versions of source dependencies and remove quilt.
> - Add VCS urls in Alioth.
> - Add in package lilo-doc dependency to lilo.
> - Optimize package descriptions.
> 
>   * Update all debian/lilo.* and debian/lilo-doc.* files.
>   * Add new debian/lilo-doc.doc-base file.
>   * Remove lilo.sh wrapper script, used because of devfsd.
>   * Remove obsolete script lilo_find_mbr and its manpage.
>   * Remove configured link update-lilo to liloconfig.
>   * Remove some obsolete manpages.
>   * Move script liloconfig into directory debian/scripts.
>   * Add new script update-lilo and its manual page. (Closes: #335084)
>   * Add new script lilo-uuid-diskid for ID conversion and its manual page.
> 
>   * Update scripts lilo.postinst, lilo.postrm, lilo.preinst.
>   * Add link creation for menu background sarge.bmp and sid.bmp
>   for compatibility in file debian/lilo.postinst.
>   * Remove hook scripts for kernel and initramfs and use upstream scripts.
>   (Closes: #590022, #306472, #389328)
>   * debian/patches:
> - Add new patches for Debian.
> - Add patches for simple rules using dh 7.
>   * debian/rules:
> - Use simple rules with dh 7 capabilities.
>   * Move debian/Makefile.floppy into debian/floppy directory
>   and fix this Makefile. (Closes: #158955)
>   * Add debian/lilo.install file.
>   * Add lintian-overrides for package lilo.
>   * Update debian/README.Debian file.
>   * Remove obsolete file debian/NEWS.
>   * Remove obsolete debian/TODO file.
>   * Remove obsolete debian/lilo.changelogs file.
>   * Add patchset and changelog entries for use in Ubuntu.
> 
>   * debconf files:
> - Remove message above old bitmap path. (Closes: #304065)
> - Update of debian/lilo.templates and debian/lilo.config.
> - Add some code to these files using lilo-uuid-diskid.
> - Small update of german translation.
> - Add updated Danish debconf translation. (Closes: #596258)
> 
>   * Some more bugfixes:
> - Add usage hints about -H option in src/lilo.c. (Closes: #459714)
> - su-to-root command without path in debian/lilo.menu. (Closes:
> #431077)
> - Diffs for NMUs already included. (Closes: #504267, #409663)
> - Remove old obsolete workaround (see bugreport 146350#25).
> 
>  -- Joachim Wiedorn   Tue, 18 Jan 2011 23:38:32 +0100

Re: RFS: snake4 (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-21 12:14, michael wrote:
> Dear Mentors and hi Niels,
> 

Hi again

> I did everything as requested in the mail below. I hope I took the bug 
> in the right way - otherwise please tell me. I additionally checked the
> package using pbuilder against sid and squeeze and it's now lintian
> clean. mentors.debian.org is telling me so, too.
> 

Great.  For pbuilder you only need to use sid for normal uploads (or
experimental if you need to upload there).

About lintian; your package is clean down to informational tags.  By
default lintian only shows a subset of all tags it can, you can add
additional flags (-IE --pedantic) to see all them.  To get the most out
of lintian you should always run it on the changes file (e.g.
snake4_1.0.12-13_i386.changes)[1].
  Note about mentors.debian.org and lintian: mentors.d.n only have the
source package available so it is unable to check for a lot of potential
issues in the binary package(s).


[1] First lintian will automatically run all packages related to the
changes file in this way.  Secondly, there are a few checks on the
changes file as well.  Finally lintian has a few cross package checks,
which currently requires that lintian processes the package in a certain
order.

> So what do I need to do next?
> 
> Kind regards
>  Michael Boegl
> 
> Am Montag, den 17.01.2011, 13:15 +0100 schrieb Niels Thykier:
> On 2011-01-16 21:33, michael wrote:
>>>> Dear mentors,
>>>>
>>>> I am looking for a sponsor for the new version 1.0.12-12
>>>> of my package "snake4".
>>>>
>>>> It builds these binary packages:
>>>> snake4 - Snake game
>>>>
>>>> The upload would fix these bugs: 581387 (O: snake4 -- Snake game)
>>>>
> 
> Hi
> 
> Thanks for your interest in Debian and for wanting to adopt an orphaned
> package.
> 
> First things first; you should officially declare your intend to adopt
> snake4. See [1] for how to do that.
> 
> You should probably also remove Ola Lundqvist from Uploaders (just
> remove the entire field).  If Ola was an active uploader the package
> would not be orphaned :)
> 
>  [...]

This looks good :)

Now, as hinted the package is mostly clean, but you have a pedantic tag
against the source package.  Some pedantic tags are usually okay (e.g.
the "no upstream changelog" - if upstream does not ship one there is not
much to do about it).

$ lintian -EvI --pedantic ../snake4_1.0.12-13_i386.changes
[... ]
N: Processing source package snake4 (version 1.0.12-13) ...
P: snake4 source: direct-changes-in-diff-but-no-patch-system
.pc/.version and 9 more

However, I would like this particular tag reviewed a bit.  It looks like
the at least .pc/ files appeared between your -12 and your -13 package.
  It is used by quilt to figure out what patches have been applied.
However you do not ship any quilt patches as far as I can tell.  I am
guessing (based on the patch name) that it comes from an incomplete
attempt to convert to 3.0 (quilt) source format.

If you convert to 3.0 (quilt) dpkg-source will automatically exclude it
when building it.  It will also automatically create it when unpacking
the source package.
  Alternatively, you should remove the .pc directory.

For the actual files changes, I would recommend moving these changes
into patches (a patch for each logical change).  dpkg-source can
generate a patch for all changes if you convert to 3.0 (quilt) and build
the package.  You can use tools like filterdiff to extract parts of the
patch into other patches.
  You can also extract them directly from the diff.gz, if you prefer
that (for larger packages this can be vastly faster) :)

Regardless of what option you take here, you have to make sure the
patch(es) are applied before the package is built.  If you use 3.0
(quilt) it will done at unpack time - just list the patch(es) in
debian/patches/series.
  Otherwise debian/rules must be updated to apply the patches before
compiling and unapply them during the clean.  Note that most build tools
always clean before building, so the "unapply" code must be able to
handle that the patches are not applied.
  If you use one of the common patch systems in Debian (e.g. quilt or
dpatch) they usually have either tools or Makefile snippets that can be
used for this.

I would also like you to clean up d/rules.  At least remove/merge
uninterested targets and comments.  Please also either fix the "noopt"
build option or remove the code for it (fixing it probably requires
patching upstreams Makefile, since it does not react to CFLAGS).
  Personally I prefer things like the debhelper "tiny rules"[2] with
override targets (or cdbs, but I have less practice with it).  These
styles have the advance of hiding the "standard st

Re: RFS: snake4 (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-01-23 16:05, michael wrote:
> [...]


Hey,

Sorry for the late reply. I am taking the liberty of answering this one
first.

> Last questions : Is it a MUST to make those suggested changes? And if
> not, what's next now?

None of these suggestions in my last email were a *must* on my part,
mostly because I intend have you contact the Debian Games Team (as I
mentioned in my first email). Due to a lack of experience with games
packages I do not feel good about being the sponsor of game packages.
  Beyond what is required by the Policies etc. (and defacto standards
where policies are outdated) you and your sponsor decides what are
*must*, what are *should* and such.

Also I suspect that you have been reading Neil Williams "Sponsoring
requirements", since you have been made a -12 and a -13 revision. It is
entirely possible that your sponsor will want you to merge these two
into a single -12 entry. But that entirely depends on your sponsor.

Regarding the next step: well,

>> > 
>> > I would also like you to clean up d/rules.  At least remove/merge
>> > uninterested targets and comments.  Please also either fix the "noopt"
>> > build option or remove the code for it (fixing it probably requires
>> > patching upstreams Makefile, since it does not react to CFLAGS).
>> >   Personally I prefer things like the debhelper "tiny rules"[2] with
>> > override targets (or cdbs, but I have less practice with it).  These
>> > styles have the advance of hiding the "standard stuff", making the
>> > "non-standard" parts more visible.
> I'm not sure if it's worth changing to cdbs and/or quilt right now for
> only 4 small changes (I use it for an other adopted package - snacc -
> right now, so it's not a question of skill).
> I removed that dh_desktop line - that's o.k. for I added the #, but I
> can't see the necessity of changing the other things or removing
> comments. It was o.k. all the time so far and is doing no harm. I also
> like to have some comments, even if they remain from the initial
> conversion to a debian package.
> 

I am fine with you having your own opinion on things like this. Since
you will be working with the package the most, I would /personally/ be
okay with keeping these particular 4 small changes directly in the diff.
  As for the unused parts of the rules file. Truly the current rules
file is functional as it is; also I am perfectly fine with you keeping
the comments in the file you need/want. If they help you as a
maintainer, then by all means keep them.

What I do not understand is; why do you want to keep the
configure{,-stamp} targets? They do nothing but touching a file and
their existence are not required by the Debian Policy. Why do you leave
the check for whether the Makefile exist being running $(MAKE) clean?
The makefile is not removed by its own clean target. This rules file
look like something geared towards a package using autotools.


Finally there is this part, which I asked you to look at:

ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
CFLAGS += -O0
else
CFLAGS += -O2
endif

I do not see any changes to it, nor to the upstream Makefile. Does this
work as intended? That is, will

  DEB_BUILD_OPTIONS=noopt dpkg-buildpackage

produce an unoptimized package? As I recall I came to the conclusion
that it probably did not work, but feel free to correct me if I am wrong.


>> > 
>> > When you clean up the rules file, please bump debhelper to at least 7.
>> > if you go with "tiny rules" with overrides, you will need a
>> > Build-Depends on debhelper (>= 7.0.50~) - but the compat is still 7 in
>> > this case.
>> > 
> Why that? Even lintian was only requesting (on that mentioned snacc
> package W: snacc source:
> package-lacks-versioned-build-depends-on-debhelper 5) to change from >>4
> to >>5. On the other hand actualised lenny is using 8.0.0~bpo50+2, so
> why not change to 8, for I haven't checked against older versions and I
> do NOT intend to do so?
> Just to be complete : this change has to be made in the control file,
> not in rules.

So, starting with Lintian here. The Lintian warning you saw is about the
package having a Build-Depends on debhelper 4, when the package said it
used debhelper 5 features (in debian/compat). Since compat 5 is not
strictly deprecated, Lintian will not warn about its usage.

As for debhelper in lenny; lenny has 7.0.15 - the version you are seeing
is debhelper in lenny-backports. There is a difference between the two.
I am willing to believe that snake4 is an unlikely candidate for
security or (old-)stable uploads.
  I see no reason why you cannot use debhelper 8 instead of 7 for snake4
actually. I have just been accustomed to using compat 7, so the new 8
compat went past me. :)

> [...]
> 
> Kind regards
>   Michael
> 
> 

If you have any questions to the above, feel free to write back on list.
If I do not reply within four days (like I failed to do this time), feel
free to ping me in pri

Re: RFS: snake4 (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-02-05 13:39, Michael wrote:
>> On 2011-01-23 16:05, michael wrote:
>>> > > [...]
>> > 
>> > 
>> > Hey,
>> > 
>> > Sorry for the late reply. I am taking the liberty of answering this one
>> > first.
> That's o.k. although I feared I had picked some wrong phrases for
> englisch is not my native language...
> 

Yeah, silence tend to give that impression; though in my experience it
is usually more of a sign on people being busy or lost track of it.

>> > 
>>> > > Last questions : Is it a MUST to make those suggested changes? And if
>>> > > not, what's next now?
>> > 
>> > None of these suggestions in my last email were a *must* on my part,
>> > mostly because I intend have you contact the Debian Games Team (as I
>> > mentioned in my first email). Due to a lack of experience with games
>> > packages I do not feel good about being the sponsor of game packages.
> I want to do that next, but I wanted to wait until squeeze is out(this
> weekend). Will a RFS mail to debian-devel-ga...@lists.debian.org be the
> correct way to do so ?
> 

I think an RFS on that list would be okay (at least others appear to do
the same). Most of the documentation I can find sort of assumes that the
package and the maintainer of the package is a part of the Games Team.

>> > 
>> >   Beyond what is required by the Policies etc. (and defacto standards
>> > where policies are outdated) you and your sponsor decides what are
>> > *must*, what are *should* and such.
>> > Also I suspect that you have been reading Neil Williams "Sponsoring
>> > requirements", since you have been made a -12 and a -13 revision. It is
>> > entirely possible that your sponsor will want you to merge these two
>> > into a single -12 entry. But that entirely depends on your sponsor.
> I'm sorry, but you are wrong. I just read the requirements on your hint
> (thanks a lot, because that's one reason, why I want to get involved
> here) and found that similar ideas lead me to the same result. 
> 

:)

>> > [...]
>> > 
>> > I am fine with you having your own opinion on things like this. Since
>> > you will be working with the package the most, I would /personally/ be
>> > okay with keeping these particular 4 small changes directly in the diff.
>> >   As for the unused parts of the rules file. Truly the current rules
>> > file is functional as it is; also I am perfectly fine with you keeping
>> > the comments in the file you need/want. If they help you as a
>> > maintainer, then by all means keep them.
>> > 
>> > What I do not understand is; why do you want to keep the
>> > configure{,-stamp} targets? They do nothing but touching a file and
>> > their existence are not required by the Debian Policy. Why do you leave
>> > the check for whether the Makefile exist being running $(MAKE) clean?
>> > The makefile is not removed by its own clean target. This rules file
>> > look like something geared towards a package using autotools.
>> > 
>> > 
>> > Finally there is this part, which I asked you to look at:
>> > 
>> > ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
>> >CFLAGS += -O0
>> > else
>> >CFLAGS += -O2
>> > endif
>> > 
>> > I do not see any changes to it, nor to the upstream Makefile. Does this
>> > work as intended? That is, will
>> > 
>> >   DEB_BUILD_OPTIONS=noopt dpkg-buildpackage
>> > 
>> > produce an unoptimized package? As I recall I came to the conclusion
>> > that it probably did not work, but feel free to correct me if I am wrong.
> I must admit that make (and automake etc.) are my least familiar tools.
> Actually I'm glad, if I can add necessary changes without destroying the
> old parts. For I adopted that stuff not knowing what the former
> maintainers thought by keeping that code I would stay on the principle
> "never change a running system", but if it's a general principle to move
> every unneeded thing out of rules and makefile I surely can do those
> changes...
> 

It is good to have a "never change a running system" view in some cases,
since it tends to avoid regressions. On the other hand that view alone
also lead to staleness.

> About that CFLAGS stuff I don't know, if it's ever needed for debian. I
> haven't used it by now, but I think it was (is) intended to use for
> debugging purpose (gdb or ddd). I have the idea to change snake4 in the
> way not crashing the snake on the borders, but to leave and entering at
> the opposite border. When doing this (maybe in the future) I can check,
> if I get an not optimised program by setting those option.
> 

I am also perfectly fine with you simply removing the "noopt" CFLAGS
stuff. The problem with keeping it is that it implies that the package
supports it, when it really does not. That being said, it would be great
if the package eventually was patched to support using CFLAGS/LDFLAGS.
  The reason is that it would allow Debian to later change the default
build flags and then snake4 would "work out of the box" with the new
build flags. Curren

Re: RFS: snake4 (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-02-05 14:28, Peter Pentchev wrote:
> On Thu, Feb 03, 2011 at 12:37:18AM +0100, Niels Thykier wrote:
> [snip]
>> Finally there is this part, which I asked you to look at:
>>
>> ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
>>  CFLAGS += -O0
>> else
>>  CFLAGS += -O2
>> endif
>>
>> I do not see any changes to it, nor to the upstream Makefile. Does this
>> work as intended? That is, will
>>
>>   DEB_BUILD_OPTIONS=noopt dpkg-buildpackage
>>
>> produce an unoptimized package? As I recall I came to the conclusion
>> that it probably did not work, but feel free to correct me if I am wrong.
> 
> Erm, why would it not work?  It's a standard snippet used in the rules
> files of many packages in the Debian archive :)
> 

Because the upstream Makefile ignores CFLAGS :P

> Recently it has started to gradually disappear for two reasons:
> 
> 1. dpkg-buildpackage now examines DEB_BUILD_OPTIONS by itself and sets
>the appropriate CFLAGS and LDFLAGS (it also checks for "nostrip").
>Still, this is far from perfect, since a package may not necessarily
>be built using dpkg-buildpackage - e.g. during testing the maintainer
>may sometimes run "debian/rules clean", "debian/rules build", etc. by
>hand to see how it goes.
> 

awesome, I did not know that :)

> 2. More recently, dpkg-dev 1.15.7 introduced the dpkg-buildflags tool
>which is perfect for this task :)  You may take a look at the rules
>files for the mbuffer or timelimit packages to see how it's used.
> 

Yeah, I assumed Ubuntu used the dpkg-buildflags approach for their new
linker flags.

> Hope that helps :)
> 
> G'luck,
> Peter
> 

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNTVEdAAoJEAVLu599gGRC9/QP/1x+gCYZm34KKve0o9/FSxkI
28WILvPYyMH5WNhnN90LlnZfzLQiumqmU1X0wRq+rjiXMS6sQGxKAby0UStv6KN8
lKnSCyEeiCeVdj9nVVFxuVHijftt0VWb9qEzaJUFTewwxrnTRj59nD+Lr69LWgyY
OxPkEohDfE4eRRO1RilXxmNfB1RL++AsIsPMSneCAL4DnwLZEigToiEs6MaYmTpO
oHafcvEReoeFrMSCHA97nO2jvuzZlylK5Sqxp8IH2WR81so112GqOQZjJHTAaYdw
mLFQkDV93cOEkyiqZS41CbABXpnriUVCjwcIBfodCWC044EV6iqPyW3DnZwEgVy9
o9mMaZ4HJbcE3BwiqxoKMnB2k1djOJJ81Gje00JyKzqdowpKFfzSRS4ITDAidtUx
MWXsVpXInLiG6AvN31VDczg9kH2hYfGBKdS3SOyMBqpmwGQNJkVrnGgOewmRe0Ee
yROMOPGHBaUt87YaA0KRIEY/7V/k2/meyY5r9w+3dQJ8SLawiDZ0x0bA8dYB1Yc9
M4idnlNipFX3PYzH2BkWPfpApyM/w5F1aY6PLso9RmLfvlaATDQD46v2L4/kwXol
cU1L6ft0+CP+gIId+Z4XL4rNc8hk86E1jgfGfAFjA1jBnDmYjPI5WUiDHfTqCC9q
9tgQyuwSKkoSHE0WDsNo
=D5q9
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d4d5120.4060...@thykier.net

Re: RFS: snake4 (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-02-05 14:51, Michael wrote:
>> On 2011-02-05 13:39, Michael wrote:
>> [...]
>> > I am also perfectly fine with you simply removing the "noopt" CFLAGS
>> > stuff. The problem with keeping it is that it implies that the package
>> > supports it, when it really does not. That being said, it would be great
> As far as I can see CFLAGS is used in CCOPT in Makefile and CCOPT is in
> the rule for .o files. So it should do something, whatever this
> something is.
> 

Certainly CFLAGS is passed into CCOPT; I guess I confused myself here.
The only thing is if gcc -O2 -O0 does the right thing here[1], which I
am guessing it does (based on -Q -O2 --help=optimizers vs -Q -O2 -O0
- --help=optimizers).
  My bad >.>

[1] Upstream makefile contains:
CCOPT= -O2 ... $(CFLAGS)

>> > [...]
> Sure! If I will do it I'll make it as an option selectable before
> starting a new game.
> 

Good good, :)

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNUBSqAAoJEAVLu599gGRCfC8P/ibJFEkWm+I51A1Vn+sqqcgB
N5J+t7i13onlGeFtuabG0ETwYizbGsJcfDOPT6206jKdsEEng1r36RpVmdbBoIvf
17Q/eCcIkOf4BrZ5LWhuVNghCdloW28u6RDz8yReFacRj6/sb9wRBoAhqDtiaPA8
NsIEz9CiZ74/BG1smx8oBL8KSmqc1oqjLOO4c7d+IJhv1MN2AkA8OYqOyublBvlL
MyLNJy/CkSYw3mvIwXlMsAWCXmbrQ/quK5Qiv23uG7ddJNoSTiJ90/RZtAMck0Gf
Yj42SPuotquluBl6xc5Q5dFgJf3ZSgolAzHlBi2dAZkuM0whC0V3h90Zml28I2bQ
bDkadQEETSKu1H74RGh0cHgv2rD01e6Rm025R5Gnk7dIkiY3MVKoIrghQmFq/qHg
0MMsIXYCfY3gzTCEWlwC/OuvHMHR1xe/nh/LY54YHjqe4vZ6urInGAcuvGsZbmt6
KWvb7477jkWDjYNJhLlv0SEdExZgn4wj2ZX63tIzAvEiCRSEIBvqq4iK3TWhvXca
gVOGuO4hQPvbJ+qXt72ngK2GB9hgX39D76ou7k0kcKRan19uRqkR8aVI/smkd5Uo
NMhOxSxlzy5JlshEaTXYnVCYOGcSipRFHa2JI8acyHMwm1cKxhR4Mk/TAscWtRAB
IwGc4mm9gsZ8aAgvQbFj
=q6CL
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d5014ab.2050...@thykier.net

Re: RFS: 9menu (updated package) (Second try)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-02-06 21:40, Daniel Echeverry wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 1.8-5
> of my package "9menu".
> 
> It builds these binary packages:
> 9menu  - Creates X menus from the shell
> 
> The package appears to be lintian clean.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/9/9menu
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/9/9menu/9menu_1.8-5.dsc
> 
> 
> Fix comment from DACA[1] new service
> 
> [1]:http://qa.debian.org/daca/cppcheck/sid/9menu_1.8-4.html
> 
> I would be glad if someone uploaded this package for me.
> 
> 
> Kind regards
>  daniel echeverry
> 

Uploaded, thanks for your contribution to Debian and sorry for the wait. :)

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNUBb8AAoJEAVLu599gGRCn8EP/2U4FJPp+PhK/rZydrox9TMI
/qAjqkTR25yk1OTYjSeMSXN2OCK9dXJsUNia3tnlu71eopD5ss/Hm2d+4gm+u2DB
ScF8jVqQYaZ1xJytQB2RmYdbqWquA3YPRhaOcA1FJnucHzYD/4L0vDEPRLuZ60Qt
J4kVXo/jo2bvAiAvI1mtx8X6FkN7R3m5fR7pj6CWzeNZGig0i2bW/tR6nKAl6AA0
qAt22EWQXlwK40OvQh/NHaNq+sdbq8cHI0MzmydCjhgzo78ATW4Abl6zanwmyRCP
9/Tst8EGQWw3qrdhRYfDRnaH2QPi0kCOJ8rARyCtBJgJQYWGqdu4P4fznhscmg+p
T/OROAX4FdUp6yRHQS6u1EP8i8yKs8s3kupu/WH/k8faFqh+U5p5nJlggEXgf3Du
vj3HhGVu5AyaNQEGW5SlXupLeHXtUWS9nTfIPzucSu3jjNdEd3tT594Mv0VsEgNT
OZMH81t9h2S7+upsIFhN5Nz2QnEGyzduBkyLgi2WdeXmuZbe3vqxJJX9hcCWu+qR
uZIRSUoXYPHYNQAPUxtFATnULqJl3gI/Nxxzf1iAaifkbrsBodRSTNPZmwDgb35x
0koSM70unHzyUs+un3ewTWjWXOlgjdHHmGysHqw1Q0xAJbWIfttRMJHUkT7qd7Z+
hZuJ1yI9AqHESTcwf16q
=h8ul
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d5016fc.7040...@thykier.net

Re: RFS: mpg321 (updated package, 2nd try)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-02-11 16:17, Nanakos Chrysostomos wrote:
> Dear mentors,
> I am looking for a sponsor for the new version 0.2.13-1 of my package 
> "mpg321".
> 
> It builds these binary packages:
> 
> mpg321 - Simple and lighweight command line MP3 player
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 148971, 196787
> 
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/m/mpg321
> - Source repository: deb-src http://mentors.debian.net/debian unstable main 
> contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/m/mpg321/mpg321_0.2.13-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
> Nanakos Chrysostomos

Hey

I cannot rebuild this in a clean chroot; as far as I can tell it is
trying to regenerate configure/Makefile.in without having all the
required dependencies.
  On a related note; I can build it in a clean chroot if I run:

 touch  configure Makefile.in

Though after building it has created a file called "[config.h].in".

debian/rules:
 - It is missing a call to "dh_prep" in the install target (dh_prep
   replaced dh_clean -k in debhelper 7)
 - Why the "\$(MAKE)" and not just "$(MAKE)" (also in install target)?
 - The CFLAGS in d/rules overrides flags set by dpkg-buildflags, which
   makes it more difficult to rebuild the package with different default
   flags (see man dpkg-buildflags).

Upstream homepage says that newest version is 0.2.12, the package claims
it is 0.2.13.

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNVYKVAAoJEAVLu599gGRCDToP/iNcLGzAJYvbYWHqAK53N7TH
2CNRGWcEu9nut/aktOSUuGmWwLo2PZHWpvFDqjcObAlYYkMI8b5ntcwZ7ezud7j8
u+3IEPnOvPySNUIOCVAMzuDYGPvxJte3Q11Da51EtYEO7yJhz1MP3/Axdvu7g1An
sUCcV+EKfSLNe7UvZTYr5KpcmbylhAZzrgGGaUnDm4YK5m0yHXPx9unWJQd9q6kM
k5bLrOvUi2rRU0lJ9VnzFz6QPFQnPm9yh92+UbhUY1rhwmdiSo+cbuErdZhLrUyt
tsLFkbIRetFeDsbuI0GnEHAs9KAcpxiIOQfq36ONwsQEH6TmuTofpE1hb+OMB6+6
ma4ekqYsGbSl2dNy2Khm1cVexB8tIldARaiH3rtx5LyiL0TFiYRn3UeKh7asN7nA
7YXcTrVw3JwMyU4VLrcM662Bj/iHMNHKE2fOeCFjfynZsWVZJBZTJ+R9bdk/iPDP
U2V3DTsuEl3H4NIFtmWWPerMWjsHd/Sqrag3fmRNjBz8TCTLC3svwdciBrRlK9jX
95wHR+PO/mLHbczdbBiIdjRgbUp/tWDak/RwFhG4w6L1uRrpIA3ozesR61UeZD2/
PbLictdCsyfWEtJwUhW3dbNuZa/DLWVsXWQU2VKEQEA2Ld+NaoR09Ag5kqL3G0lh
4ThbfIeypEPiQJh4HJeu
=nm3e
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d558297.5040...@thykier.net

Re: CFLAGS in d/rules (and Debian policy) [Was: Re: RFS: mpg321 (updated package, 2nd try)]

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-02-12 11:24, Paul Gevers wrote:
>>  - The CFLAGS in d/rules overrides flags set by dpkg-buildflags, which
>>makes it more difficult to rebuild the package with different default
>>flags (see man dpkg-buildflags).
> 
> I see that the example in the Debian policy on build options [1] also
> overrides the flags set by dpkg-buildflags. So is this an example how it
> should NOT be done and should this be changed as well?
> 
> I try to add some option to the CFLAGS, but seem not to be able to do it
> properly without specifying my own CFLAGS. My idea would be that you
> just use """CFLAGS+=some_option_here""" in your d/rules, but trying this
> out just gives me a CFLAGS with only my "some_option_here". So this can
> not be correct. It seems that d/rules does not have any CFLAGS available
> before I set them to any value. I must be overseeing something, so can
> you give an example, in mail or web page link, on how to properly
> implement adding options to CFLAGS in d/rules.
> 
> Kind regards
> Paul
> 
> [1]
> http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules-options
> 

Hey

I believe you can use:

CFLAGS:= $(CFLAGS) some_option_here
if (...)
CFLAGS += some_other_option
endif

Alternatively you can use:

CFLAGS = $(shell dpkg-buildflags --get CFLAGS) some_option_here

But that requires a versioned Build-Depends on dpkg-dev.

That being said, this is one of the places where building via
dpkg-buildpackage and debian/rules binary differs.

As for the policy; it appears that the example might benefit from a
minor update.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNVod8AAoJEAVLu599gGRCvbcP/0TzI0EZ2OZO81k24285EcwC
pCv8j2w/eUNbfqW8ihcqtlxx6nDKFRUPtgWtnG+S2qJ1eaOqHHn+kPl/uQ7WkZIT
VOgcNZZ6wpki3XJEluHkwUDx1ws17vUPbqP2zpl+25G3qrHKloZzA8qu3gYDBQ1M
Ehqsbw6ZIGiNrTtBPEhkCMViK1UXd0cIts4iYu3KZ2YGDLFrWiQcd4OPnIkVW+Ua
JcILESQaZFhwxF+Z3yMyTuXVtUx4bY9P19WJUOpL25t3wsejsSj922llnXflJzJH
YXhd3qExdLprKmL6ijVWB6tpKqo/ob+rlh0UPNyV7Gyz8FPLuynZgkewCUv2ZNhu
FVxMbF+kR4f5BD9J3EndWt5ShypcrqyvsOBcevPr3uK4euPu1bSdqiZrRl0iDg0b
N0ETXv2+jBq3Ad9nvswhYryFsTCYz3CyaTuxSugYgVCs4TMR+5CJmlmElWvRIAQP
Na+5G7rCh+0JYxGzighsY5BtE6ItlYpF3YTpHYUIYkcM0ez6ZbdQN6MCXh+2Ijdt
SQOkLPagwKo0HaqcS9hDMeUgtg5Bi1GMJpNp7nrTA5EmG4OxSziMYZosFfQ0O251
c3K2xPy8nXgUxAWzyuznQkFqtyMWXw/GsjFS0OBR7T29JKX0Dvi7shGmXQPcd669
AA15X67L6uq3Q0gsgC/U
=mzj+
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d56877d.5050...@thykier.net

Re: I'm the new developer on parcellite, but the debian maintainer for it hasn't responded

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-03-10 15:40, doug Springer wrote:
> Hi,
> I started developing parcellite because I didn't want it to disappear
> from the repositories.
> 
> I've been developing parcellite for several months now and have a new
> release that's been tested and packaged to i386 and amd64. I'd like to
> see this make it into main stream.
> 
> Where do I go from here? I'll can take over the maintenance if I need to.
> Thanks,
> Doug Springer
> 
> 

Hey,

I remember parcellite from a while back; as I recall I managed to reach
the maintainer via his other email: andrewsometh...@ubuntu.com
  That being said; the last I heard was that parcellite was being
replaced by a fork, since parcellite was inactive.  Unfortunately the
name of the fork eludes me at the time.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNeSxUAAoJEAVLu599gGRCoI0P/0mBxmKgzZFrI7CIfBeHOIhN
irpKDm0+2LT6UPVU3w5Vx6InJA1lV+sXj6zmpswR0lPNujxJXW7COTA44J74B4W8
Chb8kmx12sqj7C+nijy1HXPV8tLQrsx6MMAs9qnaJUUK0iJXe/jYoVCDW1v1Odst
mnCvcYJ3h7Wg1eBihLVxIWoOwCvB6JxM8fhiLN1aHDaII2EZpPdOL8EMOtGtPQXr
AuVsXeTAyu+9K4IHx0/XXGXc0pVY/axLnrJ1dVgM+ppa/otbHcO9bvY1opXaU+dP
VCJ5GmkyiS2PUHJCPX5GpAL9xRiZ3i/TmIJKtxdn3zz1cr2lwi2mGB8Ja8UIIiO1
/6dZeGk/TYzn5s3HztBYi1DRpsonuGc/TFpHo1feA5BgqsRObbXJ9VDRq8nZypCa
fcerJMPAU9ikg//JFHaaVOyR+Yt4NFz/LxlI8Yntfe9Dvtjq2USvOxdgIp0f1PQt
JMFDVyWme/igWmbbXZANLdPq/pdGG16SFtpdFSJuJLZ9UOd4T7cbCAh9uWLouh/V
M6hwVjnbgRq/qrAKkwji5ORK7c1XoGbHbNw8JGRmAHLbOyL9TVnXrqftlhzkCvq2
b/7LGJYu8HXMEgFNN7KuPN6uChluhc4YuoTk2o+NLn712xahGu7gdL0Ja2q+2K7I
i+5r6+GKXrOzCHm6Y7hc
=hQJV
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d792c55.4010...@thykier.net

Re: I'm the new developer on parcellite, but the debian maintainer for it hasn't responded

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-03-10 21:14, Doug Springer wrote:
> Niels,
> I took over from the original developer, and parcellite is no longer
> inactive.
> 

Hey,

That sounds good.

> There is a fork, it's called clipit, but there were lots of changes
> occurring, and I thought that parcellite (after a few bugs were
> addressed) was just fine as it was. I don't mind simple features, but
> once it looks like klipper, what's the point?
> 

Yes, clipit was the fork I was thinking of.  As pabs mentioned in a
separate email, clipit is currently its own package but there was talk
about replacing parcellite with it.

> My intent it to primarily bug fix/build fix, add bare essentials from
> time to time, and keep parcellite just as it is - but I've sent Andrew
> several emails and no response yet. I figured if he doesn't want to
> maintain it, I'll take over that part as well.
> 
> How do I go about doing that?
> 

As far as I can tell, the maintainer of parcellite is definitely active,
since he uploaded a version of parcellite 5 days ago[1].  I have CC'ed
Andrew, whom I hope will reply within a couple of days.
  If you want an active part in maintaining parcellite, your best option
right is to offer to become a co-maintainership.

[1] http://packages.qa.debian.org/p/parcellite/news/20110306T041708Z.html

> Best Regards,
> Doug Springer
> 
> 
> On 03/10/2011 12:53 PM, Niels Thykier wrote:
> On 2011-03-10 15:40, doug Springer wrote:
>   
>>>> Hi,
>>>> I started developing parcellite because I didn't want it to disappear
>>>> from the repositories.
>>>>
>>>> I've been developing parcellite for several months now and have a new
>>>> release that's been tested and packaged to i386 and amd64. I'd like to
>>>> see this make it into main stream.
>>>>
>>>> Where do I go from here? I'll can take over the maintenance if I need
>>>> to.
>>>> Thanks,
>>>> Doug Springer
>>>>
>>>>
>>>>  
> Hey,
> 
> I remember parcellite from a while back; as I recall I managed to reach
> the maintainer via his other email: andrewsometh...@ubuntu.com
>That being said; the last I heard was that parcellite was being
> replaced by a fork, since parcellite was inactive.  Unfortunately the
> name of the fork eludes me at the time.
> 
> ~Niels
> 
>>

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNed/3AAoJEAVLu599gGRCMIEQAKh2gxbWftckB0/iSkGOcy/v
ItL+CX2/EKKVAJUWS+wrnIihJBu5NQnv2LAp/HQT51h/l1CIbwYA0VnKVZ6lwzuT
Za74JrDcai+AG/e76an2Nuru3UxJGscUVS5UP0WZ82FWBGWneVwn51GOpY6K7HHg
LoMnQaoPQ3MjpfWN8r6tqbMXIAPbbXsmu9S1mHWvWvarNrdan3+xsTlpWccRvr+B
5kgvKbFJjfcROo/nZ4iApD/4Pj6W7M5ujlNjncIYulEJtOpdQHMUU1eX+P/KyB1e
I0wVav15Ego/sbRKBxaZ3izkt1pSxmJAlBfP6kKVJS7Df6X2h1sgzkBpnbRfgyJ5
o7VeAME7ZsczK8JFXiqpdat/DkZODYiBMLQwi2IJ3PwieqorYfp/CyU1299ELcfw
lasbJ9mfTampI/XGE3CIF5no4VJE5GgJJrEzTQ81Dj7FmjvWLy2dwIG8vlm005qg
1GLfXhhCm32SDTkQcFSH9GrIu40hexCAs2IJc51ByUjDJGp28Uh3mKr5PuWKU/de
lVsOFg+P6zBjCojS7E+dVdQnsUH3GJ1MhlZ3hM35Z4T4Yhp6wRoT6dw6skDGk4HL
btG7hul1zpoq2RY7mRpUFQ8P18swGWtbfqWd3gHUMyUrxNnUwA+O88yZLd76foRV
Sh2DKff5MjU64ayQymPn
=CqKP
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d79dff8.6020...@thykier.net

Re: RFS: sciteproj (updated package)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-03-06 14:44, Andreas Ronnquist wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 0.4.01-1
> of my package "sciteproj".
> 
> It builds these binary packages:
> sciteproj  - project manager for the SciTE editor
> 
> The package appears to be lintian clean.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/sciteproj
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/s/sciteproj/sciteproj_0.4.01-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Niels Thykier, who normally uploads this package for me hasn't got the
> possibility to do it this time.
> 
> 
> Kind regards
>  Andreas Rönnquist

Hi,

I am back again and will take care of this. :)

~Niels

PS: Andreas, sorry for the possible double email; I meant it to be an
on-list reply >.>

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNgxMsAAoJEAVLu599gGRCG8gP/0a8E1naqGVZlsAb3a761fks
q7hcIMtJSjQkjeJ78vcsGdvQh78vOfTz3o1DC2bVdG7Y15OuoNVxqT4DgSAolJFc
RNPF2rLMR44q5nSPXk+XIYh+VAyLCTPlzo6eWUckxp0ctWOz26jOkyY/lkmrP9ee
1BGHMFPOWdWexzY48TdEGtHQokhNIMMKWlflGkaOryipBY3zot+9Y9NOqW7/ckxz
L0qDs1um2fQIJ6xqi2G6t9A69fTix9CQSK3syUUBZuPvkX97v2ISAiRKt0+zlNTs
A/uC+UCzz6JOie8CIyKs7rMttUn769ky9Hzokjkk3oCBsU7ttjav8j/itY+x5O+f
RZeSvQSoTrwCnERvTxP3Lo3bry47xJqLGp2oSSOfQaACaNPcUaLG+nrgiL/MCFtN
ZJSYbqmP+Y4xokpuTtISluj96vXjcEyiNKmNoMGlTnhwZ8wQIEXtoTf5pa/2T56C
ALnWG24aF6wSjJWaKISJJzxi10lFjlxl3M/CHqGOwLFsKJgrfdCYV2TCkSG2WfrF
1HGGpsvAGT6UFiaCq3qLkTj7PU7Dxz6BddyW0TPr6N+KsXtdGhe9/HnArDHhLCHA
yHqMkOBql59phbT25oBtn9RPzl0hspJj23+rOvcuGfrIEeOh+uYIj/ofD7DDv/6g
lgvDqxgXdEg+wFK0t/F/
=GTC5
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d83132d.2050...@thykier.net

Re: RFS: lilo (updated package, RC bug fix)

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-03-20 16:18, Joachim Wiedorn wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 1:23.1-2
> of my package "lilo".
> 
> It builds these binary packages:
> lilo   - LInux LOader - the classic OS boot loader
> lilo-doc   - LInux LOader - Documentation for the classic OS boot loader
> 
> [...]

Hey,

I am working with Joachim on this upload (just to avoid duplicate work).

~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNiSsXAAoJEAVLu599gGRCjWcQAKRbhr+RuvM6GFiBxogeRo45
zgUGakJEMvl002kUKgFeZvqcWBsxK9WUzsEv03eWzfC/rHl4z98WiLlxUNXYVjzn
lX+hhJNKnpRoh+lH3cpG2feikTrRindHipd0yNnVFXxcRPv6a4JWm/hjNQznsayz
S22DFNgCX35Y3LA1GL7EzudUCWHy05IkIWvoW2QM5UVPn2BWd7jHaDJExlECPIUk
GH4lXJEm5HwfydZZdb524t4aMQsTDKhmZMOl2y7TAyBonTav5CLSrB2VSn1GP+PB
MKH+mnKMnfX3oZTIvAgz+9RJ2HnYuiH+s+zE47XN/nL5pgQ3h97zhkpHF45L6uw6
SdGA2qXnCHGzM6RqPcfyTAj3qf3oE6LE3tI57SG8t0r7fvQPo4TMwvGirUzrEhmQ
8ueDxDYyIH6eyuT+lT0oJENCfeLkw1QPlL0U4/6YinemC/JLv2Ju7YKoI8YCDJXu
DjBt9jwDJ7b319P7JNyFyS/fKd8KbOthVLRdFgVEmvGy68tTb0QIR+ivVR/tSssS
rnW0AW3DYbCt4DHl2Sr89ULfslHUh8nTQTU34sgNvFTyqy4mMyzilicZF53JlKmb
5xHLDuBHrQMX4NEiJtv+KyleDmBksCvJ1yX7W98IetRI7f1ihUQ0FvddYN/Jxg5z
MtpLaVWCHiTRUwFfE10k
=Fvwn
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d892b18.1060...@thykier.net

Re: Help with lintian

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-04-02 10:11, Chris Carr wrote:
> Hi all,
> 
> I'm puzzled by this warning from lintian:
> 
> chrisc@xaphod:/var/cache/pbuilder/result$ lintian -Ivi --pedantic
> angband_3.2.0-1_i386.changes 
> N: Setting up lab in /tmp/esv0j1oUBP ...
> N: Processing 3 packages...
> N: 
> N: Processing changes file angband_3.2.0-1_i386 (version 1:3.2.0-1) ...
> N: 
> N: Processing source package angband (version 1:3.2.0-1) ...
> P: angband source:
> direct-changes-in-diff-but-no-patch-system .gitmodules and 7 more
[...]
> 
> ... is it possible to configure lintian to ignore .git*, like the -i
> option to dpkg-buildpackage?
> 
> Thanks,
> 
> CC
> 
> 

Hi

Generally the diff ought not to include ".gitmodules" in the first place
if you did not intend for it (and the 7 other files) to be there.
  Most likely dpkg-source/dpkg-buildpackage with -i is not enough in
this case.  I believe [1] would solve your issue; maybe with a wishlist
bug against dpkg-dev asking for the vcs-related files to be ignored by
default.

Note: you should generally only ignore the files that are vcs-related or
auto-generated files, so please review the changes to files if they are
not clearly related to git (etc.).  If you deliberately modified one of
upstreams files, you should not ignore/filter that change.

~Niels

[1]
http://raphaelhertzog.com/2011/01/28/3-ways-to-not-clutter-your-debian-source-package-with-autogenerated-files/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNluGTAAoJEAVLu599gGRCKCYP/1ntylkLTOky6md0x2Se45n3
VhAG0nEJDL8oMQZ4IqBQ6kszMFzj5YEu96glXwLcpX5ZGR61nOqEX7BuMZzTSQMm
l+eTPZBumE6bMfCBzK9fPlf0YoEG+vMghc8g7yT3MIXAXbVcffyUP+VGq2KQ9NRm
Mp7ovYWyk0Wpx7jPBbELJ219OweTkMgqm/NEbI726OORSdcm+rYQ7ELxqKJdYBb7
xGJoFBzUaQLHUha7y5Z2SUqLIQKxtVitjD9cGhPtMMLSfSTw+gfDTd/nOBbJzkB/
SdzSpKREmofZ7V4vOJnu4gKNzLyqVaXDLKt2RhiK02YRk6+oesckDCNw9TTlFmwr
3VhfN5VynoscwUkUSMEeV6W5QsKUmWposUO8GkJrLrTB9Dhgfk/jdGJOLINR/S65
85O9MKJxhbifW47mM2JRpDW9rr1zzKlJpVOt/2DcuWDIdA8gOx/lNgsqBIRaKSaS
B9085J/W66MRC7tU8GN8BD5IpCn59up7R2cTOp9W2d84I26X+UvHBY2W5CBC/8Xr
4q32UAffdxVxV/6JjRKqf1akYUAkMsF9XFKFBD14DPcOq4TbFaJiebs+TYKYdrld
GsWTvjmYHpBJ9GOHiMCGuX0CxmD7jUuR38xOvblofiahQzd7kgUtJ5sGOi0osecB
xF/b0C8Ci5kFBPhDK77X
=TPI9
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d96e194.1070...@thykier.net

Re: How are directories managed.

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-04-12 03:56, Paul Elliott wrote:
> 
> This may be a FAQ but I could not find the answer in the documentation:
> 
> How are directories managed? When does a directory get deleted? What is the 
> lifetime of a directory? Is a directory owned by a specific package?
> 
> Which packages are alowed to deposit files in a specific directory? What 
> exactly 
> are the rules?
> 

Hi

I think it is easier for us to answer your question if you can be a
little more specific on what you want to know/do.  Depending on what you
are trying to do the answer may be covered by the Policy, FHS or/and the
interface of certain packages (e.g. like installing files into
/etc/apt/apt.conf.d/).

> If a package wants to put files in a directory, how does the package "know" 
> that the directory will live longer than the file?
> 

Assuming your question is something like:
  "If pkgA installs a file A as /some/where/A, how can pkgA know that A
   is not removed before pkgA is removed/uninstalled?"

If we take the very simple case for a moment, then this is given that A
will exist as long as pkgA is installed.  dpkg will not remove
directories as long as a file exists in it.
  Extending it a bit, the file A can legally be renamed using
dpkg-divert.  If another package uses dpkg-divert to move A, then said
package is expected to provide a replacement for A that keeps pkgA
functional.  Otherwise, the diversion can be done by the system
administrator; in this case the sysadmin is expected to know what he/she
is doing.

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNpEGfAAoJEAVLu599gGRCpXcP/2jitRJoQ1kg7iszl04n9uau
XFjsXFQmq18gG9pO0S+33H39/LpNfodnW+Zx/F1L5VrEPpZBT3tnLQYf+enwfRur
+N1yjAL+HyU40HrhRWmm5t7GnUi0s3OVSyNb5TljXgaGdmgGAih7dLpMvzG8hugU
bc4/dswPFMltO/3l0AJE26GztKbnfwNyeSSToN1G9kb3pJcetZfvaeodzh8PRBzw
ByMdPEq3tq4TXuF+jhSBy2yNxeycG2HvcZdDXA8JagXoX8J150c8Vcj3nztvHnOU
WMP4VBrvQL0j6uT4a05m1Ey730lmogspOozSUiuH0MCS1RL54eXarZj++ZjLSkBz
7sykoUYcXDjtq8aFELMjc28Ih56lQZBB9aWrRwDDE4Bvb2Q9D3Vv8wjpSuQfEgSG
kfZYOt/CuyXou0gR/7HQThYI2K8BVaVy4pRm/d/oq4+yL8xZBrKRRK7MnphTtbiq
+jgIItQ5ZfEdyUv2jZHLX4TBYMqFwat3RWDSanCJNa4JFg2LbuGNCqP0WKgMvvJf
yFRjeC0dVdTgDHzNC9CqdmqD1NlaQnyGaCf/OVD3jDKW4Mp6TnNb88cefLSUcdNs
DSCUlBNJWekM2Ba1Ayz+jepCdwlAwh9+gKwDoscSx4cWrxkDmnMyWJTykIfcNwuz
YgrRkdqTsLmiuDTIr9v6
=q7Jh
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4da4419f.6050...@thykier.net

Re: RFS: nautilus-image-manipulator

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2011-04-14 22:27, Emilien Klein wrote:
> [...]
> 
> Also, I have installed Squeeze in a VM. Since running the packaging in
> Debian directly, Lintian is not complaining anymore about using a too
> recent Standards-Version. With that, all 3 of Julien's initials
> comments [0] have now been addressed, and the package is now looking
> good!
> 

Just so you know, Lintian should complain about your Standards-Version
these days.  None of the released versions of Lintian currently in
Debian (2.5.0~rc2 or older) knows of the newest Standards-Version 3.9.2.
 It is scheduled for the next upload of Lintian, but until then you
should see a newer-standards-version.

> Can you please check my updated package [1]? Thanks!
> 
> Cheers!
> +Emilien
> 
> [0] http://lists.debian.org/debian-mentors/2011/03/msg00384.html
> [1] http://mentors.debian.net/debian/pool/main/n/nautilus-image-manipulator/
> 
> 

~Niels

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNp2OQAAoJEAVLu599gGRCWjwP/3JnJSKmNRDOtQ+zaMzgZrvK
GlnO0uEMxnpDPBrtx8MvoJ3mTceqcwxQSrC4v+6B87iaCGpLGixvP85FHfDQAlnX
NHOA0nAaPu2pUlmiQqOLkxa0W1CImepx3aG6eCFK7GvO71yKjcmv33lBLCXp0lFA
b0xi28nB+vY5fcETJICAebSVw3rtbhQOb1kFYiMA2A8AsLfu4YB30LZBCiNaO/Vi
qrI6tzqDXYbEQ+YhDbONGUSpXlw5weJ1kTs9ahErBIB4r5zPlOJF/Z3fWaxFdTSk
x8HiLL3Unl4AEqMx0iz/f3SmDGdS3jUgtiN0eDZ48UyPU/G8QMTttFL2+CvKQVPw
MiJ899v4+FuC8lPzL0nc5/U9ozWSuMXEwwWqBkYULcHfZ5DnpyTaQ7GWo4ul8JJm
7/B5Odm/QdcNSJrcrXcW9Dn6Gr0+GhZFFuU+UZP0X9w3wCyhtSbzA3i8phy3r58P
lN8prL+O5oietGT0Y3AcmPAug28/wNpuzvHSTGqGx+ZgVDJMa0Vp5+KbcjASxt+I
UjHjbC27LiNbh+OSUBQB2wC5njGZq39InQCAlynO2CQuk6pOZN68/zBh/Zev6c44
qRwF/vnbacWETM5ZlJYku4i4YH7zqwRKYARJC423OIk1VQrGsbWzviSHQwTmDx/r
2XzkSWwbJ5h5VFOxacRh
=EdFX
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4da76391.6020...@thykier.net