labath wrote:
> This was what we were doing in the [initial
> PR](https://github.com/llvm/llvm-project/pull/98528/files#diff-20a2060f8e87c6742d6f2c7ae97e919f8485995d7808bd9fccbfbede697a9ec7)
> but Pavel had correctly pointed out that the architecture was unnecessarily
> "baroque". GIven there
@@ -397,21 +413,23 @@ def connect_to_debug_monitor(self, attach_pid=None):
# Schedule debug monitor to be shut down during teardown.
logger = self.logger
-connect_attemps = 0
+connect_attempts = 0
MAX_CONNECT_ATTEMPT
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -81,9 +81,12 @@ class ObjectFile : public
std::enable_shared_from_this,
enum BinaryType {
eBinaryTypeInvalid = 0,
eBinaryTypeUnknown,
-eBinaryTypeKernel,/// kernel binary
-eBinaryTypeUser, /// user process binary
-eBinaryTypeStandalone /// sta
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5669,6 +5673,10 @@ bool ObjectFileMachO::GetCorefileMainBinaryInfo(addr_t
&value,
type = eBinaryTypeStandalone;
typestr = "standalone";
break;
+ case 4:
+type = eBinaryTypeUserAllImageInfos;
+typestr = "u
kastiglione wrote:
@jimingham does this seem ok to you?
https://github.com/llvm/llvm-project/pull/119977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> > A random idea, I don't know if it's a good one: have one object
> > (LockableStreamPair?) that holds the two streams and their mutex. One less
> > argument to pass around?
>
> Sounds good, that simplifies the signatures (which this PR is already
> touching) and keeps t
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/127156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -11,6 +11,9 @@ set(LLDB_LIBEDIT_LIBS)
if (LLDB_ENABLE_CURSES)
list(APPEND LLDB_CURSES_LIBS ${PANEL_LIBRARIES} ${CURSES_LIBRARIES})
+ if(NOT CURSES_HAS_TINFO)
+list(APPEND LLDB_CURSES_LIBS ${TINFO_LIBRARIES})
+ endif()
ajordanr-google wrote:
I think
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
@@ -11,6 +11,9 @@ set(LLDB_LIBEDIT_LIBS)
if (LLDB_ENABLE_CURSES)
list(APPEND LLDB_CURSES_LIBS ${PANEL_LIBRARIES} ${CURSES_LIBRARIES})
+ if(NOT CURSES_HAS_TINFO)
+list(APPEND LLDB_CURSES_LIBS ${TINFO_LIBRARIES})
+ endif()
JDevlieghere wrote:
How about
rchamala wrote:
Note that currently, I am returning failure if a wrong type is passed in to the
dictionary via "get_loaded_images" or if "load_addr" is missing even for one
module. Once the type checks are done, I am conditionally ignoring module load
errors.
https://github.com/llvm/llvm-proj
https://github.com/rchamala edited
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rchamala edited
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/5] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106907
>From aeb8854bbe7695e576257c8403e04d4b8268b679 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 13:48:41 +0100
Subject: [PATCH 01/10] Add: show return value on step out
---
lldb/tools/lldb-dap
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/3] [lldb] Add terminfo dependency for ncur
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/5] [lldb] Add terminfo dependency for ncur
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/4] [lldb] Add terminfo dependency for ncur
ajordanr-google wrote:
Tested with a system that has bundled terminfo in curses and one without
locally!
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
Author: Jonas Devlieghere
Date: 2025-02-14T22:28:42-08:00
New Revision: 776fa2d731c17d6ba0afad2554ebc89cf5e3e5ef
URL:
https://github.com/llvm/llvm-project/commit/776fa2d731c17d6ba0afad2554ebc89cf5e3e5ef
DIFF:
https://github.com/llvm/llvm-project/commit/776fa2d731c17d6ba0afad2554ebc89cf5e3e5ef.d
@@ -7574,7 +7574,9 @@ IOHandlerCursesGUI::IOHandlerCursesGUI(Debugger &debugger)
void IOHandlerCursesGUI::Activate() {
IOHandler::Activate();
if (!m_app_ap) {
-m_app_ap = std::make_unique(GetInputFILE(), GetOutputFILE());
+m_app_ap = std::make_unique(
--
@@ -500,19 +502,16 @@ bool
CommandObjectExpression::EvaluateExpression(llvm::StringRef expr,
void CommandObjectExpression::IOHandlerInputComplete(IOHandler &io_handler,
std::string &line) {
io_handler.SetIsDone(true);
- S
oontvoo wrote:
> > The (baroque) way that the other plugins work serves two purposes:
> >
> > 1. controlling the type (class) of the plugin being created based on some
> > runtime property
> > 2. creating an arbitrary number of plugin instances
> >
> > For telemetry "plugins", I don't think we
https://github.com/jimingham approved this pull request.
Ack, sorry I missed this...
This is fine. You won't miss the fact that you should have overridden it to
return false when you meant true, since then you'll get asked to make children
but you can't. So having a default implementation sh
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126757
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH 1/4] Addressed additional review comments from PR/119716.
---
lldb/
Author: Jonas Devlieghere
Date: 2025-02-14T22:11:03-08:00
New Revision: ed32d85d31999756602a7d5c4647cb6771d8f857
URL:
https://github.com/llvm/llvm-project/commit/ed32d85d31999756602a7d5c4647cb6771d8f857
DIFF:
https://github.com/llvm/llvm-project/commit/ed32d85d31999756602a7d5c4647cb6771d8f857.d
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks for bearing with me!
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/sga-sc edited
https://github.com/llvm/llvm-project/pull/127100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Let's see what @medismailben has to say, but I think it would be fine to
"ignore" (meaning, to continue trying to load other modules) load errors even
without the special flags, as I think that's how our non-scripted processes
work (do they?)
https://github.com/llvm/llvm-project
mstorsjo wrote:
> For the record, this PR was finally re-landed as #126988 after four separate
> commits to address issues found in CI testing when I originally merged this.
FWIW, it looks like my smoke tests are still passing fine after these changes
have been relanded now:
https://github.co
https://github.com/sga-sc updated
https://github.com/llvm/llvm-project/pull/127100
>From 1fdc2f811c239bc8992fba9aa8e3d4eb9c76e96a Mon Sep 17 00:00:00 2001
From: Georgiy Samoylov
Date: Thu, 6 Feb 2025 13:23:13 +0300
Subject: [PATCH 1/2] [lldb] Fixed a typo
---
.../test/tools/lldb-server/gdbrem
@@ -1973,6 +1973,27 @@ class DWARFASTParserClang::DelayedAddObjCClassProperty {
ClangASTMetadata m_metadata;
};
+static clang::APValue MakeAPValue(CompilerType clang_type, uint64_t bit_width,
+ uint64_t value) {
+ bool is_signed = false;
+
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/127206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -343,6 +343,22 @@ def get_target_byte_order(self):
target = self.dbg.CreateTarget(inferior_exe_path)
return target.GetByteOrder()
+def is_port_opened(self):
+connect_port = self.port
+
+err, retcode, cmd_output = self.run_platform_com
@@ -343,6 +343,22 @@ def get_target_byte_order(self):
target = self.dbg.CreateTarget(inferior_exe_path)
return target.GetByteOrder()
+def is_port_opened(self):
+connect_port = self.port
+
+err, retcode, cmd_output = self.run_platform_com
labath wrote:
Good question. I think I could use it in immediately in #126526 if I make the
result exact (return the precise set of ranges instead of the high/low water
mark). Let me see how that would look like.
https://github.com/llvm/llvm-project/pull/123622
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/127206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -343,6 +343,22 @@ def get_target_byte_order(self):
target = self.dbg.CreateTarget(inferior_exe_path)
return target.GetByteOrder()
+def is_port_opened(self):
+connect_port = self.port
+
+err, retcode, cmd_output = self.run_platform_com
@@ -397,21 +413,23 @@ def connect_to_debug_monitor(self, attach_pid=None):
# Schedule debug monitor to be shut down during teardown.
logger = self.logger
-connect_attemps = 0
+connect_attempts = 0
MAX_CONNECT_ATTEMPT
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/127206
This patch adds support for the recently added
`clang::TemplateArgument::ArgKind::StructuralValue`
(https://github.com/llvm/llvm-project/pull/78041). These are used for non-type
template parameters such as
@@ -397,21 +413,23 @@ def connect_to_debug_monitor(self, attach_pid=None):
# Schedule debug monitor to be shut down during teardown.
logger = self.logger
-connect_attemps = 0
+connect_attempts = 0
MAX_CONNECT_ATTEMPT
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch adds support for the recently added
`clang::TemplateArgument::ArgKind::StructuralValue`
(https://github.com/llvm/llvm-project/pull/78041). These are used for non-type
template parameters such a
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/127206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
134a94ae0b6cb8dccf1114fb2eefb172e9697905...759f0569807d00a059a78aeb3bd1eddeffcbdf36
lldb/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/2] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/3] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
@@ -91,7 +91,7 @@ lldb::ChildCacheState GenericBitsetFrontEnd::Update() {
size_t size = 0;
if (auto arg = m_backend.GetCompilerType().GetIntegralTemplateArgument(0))
-size = arg->value.getLimitedValue();
+size = arg->value.getInt().getLimitedValue();
--
@@ -1973,6 +1973,27 @@ class DWARFASTParserClang::DelayedAddObjCClassProperty {
ClangASTMetadata m_metadata;
};
+static clang::APValue MakeAPValue(CompilerType clang_type, uint64_t bit_width,
+ uint64_t value) {
+ bool is_signed = false;
+
labath wrote:
> > I do want to spend some time discussing the relationship between stdout and
> > stderr. The current implementation uses a separate mutex for each stream,
> > which is not _un_reasonable, but I can see at least two other possible
> > philosophies:
> >
> > 1. Since both of the
@@ -397,21 +413,23 @@ def connect_to_debug_monitor(self, attach_pid=None):
# Schedule debug monitor to be shut down during teardown.
logger = self.logger
-connect_attemps = 0
+connect_attempts = 0
MAX_CONNECT_ATTEMPT
Author: Michael Buch
Date: 2025-02-14T10:26:47Z
New Revision: 134a94ae0b6cb8dccf1114fb2eefb172e9697905
URL:
https://github.com/llvm/llvm-project/commit/134a94ae0b6cb8dccf1114fb2eefb172e9697905
DIFF:
https://github.com/llvm/llvm-project/commit/134a94ae0b6cb8dccf1114fb2eefb172e9697905.diff
LOG:
@@ -1973,6 +1973,27 @@ class DWARFASTParserClang::DelayedAddObjCClassProperty {
ClangASTMetadata m_metadata;
};
+static clang::APValue MakeAPValue(CompilerType clang_type, uint64_t bit_width,
+ uint64_t value) {
+ bool is_signed = false;
+
https://github.com/labath approved this pull request.
Looks good. Thanks. (But be sure to wait for Jonas since he clicked the
"request changes" button)
https://github.com/llvm/llvm-project/pull/127100
___
lldb-commits mailing list
lldb-commits@lists.l
@@ -397,21 +413,23 @@ def connect_to_debug_monitor(self, attach_pid=None):
# Schedule debug monitor to be shut down during teardown.
logger = self.logger
-connect_attemps = 0
+connect_attempts = 0
MAX_CONNECT_ATTEMPT
JDevlieghere wrote:
> The (baroque) way that the other plugins work serves two purposes:
>
> 1. controlling the type (class) of the plugin being created based on some
> runtime property
> 2. creating an arbitrary number of plugin instances
>
> For telemetry "plugins", I don't think we want/nee
JDevlieghere wrote:
> I guess so, but I think we're drawing different conclusions. My take on this
> is that if the only thing we get from locking stderr is the ability to
> mutually exclude two stderr accesses, then maybe we don't need to bother with
> locking stderr at all.
That's what I un
@@ -1973,6 +1973,27 @@ class DWARFASTParserClang::DelayedAddObjCClassProperty {
ClangASTMetadata m_metadata;
};
+static clang::APValue MakeAPValue(CompilerType clang_type, uint64_t bit_width,
+ uint64_t value) {
+ bool is_signed = false;
+
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/4] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
ashgti wrote:
@JDevlieghere Any thoughts on the server mode?
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mgorny approved this pull request.
https://github.com/llvm/llvm-project/pull/127100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rchamala edited
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> How would that work? We'd check the value of the passed-in `FILE*` and choose
> a mutex based on whether it happens to be `stdout` ? I don't think I'd like
> that for several reasons:
>
> * it doesn't handle the case where `stdout/err` is redirected externally (it
> stil
sga-sc wrote:
Thank you for a review, guys, can you merge it, please? I don't have merge
rights
https://github.com/llvm/llvm-project/pull/127100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/127100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Georgiy Samoylov
Date: 2025-02-14T10:39:23-08:00
New Revision: 1042bd79722a08b989e034c644c35f3a4556d83c
URL:
https://github.com/llvm/llvm-project/commit/1042bd79722a08b989e034c644c35f3a4556d83c
DIFF:
https://github.com/llvm/llvm-project/commit/1042bd79722a08b989e034c644c35f3a4556d83c.di
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/127100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > How would that work? We'd check the value of the passed-in `FILE*` and
> > choose a mutex based on whether it happens to be `stdout` ? I don't think
> > I'd like that for several reasons:
> >
> > * it doesn't handle the case where `stdout/err` is redirected externally
> > (i
wangleiat wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/124059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/6] [lldb] Add terminfo dependency for ncur
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
Author: Jordan R AW
Date: 2025-02-14T21:37:39-08:00
New Revision: 8fff0c181f26a5e8b2344c061ebf2559118b1160
URL:
https://github.com/llvm/llvm-project/commit/8fff0c181f26a5e8b2344c061ebf2559118b1160
DIFF:
https://github.com/llvm/llvm-project/commit/8fff0c181f26a5e8b2344c061ebf2559118b1160.diff
L
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
78 matches
Mail list logo
