[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

[Jonas Devlieghere via lldb-commits]

================
@@ -81,9 +81,12 @@ class ObjectFile : public 
std::enable_shared_from_this<ObjectFile>,
   enum BinaryType {
     eBinaryTypeInvalid = 0,
     eBinaryTypeUnknown,
-    eBinaryTypeKernel,    /// kernel binary
-    eBinaryTypeUser,      /// user process binary
-    eBinaryTypeStandalone /// standalone binary / firmware
+    eBinaryTypeKernel,            /// kernel binary
+    eBinaryTypeUser,              /// user process binary,
+                                  /// dyld addr
+    eBinaryTypeUserAllImageInfos, /// user process binary,
+                                  /// dyld_all_image_infos addr
+    eBinaryTypeStandalone         /// standalone binary / firmware
----------------
JDevlieghere wrote:

```suggestion
    /// kernel binary
    eBinaryTypeKernel, 
    /// user process binary, dyld addr
    eBinaryTypeUser,        
    /// user process binary, dyld_all_image_infos addr
    eBinaryTypeUserAllImageInfos, 
    /// standalone binary / firmware
    eBinaryTypeStandalone         
```

Doxygen requires `///<` for inline comments like this. I don't know how that 
works with multiline commetns and given our 80 col limit, documenting them 
above the value is more readable anyway. 

https://github.com/llvm/llvm-project/pull/127156
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits