github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/HemangGadhavi converted_to_draft
https://github.com/llvm/llvm-project/pull/126484
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi closed
https://github.com/llvm/llvm-project/pull/126484
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath commented:
After thinking about this more, I think I'd like to remove the parts related to
accessing global variables from this patch. I have two reasons for that:
- it's not required functionality for the minimum viable product (which is
replacing "frame variable") as
@@ -0,0 +1,101 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,106 @@
+//===-- DILEval.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,308 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,308 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -511,22 +514,57 @@ ValueObjectSP
StackFrame::GetValueForVariableExpressionPath(
VariableSP &var_sp, Status &error) {
ExecutionContext exe_ctx;
CalculateExecutionContext(exe_ctx);
+
bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx);
+
if (use_DIL)
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building
`lldb,llvm` at step 7 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/73/builds/12955
Here is t
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,308 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
Could not understand the right fix. Better it to leave it.
https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I also looked at this but got into a rabbit hole finding out whether you could
have channel specific invites. I think you can, but I don't think it actually
helps us. As the other problem we have had is invites expiring, so the fewer
unique invite links the better.
https:
@@ -262,9 +269,11 @@ CommandObjectDisassemble::GetContainingAddressRanges() {
addr, eSymbolContextEverything, sc, resolve_tail_call_address);
if (sc.function || sc.symbol) {
AddressRange range;
- sc.GetAddressRange(eSymbolContextFunction | eSymbolContextS
@@ -82,20 +82,25 @@
# CHECK-NEXT: (lldb) disassemble --name case2
# CHECK-NEXT: command-disassemble.s.tmp`n1::case2:
# CHECK-NEXT: command-disassemble.s.tmp[0x2044] <+0>: int$0x32
-# CHECK-NEXT: warning: Not disassembling a range because it is very large
[0x204
@@ -82,20 +82,25 @@
# CHECK-NEXT: (lldb) disassemble --name case2
# CHECK-NEXT: command-disassemble.s.tmp`n1::case2:
# CHECK-NEXT: command-disassemble.s.tmp[0x2044] <+0>: int$0x32
-# CHECK-NEXT: warning: Not disassembling a range because it is very large
[0x204
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/126505
The command already supported disassembling multiple ranges, among other
reasons because inline functions can be discontinuous. The main thing that was
missing was being able to retrieve the function ranges from
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The command already supported disassembling multiple ranges, among other
reasons because inline functions can be discontinuous. The main thing that was
missing was being able to retrieve the function ranges fr
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff aebe6c5d7f88a05a29ef6c643482ca7eaf994b19
96957acfb6847343df50a641c6de03199c924f72 --e
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/126526
>From fda9035cddce78e2109462c9cec176bcb96392d8 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 10 Feb 2025 15:20:05 +0100
Subject: [PATCH] [lldb] Fixing edge cases in "command source"
While looking at how
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
While looking at how to make Function::GetEndLineSourceInfo (which is only used
in "command source") work with discontinuous functions, I realized there are
other corner cases that this function doesn't handle
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/126526
While looking at how to make Function::GetEndLineSourceInfo (which is only used
in "command source") work with discontinuous functions, I realized there are
other corner cases that this function doesn't handle.
@@ -262,9 +269,11 @@ CommandObjectDisassemble::GetContainingAddressRanges() {
addr, eSymbolContextEverything, sc, resolve_tail_call_address);
if (sc.function || sc.symbol) {
AddressRange range;
- sc.GetAddressRange(eSymbolContextFunction | eSymbolContextS
@@ -82,20 +82,25 @@
# CHECK-NEXT: (lldb) disassemble --name case2
# CHECK-NEXT: command-disassemble.s.tmp`n1::case2:
# CHECK-NEXT: command-disassemble.s.tmp[0x2044] <+0>: int$0x32
-# CHECK-NEXT: warning: Not disassembling a range because it is very large
[0x204
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/126526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -784,14 +784,12 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (sc.block == nullptr) {
// Not an inlined function
-sc.function->GetStartLineSourceInfo(start_file, start_line);
-if (start_line == 0) {
- result.Appen
https://github.com/JDevlieghere commented:
Makes sense. Seems like a more-than-fair tradeoff between correctness and
performance.
https://github.com/llvm/llvm-project/pull/126526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
oontvoo wrote:
@JDevlieghere Hi, do you have any further comment/feedback on this? If not, I
plan to merge the PR this afternoon. Thanks!
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
JDevlieghere wrote:
> Looks like
> `lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py`
> was deleted entirely. Was this intentional?
Yes, because this replaces the old in-line progress printing. The statusline
still trims messages that don't fit and progress isn
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
@@ -21,21 +23,28 @@ namespace lldb_dap {
/// The file is destroyed when the destructor is invoked.
struct FifoFile {
FifoFile(llvm::StringRef path);
+ FifoFile(llvm::StringRef path, FILE *f);
+ FifoFile(FifoFile &&other);
+
+ FifoFile(const FifoFile &) = delete;
+ FifoFil
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
@@ -158,13 +156,25 @@ std::string
RunInTerminalDebugAdapterCommChannel::GetLauncherError() {
}
Expected> CreateRunInTerminalCommFile() {
+ int comm_fd;
SmallString<256> comm_file;
- if (std::error_code EC = sys::fs::getPotentiallyUniqueTempFileName(
- "lldb-dap-
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/126505
>From a716420ee79ea03cd64cf79f1e1f727b86960995 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 9 Jan 2025 13:02:24 +0100
Subject: [PATCH] [lldb] Support disassembling discontinuous functions
The command a
@@ -2367,11 +2370,27 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -82,20 +82,25 @@
# CHECK-NEXT: (lldb) disassemble --name case2
# CHECK-NEXT: command-disassemble.s.tmp`n1::case2:
# CHECK-NEXT: command-disassemble.s.tmp[0x2044] <+0>: int$0x32
-# CHECK-NEXT: warning: Not disassembling a range because it is very large
[0x204
https://github.com/DavidSpickett commented:
Negative offset makes sense to me given that it's relative to the symbol of the
function. Will be interesting to see how users interpret it though.
https://github.com/llvm/llvm-project/pull/126505
___
lldb-c
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/126505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -262,9 +269,11 @@ CommandObjectDisassemble::GetContainingAddressRanges() {
addr, eSymbolContextEverything, sc, resolve_tail_call_address);
if (sc.function || sc.symbol) {
AddressRange range;
- sc.GetAddressRange(eSymbolContextFunction | eSymbolContextS
@@ -82,20 +82,25 @@
# CHECK-NEXT: (lldb) disassemble --name case2
# CHECK-NEXT: command-disassemble.s.tmp`n1::case2:
# CHECK-NEXT: command-disassemble.s.tmp[0x2044] <+0>: int$0x32
-# CHECK-NEXT: warning: Not disassembling a range because it is very large
[0x204
Michael137 wrote:
> @Michael137 Changed the first argument of `computeEnumBits` to an `ArrayRef`
> to avoid the template and so it can be still seamlessly used from Sema. On
> LLDB side, I had to create a `SmallVector` and put enum constants there at
> the point of their creation (`AddEnumerat
jimingham wrote:
"command source" is another lldb command which this PR is not about...
https://github.com/llvm/llvm-project/pull/126526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -320,25 +320,37 @@ void Function::GetStartLineSourceInfo(SupportFileSP
&source_file_sp,
}
}
-void Function::GetEndLineSourceInfo(FileSpec &source_file, uint32_t &line_no) {
- line_no = 0;
- source_file.Clear();
-
- // The -1 is kind of cheesy, but I want to get the la
@@ -784,14 +784,12 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (sc.block == nullptr) {
// Not an inlined function
-sc.function->GetStartLineSourceInfo(start_file, start_line);
-if (start_line == 0) {
- result.Appen
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Nobody is overriding GetValueProperties, so in practice we're always using
`m_collection_sp`, which means we don't need to check the pointer. The temlated
helpers were already operating on `m_collec
Author: Kazu Hirata
Date: 2025-02-10T15:54:57-08:00
New Revision: 622b8edfc2485b21802778d1f4ae7aed340e
URL:
https://github.com/llvm/llvm-project/commit/622b8edfc2485b21802778d1f4ae7aed340e
DIFF:
https://github.com/llvm/llvm-project/commit/622b8edfc2485b21802778d1f4ae7aed340e.diff
L
kazutakahirata wrote:
@oontvoo I've checked in 622b8edfc2485b21802778d1f4ae7aed340e to fix a
warning. I've put `[[maybe_unused]]` instead of removing the function,
guessing that you might use this function in subsequent patches.
https://github.com/llvm/llvm-project/pull/119716
___
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/126583
Nobody is overriding GetValueProperties, so in practice we're always using
`m_collection_sp`, which means we don't need to check the pointer. The temlated
helpers were already operating on `m_collection_sp
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/126588
Details:
Upstream in LLDB, we will have a default TelemetryVendor plugin will provide a
default Config and NULL TelemetryManager. Downstream vendors can extend this to
provide a vendor-specific Config along wi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Details:
Upstream in LLDB, we will have a default TelemetryVendor plugin will provide a
default Config and NULL TelemetryManager. Downstream vendors can extend this to
provide a vendor-specific Config along wit
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/126598
Add a test for the term-width and term-height settings.
>From 6a12b9282228b24691dfcd4d8ec4d2b240747f54 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 10 Feb 2025 12:58:00 -0800
Subject: [PATCH
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add a test for the term-width and term-height settings.
---
Full diff: https://github.com/llvm/llvm-project/pull/126598.diff
1 Files Affected:
- (added) lldb/test/API/driver/terminal/TestTerminalD
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/126598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 01/15] Implement LLDB Telemetry (Part 1)
This contains only the conc
Author: Vy Nguyen
Date: 2025-02-10T13:59:52-05:00
New Revision: 50317ca13f6ad9b2196f92f8c719f5c31e5d6812
URL:
https://github.com/llvm/llvm-project/commit/50317ca13f6ad9b2196f92f8c719f5c31e5d6812
DIFF:
https://github.com/llvm/llvm-project/commit/50317ca13f6ad9b2196f92f8c719f5c31e5d6812.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/keith created
https://github.com/llvm/llvm-project/pull/126580
None
>From bb41fdf6021c7a62bf77096bc4ce31e8e9311577 Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Mon, 10 Feb 2025 19:00:31 +
Subject: [PATCH] [lldb-dap] Silence Wunused-result warning
---
lldb/tools/ll
keith wrote:
showed up since
https://github.com/llvm/llvm-project/commit/adb9ef035552d7fc42a34560677f89f4f6421295
https://github.com/llvm/llvm-project/pull/126580
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Keith Smiley (keith)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/126580.diff
1 Files Affected:
- (modified) lldb/tools/lldb-dap/OutputRedirector.cpp (+1-1)
``diff
diff --git a/lldb/tools/lldb-dap/OutputRe
keith wrote:
```
lldb/tools/lldb-dap/OutputRedirector.cpp:89:5: error: ignoring return value of
function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
89 | ::write(fd, buf, sizeof(buf));
| ^~~
1 error generated.
```
https://gith
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/126590
Both the default value and the min/max value are within LLDB's control, so an
assert is more appropriate than a runtime check.
>From 4c2391af01c626719de14aa975988df921b5bfd7 Mon Sep 17 00:00:00 2001
From:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Both the default value and the min/max value are within LLDB's control, so an
assert is more appropriate than a runtime check.
---
Full diff: https://github.com/llvm/llvm-project/pull/126590.diff
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/126630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -7574,7 +7574,9 @@ IOHandlerCursesGUI::IOHandlerCursesGUI(Debugger &debugger)
void IOHandlerCursesGUI::Activate() {
IOHandler::Activate();
if (!m_app_ap) {
-m_app_ap = std::make_unique(GetInputFILE(), GetOutputFILE());
+m_app_ap = std::make_unique(
--
https://github.com/bulbazord commented:
Overall looks fine, kind of terrified of the number of unguarded `fprintf`
calls in Editline, but maybe it's fine?
https://github.com/llvm/llvm-project/pull/126630
___
lldb-commits mailing list
lldb-commits@list
@@ -393,7 +394,7 @@ void Editline::MoveCursor(CursorLocation from,
CursorLocation to) {
int fromLine = GetLineIndexForLocation(from, editline_cursor_row);
int toLine = GetLineIndexForLocation(to, editline_cursor_row);
if (toLine != fromLine) {
-fprintf(m_output_file,
@@ -0,0 +1,74 @@
+//===-- Telemetry.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,74 @@
+//===-- Telemetry.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,22 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class TerminalDimensionsTest(PExpectTest):
+NO_DEBUG_INFO_TESTCASE = True
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/126598
>From 6a12b9282228b24691dfcd4d8ec4d2b240747f54 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 10 Feb 2025 12:58:00 -0800
Subject: [PATCH 1/2] [lldb] Add a test for terminal dimensions
Add a te
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/126598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-10T14:46:03-08:00
New Revision: d81b604656c189a9d4e9f0d14b0f4d52f454deac
URL:
https://github.com/llvm/llvm-project/commit/d81b604656c189a9d4e9f0d14b0f4d52f454deac
DIFF:
https://github.com/llvm/llvm-project/commit/d81b604656c189a9d4e9f0d14b0f4d52f454deac.d
@@ -68,11 +68,10 @@ class OptionValueSInt64 : public
Cloneable {
}
bool SetDefaultValue(int64_t value) {
-if (value >= m_min_value && value <= m_max_value) {
- m_default_value = value;
- return true;
-}
-return false;
+assert(value >= m_min_value
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/126604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Keith Smiley (keith)
Changes
This typedef doesn't match the signature below, specifically the signature
takes a `lldb:SBDebugger` vs this was defined as `lldb:SBDebugger&`.
```
lldb/source/API/SBDebugger.cpp:199:13: runtime error: call to
jimingham wrote:
This PR caused the llvm Standalone bot build to fail, for instance:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/1328/consoleText
Can someone fix that build problem?
https://github.com/llvm/llvm-project/pull/119716
https://github.com/keith created
https://github.com/llvm/llvm-project/pull/126652
This typedef doesn't match the signature below, specifically the signature
takes a `lldb:SBDebugger` vs this was defined as `lldb:SBDebugger&`.
```
lldb/source/API/SBDebugger.cpp:199:13: runtime error: call to fu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
A DriverKit process is a kernel extension that runs in userland, instead of
running in the kernel address space/priv levels, they've been around a couple
of years. From lldb's perspective a DriverKit p
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/126604
A DriverKit process is a kernel extension that runs in userland, instead of
running in the kernel address space/priv levels, they've been around a couple
of years. From lldb's perspective a DriverKit proc
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/126606
A new callback was added with the type
CommandReturnObjectCallbackResult, this commit namespaces that type to match
the format of other callback functions that have a non-primitive return type in
the lldb
1 - 100 of 120 matches
Mail list logo
