llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) <details> <summary>Changes</summary> Both the default value and the min/max value are within LLDB's control, so an assert is more appropriate than a runtime check. --- Full diff: https://github.com/llvm/llvm-project/pull/126590.diff 2 Files Affected: - (modified) lldb/include/lldb/Interpreter/OptionValueSInt64.h (+4-5) - (modified) lldb/include/lldb/Interpreter/OptionValueUInt64.h (+6-7) ``````````diff diff --git a/lldb/include/lldb/Interpreter/OptionValueSInt64.h b/lldb/include/lldb/Interpreter/OptionValueSInt64.h index 3cf41d38c0ef0c5..f7e72684e4102f9 100644 --- a/lldb/include/lldb/Interpreter/OptionValueSInt64.h +++ b/lldb/include/lldb/Interpreter/OptionValueSInt64.h @@ -68,11 +68,10 @@ class OptionValueSInt64 : public Cloneable<OptionValueSInt64, OptionValue> { } bool SetDefaultValue(int64_t value) { - if (value >= m_min_value && value <= m_max_value) { - m_default_value = value; - return true; - } - return false; + assert(value >= m_min_value && value <= m_max_value && + "disallowed default value"); + m_default_value = value; + return true; } void SetMinimumValue(int64_t v) { m_min_value = v; } diff --git a/lldb/include/lldb/Interpreter/OptionValueUInt64.h b/lldb/include/lldb/Interpreter/OptionValueUInt64.h index 07076075790c674..5cccff177cb1d60 100644 --- a/lldb/include/lldb/Interpreter/OptionValueUInt64.h +++ b/lldb/include/lldb/Interpreter/OptionValueUInt64.h @@ -73,18 +73,17 @@ class OptionValueUInt64 : public Cloneable<OptionValueUInt64, OptionValue> { } bool SetDefaultValue(uint64_t value) { - if (value >= m_min_value && value <= m_max_value) { - m_default_value = value; - return true; - } - return false; + assert(value >= m_min_value && value <= m_max_value && + "disallowed default value"); + m_default_value = value; + return true; } - void SetMinimumValue(int64_t v) { m_min_value = v; } + void SetMinimumValue(uint64_t v) { m_min_value = v; } uint64_t GetMinimumValue() const { return m_min_value; } - void SetMaximumValue(int64_t v) { m_max_value = v; } + void SetMaximumValue(uint64_t v) { m_max_value = v; } uint64_t GetMaximumValue() const { return m_max_value; } `````````` </details> https://github.com/llvm/llvm-project/pull/126590 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
