Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-11 Thread Nelio Laranjeiro
Hi Anoob, On Fri, Dec 08, 2017 at 10:10:28PM +0530, Anoob Joseph wrote: > HI Nelio, > > > On 08-12-2017 20:10, Nelio Laranjeiro wrote: > > On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote: > > > Hi Nelio, > > > > > > > > [...] > > > > + goto flow_crea

Re: [dpdk-dev] [PATCH] net/i40e: exclude LLDP packet count

2017-12-11 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, December 5, 2017 9:30 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/i40e: exclude LLDP packet count > > When use port stats register to calcuate the packet count, LLDP packets are Patch looks OK f

Re: [dpdk-dev] [PATCH] net/i40e: exclude LLDP packet count

2017-12-11 Thread Zhang, Qi Z
Thanks will fix. > -Original Message- > From: Xing, Beilei > Sent: Monday, December 11, 2017 4:50 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e: exclude LLDP packet count > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Tuesday, December 5, 20

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-11 Thread Olivier MATZ
On Mon, Dec 11, 2017 at 10:57:41AM +0530, Hemant Agrawal wrote: [...] > > License text example in [1] starts from Copyright and has All rights > > reserved. > > I agree that template should be clearly specified from the very beginning. > > > > [1] https://spdx.org/licenses/BSD-3-Clause#licenseText

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-11 Thread Anoob
Hi Nelio, On 12/11/2017 01:51 PM, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Dec 08, 2017 at 10:10:28PM +0530, Anoob Joseph wrote: HI Nelio, On 08-12-2017 20:10, Nelio Laranjeiro wrote: On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote: Hi Nelio, [...] +

Re: [dpdk-dev] [PATCH] vhost: fix error code check when creating pthread

2017-12-11 Thread Jens Freimann
On Fri, Dec 08, 2017 at 11:19:49AM +0100, Olivier Matz wrote: On error, pthread_create() returns a positive number (errno). Fix the test on the return value. Fixes: af1475918124 ("vhost: introduce API to start a specific driver") Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") Cc: sta...@dp

Re: [dpdk-dev] DPDK Amazon AWS ENA driver problem with ping

2017-12-11 Thread Burakov, Anatoly
On 04-Dec-17 10:11 PM, Jordan Rhody wrote: Hi, I have been testing the DPDK ENA driver and am hoping that someone can help in assisting an observation I have. Using the DPDK ENA driver, I can send a ping request/reply from client A to client B through an Edge device running DPDK. However, the

Re: [dpdk-dev] [PATCH 0/3] generic channel for multi-process communication

2017-12-11 Thread Burakov, Anatoly
On 30-Nov-17 6:44 PM, Jianfeng Tan wrote: This patchset adds a generic channel for multi-process (primary/secondary) communication. Patch 1: addess the purpose and howto; Patch 2: add a syncrhonous way for those messages which need a response immediately. Patch 3: Rework vfio to use this generi

Re: [dpdk-dev] [PATCH 1/2] doc: fix lists of supported algorithms

2017-12-11 Thread De Lara Guarch, Pablo
Hi Andrea, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrea Grandi > Sent: Wednesday, November 22, 2017 6:03 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: fix lists of supported algorithms > > Add a missing space must

Re: [dpdk-dev] [PATCH 2/2] doc: fix format in OpenSSL installation guide

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrea Grandi > Sent: Wednesday, November 22, 2017 6:03 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: fix format in OpenSSL installation > guide > > List of supported OpenSSL

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-11 Thread Remy Horton
On 08/12/2017 16:56, Mohammad Abdul Awal wrote: On 08/12/2017 15:02, Remy Horton wrote: [..] I think it possible to create the representor without pulling in driver codes. We probably can avoid using the rte_eth_vdev_allocate by calling the rte_eth_dev_allocate() directly. This is my general

Re: [dpdk-dev] [PATCH 1/2] doc: fix lists of supported algorithms

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrea Grandi > Sent: Wednesday, November 22, 2017 6:03 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: fix lists of supported algorithms > > Add a missing space must before the

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Radu Nicolau
Hi, On 12/6/2017 11:08 AM, Anoob wrote: Hi Akhil, On 12/04/2017 01:19 PM, Akhil Goyal wrote: Hi Anoob, On 11/29/2017 9:51 AM, Anoob Joseph wrote: Hi Akhil, On 24-11-2017 16:19, Akhil Goyal wrote: Hi Anoob, On 11/24/2017 3:28 PM, Anoob wrote:   static inline void   route4_pkts(struct rt_

Re: [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt

2017-12-11 Thread Olivier MATZ
On Fri, Dec 08, 2017 at 04:46:51PM +0100, Olivier Matz wrote: > When RTE_MBUF_REFCNT_ATOMIC=n, the decrement of the mbuf reference > counter uses an atomic operation. This is not necessary and impacts > the performance (seen with TRex traffic generator). > > We cannot replace rte_atomic16_add_retu

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
Hi, On 12/11/2017 03:56 PM, Radu Nicolau wrote: Hi, On 12/6/2017 11:08 AM, Anoob wrote: Hi Akhil, On 12/04/2017 01:19 PM, Akhil Goyal wrote: Hi Anoob, On 11/29/2017 9:51 AM, Anoob Joseph wrote: Hi Akhil, On 24-11-2017 16:19, Akhil Goyal wrote: Hi Anoob, On 11/24/2017 3:28 PM, Anoob wr

Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, November 27, 2017 11:20 AM > To: O Mahony, Billy ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst > > > > > -Original Message- > >

Re: [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int

2017-12-11 Thread Hunt, David
Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: --snip-- int -guest_channel_host_connect(const char *path, unsigned lcore_id) +guest_channel_host_connect(const char *path, unsigned int lcore_id) --snip-- I'd suggest adding the following into the commit message. It would help e

Re: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Monday, November 27, 2017 11:45 AM > To: O Mahony, Billy ; De Lara Guarch, Pablo > ; dev@dpdk.org > Cc: O Mahony, Billy > Subject: RE: [dpdk-dev] [PATCH] cryptodev: Add useful comment to > _sym_session > > > > > -Original Message--

Re: [dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files

2017-12-11 Thread Hunt, David
Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: Signed-off-by: Marko Kovacevic --- lib/librte_power/Makefile | 2 +- ...e_power_acpi_cpufreq.c => power_acpi_cpufreq.c} | 32 +++--- ...e_power_acpi_cpufreq.h => power_acpi_cpufreq.h} | 28 +++

Re: [dpdk-dev] [PATCH v2 3/4] power: clean up of kvm files

2017-12-11 Thread Hunt, David
Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: Signed-off-by: Marko Kovacevic --- lib/librte_power/Makefile | 2 +- .../{rte_power_kvm_vm.c => power_kvm_vm.c} | 28 +++--- .../{rte_power_kvm_vm.h => power_kvm_vm.h} | 28 +++

Re: [dpdk-dev] [PATCH v2 4/4] power: clean up of power common header

2017-12-11 Thread Hunt, David
Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: Signed-off-by: Marko Kovacevic --- lib/librte_power/power_acpi_cpufreq.c | 2 +- lib/librte_power/{rte_power_common.h => power_common.h} | 6 +++--- lib/librte_power/rte_power.c| 2 +- 3

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add support for inline protocol

2017-12-11 Thread Radu Nicolau
On 11/23/2017 11:19 AM, Anoob Joseph wrote: Adding support for inline protocol processing In ingress side, application will receive regular IP packets, without any IPsec related info. Application will do a selector check (SP-SA check) by making use of the metadata from the packet. In egress si

Re: [dpdk-dev] [PATCH 1/3] eal: add channel for multi-process communication

2017-12-11 Thread Burakov, Anatoly
On 30-Nov-17 6:44 PM, Jianfeng Tan wrote: Previouly, there are three channels for multi-process (i.e., primary/secondary) communication. 1. Config-file based channel, in which, the primary process writes info into a pre-defined config file, and the secondary process reads info out.

Re: [dpdk-dev] [PATCH 09/39] examples/bond: convert to new ethdev offloads API

2017-12-11 Thread Radu Nicolau
On 11/23/2017 12:14 PM, Shahaf Shuler wrote: Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/bon

[dpdk-dev] [PATCH v2 1/8] app/eventdev: add ethernet device producer option

2017-12-11 Thread Pavan Nikhilesh
Add command line option --prod_type_ethdev to specify that the events are generated by ethernet device. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Modified 'evt_parse_prod_type' to 'evt_parse_eth_prod_type' to accommodate other kinds of producers in future. ap

[dpdk-dev] [PATCH v2 2/8] app/eventdev: modify app setup to support ethdev

2017-12-11 Thread Pavan Nikhilesh
Modify app setup to accommodate event port and queue setup based on the number of ethernet ports. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Removed unnecessary RTE_SET_USED() macros. app/test-eventdev/test_perf_atq.c| 17 + app/test-eventdev

[dpdk-dev] [PATCH v2 4/8] app/eventdev: add ethernet device setup helpers

2017-12-11 Thread Pavan Nikhilesh
Add ethernet device setup functions to configure ethdev ports incase prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Removed unnecessary "\n" from evt_err, reworked ethernet queue setup. app/test-eventdev/test_perf_atq.c| 1 +

[dpdk-dev] [PATCH v2 3/8] app/eventdev: add pktmbuf pool for ethdev

2017-12-11 Thread Pavan Nikhilesh
Add pktmbuf pool creation used when configuring ethernet device as event producer. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Set cache size as 512. app/test-eventdev/test_perf_common.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH v2 5/8] app/eventdev: add ethernet device tear down

2017-12-11 Thread Pavan Nikhilesh
Add ethernet device destroy functions to stop and close ethdev ports if they are configured when prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_perf_atq.c| 1 + app/test-eventdev/test_perf_common.c | 13 + app

[dpdk-dev] [PATCH v2 6/8] app/eventdev: add event Rx adapter setup

2017-12-11 Thread Pavan Nikhilesh
Add functions to setup and configure Rx adapter based on the number of ethdev ports setup. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Used default eventdev config values instead of hardcoded values. app/test-eventdev/test_perf_atq.c| 19 -- app/test-eve

[dpdk-dev] [PATCH v2 8/8] doc: update app eventdev options

2017-12-11 Thread Pavan Nikhilesh
Update documentation about new --prod_type_ethdev option in app/eventdev. Signed-off-by: Pavan Nikhilesh Acked-by: John McNamara Acked-by: Jerin Jacob --- doc/guides/tools/testeventdev.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/tools/testeventdev.rst b

[dpdk-dev] [PATCH v2 7/8] app/eventdev: add service core configuration

2017-12-11 Thread Pavan Nikhilesh
Add service core configuration for Rx adapter. The configuration picks the least used service core to run the service on. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 41 app/test-eventdev/test_perf_atq.c| 12 +++ app/

Re: [dpdk-dev] [PATCH 3/3] doc: add description of traffic metering and policing funcs in testpmd

2017-12-11 Thread Marko Kovacevic
On 20/11/2017 16:39, Jasvinder Singh wrote: Signed-off-by: Jasvinder Singh     Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH 3/3] doc: add description of traffic metering and policing funcs in testpmd

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, November 20, 2017 4:39 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Wu, Jingjing > ; Mcnamara, John > Subject: [PATCH 3/3] doc: add description of traffic metering and policing > funcs in testpmd > > Signed-off-by: Jasv

Re: [dpdk-dev] [PATCH] eventdev: fix doxygen comments

2017-12-11 Thread Laatz, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Saturday, December 9, 2017 2:40 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] eventdev: fix doxygen comments > > Fix doxygen ret

Re: [dpdk-dev] [PATCH 13/13] doc: update example eventdev_pipeline

2017-12-11 Thread Laatz, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Thursday, December 7, 2017 8:37 PM > To: Eads, Gage ; > jerin.jacobkollanukka...@cavium.com; Van Haaren, Harry > ; Rao, Nikhil ; > hemant.agra...@nxp.com; Ma, Liang J > Cc: dev@dpdk.org; Pa

Re: [dpdk-dev] [PATCH 3/3] doc: add description of traffic metering and policing funcs in testpmd

2017-12-11 Thread Mcnamara, John
Note, there is a devtools/check-git-log.sh warning on the commit subject. Maybe use something like this instead, if you update the patchset, or the maintainer can fix inline: doc: add metering and policing funcs to testpmd docs

Re: [dpdk-dev] [PATCHv2 3/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-11 Thread Bruce Richardson
On Fri, Dec 08, 2017 at 12:14:34PM -0500, Neil Horman wrote: > Add checks during build to ensure that all symbols in the EXPERIMENTAL > version map section have __experimental tags on their definitions, and > enable the warnings needed to announce their use. Also add a > ALLOW_EXPERIMENTAL_FUNCTIO

Re: [dpdk-dev] [PATCH 2/3] eal: add synchronous multi-process communication

2017-12-11 Thread Burakov, Anatoly
On 30-Nov-17 6:44 PM, Jianfeng Tan wrote: We need the synchronous way for multi-process communication, that is to say we need an immediate response after we send a message to the other side. We will stop the mp_handler thread, and after sending message, the send thread will wait there for repons

Re: [dpdk-dev] [PATCH v1 0/8] Bus control framework

2017-12-11 Thread Shreyansh Jain
Hello Gaetan, (I am assuming that this series is still valid for 18.02 and you will spin a new version of this.) On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: Probing policy was introduced in the previous release as a configuration item. It was thus added to the generic bus struct

Re: [dpdk-dev] [PATCH v1 2/8] bus: introduce opaque control framework

2017-12-11 Thread Shreyansh Jain
On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: New configuration elements are added to the buses. They make the ABI unstable and will continue to do so. This new control scheme allows to add new bus operators without breaking the ABI and by only expanding the API. This helps having m

Re: [dpdk-dev] [PATCH 15/39] examples/ipsec-secgw: convert to new ethdev offloads API

2017-12-11 Thread Radu Nicolau
Hi, Comment inline On 11/23/2017 12:19 PM, Shahaf Shuler wrote: Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shule

Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Thursday, November 23, 2017 10:03 AM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; Gaetan Rivet ; De Lara > Guarch, Pablo ; sta...@dpdk.org > Subject: [PATCH v2 2/3] crypto: fix pedantic

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix missing ingress flow attribute

2017-12-11 Thread Radu Nicolau
On 12/4/2017 2:11 PM, Nelio Laranjeiro wrote: Generic flow API have both direction bits, ingress and egress for rules which may work on both sides. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Nelio Laranjeiro --- Acked-by:

Re: [dpdk-dev] [PATCH 1/6] doc: add empty PMDs todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 1/6] doc: add empty PMDs todo list > > Some library modifications require extra checks or modifications in

Re: [dpdk-dev] [PATCH 3/3] vfio: use the generic multi-process channel

2017-12-11 Thread Burakov, Anatoly
On 30-Nov-17 6:44 PM, Jianfeng Tan wrote: Previously, vfio has its own channel for the secondary process to get container fd and group fd from the primary process. This patch changes to use the generic mp channel. Signed-off-by: Jianfeng Tan --- lib/librte_eal/linuxapp/eal/eal.c

Re: [dpdk-dev] [PATCH 29/39] examples/vm_power_manager: convert to new offloads API

2017-12-11 Thread Hunt, David
On 23/11/2017 12:19 PM, Shahaf Shuler wrote: Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/vm

Re: [dpdk-dev] [PATCH] test/test_cryptodev: fix missing include

2017-12-11 Thread De Lara Guarch, Pablo
Hi Jerin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Tuesday, November 28, 2017 12:51 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Jerin Jacob > > Subject: [dpdk-dev] [PATCH] test/test_cryptodev: fix missing include > > time() is defi

Re: [dpdk-dev] [PATCH v1 4/8] bus: add probe mode setter

2017-12-11 Thread Shreyansh Jain
On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: Introduce new rte_bus operation to configure the probe policy. Implementation is required from buses interested in supporting this configuration element. [...] diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal

Re: [dpdk-dev] [PATCH 1/3] lib/cmdline: add echo support in batch loading from file

2017-12-11 Thread Burakov, Anatoly
On 15-Nov-17 3:45 PM, Xueming Li wrote: Add echo option to echo commandline to screen when running loaded scripts from file. Signed-off-by: Xueming Li --- <...snip...> @@ -86,7 +87,7 @@ cmdline_file_new(cmdline_parse_ctx_t *ctx, const char *prompt, const char *path) dprintf

Re: [dpdk-dev] [PATCH v1 4/8] bus: add probe mode setter

2017-12-11 Thread Shreyansh Jain
On Monday 11 December 2017 06:09 PM, Shreyansh Jain wrote: On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: Introduce new rte_bus operation to configure the probe policy. Implementation is required from buses interested in supporting this configuration element. [...] diff --git a/l

Re: [dpdk-dev] [PATCH 3/3] test: update batch loading test

2017-12-11 Thread Burakov, Anatoly
On 15-Nov-17 3:45 PM, Xueming Li wrote: Support echo back in batch loading. Signed-off-by: Xueming Li --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH 15/39] examples/ipsec-secgw: convert to new ethdev offloads API

2017-12-11 Thread Shahaf Shuler
Hi Radu, Monday, December 11, 2017 1:48 PM, Radu Nicolau : > Hi, > > Comment inline > > > On 11/23/2017 12:19 PM, Shahaf Shuler wrote: > > Ethdev offloads API has changed since: > > > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit > > cba7f53b717d ("ethdev: introduce T

Re: [dpdk-dev] [PATCH 1/2] eventdev: add implicit release disable capability

2017-12-11 Thread Van Haaren, Harry
> -Original Message- > From: Eads, Gage > Sent: Thursday, November 30, 2017 4:21 AM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; hemant.agra...@nxp.com; nipun.gu...@nxp.com; > santosh.shu...@caviumnetworks.com > Subject: [PATCH 1/2] ev

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support command echo in CLI batch loading

2017-12-11 Thread Burakov, Anatoly
On 15-Nov-17 3:45 PM, Xueming Li wrote: Use first bit of verbose_level to enable CLI echo of batch loading. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f5a483a

Re: [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE

2017-12-11 Thread Bruce Richardson
On Thu, Nov 02, 2017 at 03:38:51PM +0530, Hemant Agrawal wrote: > cross compiling DPDK for BE mode on ARM results into errors > > "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") > Cc: Neil Horman > Cc: sta

Re: [dpdk-dev] [PATCH 2/5] lpm: fix compilation on ARM BE

2017-12-11 Thread Bruce Richardson
On Thu, Nov 02, 2017 at 03:38:52PM +0530, Hemant Agrawal wrote: > Compiling on ARM BE using Linaro toolchain caused following > error/warnings. > > rte_lpm.c: In function ‘add_depth_big_v20’: > rte_lpm.c:911:4: error: braces around scalar initializer [-Werror] > { .group_idx = (uint8_t)tbl8_gr

Re: [dpdk-dev] [PATCHv2 3/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-11 Thread Neil Horman
On Mon, Dec 11, 2017 at 11:35:57AM +, Bruce Richardson wrote: > On Fri, Dec 08, 2017 at 12:14:34PM -0500, Neil Horman wrote: > > Add checks during build to ensure that all symbols in the EXPERIMENTAL > > version map section have __experimental tags on their definitions, and > > enable the warni

Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors

2017-12-11 Thread Nelio Laranjeiro
Hi Pablo, On Mon, Dec 11, 2017 at 11:49:39AM +, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Thursday, November 23, 2017 10:03 AM > > To: Akhil Goyal ; Doherty, Declan > > > > Cc: dev@dpdk.org; Gaeta

Re: [dpdk-dev] [PATCH 5/5] net/ixgbe: fix compilation on ARM BE

2017-12-11 Thread Bruce Richardson
On Thu, Nov 02, 2017 at 03:38:55PM +0530, Hemant Agrawal wrote: > fixes the following compilation error on compiling with ARM BE compiler > > ixgbe_common.c: In function ‘ixgbe_host_interface_command’: > ixgbe_common.c:4610:22: error: passing argument 1 of > ‘__builtin_bswap32’ makes integer from

[dpdk-dev] [PATCH] net/failsafe: add Rx interrupts

2017-12-11 Thread Moti Haimovsky
This patch adds support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application while inte

Re: [dpdk-dev] [PATCH v1 2/8] bus: introduce opaque control framework

2017-12-11 Thread Gaëtan Rivet
On Mon, Dec 11, 2017 at 05:30:16PM +0530, Shreyansh Jain wrote: > On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: > > New configuration elements are added to the buses. They make the ABI > > unstable and will continue to do so. > > > > This new control scheme allows to add new bus operat

Re: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Thursday, November 30, 2017 1:33 PM > To: dev@dpdk.org > Cc: m...@semihalf.com; j...@semihalf.com; d...@marvell.com; > nsams...@marvell.com; jianbo@arm.com; Tomasz Duszynski > > Subje

Re: [dpdk-dev] [PATCHv2 3/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-11 Thread Bruce Richardson
On Mon, Dec 11, 2017 at 07:40:43AM -0500, Neil Horman wrote: > On Mon, Dec 11, 2017 at 11:35:57AM +, Bruce Richardson wrote: > > On Fri, Dec 08, 2017 at 12:14:34PM -0500, Neil Horman wrote: > > > Add checks during build to ensure that all symbols in the EXPERIMENTAL > > > version map section ha

Re: [dpdk-dev] [PATCH 15/39] examples/ipsec-secgw: convert to new ethdev offloads API

2017-12-11 Thread Radu Nicolau
On 12/11/2017 12:33 PM, Shahaf Shuler wrote: Hi Radu, Monday, December 11, 2017 1:48 PM, Radu Nicolau : Hi, Comment inline On 11/23/2017 12:19 PM, Shahaf Shuler wrote: Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b71

Re: [dpdk-dev] [PATCH 1/3] hash: run-time function selection

2017-12-11 Thread Bruce Richardson
On Mon, Nov 06, 2017 at 10:04:02AM -0800, Elza Mathew wrote: > Compile-time function selection can potentially lead to > lower performance on generic builds done by distros. > Replaced compile time flag checks with run-time function > selection. > > Signed-off-by: Elza Mathew > --- > lib/librte_

Re: [dpdk-dev] [PATCH v1 2/8] bus: introduce opaque control framework

2017-12-11 Thread Shreyansh Jain
On Monday 11 December 2017 06:13 PM, Gaëtan Rivet wrote: On Mon, Dec 11, 2017 at 05:30:16PM +0530, Shreyansh Jain wrote: On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: [...] diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 331d9

Re: [dpdk-dev] [PATCH 2/3] hash: run-time function selection

2017-12-11 Thread Bruce Richardson
On Mon, Nov 06, 2017 at 10:04:49AM -0800, Elza Mathew wrote: > Compile-time function selection can potentially lead to > lower performance on generic builds done by distros. > Replaced compile time flag checks with run-time function > selection. > > Signed-off-by: Elza Mathew > --- > lib/librte_

Re: [dpdk-dev] [PATCH] vhost: fix error code check when creating pthread

2017-12-11 Thread Maxime Coquelin
On 12/08/2017 11:19 AM, Olivier Matz wrote: On error, pthread_create() returns a positive number (errno). Fix the test on the return value. Fixes: af1475918124 ("vhost: introduce API to start a specific driver") Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH 1/2] lib: refactor basic stats code

2017-12-11 Thread Daly, Lee
> Subject: [dpdk-dev] [PATCH 1/2] lib: refactor basic stats code > > Moved the code to get the basic stats names and values into static functions. > > Signed-off-by: Elza Mathew Reviewed-by: Lee Daly

Re: [dpdk-dev] [PATCH 2/2] lib: optimize _xstats_by_ids APIs

2017-12-11 Thread Daly, Lee
> Subject: [dpdk-dev] [PATCH 2/2] lib: optimize _xstats_by_ids APIs > > Introduced a check to detect if the stats IDs being requested are all basic > stats IDs. In that case, ensured that only the basic stats would be retrieved. > Previously, both basic stats and xstats were being retrieved even i

Re: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD

2017-12-11 Thread De Lara Guarch, Pablo
Hi Ravi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for > AMD CCP crypto PMD > Thanks for splitting the original p

Re: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD

2017-12-11 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar >> Sent: Thursday, November 30, 2017 1:12 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for >> AMD CCP crypto PMD >> > >Thanks for splitting th

Re: [dpdk-dev] [PATCH 2/2] event/sw: simplify credit scheme

2017-12-11 Thread Van Haaren, Harry
> -Original Message- > From: Eads, Gage > Sent: Thursday, November 30, 2017 4:21 AM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce > ; hemant.agra...@nxp.com; nipun.gu...@nxp.com; > santosh.shu...@caviumnetworks.com > Subject: [PATCH 2/2] ev

Re: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

2017-12-11 Thread Tomasz Duszynski
On Mon, Dec 11, 2017 at 12:44:43PM +, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > > Sent: Thursday, November 30, 2017 1:33 PM > > To: dev@dpdk.org > > Cc: m...@semihalf.com; j...@semihalf.com; d...@m

Re: [dpdk-dev] [PATCH v2 01/18] eal: prepend busname on legacy device declaration

2017-12-11 Thread Shreyansh Jain
One very quick comment: On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: Legacy device options (-b, -w, --vdev) need to prepend their bus name to user parameters for backward compatibility. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_options.c | 17 -

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-12-11 Thread Alex Rosenbaum
Mohammad, I did not see a v2 change log. did I miss it? please send. I don't understand who this v2 addresses the comments by Alejandro Lucero from netronome [1]. These are critical points which your proposal does not handle. It is related to the switch_domain member exposed here. thanks, Alex

Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, December 11, 2017 12:43 PM > To: De Lara Guarch, Pablo > Cc: Akhil Goyal ; Doherty, Declan > ; dev@dpdk.org; Gaetan Rivet > ; sta...@dpdk.org > Subject: Re: [PATCH v2 2/3] crypto: fix pedant

Re: [dpdk-dev] [PATCH 2/6] doc: add mbuf reorg to PMD todo list

2017-12-11 Thread Marko Kovacevic
On 21/11/2017 01:42, Ferruh Yigit wrote: To track modification: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") Proposed deadline for PMDs is v18.02 Signed-off-by: Ferruh Yigit Acked-by:Marko Kovacevic

Re: [dpdk-dev] [PATCH 07/39] examples/l3fwd-power: convert to new ethdev offloads API

2017-12-11 Thread Hunt, David
Hi Shahaf, On 23/11/2017 12:14 PM, Shahaf Shuler wrote: Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler ---

[dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: fix missing ingress flow attribute

2017-12-11 Thread Nelio Laranjeiro
Generic flow API have both direction bits, ingress and egress for rules which may work on both sides. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Nelio Laranjeiro Acked-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 2 ++ 1

[dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-11 Thread Nelio Laranjeiro
Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro --- Changes in v3: * removed PASSTHRU test for ingress. * removed check on configured queues for the queue action. Changes in v2: * Test the rule by PASSTHRU/RSS/QUEUE an

[dpdk-dev] [PATCH v2 0/2] Sync compilation with MUSDK-17.10

2017-12-11 Thread Tomasz Duszynski
This patchset comes with the following changes: o MUSDK-17.10 is the latest version of the library. Since it brings improvements and fixes switch is necessary. o Some minor updates to the documentation. Note that this series should be applied after net pmd patch series. Changes since v1: - Re

[dpdk-dev] [PATCH v2 1/2] crypto/mrvl: sync compilation with musdk-17.10

2017-12-11 Thread Tomasz Duszynski
With a new version of the musdk library it's no longer necessary to explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT. Proper defines are autogenerated by ./configure script based on passed options and available after mv_autogen_comp_flags.h inclusion. Signed-off-by: Tomasz Duszynski Acked-by: Jian

[dpdk-dev] [PATCH v2 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

2017-12-11 Thread Tomasz Duszynski
Update MRVL CRYPTO PMD documentation. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- doc/guides/cryptodevs/mrvl.rst | 28 doc/guides/nics/mrvl.rst | 2 ++ 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/doc/guides/cryptodevs/mrvl.rst

Re: [dpdk-dev] [PATCH 2/6] doc: add mbuf reorg to PMD todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 2/6] doc: add mbuf reorg to PMD todo list > > To track modification: > 8f094a9ac5d7 ("mbuf: set mbuf fields

Re: [dpdk-dev] [PATCH 3/6] doc: add dynamic logging to PMD todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 3/6] doc: add dynamic logging to PMD todo list > > To track modification: > c1b5fa94a46f ("eal: support dyn

Re: [dpdk-dev] [PATCH 5/6] doc: add offload flag to PMD todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 5/6] doc: add offload flag to PMD todo list > > To track modification: > ce17eddefc20 ("ethdev: introduce R

Re: [dpdk-dev] [PATCH 4/6] doc: add descriptor status API to PMD todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 4/6] doc: add descriptor status API to PMD todo list > > To track modification: > b1b700ce7d6f ("ethdev: ad

Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors

2017-12-11 Thread Nelio Laranjeiro
On Mon, Dec 11, 2017 at 01:54:22PM +, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Monday, December 11, 2017 12:43 PM > > To: De Lara Guarch, Pablo > > Cc: Akhil Goyal ; Doherty, Declan > > ; dev@dpdk

Re: [dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list > > To track modification: > 380a7aab1ae2 ("mbuf: rename depr

Re: [dpdk-dev] [PATCH] doc: update contribution guideline for dependent work

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 7:59 PM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh ; > techbo...@dpdk.org > Subject: [PATCH] doc: update contribution guideline for dependent work > > Changing some part of the

Re: [dpdk-dev] [PATCH 10/11] test/test: add test for AMD CCP crypto PMD

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:13 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 10/11] test/test: add test for AMD CCP crypto > PMD > > Signed-off-by: Ravi Kumar Hi Ravi, There is a comp

Re: [dpdk-dev] [PATCH 08/11] crypto/ccp: rename CCP crypto driver id

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:13 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 08/11] crypto/ccp: rename CCP crypto driver id > > Signed-off-by: Ravi Kumar Hi Ravi, I think this patch i

Re: [dpdk-dev] [PATCH v1 2/8] bus: introduce opaque control framework

2017-12-11 Thread Gaëtan Rivet
On Mon, Dec 11, 2017 at 07:06:55PM +0530, Shreyansh Jain wrote: > On Monday 11 December 2017 06:13 PM, Gaëtan Rivet wrote: > > On Mon, Dec 11, 2017 at 05:30:16PM +0530, Shreyansh Jain wrote: > > > On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: > > [...] > > > > > diff --git a/lib/librt

Re: [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new ethdev offloads API

2017-12-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, November 23, 2017 12:14 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new ethdev > offloads API > > Ethdev offloads API has changed sinc

Re: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Thursday, November 23, 2017 11:32 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow > classify lib > > Updates the docume

Re: [dpdk-dev] [PATCH 12/39] examples/ip_fragmentation: convert to new offloads API

2017-12-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, November 23, 2017 12:19 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 12/39] examples/ip_fragmentation: convert to new > offloads API > > Ethdev offloads API has changed sinc

Re: [dpdk-dev] [PATCH 2/2] doc: add description of raw mode in flow director in testpmd

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Thursday, November 23, 2017 4:15 PM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Subject: [dpdk-dev] [PATCH 2/2] doc: add descript

Re: [dpdk-dev] [PATCH 14/39] examples/ip_reassembly: convert to new ethdev offloads API

2017-12-11 Thread Ananyev, Konstantin
Hi Shahaf, > + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) != > + port_conf.rxmode.offloads) { > + printf("Some Rx offloads are not supported " > +"by port %d: requested 0x%lx supported 0x%lx\n", > +

  1   2   >