On Fri, Dec 08, 2017 at 12:14:34PM -0500, Neil Horman wrote: > Add checks during build to ensure that all symbols in the EXPERIMENTAL > version map section have __experimental tags on their definitions, and > enable the warnings needed to announce their use. Also add a > ALLOW_EXPERIMENTAL_FUNCTIONS variable check to allow for in-tree dpdk > libraries to override those checks. > > Signed-off-by: Neil Horman <nhor...@tuxdriver.com> > CC: Thomas Monjalon <tho...@monjalon.net> > CC: "Mcnamara, John" <john.mcnam...@intel.com> > ---
Hi Neil, if I read the patch functionality correctly, the ALLOW_EXPERIMENTAL_FUNCTIONS variable simply suppresses all errors for deprecated functions. However, what we really want is just to suppress the errors for the experimental functions, and not any that really are deprecated. While we may not have any now in DPDK, that doesn't mean it might not be useful to have some in future. Therefore, would an alternative scheme work where the experimental tag is set to empty if the ALLOW_EXPERIMENTAL_FUNCTIONS define is set when compiling? /Bruce
