> -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 7:59 PM > To: Thomas Monjalon <[email protected]>; Mcnamara, John > <[email protected]> > Cc: [email protected]; Yigit, Ferruh <[email protected]>; > [email protected] > Subject: [PATCH] doc: update contribution guideline for dependent work > > Changing some part of the libraries but not updating all dependent code > cause maintenance problems. > > ... > > Signed-off-by: Ferruh Yigit <[email protected]> >
integration testing. > > +* If changes effect other parts of the project, update all those parts as > well unless updating requires special knowledge. > + For the cases not all effected code updated, ensure that changes don't > break existing code. > + > * Add tests to the the ``app/test`` unit test framework where possible. > > * Add documentation, if relevant, in the form of Doxygen comments or a > User Guide in RST format. Second line would be better as: For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code. Acked-by: John McNamara <[email protected]>
