Hi Marko,
On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
Signed-off-by: Marko Kovacevic <marko.kovace...@intel.com>
---
lib/librte_power/Makefile | 2 +-
.../{rte_power_kvm_vm.c => power_kvm_vm.c} | 28 +++++++++++-----------
.../{rte_power_kvm_vm.h => power_kvm_vm.h} | 28 +++++++++++-----------
lib/librte_power/rte_power.c | 28 +++++++++++-----------
4 files changed, 43 insertions(+), 43 deletions(-)
rename lib/librte_power/{rte_power_kvm_vm.c => power_kvm_vm.c} (83%)
rename lib/librte_power/{rte_power_kvm_vm.h => power_kvm_vm.h} (85%)
diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile
index bf5a55e..a35c50a 100644
--- a/lib/librte_power/Makefile
+++ b/lib/librte_power/Makefile
@@ -43,7 +43,7 @@ LIBABIVER := 1
# all source are stored in SRCS-y
SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c
-SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c
+SRCS-$(CONFIG_RTE_LIBRTE_POWER) += power_kvm_vm.c guest_channel.c
# install this header file
SYMLINK-$(CONFIG_RTE_LIBRTE_POWER)-include := rte_power.h
diff --git a/lib/librte_power/rte_power_kvm_vm.c
b/lib/librte_power/power_kvm_vm.c
similarity index 83%
rename from lib/librte_power/rte_power_kvm_vm.c
rename to lib/librte_power/power_kvm_vm.c
--snip--
Could I suggest you add the following into the commit message?
"rename private header file rte_power_kvm_vm.c to power_kvm_vm.c. This
prevents the private functions from leaking into the documentation.
Change any private functions from rte_<function_name> to just
<function_name>. Reserve the rte_ for public functions. "
Regards,
Dave.
