[clang] 022b3c2 - [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (#106495)

2024-09-09 Thread via cfe-commits
Author: Piyou Chen Date: 2024-09-09T15:07:39+08:00 New Revision: 022b3c27e27832f27c61683095899227c26e0cca URL: https://github.com/llvm/llvm-project/commit/022b3c27e27832f27c61683095899227c26e0cca DIFF: https://github.com/llvm/llvm-project/commit/022b3c27e27832f27c61683095899227c26e0cca.diff LO

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-09-09 Thread Piyou Chen via cfe-commits
https://github.com/BeMg closed https://github.com/llvm/llvm-project/pull/106495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-09 Thread Younan Zhang via cfe-commits
zyn0217 wrote: It's been ~3 days and I'm merging it - feel free to do post-commit reviews. https://github.com/llvm/llvm-project/pull/107561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] 8549b32 - [Clang] Don't assert non-empty packs for FunctionParmPackExprs (#107561)

2024-09-09 Thread via cfe-commits
Author: Younan Zhang Date: 2024-09-09T15:09:43+08:00 New Revision: 8549b324bc1f450f4477f46f18db67439dbf6d75 URL: https://github.com/llvm/llvm-project/commit/8549b324bc1f450f4477f46f18db67439dbf6d75 DIFF: https://github.com/llvm/llvm-project/commit/8549b324bc1f450f4477f46f18db67439dbf6d75.diff

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/107561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Coroutines] Transform "coro_elide_safe" calls to switch ABI coroutines to the `noalloc` variant (PR #99285)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/4972

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-09 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/107815 Fixes #10 >From 0059de326ef8dd01e24f45cb18d9035957e77873 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Mon, 9 Sep 2024 09:15:39 +0200 Subject: [PATCH] [Clang] Fix crash due to invalid source loca

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikolas Klauser (philnik777) Changes Fixes #10 --- Full diff: https://github.com/llvm/llvm-project/pull/107815.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaExprCXX.cpp (+2-1) - (modified) clang/test/SemaCXX/type-traits.c

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-09 Thread Jim Lin via cfe-commits
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/107816 None >From f6da0096e4dcf3f7b5c8da4e8e170e88b7ebb471 Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Mon, 9 Sep 2024 12:59:30 +0800 Subject: [PATCH] [RISCV] Add testcase for -mcmodel= --- clang/test/Driver/riscv

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Jim Lin (tclin914) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107816.diff 1 Files Affected: - (added) clang/test/Driver/riscv-mcmodel.c (+14) ``diff diff --git a/clang/test/Driver/riscv-mcmodel

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jim Lin (tclin914) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107816.diff 1 Files Affected: - (added) clang/test/Driver/riscv-mcmodel.c (+14) ``diff diff --git a/clang/test/Driver/riscv-mcmodel.c b/cla

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-09 Thread Jim Lin via cfe-commits
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/107817 None >From f6da0096e4dcf3f7b5c8da4e8e170e88b7ebb471 Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Mon, 9 Sep 2024 12:59:30 +0800 Subject: [PATCH 1/2] [RISCV] Add testcase for -mcmodel= --- clang/test/Driver/r

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jim Lin (tclin914) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107817.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp (+2-1) - (added) clang/test/Driver/riscv-mcmodel.c (+20)

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-09 Thread Jim Lin via cfe-commits
https://github.com/tclin914 edited https://github.com/llvm/llvm-project/pull/107816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Remove overzealous "No dispatcher registered" assertion (PR #107294)

2024-09-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. Looks good to me :) https://github.com/llvm/llvm-project/pull/107294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-09 Thread Mikael Holmén via cfe-commits
mikaelholmen wrote: > > Btw a question about the new warning: So with > > -Wunsafe-buffer-usage-in-libc-call clang now warns on the following? > > ``` > > #include > > > > void foo(void) { > > char q[10]; > > snprintf(q, 10, "%s", "hello"); > > } > > ``` > > > > > > > > > >

[clang] [llvm] [LLVM][Coroutines] Transform "coro_elide_safe" calls to switch ABI coroutines to the `noalloc` variant (PR #99285)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-ubuntu` running on `as-builder-4` while building `llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/187/builds/1028

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: LGTM, there is no reason to crash on `#embed`. I think it would be nice to have a few testcases that show the behavior of the analyzer around `#embed`: - Can we produce bug reports if there is an (unrelated) `#embed` expression on the execution path? Or

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-09 Thread Dimitry Andric via cfe-commits
https://github.com/DimitryAndric approved this pull request. Seems reasonable, and it fixes both my minimized test case, and the full original test case. https://github.com/llvm/llvm-project/pull/107815 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [FMV][Clang][CodeGen] Resolves corresponding callee for multi-versioning callers (PR #107822)

2024-09-09 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/107822 Closes #94949. >From 110eea45aaaca6508f41032641a083df1c43092f Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Mon, 9 Sep 2024 15:53:05 +0800 Subject: [PATCH 1/2] [FMV][Clang][CodeGen] Add pre-commit tests.

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Donát Nagy via cfe-commits
NagyDonat wrote: To me this solution seems to be a bit hacky -- I don't like that we need to scatter "handle `void *` as if it was `char *`" special cases in various parts of the analyzer (I vaguely recall that I have also seen similar hacks elsewhere). I'd prefer solutions that are as generi

[clang] da11ede - [analyzer] Remove overzealous "No dispatcher registered" assertion (#107294)

2024-09-09 Thread via cfe-commits
Author: vabridgers Date: 2024-09-09T03:47:39-05:00 New Revision: da11ede57d034767a6f5d5e211c06c1c3089d7fd URL: https://github.com/llvm/llvm-project/commit/da11ede57d034767a6f5d5e211c06c1c3089d7fd DIFF: https://github.com/llvm/llvm-project/commit/da11ede57d034767a6f5d5e211c06c1c3089d7fd.diff LO

[clang] [analyzer] Remove overzealous "No dispatcher registered" assertion (PR #107294)

2024-09-09 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/107294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -40,6 +40,7 @@ static const auto ARM64EC = llvm::COFF::IMAGE_FILE_MACHINE_ARM64EC; static const auto ARM64X = llvm::COFF::IMAGE_FILE_MACHINE_ARM64X; static const auto ARMNT = llvm::COFF::IMAGE_FILE_MACHINE_ARMNT; static const auto I386 = llvm::COFF::IMAGE_FILE_MACHINE_I386;

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/107744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo commented: I browsed through the first couple commits and added a couple pointers. Overall it looks reasonable, but things can probably be split up into even smaller commits for atomicity, which also would make it clearer where we'd want more test coverage. https:/

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -51,3 +51,25 @@ MipsELFMCAsmInfo::MipsELFMCAsmInfo(const Triple &TheTriple, DwarfRegNumForCFI = true; HasMipsExpressions = true; } + +void MipsCOFFMCAsmInfoMicrosoft::anchor() { } + +MipsCOFFMCAsmInfoMicrosoft::MipsCOFFMCAsmInfoMicrosoft() { + WinEHEncodingType = WinEH:

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -1132,6 +1132,8 @@ StringRef COFFObjectFile::getFileFormatName() const { return "COFF-ARM64EC"; case COFF::IMAGE_FILE_MACHINE_ARM64X: return "COFF-ARM64X"; + case COFF::IMAGE_FILE_MACHINE_R4000: +return "COFF-R4000"; mstorsjo wrote: Hmm, do w

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -28,6 +28,8 @@ COFF::MachineTypes llvm::getMachineType(StringRef S) { .Case("arm64", COFF::IMAGE_FILE_MACHINE_ARM64) .Case("arm64ec", COFF::IMAGE_FILE_MACHINE_ARM64EC) .Case("arm64x", COFF::IMAGE_FILE_MACHINE_ARM64X) + .Case("mips", COFF::IMAGE_FILE_MA

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -45,6 +47,8 @@ StringRef llvm::machineToStr(COFF::MachineTypes MT) { return "x64"; case COFF::IMAGE_FILE_MACHINE_I386: return "x86"; + case COFF::IMAGE_FILE_MACHINE_R4000: +return "mipsel"; mstorsjo wrote: This seems wrong - this should retur

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -39,3 +39,7 @@ Sections: # BSS: Contents of section .bss: # BSS-NEXT: + +# RUN: yaml2obj %p/Inputs/COFF/mipsel.yaml | llvm-objdump -s - | FileCheck %s --check-prefix=COFF-R4000 mstorsjo wrote: This new test seems quite misplaced within this test file. Al

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -0,0 +1,43 @@ +; RUN: llc -mtriple mipsel-windows-msvc -filetype=obj < %s | obj2yaml | FileCheck %s +; RUN: llc -mtriple mipsel-windows-gnu -filetype=obj < %s | obj2yaml | FileCheck %s mstorsjo wrote: It feels to me like this test skips a couple steps. It w

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM. I knew about this issue, thanks for the fix! There is more for a proper fix but it's better than crashing. https://github.com/llvm/llvm-project/pull/107764 ___ cfe-commits mailing list cfe-c

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/107764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang_analyze_cc1 -std=c23 -analyzer-checker=core,debug.ExprInspection -verify %s + +// expected-no-diagnostics + +int main() { +const unsigned char SelfBytes[] = { +#embed "embed.c" +}; +} steakhal wrote: ```suggestion

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/107764 >From a43b9b74ac253c0072498007cf56ed57d8255143 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sun, 8 Sep 2024 11:52:28 -0400 Subject: [PATCH 1/2] [clang][analyzer] Fix #embed crash Fix #107724. --- c

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-09 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. https://github.com/llvm/llvm-project/pull/107816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread Andrew Savonichev via cfe-commits
https://github.com/asavonic created https://github.com/llvm/llvm-project/pull/107828 Fields from external sources are typically loaded implicitly by `RecordDecl` or `DeclContext` iterators and other functions (see LoadFieldsFromExternalStorage function and its uses). The assumption is that we

[clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andrew Savonichev (asavonic) Changes Fields from external sources are typically loaded implicitly by `RecordDecl` or `DeclContext` iterators and other functions (see LoadFieldsFromExternalStorage function and its uses). The assumption is

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [AArch64] Implement NEON vamin/vamax intrinsics (PR #99041)

2024-09-09 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/99041 >From 0cca71a770750e34474d7734c8f803fb31feacee Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Mon, 15 Jul 2024 17:50:43 +0100 Subject: [PATCH 1/4] [AArch64] Implement NEON vamin/vamax intrinsics Th

[clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread Michael Buch via cfe-commits
Michael137 wrote: Thanks for taking a stab at this and for the analysis. You rightly point out that this is the root problem: > If an implicit import happens between (2) and (3), it may indirectly bring > the same field into the context. When (3) happens we add it again, > duplicating the f

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread via cfe-commits
@@ -206,19 +206,28 @@ namespace cwg1814 { // cwg1814: yes #endif } -namespace cwg1815 { // cwg1815: no +namespace cwg1815 { // cwg1815: 19 yronglin wrote: Oh, I missed this! I'll fix it. Thank you for point out this. https://github.com/llvm/llvm-project/pull

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts edited https://github.com/llvm/llvm-project/pull/107408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts deleted https://github.com/llvm/llvm-project/pull/107408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-09 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd updated https://github.com/llvm/llvm-project/pull/107410 >From a20158570f15b4200937650b90e07b99e230e3df Mon Sep 17 00:00:00 2001 From: Edd Dawson Date: Wed, 4 Sep 2024 12:30:11 +0100 Subject: [PATCH 1/3] [PS4,PS5][Driver] Detangle --sysroot and -isysroot The

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -744,79 +744,139 @@ static void insertSpirvDecorations(MachineFunction &MF, MachineIRBuilder MIB) { MI->eraseFromParent(); } -// Find basic blocks of the switch and replace registers in spv_switch() by its -// MBB equivalent. -static void processSwitches(MachineFunctio

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -744,79 +744,139 @@ static void insertSpirvDecorations(MachineFunction &MF, MachineIRBuilder MIB) { MI->eraseFromParent(); } -// Find basic blocks of the switch and replace registers in spv_switch() by its -// MBB equivalent. -static void processSwitches(MachineFunctio

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/102040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: I think there are some good parallel disscussions happening in the RFC, but despite their outcomes, we could probably update the PR to capture current behavior in those interesting cases. I left a few comments along those lines, PTAL. https://githu

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
@@ -1472,3 +1472,25 @@ template struct Outer { }; }; Outer::Inner outerinner; + +void aggregate() { ilya-biryukov wrote: Could we add examples from @AaronBallman's [RFC comment](https://discourse.llvm.org/t/rfc-add-clang-attribute-to-ensure-that-fields-are-

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
@@ -2133,6 +2142,18 @@ void CXXRecordDecl::completeDefinition(CXXFinalOverriderMap *FinalOverriders) { for (conversion_iterator I = conversion_begin(), E = conversion_end(); I != E; ++I) I.setAccess((*I)->getAccess()); + + ASTContext &Context = getASTContext(); +

[clang] [llvm] Double run offloading (PR #107834)

2024-09-09 Thread Aleksei Romanov via cfe-commits
https://github.com/saveasguy created https://github.com/llvm/llvm-project/pull/107834 None >From 5ca9c3f25663e78ea5205a901735b649756e9c1e Mon Sep 17 00:00:00 2001 From: Aleksei Romanov Date: Wed, 20 Sep 2023 01:10:02 +0300 Subject: [PATCH 1/5] [LVN] Add tests on LVN Pass (NFC) --- llvm/inclu

[clang] [llvm] Double run offloading (PR #107834)

2024-09-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Double run offloading (PR #107834)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-transforms Author: Aleksei Romanov (saveasguy) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107834.diff 11 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+6) - (modified) clan

[clang] [llvm] Double run offloading (PR #107834)

2024-09-09 Thread Aleksei Romanov via cfe-commits
https://github.com/saveasguy closed https://github.com/llvm/llvm-project/pull/107834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-09 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd updated https://github.com/llvm/llvm-project/pull/107410 >From a20158570f15b4200937650b90e07b99e230e3df Mon Sep 17 00:00:00 2001 From: Edd Dawson Date: Wed, 4 Sep 2024 12:30:11 +0100 Subject: [PATCH 1/4] [PS4,PS5][Driver] Detangle --sysroot and -isysroot The

[clang] [llvm] [Offload] Provide a kernel library useable by the offload runtime (PR #104168)

2024-09-09 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr edited https://github.com/llvm/llvm-project/pull/104168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload] Provide a kernel library useable by the offload runtime (PR #104168)

2024-09-09 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr commented: I tried a bot-config build and it fails with a compiler error, see my comment. https://github.com/llvm/llvm-project/pull/104168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [llvm] [Offload] Provide a kernel library useable by the offload runtime (PR #104168)

2024-09-09 Thread Jan Patrick Lehr via cfe-commits
@@ -1533,6 +1565,67 @@ Error GenericDeviceTy::printInfo() { return Plugin::success(); } +Expected GenericDeviceTy::getKernel(llvm::StringRef Name, + DeviceImageTy *ImagePtr, +

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This PR triggers failed asserts. This is reproducible with https://martin.st/temp/qtdeclarative-repro1.cpp, like this: ``` $ clang -target aarch64-w64-mingw32 -c qtdeclarative-repro1.cpp Assertion failed: ((ND->isUsed(false) || !isa(ND) || E->isNonOdrUse() || !E->getLocation().i

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-09 Thread Edd Dawson via cfe-commits
@@ -1,42 +1,64 @@ -// Check that PS4 clang doesn't report a warning message when locating -// system header files (either by looking at the value of SCE_ORBIS_SDK_DIR -// or relative to the location of the compiler driver), if "-nostdinc", -// "--sysroot" or "-isysroot" option is

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/107213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/107213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-09 Thread Utkarsh Saxena via cfe-commits
@@ -990,13 +1009,16 @@ static void checkExprLifetimeImpl(Sema &SemaRef, // int &p = *localUniquePtr; // someContainer.add(std::move(localUniquePtr)); // return p; -IsLocalGslOwner = isRecordWithAttr(L->getType()); +IsLocalGslOwner =

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-09 Thread Utkarsh Saxena via cfe-commits
@@ -292,7 +292,7 @@ Improvements to Clang's diagnostics - Clang now warns for u8 character literals used in C23 with ``-Wpre-c23-compat`` instead of ``-Wpre-c++17-compat``. -- Clang now diagnoses cases where a dangling `GSLOwner`` object is constructed, e.g. `std::vector v

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/107213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-09 Thread Sam Elliott via cfe-commits
lenary wrote: What's the status of backend support for the large code model? That would presumably be a prerequisite to landing this. https://github.com/llvm/llvm-project/pull/107817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread via cfe-commits
yronglin wrote: > This PR triggers failed asserts. This is reproducible with > https://martin.st/temp/qtdeclarative-repro1.cpp, like this: > > ``` > $ clang -target aarch64-w64-mingw32 -c qtdeclarative-repro1.cpp > Assertion failed: ((ND->isUsed(false) || !isa(ND) || > E->isNonOdrUse() || !E->

[clang] [NFC][clang] Fix clang version in the test for the implementation of cwg1815 (PR #107838)

2024-09-09 Thread via cfe-commits
https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/107838 This PR fix the clang version in https://github.com/llvm/llvm-project/pull/97308 . >From d99447b57b723efea16ad10015a6b83cc1fd51c5 Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 9 Sep 2024 18:48:37 +0800 S

[clang] [NFC][clang] Fix clang version in the test for the implementation of cwg1815 (PR #107838)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (yronglin) Changes This PR fix the clang version in https://github.com/llvm/llvm-project/pull/97308 . --- Full diff: https://github.com/llvm/llvm-project/pull/107838.diff 1 Files Affected: - (modified) clang/test/CXX/drs/cwg18xx.c

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] 049512e - [NFC][clang] Fix clang version in the test for the implementation of cwg1815 (#107838)

2024-09-09 Thread via cfe-commits
Author: yronglin Date: 2024-09-09T19:01:11+08:00 New Revision: 049512e39d96995cb373a76cf2d009a86eaf3aab URL: https://github.com/llvm/llvm-project/commit/049512e39d96995cb373a76cf2d009a86eaf3aab DIFF: https://github.com/llvm/llvm-project/commit/049512e39d96995cb373a76cf2d009a86eaf3aab.diff LOG:

[clang] [NFC][clang] Fix clang version in the test for the implementation of cwg1815 (PR #107838)

2024-09-09 Thread via cfe-commits
https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/107838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Migrate clang-tblgen to use const RecordKeeper (PR #107533)

2024-09-09 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/107533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Coroutines] Transform "coro_elide_safe" calls to switch ABI coroutines to the `noalloc` variant (PR #99285)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-win` running on `as-worker-93` while building `llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/14/builds/1362 H

[clang] d84d955 - [clang][analyzer] Fix #embed crash (#107764)

2024-09-09 Thread via cfe-commits
Author: Nicolas van Kempen Date: 2024-09-09T13:12:46+02:00 New Revision: d84d9559bdc7aeb4ce14c251f6a3490c66db8d3a URL: https://github.com/llvm/llvm-project/commit/d84d9559bdc7aeb4ce14c251f6a3490c66db8d3a DIFF: https://github.com/llvm/llvm-project/commit/d84d9559bdc7aeb4ce14c251f6a3490c66db8d3a.

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/107764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [TableGen] Change SetTheory set/vec to use const Record * (PR #107692)

2024-09-09 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/107692 >From b11f8fbde5cc005e4667877ed60954f36abcec0c Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Sat, 7 Sep 2024 04:33:09 -0700 Subject: [PATCH] [TableGen] Change SetTheory set/vec to use consr Record * Change S

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread Balazs Benics via cfe-commits
steakhal wrote: > PS: Should this be cherry-picked into 19? Requested the backport in https://github.com/llvm/llvm-project/pull/107841 https://github.com/llvm/llvm-project/pull/107764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-09 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/67802 >From 80e15f748b30d4e977b58a42d8fd4403234bb954 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Fri, 29 Sep 2023 15:01:58 +0200 Subject: [PATCH] [clangd] Collect comments from function definitions into t

[clang] [clang][analyzer] Fix #embed crash (PR #107764)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/5193 Here is the r

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-09 Thread Christian Kandeler via cfe-commits
ckandeler wrote: > At this point, my main feedback is that it would be good to include some unit > tests. `SymbolCollectorTests.cpp` is a good > place for them. I've added a new test and verified that it fails without this patch. > What is the purpose of the change to `ASTContext.cpp`? Ther

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-09 Thread Christian Kandeler via cfe-commits
@@ -1069,6 +1071,27 @@ void SymbolCollector::addDefinition(const NamedDecl &ND, Symbol S = DeclSym; // FIXME: use the result to filter out symbols. S.Definition = *DefLoc; + + std::string DocComment; + std::string Documentation; + if (!(S.Flags & Symbol::HasDocComment)

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/107850 Subscripting `Tuple`: `Tuple[str, str]` is not supported until python 3.9. Tested with python 3.8.19, 3.9.19 and 3.12.4. Fixes #107846 >From 36fff2ffdb29d8510c31464f6f6aad97721607c9 Mon Sep 17 00:00:00 2001 F

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Julian Schmidt (5chmidti) Changes Subscripting `Tuple`: `Tuple[str, str]` is not supported until python 3.9. Tested with python 3.8.19, 3.9.19 and 3.12.4. Fixes #107846 --- Full diff: https://github.com/llvm/llvm-project/pull/107850

[clang] cca54e3 - Revert "Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (#97308)"

2024-09-09 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2024-09-09T15:09:45+03:00 New Revision: cca54e347ac34912cdfb9983533c61836db135e0 URL: https://github.com/llvm/llvm-project/commit/cca54e347ac34912cdfb9983533c61836db135e0 DIFF: https://github.com/llvm/llvm-project/commit/cca54e347ac34912cdfb9983533c61836db135e0.diff

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: I pushed a revert now. My reduction did complete in the end - it's reproducible with a small snippet like this: ```c++ struct a { } constexpr b; class c { public: c(a); }; class B { public: using d = int; struct e { enum { f } g; int h; c i; d j{}; }; };

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-09 Thread Alex Voicu via cfe-commits
@@ -766,8 +766,17 @@ static void EmitAtomicOp(CodeGenFunction &CGF, AtomicExpr *Expr, Address Dest, // LLVM atomic instructions always have synch scope. If clang atomic // expression has no scope operand, use default LLVM synch scope. if (!ScopeModel) { +llvm::SyncSc

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-09 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: > What's the status of backend support for the large code model? That would > presumably be a prerequisite to landing this. It was just merged: https://github.com/llvm/llvm-project/pull/70308. https://github.com/llvm/llvm-project/pull/107817 ___

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-09-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From b50e49be3765c31b1c555384c41e1f528d529a88 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 9 Sep 2024 02:30:35 +0300 Subject: [PATCH] [Clang] prevent recovery call expression from proceeding with e

  1   2   3   4   5   >