================
@@ -39,3 +39,7 @@ Sections:
 
 # BSS: Contents of section .bss:
 # BSS-NEXT: <skipping contents of bss section at [12c8, 12cc)>
+
+# RUN: yaml2obj %p/Inputs/COFF/mipsel.yaml | llvm-objdump -s - | FileCheck %s 
--check-prefix=COFF-R4000
----------------
mstorsjo wrote:

This new test seems quite misplaced within this test file. Also I wonder if 
it'd be better to place this test perhaps in the `llvm/test/tools/yaml2obj` 
directory, and include a couple of the newly added relocations in the object 
file too, to have the test actually cover more of what's being added in this 
commit.

The handling of the `/machine:` flag values seems a bit unrelated to this 
commit, perhaps that can be split to another one? Or is it needed by some of 
the objdump aspects?

https://github.com/llvm/llvm-project/pull/107744
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to