================
@@ -0,0 +1,43 @@
+; RUN: llc -mtriple mipsel-windows-msvc -filetype=obj < %s | obj2yaml | 
FileCheck %s
+; RUN: llc -mtriple mipsel-windows-gnu -filetype=obj < %s | obj2yaml | 
FileCheck %s
----------------
mstorsjo wrote:

It feels to me like this test skips a couple steps.

It would be better to separate things out entirely; in `test/CodeGen/Mips`, 
you'd have a test that takes `.ll` and generates assembly, where you check the 
related aspects. (They're probably quite unspectacular at this point, that's 
fine. And if that's irrelevant at this point, perhaps that test can be skipped 
or deferred to a later patch?) Then in `test/MC/Mips`, you'd have a test that 
takes `.s` assembly input and verifies the output aspects of it. Such tests 
more often would use e.g. `objdump -d -r` rather than `obj2yaml` for inspecting 
the output object file too.

https://github.com/llvm/llvm-project/pull/107744
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to