https://github.com/mstorsjo commented:

I browsed through the first couple commits and added a couple pointers. Overall 
it looks reasonable, but things can probably be split up into even smaller 
commits for atomicity, which also would make it clearer where we'd want more 
test coverage.

https://github.com/llvm/llvm-project/pull/107744
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to