Author: ibiryukov
Date: Tue Sep 11 00:29:09 2018
New Revision: 341910
URL: http://llvm.org/viewvc/llvm-project?rev=341910&view=rev
Log:
[Tooling] Restore working dir in ClangTool.
Summary:
And add an option to disable this behavior. The option is only used in
AllTUsExecutor to avoid races when ru
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341910: [Tooling] Restore working dir in ClangTool.
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51864?vs=164686&id=164816#toc
Repository:
rC Clang
http
mgorny added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D50171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
In https://reviews.llvm.org/D51847#1228927, @zturner wrote:
> What prints this? How do you exercise this codepath?
DFGImpl::OutputDependencyFile() -> for (StringRef File : Files)
https://reviews.llvm.org/D51847
___
cfe-c
kbobyrev updated this revision to Diff 164821.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D51860
Files:
clang-tools-extra/clangd/index/Index.cpp
clang-tools-extra/clangd/index/Index.h
Index: clang-tools-extra/clangd/index/Index.h
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits::max();
+ uint32_t MaxCandidateCount = std::numeric_limits::m
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std:
takuto.ikuta updated this revision to Diff 164822.
takuto.ikuta added a comment.
I'm trying to handle local static var correctly.
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Driver/CLCompatOptions.td
clang/include/clang/Sema/Sema.h
clang/lib/Driver/ToolChains/Clang.cpp
cl
takuto.ikuta added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244
+ false))
+CmdArgs.push_back("-fvisibility-inlines-hidden");
+
hans wrote:
> takuto.ikuta wrote:
> > hans wrote:
> > > Huh, does this actually affect
JonasToth added a comment.
i had an issue with msvc before, where `-fno-delayed-template-parsing` had to
be added to the compilation, because MSVC did not have uninstantiated
templates. Maybe this could be similar? But i am not sure how to resolve the
issue here, as you probably can't pass in f
ilya-biryukov added a comment.
Also can't explain why `const` and `volatile` have a different priority now.
The `P::` and `Q::` seem to be completely different completion items from `P`
and `Q` (wildly different priorities suggest they're not the same), can't
explain what caused the first ones n
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits::max();
+ uint32_t MaxCandidateCount = std::numeric_limi
JonasToth added a comment.
In https://reviews.llvm.org/D50953#1230003, @shuaiwang wrote:
> In https://reviews.llvm.org/D50953#1229287, @JonasToth wrote:
>
> > What happens to pointers in a typedef (in the sense of `*` instead of `&`)?
>
>
> I checked around and I believe reference type is the onl
kadircet created this revision.
kadircet added reviewers: sammccall, ilya-biryukov, ioeric.
Herald added a subscriber: cfe-commits.
Factors out member decleration gathering and uses it in parsing to call
signature
help. Doesn't support signature help for base class constructors, the code was
too
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits::max();
+ uint32_t MaxCandidateCount = std::numeric_limits::
JonasToth added inline comments.
Comment at: unittests/clang-tidy/ExprMutationAnalyzerTest.cpp:658
+ "void f() { UniquePtr x; x->mf(); }");
+ Results = match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());
+ EXPECT_FALSE(isMutated(Results, AST.
kadircet added a comment.
In https://reviews.llvm.org/D51297#1228725, @ioeric wrote:
> I also support having some instructions/pointers on editor integration. That
> said, I think we should have a section "Editor integration" with a list of
> editor clients that are known to work with clangd, i
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm!
Please add a note to docs/ReleaseNotes.rst when landing.
https://reviews.llvm.org/D51391
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits::max();
+ uint32_t MaxCandidateCount = std::numeric_limits::max
ilya-biryukov added inline comments.
Comment at: include/clang/Sema/Sema.h:10798
+ValueDecl *tryGetMember(CXXRecordDecl *ClassDecl, CXXScopeSpec &SS,
+ParsedType TemplateTypeTy,
The name is very generic, but the helper is only applicable
sammccall added a comment.
Nice and simple :-) Looks good, just some details.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:1
+//===--- DexBenchmark.cpp - DexIndex benchmarks -*- C++
-*-===//
+//
rename? (it's not just dex
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits::max();
+ uint32_t MaxCandidateCount = std::numeric_limi
kadircet updated this revision to Diff 164830.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Change flag's name and rebase.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51214
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
ilya-biryukov added a comment.
LG from my side, @sammccall is not a big fan of options so please wait for his
approval too
Comment at: clangd/tool/ClangdMain.cpp:174
+llvm::cl::desc(
+"Enables suggestion of completion items that needs additional changes.
"
+
kbobyrev updated this revision to Diff 164834.
kbobyrev marked 8 inline comments as done.
kbobyrev added a comment.
Address a round of comments; implement a dummy ad-hoc subcommand parser.
https://reviews.llvm.org/D51628
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clang
kbobyrev updated this revision to Diff 164836.
https://reviews.llvm.org/D51860
Files:
clang-tools-extra/clangd/index/Index.cpp
clang-tools-extra/clangd/index/Index.h
Index: clang-tools-extra/clangd/index/Index.h
===
--- clang-t
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:197
+static llvm::cl::opt IncludeFixIts(
+"include-fixits",
ilya-biryukov wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > I wonder if we should make the `IncludeFixIts` option
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits::max();
+ uint32_t MaxCandidateCount = std::numeric_limits::m
AlistairD updated this revision to Diff 164835.
https://reviews.llvm.org/D51411
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/to_addr_builtin.cl
Index: test/SemaOpenCL/to_addr_builtin.cl
JonasToth added a comment.
In https://reviews.llvm.org/D51880#1229513, @aaron.ballman wrote:
> Missing tests and changes to Registry.cpp for dynamic matchers.
>
> Also, do you want to add `isInstantiationDependent()` at the same time, given
> the relationship with the other two matchers?
Do yo
AlistairD added a comment.
Reworded warning message, switched warning off by default, and added it to
-Wconversion group
https://reviews.llvm.org/D51411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: omtcyfz
Date: Tue Sep 11 03:31:38 2018
New Revision: 341921
URL: http://llvm.org/viewvc/llvm-project?rev=341921&view=rev
Log:
[clangd] NFC: Use uint32_t for FuzzyFindRequest limits
Reviewed By: ioeric
Differential Revision: https://reviews.llvm.org/D51860
Modified:
clang-tools-extra
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/dexplorer/Dexplorer.cpp:39
+
+// FIXME(kbobyrev): Make this an actual REPL: probably use LLVM Command Line
+// library for parsing flags and arguments.
ilya-biryukov wrote:
> kbobyrev wrote:
> >
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341921: [clangd] NFC: Use uint32_t for FuzzyFindRequest
limits (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51860?vs=
sammccall created this revision.
sammccall added a reviewer: bkramer.
Herald added subscribers: cfe-commits, fedor.sergeev.
Most callers I can find are using only `getName()`. Type is used by the
recursive iterator.
Now we don't have to call stat() on every listed file (on most platforms).
Except
kbobyrev updated this revision to Diff 164841.
kbobyrev added a comment.
Outline the structure for "Editor Integration" section which is to be filled
with other options later.
https://reviews.llvm.org/D51297
Files:
clang-tools-extra/docs/clangd.rst
Index: clang-tools-extra/docs/clangd.rst
Author: d0k
Date: Tue Sep 11 03:37:08 2018
New Revision: 341925
URL: http://llvm.org/viewvc/llvm-project?rev=341925&view=rev
Log:
[clang-tidy] Add a missing comma after "flags"
Added:
clang-tools-extra/trunk/test/clang-tidy/Inputs/absl/flags/
clang-tools-extra/trunk/test/clang-tidy/Inputs
kbobyrev added a comment.
@ioeric does it look better now?
https://reviews.llvm.org/D51292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
Dexplorer is a long name. How about shortening it to `dexp`?
Comment at: clang-tools-extra/clangd/index/dex/dexplorer/DExplorer.cpp:56
+
+template
+void reportTime(StringRef Name, Function F) {
Why do we want `TimeUnit`?
It adds
sammccall added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:135
+ // For compatibility with old Status-based API. Prefer using Path directly.
+ StringRef getName() const { return Path; }
+};
Backwards-compatibility notes:
- Almost all
ilya-biryukov added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:197
+static llvm::cl::opt IncludeFixIts(
+"include-fixits",
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > ilya-biryukov wrote:
> > > > I wonder if we should mak
asavonic added a comment.
In https://reviews.llvm.org/D51544#1229105, @Anastasia wrote:
> > With this setup, we can compile opencl-c-common.h, opencl-c-fp16.h and
> > opencl-c-fp64.h into PCHs with one set of extensions/OpenCL version,
> > and use them for any other set of extensions/OpenCL ver
kadircet updated this revision to Diff 164844.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Move ValueDecl extraction to a helper.
- Call completion handlers as well.
Repository:
rC Clang
https://reviews.llvm.org/D51917
Files:
include/clang/Sema/Sema.h
lib/Parse
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51924
Files:
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/Code
ilya-biryukov added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3472
+ParseExpressionList(ArgExprs, CommaLocs, [&] {
+ if (CalledSignatureHelp)
+return;
Let's always call signature help and code completion here to be consi
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/dexplorer/DExplorer.cpp:23
+#include "llvm/Support/Signals.h"
+#include "llvm/Support/YAMLTraits.h"
+#include
why?
Comment at: clang-tools-extra/clangd/index/dex/d
kadircet updated this revision to Diff 164847.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Update descriptions and change parameter name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51214
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/Cla
sammccall added a comment.
I think I'm still where I was a few weeks ago - option to drop args makes
sense, completions with fixes isn't something users should care about.
Comment at: clangd/tool/ClangdMain.cpp:197
+static llvm::cl::opt IncludeFixIts(
+"include-fixits",
kbobyrev updated this revision to Diff 164848.
kbobyrev marked 6 inline comments as done.
kbobyrev added a comment.
Address few comments (not all of them for now, though).
https://reviews.llvm.org/D51090
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/benchmarks/CMak
calixte updated this revision to Diff 164851.
calixte added a comment.
- Add some ImplicitCode when there is some stuff at the end of a function
- Fix the tests
Repository:
rC Clang
https://reviews.llvm.org/D49916
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen
aaron.ballman added a comment.
In https://reviews.llvm.org/D51880#1230221, @JonasToth wrote:
> In https://reviews.llvm.org/D51880#1229513, @aaron.ballman wrote:
>
> > Missing tests and changes to Registry.cpp for dynamic matchers.
> >
> > Also, do you want to add `isInstantiationDependent()` at t
Author: d0k
Date: Tue Sep 11 05:19:45 2018
New Revision: 341929
URL: http://llvm.org/viewvc/llvm-project?rev=341929&view=rev
Log:
[clang-tidy] Insert absl::StrAppend when replacing StrCat.
There might be no using decl for StrAppend around, inserting the
qualified name is less likely to break thin
ilya-biryukov added inline comments.
Comment at: include/clang/Sema/Sema.h:4571
+ /// Tries to get decleration for a member field.
+ ValueDecl *tryLookupCtorInitMemberDecl(CXXRecordDecl *ClassDecl,
s/decleration/declaration.
Maybe even remove the comment? th
Author: jbcoe
Date: Tue Sep 11 05:44:52 2018
New Revision: 341930
URL: http://llvm.org/viewvc/llvm-project?rev=341930&view=rev
Log:
[python bindings] Expose getNumTemplateArguments
Expose the C bindings for clang_Type_getNumTemplateArguments() and
clang_Type_getTemplateArgumentAsType() in the pyt
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341930: [python bindings] Expose getNumTemplateArguments
(authored by jbcoe, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51299?vs=162667&id=164854#toc
Repository:
rL LLVM
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341930: [python bindings] Expose getNumTemplateArguments
(authored by jbcoe, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51299
Files:
cfe/t
lorincbalog created this revision.
lorincbalog added reviewers: rizsotto.mailinglist, dcoughlin.
Herald added subscribers: cfe-commits, whisperity.
During the mapping of functions for cross-translation unit analysis, the
functions' names and the containing files are collected by clang-func-mappin
Author: jonastoth
Date: Tue Sep 11 06:01:49 2018
New Revision: 341933
URL: http://llvm.org/viewvc/llvm-project?rev=341933&view=rev
Log:
[NFC][clangd] fix warning for extra semicolon
Modified:
clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp
Modified: clang-tools-extra/trunk/unittests/
ilya-biryukov added a comment.
+1 to adding an option to drop arguments from snippets and removing the option
for the fixes.
Comment at: clangd/tool/ClangdMain.cpp:197
+static llvm::cl::opt IncludeFixIts(
+"include-fixits",
sammccall wrote:
> ilya-biryuk
kadircet added a comment.
In https://reviews.llvm.org/D51747#1229066, @sammccall wrote:
> In https://reviews.llvm.org/D51747#1228919, @ilya-biryukov wrote:
>
> > > Most of the value of adding an option is: if someone complains, we can
> > > tell them to go away :-) One possible corollary is: we
sammccall added a comment.
In https://reviews.llvm.org/D51747#1230420, @kadircet wrote:
> In https://reviews.llvm.org/D51747#1229066, @sammccall wrote:
>
> > In https://reviews.llvm.org/D51747#1228919, @ilya-biryukov wrote:
> >
> > > > Most of the value of adding an option is: if someone complain
calixte updated this revision to Diff 164860.
calixte added a comment.
- only put an ImplicitCode for EmitLandingPad
- fix tests (were broken with clanf-format-diff)
Repository:
rC Clang
https://reviews.llvm.org/D49916
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/Co
Author: rksimon
Date: Tue Sep 11 06:42:15 2018
New Revision: 341938
URL: http://llvm.org/viewvc/llvm-project?rev=341938&view=rev
Log:
Remove unnecessary semicolon to silence -Wpedantic warning. NFCI.
Modified:
clang-tools-extra/trunk/clangd/RIFF.cpp
Modified: clang-tools-extra/trunk/clangd/R
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51747#1229066, @sammccall wrote:
> A few thoughts here:
>
> - does CDB describe user or project preferences? unclear.
Agree, it's a mix, defaults are from the project but users can add extra flags.
> - "show this warning for code I bu
JonasToth updated this revision to Diff 164863.
JonasToth added a comment.
- add isInstantiationDependent matcher as well
- add unit tests for new matchers
Repository:
rC Clang
https://reviews.llvm.org/D51880
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.
kadircet updated this revision to Diff 164864.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rC Clang
https://reviews.llvm.org/D51917
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaCodeComplete.cpp
li
kadircet added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:197
+static llvm::cl::opt IncludeFixIts(
+"include-fixits",
ilya-biryukov wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > I wonder if we should make the `IncludeFixIts` option h
kbobyrev updated this revision to Diff 164865.
kbobyrev marked 19 inline comments as done.
kbobyrev added a comment.
Address comments.
https://reviews.llvm.org/D51628
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt
clang-tools-extra/cl
Author: abataev
Date: Tue Sep 11 06:59:10 2018
New Revision: 341939
URL: http://llvm.org/viewvc/llvm-project?rev=341939&view=rev
Log:
[OPENMP] Simplified checks for declarations in declare target regions.
Sema analysis should not mark functions as an implicit declare target,
it may break codegen.
kadircet updated this revision to Diff 164866.
kadircet added a comment.
- Update tests.
Repository:
rC Clang
https://reviews.llvm.org/D51917
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaCodeComplete.cpp
lib/Sema/SemaDeclCXX.cpp
test/CodeCompletion/ctor-
mgorny updated this revision to Diff 164871.
mgorny added a comment.
Ai, sorry about that. Uploaded the proper diff now. I suppose it's not going to
make it for 7.0.0 anymore, so it's not a priority. I'll try to bisect it today
once I finish testing RC3.
https://reviews.llvm.org/D50171
Files:
JonasToth updated this revision to Diff 164873.
JonasToth added a comment.
- fix typos, include example in doc and adjust tests
Repository:
rC Clang
https://reviews.llvm.org/D51880
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/
JonasToth updated this revision to Diff 164876.
JonasToth added a comment.
rebase to master
Repository:
rC Clang
https://reviews.llvm.org/D51880
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers
ilya-biryukov added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:205
+static llvm::cl::opt EnableFunctionArgSnippets(
+"enable-function-arg-snippets",
+llvm::cl::desc("Gives snippets for function arguments, when disabled only "
sammccall wrote:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Really just details now.
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:56
+// llvm::formatv string pattern for pretty-printing symbols.
+static const aut
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the fix!
Repository:
rC Clang
https://reviews.llvm.org/D51917
___
cfe-commits mailing list
cfe-commits@lists.ll
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt:10
+ Dexp.cpp
+ )
+
Should we indent closing parens to the opening one or keep at the start of the
line?
Let's pick one style and be consistent (the best op
kbobyrev updated this revision to Diff 164881.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
The only problem left is that I'm not sure how to run binary which is not under
bin (`IndexBenchmark`) using llvm-lit.
https://reviews.llvm.org/D51090
Files:
clang-tools-extra/
Author: kadircet
Date: Tue Sep 11 08:02:18 2018
New Revision: 341949
URL: http://llvm.org/viewvc/llvm-project?rev=341949&view=rev
Log:
[CodeCompletion] Enable signature help when initializing class/struct/union
members.
Summary:
Factors out member decleration gathering and uses it in parsing to
lebedev.ri added a comment.
In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote:
> The only problem left is that I'm not sure how to run binary which is not
> under bin (`IndexBenchmark`) using llvm-lit.
But it's a //benchmark//.. What use could be from running it as part of the
_test
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341949: [CodeCompletion] Enable signature help when
initializing class/struct/union… (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51917?vs=164866&id=164883#t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341949: [CodeCompletion] Enable signature help when
initializing class/struct/union… (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
teemperor updated this revision to Diff 164885.
teemperor marked 3 inline comments as done.
teemperor added a comment.
- Removed comment about redeclaring free in the test. That's wasn't correctly
formulated and is anyway no longer true now that the test case including this
file got bigger.
- Fi
Author: kadircet
Date: Tue Sep 11 08:12:10 2018
New Revision: 341950
URL: http://llvm.org/viewvc/llvm-project?rev=341950&view=rev
Log:
[clangd] Add unittests for D51917
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341950: [clangd] Add unittests for D51917 (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51924?vs=164845&id=164886#toc
I mean in practice. What command do i run to hit this and what will the
output look like? Can you paste some terminal output showing the command
and output?
On Tue, Sep 11, 2018 at 12:55 AM Dávid Bolvanský via Phabricator <
revi...@reviews.llvm.org> wrote:
> xbolva00 added a comment.
>
> In https:
aprantl added inline comments.
Comment at: docs/Modules.rst:470
+*platform variant*
+ A specific os/platform variant (e.g. ``ios``, ``macos``, ``android``,
``win32``, ``linux``, etc) is available.
Does this work with platforms+environment combinations, such a
zturner added a comment.
I mean in practice. What command do i run to hit this and what will the
output look like? Can you paste some terminal output showing the command
and output?
https://reviews.llvm.org/D51847
___
cfe-commits mailing list
cfe-co
kbobyrev updated this revision to Diff 164887.
kbobyrev added a comment.
Find a hacky workaround to call `IndexBenchmark` binary.
https://reviews.llvm.org/D51090
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/benchmarks/CMakeLists.txt
clang-tools-extra/clangd/benc
lebedev.ri added a comment.
In https://reviews.llvm.org/D51090#1230629, @sammccall wrote:
> In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote:
> >
> > > The only problem left is that I'm not sure how to run binary whic
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote:
> In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote:
>
> > The only problem left is that I'm not sure how to run b
whisperity added a comment.
Will this properly synergise across compilers with user-specified warning
options, such as `-Wall -Werror`?
Repository:
rC Clang
https://reviews.llvm.org/D51926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kbobyrev updated this revision to Diff 164893.
kbobyrev marked 9 inline comments as done.
kbobyrev added a comment.
Address comments
https://reviews.llvm.org/D51628
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt
clang-tools-extra/clan
kbobyrev updated this revision to Diff 164895.
kbobyrev added a comment.
Add `--benchmark_min_time=0.01` to prevent testing time increase.
https://reviews.llvm.org/D51090
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/benchmarks/CMakeLists.txt
clang-tools-extra/cl
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:55
+
+// llvm::formatv string pattern for pretty-printing symbols.
+void fuzzyFind(llvm::StringRef UnqualifiedName, const SymbolIndex &Index) {
Is this a leftover fr
Anastasia added a comment.
In https://reviews.llvm.org/D51544#1230264, @asavonic wrote:
> In https://reviews.llvm.org/D51544#1229105, @Anastasia wrote:
>
> > > With this setup, we can compile opencl-c-common.h, opencl-c-fp16.h and
> > > opencl-c-fp64.h into PCHs with one set of extensions/OpenCL
JonasToth updated this revision to Diff 164898.
JonasToth added a comment.
- ignore lambdas properly
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp
clang-tidy/c
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D51880
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: juliehockett
Date: Tue Sep 11 08:56:55 2018
New Revision: 341955
URL: http://llvm.org/viewvc/llvm-project?rev=341955&view=rev
Log:
Reland "Implement a (simple) Markdown generator"
Relanding with fixes to tests for the failing bots.
Differential Revision: https://reviews.llvm.org/D43424
1 - 100 of 175 matches
Mail list logo
