sammccall added inline comments.

================
Comment at: include/clang/Basic/VirtualFileSystem.h:135
+  // For compatibility with old Status-based API. Prefer using Path directly.
+  StringRef getName() const { return Path; }
+};
----------------
Backwards-compatibility notes:

 - Almost all users of `directory_iterator` require no source changes (with 
this change)
 - Implementations of VFS require changes if they support directory iteration 
and do not merely wrap other VFSes. Anecdotally, most do not require changes. 

So this weird API seems worth having to make out-of-tree breakages less painful.
Happy to update the internal uses though if that seems worthwhile.


Repository:
  rC Clang

https://reviews.llvm.org/D51921



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to