ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits<size_t>::max(); + uint32_t MaxCandidateCount = std::numeric_limits<uint32_t>::max(); /// If set to true, only symbols for completion support will be considered. ---------------- kbobyrev wrote: > ioeric wrote: > > Or use `unsigned`? > `unsigned` would have different size on different platforms, I'm not really > sure we want that; could you elaborate on why you think that would be better? I thought it's (almost) always 4 bytes? But it should always have a smaller size than `uint64_t` in json serialization, so it should work for us. In general, I would prefer `unsigned` to `uint32_t` when possible. For most of the platforms, they are the same. But up to you :) I don't really feel strong about this. https://reviews.llvm.org/D51860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
