cloud-fan commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2058983611
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,27 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
- uninterruptibleLock.synchronized {
- if (uninterruptible) {
- shouldInterruptThread = true
+ if (uninterruptibleLock.synchronized {
Review Comment:
code style nit: shall we move the if condition into a method like `def
shouldDoInterruption`?
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,27 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
- uninterruptibleLock.synchronized {
- if (uninterruptible) {
- shouldInterruptThread = true
+ if (uninterruptibleLock.synchronized {
Review Comment:
code style nit: shall we move the if condition into a method like `def
shouldDoThreadInterruption`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
