mridulm commented on PR #50594:
URL: https://github.com/apache/spark/pull/50594#issuecomment-2829589932
Ok, I see the problem.
The expectation is for begin and end to be within try/finally - but usually
coding pattern would result in the try being used to catch InterruptedException
and handle it there (via interrupt).
So instead of :
```
try {
begin();
try {
expensiveOp();
} finally {
end();
}
} catch (InterruptedException ex) {
Thread.currentThread.interrupt();
}
```
it is common to do:
```
begin();
try {
expensiveOp();
} catch (InterruptedException ex) {
Thread.currentThread.interrupt();
} finally {
end();
}
```
Thanks for the PR, let me take a look at the proposed change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
