vrozov commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2057232921
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,17 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
- uninterruptibleLock.synchronized {
- if (uninterruptible) {
- shouldInterruptThread = true
- } else {
+ if (uninterruptibleLock.synchronized {
+ shouldInterruptThread = uninterruptible
+ awaitInterruptThread = !shouldInterruptThread
+ awaitInterruptThread
Review Comment:
I was referring to a use case where `interrupt()` is called several times
from the same thread or from different threads but not concurrently. For the
concurrent calls to `interrupt()` I already provided new version with the fix
similar to what you also proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
