cloud-fan commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2057273595
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,17 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
- uninterruptibleLock.synchronized {
- if (uninterruptible) {
- shouldInterruptThread = true
- } else {
+ if (uninterruptibleLock.synchronized {
+ shouldInterruptThread = uninterruptible
+ awaitInterruptThread = !shouldInterruptThread
+ awaitInterruptThread
Review Comment:
> use case where interrupt() is called several times from the same thread or
from different threads
I don't think this can happen w.r.t. how Spark uses `UninterruptibleThread`.
It's a private API that only Spark can use. Plus I don't think it's an issue if
we run `super.interrupt` only once even if `UninterruptibleThread#interrupt`
has been invoked multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
