cloud-fan commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2056601639
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,17 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
- uninterruptibleLock.synchronized {
- if (uninterruptible) {
- shouldInterruptThread = true
- } else {
+ if (uninterruptibleLock.synchronized {
+ shouldInterruptThread = uninterruptible
+ awaitInterruptThread = !shouldInterruptThread
+ awaitInterruptThread
Review Comment:
I'm thinking about something like this
```
def interrupt() {
def shouldInterrupt() = uninterruptibleLock.synchronized {
shouldInterruptThread = true
awaitInterruptThread = !uninterruptible
awaitInterruptThread
}
if (shouldInterrupt()) {
try {
super.interrupt()
} finally {
latch.countDown()
}
}
}
def runUninterruptibly() {
...
uninterruptibleLock.synchronized {
uninterruptible = true
}
if (uninterruptibleLock.synchronized(awaitInterruptThread)) {
latch.await(...)
// Clear the interrupted status if it's set.
Thread.interrupted()
}
try {
f
} ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
