vrozov commented on PR #50378: URL: https://github.com/apache/spark/pull/50378#issuecomment-2753232519
@HyukjinKwon > why don't you open your PR and replace this change? Once the consensus is made in your PR, your change will be merged. If you think my veto in your PR is a problem, that's fine. I can revoke and see if there is a consensus made in your PR. The PR is already open. It is WIP as I don't have all tests properly skipped/disabled yet. The approach on the PR is already clear and can be reviewed. If it is not clear, I can clarify once comments/questions are added to the PR. In general it is what @dongjoon-hyun proposed: 1. Remove jars and disable affected tests 2. Re-enable tests one by one or all at once after source code for the jars is available in follow up PRs. As long as the PR has -1 veto, I do not plan to continue working on it. I am OK to resume working on the PR assuming that 1. PR will be merged into the master. 2. It is up to committers/PMCs to decide whether it should also go into 4.0 or can wait. > There is only one thing to discuss here. Do we want to run tests although it's not the best way? My answer is yes. Your answer is no. Sorry, we are going in circles here. My answer is 1. Legal issue takes priority over tests 2. Tests can be enabled back once source code for tests jars is reconstructed. 3. Approach that deletes jars during release process does not sound. Maybe you can point me to another project that does the same? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
