LuciferYang commented on code in PR #50378: URL: https://github.com/apache/spark/pull/50378#discussion_r2013712753
########## dev/create-release/release-tag.sh: ########## @@ -106,6 +106,8 @@ sed -i".tmp7" 's/SPARK_VERSION:.*$/SPARK_VERSION: '"$NEXT_VERSION"'/g' docs/_con sed -i".tmp8" 's/SPARK_VERSION_SHORT:.*$/SPARK_VERSION_SHORT: '"$R_NEXT_VERSION"'/g' docs/_config.yml # Update the version index of DocSearch as the short version sed -i".tmp9" "s/'facetFilters':.*$/'facetFilters': [\"version:$R_NEXT_VERSION\"]/g" docs/_config.yml +# Remove test jars that do not beling to source releases. +rm $(<dev/test-jars.txt) Review Comment: @HyukjinKwon Suppose we are releasing version 4.0. Is the process for `tag` after this pull request as follows? 1. Pull a `branch-4.0` branch. 2. Remove jars from `branch-4.0`. 3. Set the version to 4.0.0 using Maven. 4. Use this branch to create a `4.0-rcX` tag. At this point, the `4.0-rcX` tag will not include these jars. 5. Set the version to 4.0.1-SNAPSHOT using Maven. 6. Push the previous commits to `branch-4.0`. If this is the case, will the jars removed in step 2 be permanently lost after one `tag` operation? It seems that we should revert the commit from step 2 between steps 4 and 5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
