HeartSaVioR commented on code in PR #50378:
URL: https://github.com/apache/spark/pull/50378#discussion_r2013371019
##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -244,10 +244,11 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
test("add and list jar files") {
- val jarPath =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
+ val testJar =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
Review Comment:
No, you can't compare this with non-conditional thing.
Having `;` or not does not have any effect and it's de-facto to not have `;`
in the end. It's not selectively applied.
But, the definition of "pure method" is quite unclear (I think I said there
are multiple interpretations) - the main problem here is that it's
"selectively" applied. If we enforce this, there will be always an argument
just to have () or not, and in some cases, both could be right depending on the
viewpoint. This is a waste of time for everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
