vrozov commented on code in PR #50378:
URL: https://github.com/apache/spark/pull/50378#discussion_r2013342168
##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -244,10 +244,11 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
test("add and list jar files") {
- val jarPath =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
+ val testJar =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
Review Comment:
@HyukjinKwon you did not answer my question. You don't need to answer or
pay attention to the style discussion with @HeartSaVioR.
> How that minimizes the change? Please elaborate. All I see is that jarPath
->testJar. Why you can't simply add assume(jarPath != null) on line 248?
@HeartSaVioR I agree that it may not be always enforced by the style
formatter (I did not mean to enforce it by the formatter). For example extra
`;` may not be enforced by the formatter and it is necessary to delegate that
to PR reviewers/committers. IMO, the same should be applied to the code above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
