cloud-fan commented on PR #50378: URL: https://github.com/apache/spark/pull/50378#issuecomment-2753395858
> Legal issue takes priority over tests 100% agree > Tests can be enabled back once source code for tests jars is reconstructed. This is true but the question is how long it takes? It's possible that no one has the source code anymore and this can never be done. I think the current approach (although not perfect, it fixes the legal issue) is better than disabling the tests and losing test coverage. That said, I'm open to other solutions but if we can't find something better, I think we should proceed with the current approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
