HeartSaVioR commented on code in PR #50378:
URL: https://github.com/apache/spark/pull/50378#discussion_r2013090284


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -244,10 +244,11 @@ class SparkContextSuite extends SparkFunSuite with 
LocalSparkContext with Eventu
   }
 
   test("add and list jar files") {
-    val jarPath = 
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
+    val testJar = 
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")

Review Comment:
   @vrozov 
   Again, the strict check we are doing is based on "Spark" Scala style guide. 
You can't just push someone beyond Scala style guide for style fix. That is a 
room we leave to committers; e.g. say, there are two empty lines, someone 
strongly concerns about style may require to reduce this to one, but some other 
may just allow this. Thanks for the suggestion anyway, but this is not an 
enforcement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to