vrozov commented on code in PR #50378:
URL: https://github.com/apache/spark/pull/50378#discussion_r2012753478
##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -244,10 +244,11 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
test("add and list jar files") {
- val jarPath =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
+ val testJar =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
Review Comment:
@HyukjinKwon why the change(rename) is necessary?
@HeartSaVioR regarding our
[discussion](https://github.com/apache/spark/pull/50348#discussion_r2011212796).
IMO, it should follow the same style either with `()` or without `()`. Mixing
them on the same line is a bad practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
