HeartSaVioR commented on code in PR #50378:
URL: https://github.com/apache/spark/pull/50378#discussion_r2012994563
##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -244,10 +244,11 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
test("add and list jar files") {
- val jarPath =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
+ val testJar =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
Review Comment:
@vrozov
In overall, I think we are not here to just nitpick.
For style, we have [Scala style
guide](https://github.com/databricks/scala-style-guide) which is used across
projects Databricks was original author of that.
(Worth noting that this representation is not violating ASF policy -
https://apache.org/foundation/faq.html#can-i-refer-to-an-individual-or-organization-as-the-founder-or-creator-of-an-asf-project
- I'm mentioning this because this seems to be an ongoing discussion/debate in
incubation mailing list).
Beyond that Scala style guide, we are not being super strict on Scala
Idiomatic, because they define this to ambiguous and there will be so many
arguments if we decide to strictly follow it. See, you should have read the
thread on Scala which people expands what is "pure" method. I don't think this
can be a definite guide unless they resolve such an ambiguiousity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
