vrozov commented on code in PR #50378:
URL: https://github.com/apache/spark/pull/50378#discussion_r2013057946
##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -244,10 +244,11 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
test("add and list jar files") {
- val jarPath =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
+ val testJar =
Thread.currentThread().getContextClassLoader.getResource("TestUDTF.jar")
Review Comment:
@HeartSaVioR I am not trying to nitpick on the Scala style. IMO, style is
needed to make code more readable and consistent. My comment to you on this PR
is not related to the jar removal and ASF release policy. The comment is
related to the [discussion
](https://github.com/apache/spark/pull/50348#discussion_r2011212796) on my PR
and I just wanted to provide an example of inconsistent style that may cause
confusion (is `getContextClassLoader` method more "pure" than
`currentThread()`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
