Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Add run unit tests of external jdbc tables for MySQL ...................................................................... Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/20710/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20710/5//COMMIT_MSG@7 PS5, Line 7: run nit: remove run http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/copy-ext-data-sources.sh File testdata/bin/copy-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/copy-ext-data-sources.sh@58 PS5, Line 58: # Download and Copy mysql JDBC driver to HDFS : cd /tmp && wget "https://downloads.mysql.com/archives/get/p/3/file/\ : mysql-connector-j-8.1.0.tar.gz" : tar xvzf mysql-connector-j-8.1.0.tar.gz : : hadoop fs -put -f \ : /tmp/mysql-connector-j-8.1.0/mysql-connector-j-8.1.0.jar \ : ${JDBC_DRIVERS_HDFS_PATH}/mysql-jdbc.jar : : echo "Copied" ${IMPALA_HOME}/fe/target/dependency/mysql-*.jar \ : "into HDFS" ${JDBC_DRIVERS_HDFS_PATH} : : # Cleanup the jar : rm -rf /tmp/mysql-connector-j-8* don't need to download mysql driver here http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/create-ext-mysql-data-source-table.sql File testdata/bin/create-ext-mysql-data-source-table.sql: http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/create-ext-mysql-data-source-table.sql@77 PS5, Line 77: AllTypesWithQuote nit: change table name as AllTypesCaseSensitiveNames http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/load-ext-data-sources.sh File testdata/bin/load-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/load-ext-data-sources.sh@a80 PS5, Line 80: nit: unnecessary change http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/setup-mysql-env.sh File testdata/bin/setup-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/setup-mysql-env.sh@32 PS5, Line 32: sleep 10 Check if mysql server is ready and retry 10 times if failed. http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/setup-mysql-env.sh@81 PS5, Line 81: AllTypesWithQuote change table name as AllTypesCaseSensitiveNames http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/bin/setup-mysql-env.sh@108 PS5, Line 108: AllTypesWithQuote nit: change table name http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/20710/5/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@70 PS5, Line 70: AllTypesWithQuote change table name as AllTypesCaseSensitiveNames http://gerrit.cloudera.org:8080/#/c/20710/5/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20710/5/tests/custom_cluster/test_ext_data_sources.py@88 PS5, Line 88: # if cls.exploration_strategy() != 'exhaustive': : # pytest.skip('These tests only run in exhaustive') make the test ran only for exhaustive test. -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 21:40:29 +0000 Gerrit-HasComments: Yes
