Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Add unit tests of external jdbc tables for MySQL ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/bin/load-ext-data-sources.sh File testdata/bin/load-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/bin/load-ext-data-sources.sh@a80 PS6, Line 80: nit: revert unnecessary change http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@41 PS6, Line 41: /test-warehouse/data-sources/jdbc-drivers/mysql-jdbc.jar To support s3 and Ozone, need to add $FILESYSTEM_PREFIX as "$FILESYSTEM_PREFIX/test-warehouse/data-sources/jdbc-drivers/mysql-jdbc.jar" http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@67 PS6, Line 67: "hdfs://localhost:20500/test-warehouse/data-sources/jdbc-drivers/mysql-jdbc.jar" To support s3 and Ozone, need to change hdfs to $FILESYSTEM_PREFIX, like "$FILESYSTEM_PREFIX/test-warehouse/data-sources/jdbc-drivers/mysql-jdbc.jar" -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 18:08:39 +0000 Gerrit-HasComments: Yes
