Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Add unit tests of external jdbc tables for MySQL ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/bin/setup-mysql-env.sh File testdata/bin/setup-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/bin/setup-mysql-env.sh@32 PS6, Line 32: sudo docker stop mysql nit: indent the lines in while loop http://gerrit.cloudera.org:8080/#/c/20710/6/testdata/bin/setup-mysql-env.sh@42 PS6, Line 42: Should we exit with error if mysql is still not ready? -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 17:58:20 +0000 Gerrit-HasComments: Yes
