Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20710 )

Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables 
for mysql
......................................................................


Patch Set 1:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/copy-ext-data-sources.sh
File testdata/bin/copy-ext-data-sources.sh:

http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/copy-ext-data-sources.sh@59
PS1, Line 59: cd /tmp && wget 
https://downloads.mysql.com/archives/get/p/3/file/mysql-connector-j-8.1.0.tar.gz
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/copy-ext-data-sources.sh@60
PS1, Line 60: tar xvzf mysql-connector-j-8.1.0.tar.gz
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh
File testdata/bin/load-ext-data-sources.sh:

http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@108
PS1, Line 108: sudo mysql -h localhost -P 3306 --protocol=tcp -u root -e 'drop 
database if exists functional;\
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@113
PS1, Line 113:   GRANT CREATE, ALTER, DROP, INSERT, UPDATE, DELETE, SELECT ON 
functional.alltypes TO "hiveuser";'
line too long (98 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@134
PS1, Line 134: sudo mysql -h localhost -P 3306 --protocol=tcp -u root 
functional < /tmp/mysql_jdbc_alltypes.sql
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@154
PS1, Line 154: sudo mysql -h localhost -P 3306 --protocol=tcp -u root 
functional < /tmp/mysql_jdbc_alltypes_with_quote.sql
line too long (107 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@158
PS1, Line 158: loadCmd="LOAD DATA LOCAL INFILE '/tmp/mysql_jdbc_alltypes.csv' 
INTO TABLE alltypes COLUMNS TERMINATED BY ','"
line too long (109 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@159
PS1, Line 159: sudo mysql -h localhost -P 3306 --protocol=tcp --local-infile -u 
root functional -e "$loadCmd"
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@161
PS1, Line 161: loadCmd="LOAD DATA LOCAL INFILE '/tmp/mysql_jdbc_alltypes.csv' 
INTO TABLE AllTypesWithQuote COLUMNS TERMINATED BY ','"
line too long (118 > 90)


http://gerrit.cloudera.org:8080/#/c/20710/1/testdata/bin/load-ext-data-sources.sh@162
PS1, Line 162: sudo mysql -h localhost -P 3306 --protocol=tcp --local-infile -u 
root functional -e "$loadCmd"
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/20710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae
Gerrit-Change-Number: 20710
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 15 Nov 2023 19:52:04 +0000
Gerrit-HasComments: Yes

Reply via email to