Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql ...................................................................... Patch Set 2: (3 comments) separate the code changes in these three files as new files, then add a new class in tests/custom_cluster/test_ext_data_sources.py for MySQL. http://gerrit.cloudera.org:8080/#/c/20710/2/testdata/bin/copy-ext-data-sources.sh File testdata/bin/copy-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20710/2/testdata/bin/copy-ext-data-sources.sh@59 PS2, Line 59: cd /tmp it's better to call "pushd /tmp", later call "popd" to restore original directory. http://gerrit.cloudera.org:8080/#/c/20710/2/testdata/bin/copy-ext-data-sources.sh@70 PS2, Line 70: jar jar and tar.gz files http://gerrit.cloudera.org:8080/#/c/20710/2/testdata/bin/create-ext-data-source-table.sql File testdata/bin/create-ext-data-source-table.sql: http://gerrit.cloudera.org:8080/#/c/20710/2/testdata/bin/create-ext-data-source-table.sql@100 PS2, Line 100: remove extra space in the end of line -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2023 01:09:22 +0000 Gerrit-HasComments: Yes
