Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 9: Code-Review+1 (2 comments) This is looking good to me, just a minor nit http://gerrit.cloudera.org:8080/#/c/23572/9/bin/bootstrap_development.sh File bin/bootstrap_development.sh: http://gerrit.cloudera.org:8080/#/c/23572/9/bin/bootstrap_development.sh@57 PS9, Line 57: # Use ninja for builds to better handle concurrent linking. : time -p ./buildall.sh -ninja -format -testdata -skiptests Nit: If we are using IMPALA_MAKE_CMD=ninja from the bin/jenkins/all-tests.sh, then I think we can drop -ninja here http://gerrit.cloudera.org:8080/#/c/23572/9/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/23572/9/bin/jenkins/all-tests.sh@34 PS9, Line 34: # Use ninja for better link concurrency and since we use bootstrap_development.sh then : # run-all-tests.sh and they need to use the same build system. Nit: If we drop -ninja from bin/bootstrap_development.sh, then we will want to adjust this comment. -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 21:58:34 +0000 Gerrit-HasComments: Yes
