Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23572/8/bin/bootstrap_development.sh File bin/bootstrap_development.sh: http://gerrit.cloudera.org:8080/#/c/23572/8/bin/bootstrap_development.sh@57 PS8, Line 57: # Use ninja for builds to better handle concurrent linking. : time -p ./buildall.sh -ninja -format -testdata -skiptests I think for the test jobs, we would want to set IMPALA_MAKE_CMD=ninja so that everything knows about it. There are two modes: 1. buildall.sh does everything and calls everything. For the -ninja arg to work, the scripts it calls need to know it ran ninja. I think MAKE_CMD could have been providing that, as buildall.sh exports MAKE_CMD and scripts called from it would inherit that value. Then again, we haven't run tests with ninja, so who knows. 2. buildall.sh does the build / dataload, but then bin/run-all-tests.sh runs separately. I think this basically needs a global environment variable. The bin/run-backend-tests.sh doesn't know we used -ninja here. -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 19:20:39 +0000 Gerrit-HasComments: Yes
