Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23572/8/bin/bootstrap_development.sh File bin/bootstrap_development.sh: http://gerrit.cloudera.org:8080/#/c/23572/8/bin/bootstrap_development.sh@57 PS8, Line 57: # Use ninja for builds to better handle concurrent linking. : time -p ./buildall.sh -ninja -format -testdata -skiptests > I think for the test jobs, we would want to set IMPALA_MAKE_CMD=ninja so th I thought bootstrap_development.sh was more focused on initial setup. But I see now it's also used in bin/jenkins/all-tests.sh, so setting IMPALA_MAKE_CMD=ninja makes sense there to use it in run-all-tests as well. Should I get rid of -ninja as a buildall.sh option? -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 19:57:38 +0000 Gerrit-HasComments: Yes
