Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23572/6/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/23572/6/buildall.sh@83 PS6, Line 83: export MAKE_CMD=default > There are a couple other scripts that assume make if MAKE_CMD is not set. I Another approach is to have a global setting for the make command. i.e. 1. Something like IMPALA_MAKE_CMD is set in bin/impala-config.sh 2. Developers or test scripts can override it via an env var or bin/impala-config-local.sh 3. Locations in the repository use IMPALA_MAKE_CMD, including buildall.sh 4. External test runner scripts can detect IMPALA_MAKE_CMD and if it isn't set use make like before The problem with this approach is that if someone manually specifies -ninja or -make that is different from IMPALA_MAKE_CMD, things won't work. Maybe it would be better for the env var to determine the value for buildall.sh, but other locations use the detection helper. -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 18:18:01 +0000 Gerrit-HasComments: Yes
