Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/23572/12/bin/run-backend-tests.sh File bin/run-backend-tests.sh: http://gerrit.cloudera.org:8080/#/c/23572/12/bin/run-backend-tests.sh@47 PS12, Line 47: # Ninja doesn't accept variable declaration in the command, so pass as an envvar. : ARGS="${BE_TEST_ARGS}" "${MAKE_CMD:-${IMPALA_MAKE_CMD}}" test It looks like ninja just doesn't support arguments, even as environment variables. If we specify SKIP_BE_TEST_PATTERN=session* (which passes in ARGS) and run this with ninja, it doesn't skip the session-expiry-test. I don't think that's a blocker for this. The only time that we use SKIP_BE_TEST_PATTERN is when we are using TARGET_FILESYSTEM=local and we basically never do that. If it becomes critical, we can switch to running ctest directly. -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 12 Dec 2025 19:00:55 +0000 Gerrit-HasComments: Yes
