Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23572/4/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/23572/4/bin/impala-config.sh@1182 PS4, Line 1182: IMPALA_MINIMAL_DEBUG_INFO Nit: use curly braces "${IMPALA_MINIMAL_DEBUG_INFO}" http://gerrit.cloudera.org:8080/#/c/23572/4/bin/impala-config.sh@1192 PS4, Line 1192: - The single dash only replaces IMPALA_LINK_THREADS if that variable is not defined. To me, we should use :- which replaces IMPALA_LINK_THREADS if it is empty or unset. ${IMPALA_LINK_THREADS:-"${BOUNDED_LINKS}"} -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 23:25:18 +0000 Gerrit-HasComments: Yes
